Great milestone!

On Sun, Jul 5, 2020 at 9:25 PM Dan Kenigsberg <danken@redhat.com> wrote:
Seven years ago, in June 2013, Giuseppe Valarelli introduced
tests/functional/networkTests.py in
https://gerrit.ovirt.org/#/c/14840/. It held high aspirations: to
provide a comprehensive functional test for Vdsm's network API, in
order to ease development of new code and reduce chances of
reintroducing old bugs.

390 commits later, Andrej Cernak removed the last lines of code from
that file in https://gerrit.ovirt.org/#/c/109182/.

In between, many many other developers contributed to the set of
tests, and later dissipated its content to multiple pytest-driven test
modules. tests/functional/networkTests.py was never an emblem of great
software design; it makes me happy to see it gone. But it was very
useful and its spirit lives on: API tests are now the rule of Vdsm
development, not an exception.

I'd like to thank all the people who made this possible.

$ git log 1c5f15c9b~ -- tests/functional/networkTests.py|grep
Author|sort|uniq -c|sort -nr
     72 Author: Edward Haas <edwardh@redhat.com>
     58 Author: Ido Barkan <ibarkan@redhat.com>
     46 Author: Ondřej Svoboda <osvoboda@redhat.com>
     40 Author: Petr Horáček <phoracek@redhat.com>
     35 Author: Dan Kenigsberg <danken@redhat.com>
     34 Author: Antoni S. Puimedon <asegurap@redhat.com>
     24 Author: Bell Levin <blevin@redhat.com>
     23 Author: Leon Goldberg <lgoldber@redhat.com>
     18 Author: Giuseppe Vallarelli <gvallare@redhat.com>
      8 Author: Assaf Muller <amuller@redhat.com>
      5 Author: Sveta Haas <sveta.haas@gmail.com>
      4 Author: Mark Wu <wudxw@linux.vnet.ibm.com>
      3 Author: Nir Soffer <nsoffer@redhat.com>
      2 Author: Yaniv Bronhaim <ybronhei@redhat.com>
      2 Author: Sagi Shnaidman <sshnaidm@redhat.com>
      2 Author: Petr Sebek <psebek@redhat.com>
      2 Author: Miguel Angel Ajo <miguelangel@ajo.es>
      2 Author: Andrej Cernek <acernek@redhat.com>
      1 Author: Viliam Serecun <v.serecun@gmail.com>
      1 Author: Vered Volansky <vvolansk@redhat.com>
      1 Author: Timothy Asir Jeyasingh <tjeyasin@redhat.com>
      1 Author: shlad <a.shlado@gmail.com>
      1 Author: pkliczewski <piotr.kliczewski@gmail.com>
      1 Author: Petr Benas <pbenas@redhat.com>
      1 Author: Marcin Sobczyk <msobczyk@redhat.com>
      1 Author: Marcin Mirecki <mmirecki@redhat.com>
      1 Author: Ilia Meerovich <iliam@redhat.com>
      1 Author: Genadi Chereshnya <gcheresh@redhat.com>
      1 Author: Dominik Holler <dholler@redhat.com>