On Tue, Mar 16, 2021 at 11:13 AM Vojtech Juranek <vjuranek@redhat.com> wrote:
On Tuesday, 16 March 2021 08:48:46 CET Benny Zlotnik wrote:
> I think you had an issue because you clashed with the script number
> (or something like that, since you have a patch with an upgrade
> script), I think if you run manually the SQL in[1] and rerun
> engine-setup it should sort it out

Thanks Benny and Didi, indeed, in my patch I *had* upgrade script
04_04_1010_something, which I renamed after to 04_04_1020_something after I
rebased on top of gerrit #112642. However, DB remembers it and skips
04_04_1010_*.

BTW, an old trick to prevent this from happening is to name the script locally with index % 10 != 0 until it's merged
 

Running 04_04_1010_add_virtio_scsi_multi_queues_enabled_to_vm_static.sq
manually fixed the issue.

Thanks!
Vojta

> [1]
> https://gerrit.ovirt.org/c/ovirt-engine/+/112642/16/packaging/dbscripts/upg
> rade/04_04_1010_add_virtio_scsi_multi_queues_enabled_to_vm_static.sql#1

> On Tue, Mar 16, 2021 at 9:40 AM Vojtech Juranek <vjuranek@redhat.com>
> wrote:
> >
> >
> > On Tuesday, 16 March 2021 08:29:07 CET Ales Musil wrote:
> >
> > > On Tue, Mar 16, 2021 at 8:24 AM Vojtech Juranek <vjuranek@redhat.com>
> > > wrote:
> >
> > > > On Tuesday, 16 March 2021 07:08:31 CET Yedidyah Bar David wrote:
> > > >
> > > > > On Mon, Mar 15, 2021 at 10:48 PM Vojtech Juranek
> > > > > <vjuranek@redhat.com>
> > > >
> > > >
> > > >
> > > > wrote:
> > > >
> > > > > > Hi,
> > > > > > when I try to upgrade my engine with built artifacts (e.g. [1]),
> > > > > > it
> > > >
> > > >
> > > >
> > > > fails
> > > >
> > > >
> > > >
> > > > > > with:
> > > > > >
> > > > > >
> > > > > >
> > > > > > psql:/usr/share/ovirt-engine/dbscripts/create_views.sql:1000:
> > > > > > ERROR:
> > > > > > column vm_templates.virtio_scsi_multi_queues_enabled does not
> > > > > > exist
> > > >
> > > >
> > > >
> > > > LINE
> > > >
> > > >
> > > >
> > > > > > 86:     vm_templates.virtio_scsi_multi_queues_enabled AS
> > > > > > virtio_...>
> > > > > >
> > > > > >
> > > > > >
> > > > > >              ^
> > > > > >
> > > > > >
> > > > > >
> > > > > > FATAL: Cannot execute sql command:
> > > > > > --file=/usr/share/ovirt-engine/dbscripts/create_views.sql
> > > > > >
> > > > > >
> > > > > >
> > > > > > Same issue happens when I tried to update my dev engine with
> > > > > > local
> > > >
> > > >
> > > >
> > > > build.
> > > >
> > > >
> > > >
> > > > > > However, OST is passing [2].
> > > > > >
> > > > > >
> > > > > >
> > > > > > Any idea what's wrong? I don't see anything wrong in [3], which
> > > > > > is
> > > > > > probably the culprit, but I haven't much experience with
> > > > > > engine/db
> > > > > > though. Or maybe some issue on my side?
> > > > >
> > > > >
> > > > >
> > > > > I suppose this failure happens in engine-setup, right? Please share
> > > > > its logs. Thanks.
> > > >
> > > >
> > > >
> > > > attached
> > > >
> > > >
> > > >
> > > > > Best regards,
> > > > >
> > > > >
> > > > >
> > > > > > Thanks
> > > > > > Vojta
> > > > > >
> > > > > >
> > > > > >
> > > > > > [1]
> > > >
> > > >
> > > >
> > > > https://jenkins.ovirt.org/job/ovirt-engine_standard-check-patch/11174/
> > > > art
> > > >
> > > >
> > > >
> > > > > > ifact/check-patch.el8.x86_64/ [2]
> > > > > > https://jenkins.ovirt.org/job/ovirt-system-tests_manual/7880/
> > > > > > [3]
> > > >
> > > >
> > > >
> > > > https://github.com/oVirt/ovirt-engine/commit/52caf76e60ace2266d8283c13
> > > > 1d4
> > > >
> > > >
> > > >
> > > > > > 673a2dd79289_______________________________________________ Devel
> > > >
> > > >
> > > >
> > > > mailing
> > > >
> > > >
> > > >
> > > > > > list -- devel@ovirt.org
> > > > > > To unsubscribe send an email to devel-leave@ovirt.org
> > > > > > Privacy Statement: https://www.ovirt.org/privacy-policy.html
> > > > > > oVirt Code of Conduct:
> > > > > > https://www.ovirt.org/community/about/community-guidelines/ List
> > > >
> > > >
> > > >
> > > > > > Archives:
> > > >
> > > > https://lists.ovirt.org/archives/list/devel@ovirt.org/message/DWCUVM4H
> > > > RGV
> > > >
> > > >
> > > >
> > > > > > SUNLCS3TWL4LHKXDD2NPO/
> > > >
> > > >
> > > >
> > > > _______________________________________________
> > > > Devel mailing list -- devel@ovirt.org
> > > > To unsubscribe send an email to devel-leave@ovirt.org
> > > > Privacy Statement: https://www.ovirt.org/privacy-policy.html
> > > > oVirt Code of Conduct:
> > > > https://www.ovirt.org/community/about/community-guidelines/
> > > > List Archives:
> > > > https://lists.ovirt.org/archives/list/devel@ovirt.org/message/TDSBKKXB
> > > > 42Y4
> > > > V644AI3PDRMV5QWWUF5J/
> > >
> > > Hi,
> > > it happened to me as well on my dev engine.
> > > I workaround this by cleaning my engine and running setup again from
> > > scratch.
> >
> >
> >
> > this would very likely work as OST is passing, but I'd like to avoid it as
> > I
 have quite a lot of stuff configured there and don't want to do it
> > again>
> >
> >
> > > I suspect that it is related to [0].
> > >
> > >
> > >
> > > Thanks,
> > > Ales
> > >
> > >
> > >
> > > [0] https://gerrit.ovirt.org/c/ovirt-engine/+/112642
> >
> >
> >
> > _______________________________________________
> > Devel mailing list -- devel@ovirt.org
> > To unsubscribe send an email to devel-leave@ovirt.org
> > Privacy Statement: https://www.ovirt.org/privacy-policy.html
> > oVirt Code of Conduct:
> > https://www.ovirt.org/community/about/community-guidelines/
 List
> > Archives:
> > https://lists.ovirt.org/archives/list/devel@ovirt.org/message/XUSTEKEJT67
> > E5TEVO2WYHNPUHSIPC2AR/
> _______________________________________________
> Devel mailing list -- devel@ovirt.org
> To unsubscribe send an email to devel-leave@ovirt.org
> Privacy Statement: https://www.ovirt.org/privacy-policy.html
> oVirt Code of Conduct:
> https://www.ovirt.org/community/about/community-guidelines/ List Archives:
> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/WQPKY6UZHY77B
> REVAI5MCTTNGGK6UMIZ/

_______________________________________________
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-leave@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/
List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/BATU3QTZS6YJNHMJQHAP2MBV2DPSQQB7/