any updates about that?

https://gerrit.ovirt.org/#/c/52357/ - this can be verified and get it

https://gerrit.ovirt.org/#/c/52349/ - got tiny comment about unneeded kill call

https://gerrit.ovirt.org/51407 - Nir can merge

Nir - please review https://gerrit.ovirt.org/52646 or take over

and update soon what the plans regarding the async usages in

vdsm/storage/mount.py

vdsm/storage/iscsiadm.py

vdsm/storage/imageSharing.py

vdsm/storage/hba.py

vdsm/storage/blockSD.py

and v2v.py

I prefer not to wait for that too long - we can remove the deathSignal usages there, and continue with https://gerrit.ovirt.org/#/c/48384

Please also check if you can take over the re-implementation of async proc (https://gerrit.ovirt.org/49441) as you (storage operations) are the main and only user of it, and it should fit Popen proc.

On Mon, Jan 18, 2016 at 3:12 PM, Francesco Romani <fromani@redhat.com> wrote:

----- Original Message -----
> From: "Yaniv Bronheim" <ybronhei@redhat.com>
> To: "devel" <devel@ovirt.org>, "Shahar Havivi" <shavivi@redhat.com>, "Francesco Romani" <fromani@redhat.com>, "Nir
> Soffer" <nsoffer@redhat.com>
> Sent: Monday, January 18, 2016 11:01:10 AM
> Subject: Ensure processes death by terminating decorator - https://gerrit.ovirt.org/51407
>
> Hi guys,
>
> Following the work to omit deathSignal attribute from our cpopen
> implementation we posted https://gerrit.ovirt.org/51407 which is ready for
> use.
> Currently locations that should use it are:
> (I wrote above who I expect to check the area and post a patch for that -
> we'll discuss it during next vdsm-sync to follow the work)

> fromani:
> vdsm_hooks/checkimages/before_vm_start.py - in checkImage - the code looks
> ok, but check if not better to use the terminating decorator.. I think it
> will be nicer

Fair enough, posted https://gerrit.ovirt.org/52349

> some places define deathSignal for no reason, the call is sync - please
> remove those places:
[...]
> fromani:
> lib/vdsm/virtsparsify.py

Done in https://gerrit.ovirt.org/52357

--
Francesco Romani
RedHat Engineering Virtualization R & D
Phone: 8261328
IRC: fromani

Yaniv Bronhaim.