On Tue, Oct 4, 2016 at 4:38 PM, Juan Hernández <jhernand@redhat.com> wrote:
On 10/04/2016 04:33 PM, Sandro Bonazzola wrote:
>
>
> On Tue, Oct 4, 2016 at 3:27 PM, Juan Hernández <jhernand@redhat.com
> <mailto:jhernand@redhat.com>> wrote:
>
>     On 10/04/2016 03:16 PM, Sandro Bonazzola wrote:
>     > Hi, I'm checking the packaging of ovirt-engine for 4.1 and I've
>     some doubts:
>     >
>     > $ LC_ALL=C rpm -qlvp
>     >
>     http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/fc24/noarch/ovirt-engine-backend-4.1.0-0.0.master.20161003221921.git2653cbc.fc24.noarch.rpm|grep
>     <http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/fc24/noarch/ovirt-engine-backend-4.1.0-0.0.master.20161003221921.git2653cbc.fc24.noarch.rpm|grep>
>     > jar |grep -v ^l |grep common
>     > -rw-r--r--    1 root    root                    77761 Oct  4 00:20
>     >
>     /usr/share/ovirt-engine/modules/common/com/netflix/config/main/archaius-core.jar
>     > -rw-r--r--    1 root    root                    16442 Oct  4 00:20
>     >
>     /usr/share/ovirt-engine/modules/common/com/netflix/hystrix/contrib/main/hystrix-metrics-event-stream.jar
>     > -rw-r--r--    1 root    root                   290223 Oct  4 00:20
>     >
>     /usr/share/ovirt-engine/modules/common/com/netflix/hystrix/main/hystrix-core.jar
>     > -rw-r--r--    1 root    root                   738300 Oct  4 00:20
>     >
>     /usr/share/ovirt-engine/modules/common/io/reactivex/rxjava/main/rxjava.jar
>     > -rw-r--r--    1 root    root                     6073 Oct  4 00:20
>     >
>     /usr/share/ovirt-engine/modules/common/org/ovirt/engine/api/metamodel-server/main/metamodel-server.jar
>     > -rw-r--r--    1 root    root                     8224 Oct  4 00:21
>     >
>     /usr/share/ovirt-engine/modules/common/org/ovirt/engine/core/auth-plugin/main/auth-plugin.jar
>     > -rw-r--r--    1 root    root                     4010 Oct  4 00:22
>     >
>     /usr/share/ovirt-engine/modules/common/org/ovirt/engine/core/logger/main/logger.jar
>     > -rw-r--r--    1 root    root                   370051 Oct  4 00:20
>     >
>     /usr/share/ovirt-engine/modules/common/org/springframework/main/spring-aop.jar
>     > -rw-r--r--    1 root    root                   731512 Oct  4 00:20
>     >
>     /usr/share/ovirt-engine/modules/common/org/springframework/main/spring-beans.jar
>     > -rw-r--r--    1 root    root                  1097552 Oct  4 00:20
>     >
>     /usr/share/ovirt-engine/modules/common/org/springframework/main/spring-context.jar
>     > -rw-r--r--    1 root    root                  1078737 Oct  4 00:20
>     >
>     /usr/share/ovirt-engine/modules/common/org/springframework/main/spring-core.jar
>     > -rw-r--r--    1 root    root                   262990 Oct  4 00:20
>     >
>     /usr/share/ovirt-engine/modules/common/org/springframework/main/spring-expression.jar
>     > -rw-r--r--    1 root    root                     7243 Oct  4 00:20
>     >
>     /usr/share/ovirt-engine/modules/common/org/springframework/main/spring-instrument.jar
>     > -rw-r--r--    1 root    root                   423369 Oct  4 00:20
>     >
>     /usr/share/ovirt-engine/modules/common/org/springframework/main/spring-jdbc.jar
>     > -rw-r--r--    1 root    root                   265523 Oct  4 00:20
>     >
>     /usr/share/ovirt-engine/modules/common/org/springframework/main/spring-tx.jar
>     >
>     > $ dnf provides "*/archaius-core.jar" ->
>     archaius-core-0.7.3-4.fc24.noarch
>     > $ dnf provides "*/hystrix-metrics-event-stream.jar"
>     > -> hystrix-metrics-event-stream-1.4.21-5.fc24.noarch
>     > and so on with the other jar files.
>     >
>     > Any chance we can just reuse system libs and symlink them?
>     >
>     > Please note that the question is for el7 as well:
>     >
>     > $ LC_ALL=C rpm -qlvp
>     >
>     http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/el7/noarch/ovirt-engine-backend-4.1.0-0.0.master.20161003211313.git2653cbc.el7.centos.noarch.rpm
>     <http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/el7/noarch/ovirt-engine-backend-4.1.0-0.0.master.20161003211313.git2653cbc.el7.centos.noarch.rpm>
>     > |grep jar |grep -v ^l |grep common
>     > -rw-r--r--    1 root    root                   608376 Oct  3 23:14
>     > /usr/share/ovirt-engine/modules/common/com/mchange/c3p0/main/c3p0.jar
>     > -rw-r--r--    1 root    root                    77761 Oct  3 23:14
>     >
>     /usr/share/ovirt-engine/modules/common/com/netflix/config/main/archaius-core.jar
>     > -rw-r--r--    1 root    root                    16442 Oct  3 23:14
>     >
>     /usr/share/ovirt-engine/modules/common/com/netflix/hystrix/contrib/main/hystrix-metrics-event-stream.jar
>     > -rw-r--r--    1 root    root                   290223 Oct  3 23:14
>     >
>     /usr/share/ovirt-engine/modules/common/com/netflix/hystrix/main/hystrix-core.jar
>     > -rw-r--r--    1 root    root                    23234 Oct  3 23:14
>     >
>     /usr/share/ovirt-engine/modules/common/com/woorea/openstack/sdk/main/cinder-client.jar
>     > -rw-r--r--    1 root    root                    20755 Oct  3 23:14
>     >
>     /usr/share/ovirt-engine/modules/common/com/woorea/openstack/sdk/main/cinder-model.jar
>     > -rw-r--r--    1 root    root                    18277 Oct  3 23:14
>     >
>     /usr/share/ovirt-engine/modules/common/com/woorea/openstack/sdk/main/glance-client.jar
>     > -rw-r--r--    1 root    root                     8780 Oct  3 23:14
>     >
>     /usr/share/ovirt-engine/modules/common/com/woorea/openstack/sdk/main/glance-model.jar
>     > -rw-r--r--    1 root    root                    34756 Oct  3 23:14
>     >
>     /usr/share/ovirt-engine/modules/common/com/woorea/openstack/sdk/main/keystone-client.jar
>     > -rw-r--r--    1 root    root                    23183 Oct  3 23:14
>     >
>     /usr/share/ovirt-engine/modules/common/com/woorea/openstack/sdk/main/keystone-model.jar
>     > -rw-r--r--    1 root    root                    10861 Oct  3 23:14
>     >
>     /usr/share/ovirt-engine/modules/common/com/woorea/openstack/sdk/main/openstack-client.jar
>     > -rw-r--r--    1 root    root                    20104 Oct  3 23:14
>     >
>     /usr/share/ovirt-engine/modules/common/com/woorea/openstack/sdk/main/quantum-client.jar
>     > -rw-r--r--    1 root    root                    16031 Oct  3 23:14
>     >
>     /usr/share/ovirt-engine/modules/common/com/woorea/openstack/sdk/main/quantum-model.jar
>     > -rw-r--r--    1 root    root                     8972 Oct  3 23:14
>     >
>     /usr/share/ovirt-engine/modules/common/com/woorea/openstack/sdk/main/resteasy-connector.jar
>     > -rw-r--r--    1 root    root                   738300 Oct  3 23:14
>     >
>     /usr/share/ovirt-engine/modules/common/io/reactivex/rxjava/main/rxjava.jar
>     > -rw-r--r--    1 root    root                   621694 Oct  3 23:14
>     >
>     /usr/share/ovirt-engine/modules/common/org/apache/sshd/main/sshd-core.jar
>     > -rw-r--r--    1 root    root                     6073 Oct  3 23:14
>     >
>     /usr/share/ovirt-engine/modules/common/org/ovirt/engine/api/metamodel-server/main/metamodel-server.jar
>     > -rw-r--r--    1 root    root                     8222 Oct  3 23:15
>     >
>     /usr/share/ovirt-engine/modules/common/org/ovirt/engine/core/auth-plugin/main/auth-plugin.jar
>     > -rw-r--r--    1 root    root                     4010 Oct  3 23:16
>     >
>     /usr/share/ovirt-engine/modules/common/org/ovirt/engine/core/logger/main/logger.jar
>     > -rw-r--r--    1 root    root                   554885 Oct  3 23:14
>     > /usr/share/ovirt-engine/modules/common/org/quartz/main/quartz.jar
>     > -rw-r--r--    1 root    root                   450124 Oct  3 23:14
>     > /usr/share/ovirt-engine/modules/common/org/snmp4j/main/snmp4j.jar
>     > -rw-r--r--    1 root    root                   370051 Oct  3 23:14
>     >
>     /usr/share/ovirt-engine/modules/common/org/springframework/main/spring-aop.jar
>     > -rw-r--r--    1 root    root                   731512 Oct  3 23:14
>     >
>     /usr/share/ovirt-engine/modules/common/org/springframework/main/spring-beans.jar
>     > -rw-r--r--    1 root    root                  1097552 Oct  3 23:14
>     >
>     /usr/share/ovirt-engine/modules/common/org/springframework/main/spring-context.jar
>     > -rw-r--r--    1 root    root                  1078737 Oct  3 23:14
>     >
>     /usr/share/ovirt-engine/modules/common/org/springframework/main/spring-core.jar
>     > -rw-r--r--    1 root    root                   262990 Oct  3 23:14
>     >
>     /usr/share/ovirt-engine/modules/common/org/springframework/main/spring-expression.jar
>     > -rw-r--r--    1 root    root                     7243 Oct  3 23:14
>     >
>     /usr/share/ovirt-engine/modules/common/org/springframework/main/spring-instrument.jar
>     > -rw-r--r--    1 root    root                   423369 Oct  3 23:14
>     >
>     /usr/share/ovirt-engine/modules/common/org/springframework/main/spring-jdbc.jar
>     > -rw-r--r--    1 root    root                   265523 Oct  3 23:14
>     >
>     /usr/share/ovirt-engine/modules/common/org/springframework/main/spring-tx.jar
>     >
>     > If any dependency is missing on el7 I can try to provide it within
>     > CentOS Virt SIG, just let me know the Fedora equivalent rpm name.
>     > Thanks,
>     >
>
>     The OpenStack client .ajr files could be replaced by links in Fedora 24,
>     as it has the same version that we use: 3.1.1. The packages are named
>     "openstack-java-*", in case you also want to provide them from the
>     CentOS Virt SIG.
>
>     The "sshd.jar" file can't be a link because the version that we use is
>     0.12.0, and the version available in Fedora 24 is 0.11.0.
>
>
> Can we update our code to use 0.14.0 so we'll be in sync with Fedora 25
> once it will be out?
> http://koji.fedoraproject.org/koji/buildinfo?buildID=774394
>

Yes, we can. However, if I remember correctly, this has historically
been an area where the engine is very sensible to changes in the
version. In addition, if we do an effort to update, it should be to some
1.y.z version, which is not trivial, if I remember correctly. All in all
I'd say that the benefit of using the system library instead of bundling
it isn't worth the risk.

​Currently working on upgrade to apache-sshd 1.2​
 
​which should be used in 4.1 ...

>
>     The "metamodel-server.jar" file can't be replaced with a link because
>     the project isn't packaged as a RPM, and I don't have plans to
>     package it.
>
>     The "spring-*.jar" files can't be replaced with links because we use
>     version 4, and the packages in Fedora 24 are version 3.
>

--
Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta
3ºD, 28016 Madrid, Spain
Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.