Hi everyone, As you know vdsm has hooks mechanism and we already support dozen of hooks for different needs. Now it's a network's time. We would like to get your comments regarding our proposition for network related hooks. In general we are planning to prepare framework for future support of bunch network related hooks. Some of them already proposed by Itzik Brown [1] and Dan Yasny [2]. Below you can find the additional hooks list that we propose: Note: In the first stage we can implement these hooks without any parameters, just to provide an entry point for simple hooks. Networks manipulation: - before_add_network(conf={}, customProperty={}) - after_add_network(conf={}, customProperty={}) - before_del_network(conf={}, customProperty={}) - after_del_network(conf={}, customProperty={}) - before_edit_network(conf={}, customProperty={}) - after_edit_network(conf={}, customProperty={}) - TBD Bondings manipulations:

- before_add_bond(conf={}, customProperty={}) - after_add_bond(conf={}, customProperty={}) - before_del_bond(conf={}, customProperty={}) - after_del_bond(conf={}, customProperty={}) - before_edit_bond(conf={}, customProperty={}) - after_edit_bond(conf={}, customProperty={}) - TBD General purpose: - before_persist_network - after_persist_network Now we just need to figure out the use cases. Your input more than welcome... [1] http://gerrit.ovirt.org/#/c/7224/ - Adding hooks support for NIC hotplug [2] http://gerrit.ovirt.org/#/c/7547/ - Hook: Cisco VM-FEX support Regards, Igor Lvovsky _______________________________________________ Engine-devel mailing list Engine-devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel

From: "Simon Grinberg" <simon(a)redhat.com&gt; To: "Igor Lvovsky" <ilvovsky(a)redhat.com&gt; Cc: "Dan Yasny" <dyasny(a)redhat.com&gt;, "vdsm-devel" <vdsm-devel(a)lists.fedorahosted.org&gt;, "engine-devel" <engine-devel(a)ovirt.org&gt; Sent: Wednesday, October 10, 2012 5:03:52 PM Subject: Re: [Engine-devel] Network related hooks in vdsm ----- Original Message ----- > From: "Igor Lvovsky" <ilvovsky(a)redhat.com&gt; > To: "vdsm-devel" <vdsm-devel(a)lists.fedorahosted.org&gt;, > "engine-devel" <engine-devel(a)ovirt.org&gt; > Cc: "Dan Yasny" <dyasny(a)redhat.com&gt; > Sent: Wednesday, October 10, 2012 4:47:28 PM > Subject: [Engine-devel] Network related hooks in vdsm > > Hi everyone, > As you know vdsm has hooks mechanism and we already support dozen > of > hooks for different needs. > Now it's a network's time. > We would like to get your comments regarding our proposition for > network related hooks. > > In general we are planning to prepare framework for future support > of > bunch network related hooks. > Some of them already proposed by Itzik Brown [1] and Dan Yasny [2]. > > Below you can find the additional hooks list that we propose: > > Note: In the first stage we can implement these hooks without any > parameters, just to provide an entry point > for simple hooks. > > Networks manipulation: > - before_add_network(conf={}, customProperty={}) > - after_add_network(conf={}, customProperty={}) > - before_del_network(conf={}, customProperty={}) > - after_del_network(conf={}, customProperty={}) > - before_edit_network(conf={}, customProperty={}) > - after_edit_network(conf={}, customProperty={}) > - TBD + VM networking related points in addition to before/after vm start/stop before_hotplug_nic(conf={}, customProperty={}) *after_hotplug_nic(conf={}, customProperty={}) before_hotunplug_nic(conf={}, customProperty={}) *after_hotunplug_nic(conf={}, customProperty={}) * Not sure about use case for those two

The above will require VM IDs and networks? Sorry that I did not look into the actual implementation of the above naming is more of a guess work, but I think the meaning is clear. There may be other VM networking related entry points I've missed. > > Bondings manipulations: > - before_add_bond(conf={}, customProperty={}) > - after_add_bond(conf={}, customProperty={}) > - before_del_bond(conf={}, customProperty={}) > - after_del_bond(conf={}, customProperty={}) > - before_edit_bond(conf={}, customProperty={}) > - after_edit_bond(conf={}, customProperty={}) > - TBD > > General purpose: > - before_persist_network > - after_persist_network > > > Now we just need to figure out the use cases. > > Your input more than welcome... > > [1] http://gerrit.ovirt.org/#/c/7224/ - Adding hooks support for > NIC hotplug > [2] http://gerrit.ovirt.org/#/c/7547/ - Hook: Cisco VM-FEX > support > > > Regards, > Igor Lvovsky > _______________________________________________ > Engine-devel mailing list > Engine-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel >

From: "Igor Lvovsky" <ilvovsky(a)redhat.com&gt; To: "Simon Grinberg" <simon(a)redhat.com&gt; Cc: "Dan Yasny" <dyasny(a)redhat.com&gt;, "engine-devel" <engine-devel(a)ovirt.org&gt;, "vdsm-devel" <vdsm-devel(a)lists.fedorahosted.org&gt; Sent: Wednesday, October 10, 2012 5:27:13 PM Subject: Re: [Engine-devel] Network related hooks in vdsm ----- Original Message ----- > From: "Simon Grinberg" <simon(a)redhat.com&gt; > To: "Igor Lvovsky" <ilvovsky(a)redhat.com&gt; > Cc: "Dan Yasny" <dyasny(a)redhat.com&gt;, "vdsm-devel" > <vdsm-devel(a)lists.fedorahosted.org&gt;, "engine-devel" > <engine-devel(a)ovirt.org&gt; > Sent: Wednesday, October 10, 2012 5:03:52 PM > Subject: Re: [Engine-devel] Network related hooks in vdsm > > > > ----- Original Message ----- > > From: "Igor Lvovsky" <ilvovsky(a)redhat.com&gt; > > To: "vdsm-devel" <vdsm-devel(a)lists.fedorahosted.org&gt;, > > "engine-devel" <engine-devel(a)ovirt.org&gt; > > Cc: "Dan Yasny" <dyasny(a)redhat.com&gt; > > Sent: Wednesday, October 10, 2012 4:47:28 PM > > Subject: [Engine-devel] Network related hooks in vdsm > > > > Hi everyone, > > As you know vdsm has hooks mechanism and we already support dozen > > of > > hooks for different needs. > > Now it's a network's time. > > We would like to get your comments regarding our proposition for > > network related hooks. > > > > In general we are planning to prepare framework for future > > support > > of > > bunch network related hooks. > > Some of them already proposed by Itzik Brown [1] and Dan Yasny > > [2]. > > > > Below you can find the additional hooks list that we propose: > > > > Note: In the first stage we can implement these hooks without any > > parameters, just to provide an entry point > > for simple hooks. > > > > Networks manipulation: > > - before_add_network(conf={}, customProperty={}) > > - after_add_network(conf={}, customProperty={}) > > - before_del_network(conf={}, customProperty={}) > > - after_del_network(conf={}, customProperty={}) > > - before_edit_network(conf={}, customProperty={}) > > - after_edit_network(conf={}, customProperty={}) > > - TBD > > + VM networking related points in addition to before/after vm > start/stop > before_hotplug_nic(conf={}, customProperty={}) > *after_hotplug_nic(conf={}, customProperty={}) > before_hotunplug_nic(conf={}, customProperty={}) > *after_hotunplug_nic(conf={}, customProperty={}) > > * Not sure about use case for those two > Yep, part of them already proposed by Itzik (look at [1])

> The above will require VM IDs and networks? Sorry that I did not > look > into the actual implementation of the above naming is more of a > guess work, but I think the meaning is clear. There may be other VM > networking related entry points I've missed. > > > > > Bondings manipulations: > > - before_add_bond(conf={}, customProperty={}) > > - after_add_bond(conf={}, customProperty={}) > > - before_del_bond(conf={}, customProperty={}) > > - after_del_bond(conf={}, customProperty={}) > > - before_edit_bond(conf={}, customProperty={}) > > - after_edit_bond(conf={}, customProperty={}) > > - TBD > > > > General purpose: > > - before_persist_network > > - after_persist_network > > > > > > Now we just need to figure out the use cases. > > > > Your input more than welcome... > > > > [1] http://gerrit.ovirt.org/#/c/7224/ - Adding hooks support > > for > > NIC hotplug > > [2] http://gerrit.ovirt.org/#/c/7547/ - Hook: Cisco VM-FEX > > support > > > > > > Regards, > > Igor Lvovsky > > _______________________________________________ > > Engine-devel mailing list > > Engine-devel(a)ovirt.org > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > _______________________________________________ Engine-devel mailing list Engine-devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel

----- Original Message ----- > From: "Yaniv Kaul" <ykaul(a)redhat.com&gt; > To: "Igor Lvovsky" <ilvovsky(a)redhat.com&gt; > Cc: "Dan Yasny" <dyasny(a)redhat.com&gt;, "engine-devel" <engine-devel(a)ovirt.org&gt;, "vdsm-devel" > <vdsm-devel(a)lists.fedorahosted.org&gt; > Sent: Wednesday, October 10, 2012 10:53:19 AM > Subject: Re: [Engine-devel] Network related hooks in vdsm > > On 10/10/2012 04:47 PM, Igor Lvovsky wrote: > > Hi everyone, > > As you know vdsm has hooks mechanism and we already support dozen > > of hooks for different needs. > > Now it's a network's time. > > We would like to get your comments regarding our proposition for > > network related hooks. > > > > In general we are planning to prepare framework for future support > > of bunch network related hooks. > > Some of them already proposed by Itzik Brown [1] and Dan Yasny [2]. > > > > Below you can find the additional hooks list that we propose: > > > > Note: In the first stage we can implement these hooks without any > > parameters, just to provide an entry point > > for simple hooks. > > > > Networks manipulation: > > - before_add_network(conf={}, customProperty={}) > > - after_add_network(conf={}, customProperty={}) > > - before_del_network(conf={}, customProperty={}) > > - after_del_network(conf={}, customProperty={}) > > - before_edit_network(conf={}, customProperty={}) > > - after_edit_network(conf={}, customProperty={}) > > - TBD > > > > Bondings manipulations: > > Bond might be interesting because it may require switch configuration > - > but so will VLAN changes, so perhaps triggers in VLAN changes are > worthwhile as well. > Y. > > > - before_add_bond(conf={}, customProperty={}) > > - after_add_bond(conf={}, customProperty={}) > > - before_del_bond(conf={}, customProperty={}) > > - after_del_bond(conf={}, customProperty={}) > > - before_edit_bond(conf={}, customProperty={}) > > - after_edit_bond(conf={}, customProperty={}) > > - TBD > > > > General purpose: > > - before_persist_network > > - after_persist_network What about some way of doing a push that's not tied to an event - if we want to "push" something

Hi everyone, As you know vdsm has hooks mechanism and we already support dozen of hooks for different needs. Now it's a network's time. We would like to get your comments regarding our proposition for network related hooks. In general we are planning to prepare framework for future support of bunch network related hooks. Some of them already proposed by Itzik Brown [1] and Dan Yasny [2]. Below you can find the additional hooks list that we propose:

Note: In the first stage we can implement these hooks without any parameters, just to provide an entry point for simple hooks. Networks manipulation: - before_add_network(conf={}, customProperty={}) - after_add_network(conf={}, customProperty={}) - before_del_network(conf={}, customProperty={}) - after_del_network(conf={}, customProperty={}) - before_edit_network(conf={}, customProperty={}) - after_edit_network(conf={}, customProperty={}) - TBD Bondings manipulations: - before_add_bond(conf={}, customProperty={}) - after_add_bond(conf={}, customProperty={}) - before_del_bond(conf={}, customProperty={}) - after_del_bond(conf={}, customProperty={}) - before_edit_bond(conf={}, customProperty={}) - after_edit_bond(conf={}, customProperty={}) - TBD General purpose: - before_persist_network - after_persist_network Now we just need to figure out the use cases. Your input more than welcome... [1] http://gerrit.ovirt.org/#/c/7224/ - Adding hooks support for NIC hotplug [2] http://gerrit.ovirt.org/#/c/7547/ - Hook: Cisco VM-FEX support Regards, Igor Lvovsky _______________________________________________ Engine-devel mailing list Engine-devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel

----- Original Message ----- > On 10/10/12 16:47, Igor Lvovsky wrote: >> Hi everyone, >> As you know vdsm has hooks mechanism and we already support dozen >> of hooks for different needs. >> Now it's a network's time. >> We would like to get your comments regarding our proposition for >> network related hooks. >> >> In general we are planning to prepare framework for future support >> of bunch network related hooks. >> Some of them already proposed by Itzik Brown [1] and Dan Yasny [2]. >> >> Below you can find the additional hooks list that we propose: >> > > Many of the API calls bellow are deprecated. Why do we want to add > hooks > before/after to deprecated APIs? They are actually still very much in use with the REST API.

Perhaps we should address just the logical entry points instead of specific commands. A command such as setup networks can trigger multiple logical events in which hooks can be planted (same goes for edit network in a smaller scale).

> >> Note: In the first stage we can implement these hooks without any >> parameters, just to provide an entry point >> for simple hooks. >> >> Networks manipulation: >> - before_add_network(conf={}, customProperty={}) >> - after_add_network(conf={}, customProperty={}) >> - before_del_network(conf={}, customProperty={}) >> - after_del_network(conf={}, customProperty={}) >> - before_edit_network(conf={}, customProperty={}) >> - after_edit_network(conf={}, customProperty={}) >> - TBD >> >> Bondings manipulations: >> - before_add_bond(conf={}, customProperty={}) >> - after_add_bond(conf={}, customProperty={}) >> - before_del_bond(conf={}, customProperty={}) >> - after_del_bond(conf={}, customProperty={}) >> - before_edit_bond(conf={}, customProperty={}) >> - after_edit_bond(conf={}, customProperty={}) >> - TBD >> >> General purpose: >> - before_persist_network >> - after_persist_network >> >> >> Now we just need to figure out the use cases. >> >> Your input more than welcome... >> >> [1] http://gerrit.ovirt.org/#/c/7224/ - Adding hooks support for >> NIC hotplug >> [2] http://gerrit.ovirt.org/#/c/7547/ - Hook: Cisco VM-FEX >> support >> >> >> Regards, >> Igor Lvovsky >> _______________________________________________ >> Engine-devel mailing list >> Engine-devel(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/engine-devel >> > > _______________________________________________ > Engine-devel mailing list > Engine-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel >