12:56 a.m.
Include the devel group.
Thanks Eli for the quick responses for our first design and sorry for the nag.
We appreciate any of the comments for our database design and will follow the design to do
the implementation if no more comments.
http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
Thanks & Best Regards
Shi, Xiao-Lei (Bruce)
Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China
Telephone +86 23 65683093
Mobile +86 18696583447
Email xiao-lei.shi(a)hp.com
-----Original Message-----
From: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
Sent: Friday, March 28, 2014 1:30 PM
To: 'Eli Mesika'
Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck; Gilad Chaplik; Vinod,
Chegu; Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary
Subject: RE: Please help us to review our database schema design with NUMA feature on
ovirt
Hi Eli,
After the UX design meeting, we did some modification for the database schema, and merged
some update according to your last review comments.
Now the document has been posted on ovirt wikipage, could you help to review the database
design again:
http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
Thanks & Best Regards
Shi, Xiao-Lei (Bruce)
Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China Telephone +86 23 65683093 Mobile +86 18696583447
Email xiao-lei.shi(a)hp.com
-----Original Message-----
From: Eli Mesika [mailto:emesika@redhat.com]
Sent: Monday, March 24, 2014 6:24 PM
To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck; Gilad Chaplik; Vinod,
Chegu; Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary
Subject: Re: Please help us to review our database schema design with NUMA feature on
ovirt
----- Original Message -----
From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
To: "Eli Mesika" <emesika(a)redhat.com>, "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>
Cc: "Doron Fediuck" <dfediuck(a)redhat.com>, "Gilad Chaplik"
<gchaplik(a)redhat.com>, "Chegu Vinod" <chegu_vinod(a)hp.com>,
"Shang-Chun
Liang (David Liang, HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>
Sent: Monday, March 24, 2014 11:23:39 AM
Subject: RE: Please help us to review our database schema design with
NUMA feature on ovirt
Hi Eli,
Thanks for your comments.
I have updated the document according to your comments except the below one:
Missing from here are 2 issues:
1) Impact on the search engine, which new columns are search-able and
which changes are planned in the search engine code to enable that
2) Impact on engine-reports, are those changed planned to be exposed
to the engine data warehouse and required new/modified reports?
Could you tell us more detailed information about the modules you
mentioned above? I mean "search engine" and "engine-reports". I think
we missed these two parts in our previous investigation.
I just find org.ovirt.engine.core.bll.SearchQuery, is that the right
object for search engine?
Yes, actually when you are opening the admin UI, there are TABs for each entity , i.e.
Data Center, Cluster, Host etc.
In each, you can see a text-box in which you can search for by writing a search expression
My question is
1) What is the impact of your work on the search on the Fost and VM TABs
a) Are there any fields that are supported now in the search expression and should
pop-up when you write the expression by the auto-completion mechanism ?
b) Are there any added columns displayed in the result of such a search in the grid
?
How about the engine-reports, could you give us some hints, like the
code location and any more detailed information that we can start more
investigation?
CCing Yaniv D who is in charge of the reports/dwh module Yaniv, any planned work for
adding Numa features to Host/VM in the reports side ?
Thanks
Thanks & Best Regards
Shi, Xiao-Lei (Bruce)
Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China Telephone +86 23 65683093
Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
-----Original Message-----
From: Eli Mesika [mailto:emesika@redhat.com]
Sent: Sunday, March 23, 2014 4:44 PM
To: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
Cc: Doron Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun
(David Liang, HPservers-Core-OE-PSC); Shi, Xiao-Lei (Bruce, HP
Servers-PSC-CQ)
Subject: Re: Please help us to review our database schema design with
NUMA feature on ovirt
----- Original Message -----
> From: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> <chuan.liao(a)hp.com>
> To: emesika(a)redhat.com
> Cc: "Doron Fediuck" <dfediuck(a)redhat.com>, "Gilad
Chaplik"
> <gchaplik(a)redhat.com>, "Chegu Vinod" <chegu_vinod(a)hp.com>,
> "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
> <shangchun.liang(a)hp.com>, "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> <xiao-lei.shi(a)hp.com>
> Sent: Friday, March 21, 2014 10:42:33 AM
> Subject: Please help us to review our database schema design with
> NUMA feature on ovirt
>
> Hi Eli,
>
> Please help us to review our database schema design with NUMA
> feature on ovirt
> https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcmbGWAcyQo_IST
> Y8
> ykDr0I6VY/edit?usp=sharing
>
> Feel free to take comments on document at anywhere
Done, had commented on the document.
Eli
>
> Especially, 5.4 The used interface between engine core and
> database(schema)
>
> Your approve and your comments with this section will be much more
> appreciate for us.
>
> Best Regards,
> Jason Liao
>
>
4:12 a.m.
New subject: [Engine-devel] Please help us to review our database schema design with NUMA feature on ovirt
----- Original Message -----
From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
To: "Eli Mesika" <emesika(a)redhat.com>
Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>,
"Doron Fediuck" <dfediuck(a)redhat.com>,
"Gilad Chaplik" <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>, "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv Dary"
<ydary(a)redhat.com>, engine-devel(a)ovirt.org
Sent: Monday, March 31, 2014 8:56:20 AM
Subject: RE: Please help us to review our database schema design with NUMA feature on
ovirt
Include the devel group.
Thanks Eli for the quick responses for our first design and sorry for the
nag.
We appreciate any of the comments for our database design and will follow the
design to do the implementation if no more comments.
http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
Seems OK for me except an unanswered question I had asked in my first review :
Why in the Host level NUMA fields are added to vds_dynamic while in the VM level it is
added to vm_static ???
I would expect it to be in both on static or dynamic , can you please explain ? Thanks
Thanks & Best Regards
Shi, Xiao-Lei (Bruce)
Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China
Telephone +86 23 65683093
Mobile +86 18696583447
Email xiao-lei.shi(a)hp.com
-----Original Message-----
From: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
Sent: Friday, March 28, 2014 1:30 PM
To: 'Eli Mesika'
Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck; Gilad
Chaplik; Vinod, Chegu; Liang, Shang-Chun (David Liang,
HPservers-Core-OE-PSC); Yaniv Dary
Subject: RE: Please help us to review our database schema design with NUMA
feature on ovirt
Hi Eli,
After the UX design meeting, we did some modification for the database
schema, and merged some update according to your last review comments.
Now the document has been posted on ovirt wikipage, could you help to review
the database design again:
http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
Thanks & Best Regards
Shi, Xiao-Lei (Bruce)
Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China Telephone +86 23 65683093 Mobile +86
18696583447 Email xiao-lei.shi(a)hp.com
-----Original Message-----
From: Eli Mesika [mailto:emesika@redhat.com]
Sent: Monday, March 24, 2014 6:24 PM
To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck; Gilad
Chaplik; Vinod, Chegu; Liang, Shang-Chun (David Liang,
HPservers-Core-OE-PSC); Yaniv Dary
Subject: Re: Please help us to review our database schema design with NUMA
feature on ovirt
----- Original Message -----
> From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> To: "Eli Mesika" <emesika(a)redhat.com>, "Chuan Liao (Jason
Liao,
> HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>
> Cc: "Doron Fediuck" <dfediuck(a)redhat.com>, "Gilad
Chaplik"
> <gchaplik(a)redhat.com>, "Chegu Vinod" <chegu_vinod(a)hp.com>,
"Shang-Chun
> Liang (David Liang, HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>
> Sent: Monday, March 24, 2014 11:23:39 AM
> Subject: RE: Please help us to review our database schema design with
> NUMA feature on ovirt
>
> Hi Eli,
>
> Thanks for your comments.
> I have updated the document according to your comments except the below
> one:
> Missing from here are 2 issues:
>
> 1) Impact on the search engine, which new columns are search-able and
> which changes are planned in the search engine code to enable that
>
> 2) Impact on engine-reports, are those changed planned to be exposed
> to the engine data warehouse and required new/modified reports?
>
> Could you tell us more detailed information about the modules you
> mentioned above? I mean "search engine" and "engine-reports". I
think
> we missed these two parts in our previous investigation.
> I just find org.ovirt.engine.core.bll.SearchQuery, is that the right
> object for search engine?
Yes, actually when you are opening the admin UI, there are TABs for each
entity , i.e. Data Center, Cluster, Host etc.
In each, you can see a text-box in which you can search for by writing a
search expression My question is
1) What is the impact of your work on the search on the Fost and VM TABs
a) Are there any fields that are supported now in the search expression
and should pop-up when you write the expression by the auto-completion
mechanism ?
b) Are there any added columns displayed in the result of such a search
in the grid ?
> How about the engine-reports, could you give us some hints, like the
> code location and any more detailed information that we can start more
> investigation?
CCing Yaniv D who is in charge of the reports/dwh module Yaniv, any planned
work for adding Numa features to Host/VM in the reports side ?
Thanks
>
> Thanks & Best Regards
> Shi, Xiao-Lei (Bruce)
>
> Hewlett-Packard Co., Ltd.
> HP Servers Core Platform Software China Telephone +86 23 65683093
> Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
>
> -----Original Message-----
> From: Eli Mesika [mailto:emesika@redhat.com]
> Sent: Sunday, March 23, 2014 4:44 PM
> To: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
> Cc: Doron Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun
> (David Liang, HPservers-Core-OE-PSC); Shi, Xiao-Lei (Bruce, HP
> Servers-PSC-CQ)
> Subject: Re: Please help us to review our database schema design with
> NUMA feature on ovirt
>
>
>
> ----- Original Message -----
> > From: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > <chuan.liao(a)hp.com>
> > To: emesika(a)redhat.com
> > Cc: "Doron Fediuck" <dfediuck(a)redhat.com>, "Gilad
Chaplik"
> > <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>,
> > "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
> > <shangchun.liang(a)hp.com>, "Xiao-Lei Shi (Bruce, HP
Servers-PSC-CQ)"
> > <xiao-lei.shi(a)hp.com>
> > Sent: Friday, March 21, 2014 10:42:33 AM
> > Subject: Please help us to review our database schema design with
> > NUMA feature on ovirt
> >
> > Hi Eli,
> >
> > Please help us to review our database schema design with NUMA
> > feature on ovirt
> > https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcmbGWAcyQo_IST
> > Y8
> > ykDr0I6VY/edit?usp=sharing
> >
> > Feel free to take comments on document at anywhere
>
> Done, had commented on the document.
> Eli
>
> >
> > Especially, 5.4 The used interface between engine core and
> > database(schema)
> >
> > Your approve and your comments with this section will be much more
> > appreciate for us.
> >
> > Best Regards,
> > Jason Liao
> >
> >
>
4:21 a.m.
New subject: [Engine-devel] Please help us to review our database schema design with NUMA feature on ovirt
+1
IMO: vds data should reside in static
VM need to think about it.
Roy?
Thanks,
Gilad.
----- Original Message -----
From: "Eli Mesika" <emesika(a)redhat.com>
To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <xiao-lei.shi(a)hp.com>
Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>,
"Doron Fediuck" <dfediuck(a)redhat.com>,
"Gilad Chaplik" <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>, "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv Dary"
<ydary(a)redhat.com>, engine-devel(a)ovirt.org
Sent: Monday, March 31, 2014 12:12:50 PM
Subject: Re: Please help us to review our database schema design with NUMA feature on
ovirt
----- Original Message -----
> From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> To: "Eli Mesika" <emesika(a)redhat.com>
> Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
<chuan.liao(a)hp.com>,
> "Doron Fediuck" <dfediuck(a)redhat.com>,
> "Gilad Chaplik" <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>,
> "Shang-Chun Liang (David Liang,
> HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv Dary"
> <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> Sent: Monday, March 31, 2014 8:56:20 AM
> Subject: RE: Please help us to review our database schema design with NUMA
> feature on ovirt
>
> Include the devel group.
> Thanks Eli for the quick responses for our first design and sorry for the
> nag.
> We appreciate any of the comments for our database design and will follow
> the
> design to do the implementation if no more comments.
> http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
Seems OK for me except an unanswered question I had asked in my first review
:
Why in the Host level NUMA fields are added to vds_dynamic while in the VM
level it is added to vm_static ???
I would expect it to be in both on static or dynamic , can you please explain
? Thanks
>
> Thanks & Best Regards
> Shi, Xiao-Lei (Bruce)
>
> Hewlett-Packard Co., Ltd.
> HP Servers Core Platform Software China
> Telephone +86 23 65683093
> Mobile +86 18696583447
> Email xiao-lei.shi(a)hp.com
>
> -----Original Message-----
> From: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> Sent: Friday, March 28, 2014 1:30 PM
> To: 'Eli Mesika'
> Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck; Gilad
> Chaplik; Vinod, Chegu; Liang, Shang-Chun (David Liang,
> HPservers-Core-OE-PSC); Yaniv Dary
> Subject: RE: Please help us to review our database schema design with NUMA
> feature on ovirt
>
> Hi Eli,
>
> After the UX design meeting, we did some modification for the database
> schema, and merged some update according to your last review comments.
> Now the document has been posted on ovirt wikipage, could you help to
> review
> the database design again:
> http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
>
>
> Thanks & Best Regards
> Shi, Xiao-Lei (Bruce)
>
> Hewlett-Packard Co., Ltd.
> HP Servers Core Platform Software China Telephone +86 23 65683093 Mobile
> +86
> 18696583447 Email xiao-lei.shi(a)hp.com
>
>
> -----Original Message-----
> From: Eli Mesika [mailto:emesika@redhat.com]
> Sent: Monday, March 24, 2014 6:24 PM
> To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck; Gilad
> Chaplik; Vinod, Chegu; Liang, Shang-Chun (David Liang,
> HPservers-Core-OE-PSC); Yaniv Dary
> Subject: Re: Please help us to review our database schema design with NUMA
> feature on ovirt
>
>
>
> ----- Original Message -----
> > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> > To: "Eli Mesika" <emesika(a)redhat.com>, "Chuan Liao (Jason
Liao,
> > HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>
> > Cc: "Doron Fediuck" <dfediuck(a)redhat.com>, "Gilad
Chaplik"
> > <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>, "Shang-Chun
> > Liang (David Liang, HPservers-Core-OE-PSC)"
<shangchun.liang(a)hp.com>
> > Sent: Monday, March 24, 2014 11:23:39 AM
> > Subject: RE: Please help us to review our database schema design with
> > NUMA feature on ovirt
> >
> > Hi Eli,
> >
> > Thanks for your comments.
> > I have updated the document according to your comments except the below
> > one:
> > Missing from here are 2 issues:
> >
> > 1) Impact on the search engine, which new columns are search-able and
> > which changes are planned in the search engine code to enable that
> >
> > 2) Impact on engine-reports, are those changed planned to be exposed
> > to the engine data warehouse and required new/modified reports?
> >
> > Could you tell us more detailed information about the modules you
> > mentioned above? I mean "search engine" and
"engine-reports". I think
> > we missed these two parts in our previous investigation.
> > I just find org.ovirt.engine.core.bll.SearchQuery, is that the right
> > object for search engine?
>
> Yes, actually when you are opening the admin UI, there are TABs for each
> entity , i.e. Data Center, Cluster, Host etc.
> In each, you can see a text-box in which you can search for by writing a
> search expression My question is
> 1) What is the impact of your work on the search on the Fost and VM TABs
> a) Are there any fields that are supported now in the search
> expression
> and should pop-up when you write the expression by the
> auto-completion
> mechanism ?
> b) Are there any added columns displayed in the result of such a
> search
> in the grid ?
>
> > How about the engine-reports, could you give us some hints, like the
> > code location and any more detailed information that we can start more
> > investigation?
>
> CCing Yaniv D who is in charge of the reports/dwh module Yaniv, any planned
> work for adding Numa features to Host/VM in the reports side ?
>
> Thanks
>
> >
> > Thanks & Best Regards
> > Shi, Xiao-Lei (Bruce)
> >
> > Hewlett-Packard Co., Ltd.
> > HP Servers Core Platform Software China Telephone +86 23 65683093
> > Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> >
> > -----Original Message-----
> > From: Eli Mesika [mailto:emesika@redhat.com]
> > Sent: Sunday, March 23, 2014 4:44 PM
> > To: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
> > Cc: Doron Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun
> > (David Liang, HPservers-Core-OE-PSC); Shi, Xiao-Lei (Bruce, HP
> > Servers-PSC-CQ)
> > Subject: Re: Please help us to review our database schema design with
> > NUMA feature on ovirt
> >
> >
> >
> > ----- Original Message -----
> > > From: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > > <chuan.liao(a)hp.com>
> > > To: emesika(a)redhat.com
> > > Cc: "Doron Fediuck" <dfediuck(a)redhat.com>, "Gilad
Chaplik"
> > > <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>,
> > > "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
> > > <shangchun.liang(a)hp.com>, "Xiao-Lei Shi (Bruce, HP
Servers-PSC-CQ)"
> > > <xiao-lei.shi(a)hp.com>
> > > Sent: Friday, March 21, 2014 10:42:33 AM
> > > Subject: Please help us to review our database schema design with
> > > NUMA feature on ovirt
> > >
> > > Hi Eli,
> > >
> > > Please help us to review our database schema design with NUMA
> > > feature on ovirt
> > > https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcmbGWAcyQo_IST
> > > Y8
> > > ykDr0I6VY/edit?usp=sharing
> > >
> > > Feel free to take comments on document at anywhere
> >
> > Done, had commented on the document.
> > Eli
> >
> > >
> > > Especially, 5.4 The used interface between engine core and
> > > database(schema)
> > >
> > > Your approve and your comments with this section will be much more
> > > appreciate for us.
> > >
> > > Best Regards,
> > > Jason Liao
> > >
> > >
> >
>
4:38 a.m.
New subject: [Engine-devel] Please help us to review our database schema design with NUMA feature on ovirt
We put host level NUMA fields in vds_dynamic because these information are from host
itself, and NUMA topology may be changed if the host's hardware make a change. NUMA
information are similar to the host's cpu topology information like cpu_cores and
cpu_sockets which are in vds_dynamic, we refer to this.
VM level NUMA fields are configured by user, and actually we originally think they should
be in vm_dynamic. But we found that the field of another feature cpuPin which is similar
as NUMA feature is in vm_static, so we put vm NUMA fields in vm_static.
Do you think we need to put VM level NUMA fields in vm_dynamic?
Thanks & Best Regards
Shi, Xiao-Lei (Bruce)
Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China
Telephone +86 23 65683093
Mobile +86 18696583447
Email xiao-lei.shi(a)hp.com
-----Original Message-----
From: Gilad Chaplik [mailto:gchaplik@redhat.com]
Sent: Monday, March 31, 2014 5:22 PM
To: Eli Mesika; Roy Golan
Cc: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Liao, Chuan (Jason Liao,
HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang, Shang-Chun (David Liang,
HPservers-Core-OE-PSC); Yaniv Dary; engine-devel(a)ovirt.org
Subject: Re: Please help us to review our database schema design with NUMA feature on
ovirt
+1
IMO: vds data should reside in static
VM need to think about it.
Roy?
Thanks,
Gilad.
----- Original Message -----
From: "Eli Mesika" <emesika(a)redhat.com>
To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <xiao-lei.shi(a)hp.com>
Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>,
"Doron Fediuck" <dfediuck(a)redhat.com>,
"Gilad Chaplik" <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>, "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv Dary"
<ydary(a)redhat.com>, engine-devel(a)ovirt.org
Sent: Monday, March 31, 2014 12:12:50 PM
Subject: Re: Please help us to review our database schema design with NUMA feature on
ovirt
----- Original Message -----
> From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> To: "Eli Mesika" <emesika(a)redhat.com>
> Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
<chuan.liao(a)hp.com>,
> "Doron Fediuck" <dfediuck(a)redhat.com>,
> "Gilad Chaplik" <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>,
> "Shang-Chun Liang (David Liang,
> HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv
Dary"
> <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> Sent: Monday, March 31, 2014 8:56:20 AM
> Subject: RE: Please help us to review our database schema design with NUMA
> feature on ovirt
>
> Include the devel group.
> Thanks Eli for the quick responses for our first design and sorry for the
> nag.
> We appreciate any of the comments for our database design and will follow
> the
> design to do the implementation if no more comments.
> http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
Seems OK for me except an unanswered question I had asked in my first review
:
Why in the Host level NUMA fields are added to vds_dynamic while in the VM
level it is added to vm_static ???
I would expect it to be in both on static or dynamic , can you please explain
? Thanks
>
> Thanks & Best Regards
> Shi, Xiao-Lei (Bruce)
>
> Hewlett-Packard Co., Ltd.
> HP Servers Core Platform Software China
> Telephone +86 23 65683093
> Mobile +86 18696583447
> Email xiao-lei.shi(a)hp.com
>
> -----Original Message-----
> From: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> Sent: Friday, March 28, 2014 1:30 PM
> To: 'Eli Mesika'
> Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck; Gilad
> Chaplik; Vinod, Chegu; Liang, Shang-Chun (David Liang,
> HPservers-Core-OE-PSC); Yaniv Dary
> Subject: RE: Please help us to review our database schema design with NUMA
> feature on ovirt
>
> Hi Eli,
>
> After the UX design meeting, we did some modification for the database
> schema, and merged some update according to your last review comments.
> Now the document has been posted on ovirt wikipage, could you help to
> review
> the database design again:
> http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
>
>
> Thanks & Best Regards
> Shi, Xiao-Lei (Bruce)
>
> Hewlett-Packard Co., Ltd.
> HP Servers Core Platform Software China Telephone +86 23 65683093 Mobile
> +86
> 18696583447 Email xiao-lei.shi(a)hp.com
>
>
> -----Original Message-----
> From: Eli Mesika [mailto:emesika@redhat.com]
> Sent: Monday, March 24, 2014 6:24 PM
> To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck; Gilad
> Chaplik; Vinod, Chegu; Liang, Shang-Chun (David Liang,
> HPservers-Core-OE-PSC); Yaniv Dary
> Subject: Re: Please help us to review our database schema design with NUMA
> feature on ovirt
>
>
>
> ----- Original Message -----
> > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> > To: "Eli Mesika" <emesika(a)redhat.com>, "Chuan Liao (Jason
Liao,
> > HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>
> > Cc: "Doron Fediuck" <dfediuck(a)redhat.com>, "Gilad
Chaplik"
> > <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>, "Shang-Chun
> > Liang (David Liang, HPservers-Core-OE-PSC)"
<shangchun.liang(a)hp.com>
> > Sent: Monday, March 24, 2014 11:23:39 AM
> > Subject: RE: Please help us to review our database schema design with
> > NUMA feature on ovirt
> >
> > Hi Eli,
> >
> > Thanks for your comments.
> > I have updated the document according to your comments except the below
> > one:
> > Missing from here are 2 issues:
> >
> > 1) Impact on the search engine, which new columns are search-able and
> > which changes are planned in the search engine code to enable that
> >
> > 2) Impact on engine-reports, are those changed planned to be exposed
> > to the engine data warehouse and required new/modified reports?
> >
> > Could you tell us more detailed information about the modules you
> > mentioned above? I mean "search engine" and
"engine-reports". I think
> > we missed these two parts in our previous investigation.
> > I just find org.ovirt.engine.core.bll.SearchQuery, is that the right
> > object for search engine?
>
> Yes, actually when you are opening the admin UI, there are TABs for each
> entity , i.e. Data Center, Cluster, Host etc.
> In each, you can see a text-box in which you can search for by writing a
> search expression My question is
> 1) What is the impact of your work on the search on the Fost and VM TABs
> a) Are there any fields that are supported now in the search
> expression
> and should pop-up when you write the expression by the
> auto-completion
> mechanism ?
> b) Are there any added columns displayed in the result of such a
> search
> in the grid ?
>
> > How about the engine-reports, could you give us some hints, like the
> > code location and any more detailed information that we can start more
> > investigation?
>
> CCing Yaniv D who is in charge of the reports/dwh module Yaniv, any planned
> work for adding Numa features to Host/VM in the reports side ?
>
> Thanks
>
> >
> > Thanks & Best Regards
> > Shi, Xiao-Lei (Bruce)
> >
> > Hewlett-Packard Co., Ltd.
> > HP Servers Core Platform Software China Telephone +86 23 65683093
> > Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> >
> > -----Original Message-----
> > From: Eli Mesika [mailto:emesika@redhat.com]
> > Sent: Sunday, March 23, 2014 4:44 PM
> > To: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
> > Cc: Doron Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun
> > (David Liang, HPservers-Core-OE-PSC); Shi, Xiao-Lei (Bruce, HP
> > Servers-PSC-CQ)
> > Subject: Re: Please help us to review our database schema design with
> > NUMA feature on ovirt
> >
> >
> >
> > ----- Original Message -----
> > > From: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > > <chuan.liao(a)hp.com>
> > > To: emesika(a)redhat.com
> > > Cc: "Doron Fediuck" <dfediuck(a)redhat.com>, "Gilad
Chaplik"
> > > <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>,
> > > "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
> > > <shangchun.liang(a)hp.com>, "Xiao-Lei Shi (Bruce, HP
Servers-PSC-CQ)"
> > > <xiao-lei.shi(a)hp.com>
> > > Sent: Friday, March 21, 2014 10:42:33 AM
> > > Subject: Please help us to review our database schema design with
> > > NUMA feature on ovirt
> > >
> > > Hi Eli,
> > >
> > > Please help us to review our database schema design with NUMA
> > > feature on ovirt
> > > https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcmbGWAcyQo_IST
> > > Y8
> > > ykDr0I6VY/edit?usp=sharing
> > >
> > > Feel free to take comments on document at anywhere
> >
> > Done, had commented on the document.
> > Eli
> >
> > >
> > > Especially, 5.4 The used interface between engine core and
> > > database(schema)
> > >
> > > Your approve and your comments with this section will be much more
> > > appreciate for us.
> > >
> > > Best Regards,
> > > Jason Liao
> > >
> > >
> >
>
4:48 a.m.
New subject: [Engine-devel] Please help us to review our database schema design with NUMA feature on ovirt
----- Original Message -----
From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
To: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Eli Mesika"
<emesika(a)redhat.com>, "Roy Golan" <rgolan(a)redhat.com>
Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>,
"Doron Fediuck" <dfediuck(a)redhat.com>,
"Chegu Vinod" <chegu_vinod(a)hp.com>, "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)"
<shangchun.liang(a)hp.com>, "Yaniv Dary" <ydary(a)redhat.com>,
engine-devel(a)ovirt.org
Sent: Monday, March 31, 2014 12:38:04 PM
Subject: RE: Please help us to review our database schema design with NUMA feature on
ovirt
We put host level NUMA fields in vds_dynamic because these information are
from host itself, and NUMA topology may be changed if the host's hardware
make a change. NUMA information are similar to the host's cpu topology
information like cpu_cores and cpu_sockets which are in vds_dynamic, we
refer to this.
VM level NUMA fields are configured by user, and actually we originally think
they should be in vm_dynamic. But we found that the field of another feature
cpuPin which is similar as NUMA feature is in vm_static, so we put vm NUMA
fields in vm_static.
Do you think we need to put VM level NUMA fields in vm_dynamic?
I think that in this case we should fix cpuPin to be in vm_dynamic and put after that the
other NUMA fields in vm_dynamic as well
Thanks & Best Regards
Shi, Xiao-Lei (Bruce)
Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China
Telephone +86 23 65683093
Mobile +86 18696583447
Email xiao-lei.shi(a)hp.com
-----Original Message-----
From: Gilad Chaplik [mailto:gchaplik@redhat.com]
Sent: Monday, March 31, 2014 5:22 PM
To: Eli Mesika; Roy Golan
Cc: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Liao, Chuan (Jason Liao,
HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang, Shang-Chun
(David Liang, HPservers-Core-OE-PSC); Yaniv Dary; engine-devel(a)ovirt.org
Subject: Re: Please help us to review our database schema design with NUMA
feature on ovirt
+1
IMO: vds data should reside in static
VM need to think about it.
Roy?
Thanks,
Gilad.
----- Original Message -----
> From: "Eli Mesika" <emesika(a)redhat.com>
> To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <xiao-lei.shi(a)hp.com>
> Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
<chuan.liao(a)hp.com>,
> "Doron Fediuck" <dfediuck(a)redhat.com>,
> "Gilad Chaplik" <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>,
> "Shang-Chun Liang (David Liang,
> HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv Dary"
> <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> Sent: Monday, March 31, 2014 12:12:50 PM
> Subject: Re: Please help us to review our database schema design with NUMA
> feature on ovirt
>
>
>
> ----- Original Message -----
> > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> > To: "Eli Mesika" <emesika(a)redhat.com>
> > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
<chuan.liao(a)hp.com>,
> > "Doron Fediuck" <dfediuck(a)redhat.com>,
> > "Gilad Chaplik" <gchaplik(a)redhat.com>, "Chegu Vinod"
> > <chegu_vinod(a)hp.com>,
> > "Shang-Chun Liang (David Liang,
> > HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv
Dary"
> > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > Sent: Monday, March 31, 2014 8:56:20 AM
> > Subject: RE: Please help us to review our database schema design with
> > NUMA
> > feature on ovirt
> >
> > Include the devel group.
> > Thanks Eli for the quick responses for our first design and sorry for the
> > nag.
> > We appreciate any of the comments for our database design and will follow
> > the
> > design to do the implementation if no more comments.
> > http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
>
> Seems OK for me except an unanswered question I had asked in my first
> review
> :
>
> Why in the Host level NUMA fields are added to vds_dynamic while in the VM
> level it is added to vm_static ???
> I would expect it to be in both on static or dynamic , can you please
> explain
> ? Thanks
>
> >
> > Thanks & Best Regards
> > Shi, Xiao-Lei (Bruce)
> >
> > Hewlett-Packard Co., Ltd.
> > HP Servers Core Platform Software China
> > Telephone +86 23 65683093
> > Mobile +86 18696583447
> > Email xiao-lei.shi(a)hp.com
> >
> > -----Original Message-----
> > From: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > Sent: Friday, March 28, 2014 1:30 PM
> > To: 'Eli Mesika'
> > Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck; Gilad
> > Chaplik; Vinod, Chegu; Liang, Shang-Chun (David Liang,
> > HPservers-Core-OE-PSC); Yaniv Dary
> > Subject: RE: Please help us to review our database schema design with
> > NUMA
> > feature on ovirt
> >
> > Hi Eli,
> >
> > After the UX design meeting, we did some modification for the database
> > schema, and merged some update according to your last review comments.
> > Now the document has been posted on ovirt wikipage, could you help to
> > review
> > the database design again:
> > http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
> >
> >
> > Thanks & Best Regards
> > Shi, Xiao-Lei (Bruce)
> >
> > Hewlett-Packard Co., Ltd.
> > HP Servers Core Platform Software China Telephone +86 23 65683093 Mobile
> > +86
> > 18696583447 Email xiao-lei.shi(a)hp.com
> >
> >
> > -----Original Message-----
> > From: Eli Mesika [mailto:emesika@redhat.com]
> > Sent: Monday, March 24, 2014 6:24 PM
> > To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck; Gilad
> > Chaplik; Vinod, Chegu; Liang, Shang-Chun (David Liang,
> > HPservers-Core-OE-PSC); Yaniv Dary
> > Subject: Re: Please help us to review our database schema design with
> > NUMA
> > feature on ovirt
> >
> >
> >
> > ----- Original Message -----
> > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> > > To: "Eli Mesika" <emesika(a)redhat.com>, "Chuan Liao
(Jason Liao,
> > > HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>
> > > Cc: "Doron Fediuck" <dfediuck(a)redhat.com>, "Gilad
Chaplik"
> > > <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>, "Shang-Chun
> > > Liang (David Liang, HPservers-Core-OE-PSC)"
<shangchun.liang(a)hp.com>
> > > Sent: Monday, March 24, 2014 11:23:39 AM
> > > Subject: RE: Please help us to review our database schema design with
> > > NUMA feature on ovirt
> > >
> > > Hi Eli,
> > >
> > > Thanks for your comments.
> > > I have updated the document according to your comments except the below
> > > one:
> > > Missing from here are 2 issues:
> > >
> > > 1) Impact on the search engine, which new columns are search-able and
> > > which changes are planned in the search engine code to enable that
> > >
> > > 2) Impact on engine-reports, are those changed planned to be exposed
> > > to the engine data warehouse and required new/modified reports?
> > >
> > > Could you tell us more detailed information about the modules you
> > > mentioned above? I mean "search engine" and
"engine-reports". I think
> > > we missed these two parts in our previous investigation.
> > > I just find org.ovirt.engine.core.bll.SearchQuery, is that the right
> > > object for search engine?
> >
> > Yes, actually when you are opening the admin UI, there are TABs for each
> > entity , i.e. Data Center, Cluster, Host etc.
> > In each, you can see a text-box in which you can search for by writing a
> > search expression My question is
> > 1) What is the impact of your work on the search on the Fost and VM
> > TABs
> > a) Are there any fields that are supported now in the search
> > expression
> > and should pop-up when you write the expression by the
> > auto-completion
> > mechanism ?
> > b) Are there any added columns displayed in the result of such a
> > search
> > in the grid ?
> >
> > > How about the engine-reports, could you give us some hints, like the
> > > code location and any more detailed information that we can start more
> > > investigation?
> >
> > CCing Yaniv D who is in charge of the reports/dwh module Yaniv, any
> > planned
> > work for adding Numa features to Host/VM in the reports side ?
> >
> > Thanks
> >
> > >
> > > Thanks & Best Regards
> > > Shi, Xiao-Lei (Bruce)
> > >
> > > Hewlett-Packard Co., Ltd.
> > > HP Servers Core Platform Software China Telephone +86 23 65683093
> > > Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > >
> > > -----Original Message-----
> > > From: Eli Mesika [mailto:emesika@redhat.com]
> > > Sent: Sunday, March 23, 2014 4:44 PM
> > > To: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
> > > Cc: Doron Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun
> > > (David Liang, HPservers-Core-OE-PSC); Shi, Xiao-Lei (Bruce, HP
> > > Servers-PSC-CQ)
> > > Subject: Re: Please help us to review our database schema design with
> > > NUMA feature on ovirt
> > >
> > >
> > >
> > > ----- Original Message -----
> > > > From: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > > > <chuan.liao(a)hp.com>
> > > > To: emesika(a)redhat.com
> > > > Cc: "Doron Fediuck" <dfediuck(a)redhat.com>,
"Gilad Chaplik"
> > > > <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>,
> > > > "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
> > > > <shangchun.liang(a)hp.com>, "Xiao-Lei Shi (Bruce, HP
Servers-PSC-CQ)"
> > > > <xiao-lei.shi(a)hp.com>
> > > > Sent: Friday, March 21, 2014 10:42:33 AM
> > > > Subject: Please help us to review our database schema design with
> > > > NUMA feature on ovirt
> > > >
> > > > Hi Eli,
> > > >
> > > > Please help us to review our database schema design with NUMA
> > > > feature on ovirt
> > > > https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcmbGWAcyQo_IST
> > > > Y8
> > > > ykDr0I6VY/edit?usp=sharing
> > > >
> > > > Feel free to take comments on document at anywhere
> > >
> > > Done, had commented on the document.
> > > Eli
> > >
> > > >
> > > > Especially, 5.4 The used interface between engine core and
> > > > database(schema)
> > > >
> > > > Your approve and your comments with this section will be much more
> > > > appreciate for us.
> > > >
> > > > Best Regards,
> > > > Jason Liao
> > > >
> > > >
> > >
> >
>
7:20 a.m.
New subject: [Engine-devel] Please help us to review our database schema design with NUMA feature on ovirt
Thanks Eli.
I will move the vm level NUMA fields to vm_dynamic, and the related database schema will
be updated accordingly.
Thanks & Best Regards
Shi, Xiao-Lei (Bruce)
Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China
Telephone +86 23 65683093
Mobile +86 18696583447
Email xiao-lei.shi(a)hp.com
-----Original Message-----
From: Eli Mesika [mailto:emesika@redhat.com]
Sent: Monday, March 31, 2014 5:49 PM
To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
Cc: Gilad Chaplik; Roy Golan; Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron
Fediuck; Vinod, Chegu; Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
engine-devel(a)ovirt.org
Subject: Re: Please help us to review our database schema design with NUMA feature on
ovirt
----- Original Message -----
From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
To: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Eli Mesika"
<emesika(a)redhat.com>, "Roy Golan" <rgolan(a)redhat.com>
Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
<chuan.liao(a)hp.com>, "Doron Fediuck" <dfediuck(a)redhat.com>,
"Chegu Vinod" <chegu_vinod(a)hp.com>, "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)"
<shangchun.liang(a)hp.com>, "Yaniv Dary" <ydary(a)redhat.com>,
engine-devel(a)ovirt.org
Sent: Monday, March 31, 2014 12:38:04 PM
Subject: RE: Please help us to review our database schema design with
NUMA feature on ovirt
We put host level NUMA fields in vds_dynamic because these information
are from host itself, and NUMA topology may be changed if the host's
hardware make a change. NUMA information are similar to the host's cpu
topology information like cpu_cores and cpu_sockets which are in
vds_dynamic, we refer to this.
VM level NUMA fields are configured by user, and actually we
originally think they should be in vm_dynamic. But we found that the
field of another feature cpuPin which is similar as NUMA feature is in
vm_static, so we put vm NUMA fields in vm_static.
Do you think we need to put VM level NUMA fields in vm_dynamic?
I think that in this case we should fix cpuPin to be in vm_dynamic and put after that the
other NUMA fields in vm_dynamic as well
Thanks & Best Regards
Shi, Xiao-Lei (Bruce)
Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China Telephone +86 23 65683093
Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
-----Original Message-----
From: Gilad Chaplik [mailto:gchaplik@redhat.com]
Sent: Monday, March 31, 2014 5:22 PM
To: Eli Mesika; Roy Golan
Cc: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Liao, Chuan (Jason Liao,
HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang, Shang-Chun
(David Liang, HPservers-Core-OE-PSC); Yaniv Dary; engine-devel(a)ovirt.org
Subject: Re: Please help us to review our database schema design with NUMA
feature on ovirt
+1
IMO: vds data should reside in static
VM need to think about it.
Roy?
Thanks,
Gilad.
----- Original Message -----
> From: "Eli Mesika" <emesika(a)redhat.com>
> To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
<chuan.liao(a)hp.com>,
> "Doron Fediuck" <dfediuck(a)redhat.com>,
> "Gilad Chaplik" <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>,
> "Shang-Chun Liang (David Liang,
> HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv
Dary"
> <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> Sent: Monday, March 31, 2014 12:12:50 PM
> Subject: Re: Please help us to review our database schema design with NUMA
> feature on ovirt
>
>
>
> ----- Original Message -----
> > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> > To: "Eli Mesika" <emesika(a)redhat.com>
> > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
<chuan.liao(a)hp.com>,
> > "Doron Fediuck" <dfediuck(a)redhat.com>,
> > "Gilad Chaplik" <gchaplik(a)redhat.com>, "Chegu
Vinod"
> > <chegu_vinod(a)hp.com>,
> > "Shang-Chun Liang (David Liang,
> > HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv
Dary"
> > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > Sent: Monday, March 31, 2014 8:56:20 AM
> > Subject: RE: Please help us to review our database schema design with
> > NUMA
> > feature on ovirt
> >
> > Include the devel group.
> > Thanks Eli for the quick responses for our first design and sorry for the
> > nag.
> > We appreciate any of the comments for our database design and will follow
> > the
> > design to do the implementation if no more comments.
> > http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
>
> Seems OK for me except an unanswered question I had asked in my first
> review
> :
>
> Why in the Host level NUMA fields are added to vds_dynamic while in the VM
> level it is added to vm_static ???
> I would expect it to be in both on static or dynamic , can you please
> explain
> ? Thanks
>
> >
> > Thanks & Best Regards
> > Shi, Xiao-Lei (Bruce)
> >
> > Hewlett-Packard Co., Ltd.
> > HP Servers Core Platform Software China
> > Telephone +86 23 65683093
> > Mobile +86 18696583447
> > Email xiao-lei.shi(a)hp.com
> >
> > -----Original Message-----
> > From: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > Sent: Friday, March 28, 2014 1:30 PM
> > To: 'Eli Mesika'
> > Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck; Gilad
> > Chaplik; Vinod, Chegu; Liang, Shang-Chun (David Liang,
> > HPservers-Core-OE-PSC); Yaniv Dary
> > Subject: RE: Please help us to review our database schema design with
> > NUMA
> > feature on ovirt
> >
> > Hi Eli,
> >
> > After the UX design meeting, we did some modification for the database
> > schema, and merged some update according to your last review comments.
> > Now the document has been posted on ovirt wikipage, could you help to
> > review
> > the database design again:
> > http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
> >
> >
> > Thanks & Best Regards
> > Shi, Xiao-Lei (Bruce)
> >
> > Hewlett-Packard Co., Ltd.
> > HP Servers Core Platform Software China Telephone +86 23 65683093 Mobile
> > +86
> > 18696583447 Email xiao-lei.shi(a)hp.com
> >
> >
> > -----Original Message-----
> > From: Eli Mesika [mailto:emesika@redhat.com]
> > Sent: Monday, March 24, 2014 6:24 PM
> > To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck; Gilad
> > Chaplik; Vinod, Chegu; Liang, Shang-Chun (David Liang,
> > HPservers-Core-OE-PSC); Yaniv Dary
> > Subject: Re: Please help us to review our database schema design with
> > NUMA
> > feature on ovirt
> >
> >
> >
> > ----- Original Message -----
> > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> > > To: "Eli Mesika" <emesika(a)redhat.com>, "Chuan Liao
(Jason Liao,
> > > HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>
> > > Cc: "Doron Fediuck" <dfediuck(a)redhat.com>, "Gilad
Chaplik"
> > > <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>, "Shang-Chun
> > > Liang (David Liang, HPservers-Core-OE-PSC)"
<shangchun.liang(a)hp.com>
> > > Sent: Monday, March 24, 2014 11:23:39 AM
> > > Subject: RE: Please help us to review our database schema design with
> > > NUMA feature on ovirt
> > >
> > > Hi Eli,
> > >
> > > Thanks for your comments.
> > > I have updated the document according to your comments except the below
> > > one:
> > > Missing from here are 2 issues:
> > >
> > > 1) Impact on the search engine, which new columns are search-able and
> > > which changes are planned in the search engine code to enable that
> > >
> > > 2) Impact on engine-reports, are those changed planned to be exposed
> > > to the engine data warehouse and required new/modified reports?
> > >
> > > Could you tell us more detailed information about the modules you
> > > mentioned above? I mean "search engine" and
"engine-reports". I think
> > > we missed these two parts in our previous investigation.
> > > I just find org.ovirt.engine.core.bll.SearchQuery, is that the right
> > > object for search engine?
> >
> > Yes, actually when you are opening the admin UI, there are TABs for each
> > entity , i.e. Data Center, Cluster, Host etc.
> > In each, you can see a text-box in which you can search for by writing a
> > search expression My question is
> > 1) What is the impact of your work on the search on the Fost and VM
> > TABs
> > a) Are there any fields that are supported now in the search
> > expression
> > and should pop-up when you write the expression by the
> > auto-completion
> > mechanism ?
> > b) Are there any added columns displayed in the result of such a
> > search
> > in the grid ?
> >
> > > How about the engine-reports, could you give us some hints, like the
> > > code location and any more detailed information that we can start more
> > > investigation?
> >
> > CCing Yaniv D who is in charge of the reports/dwh module Yaniv, any
> > planned
> > work for adding Numa features to Host/VM in the reports side ?
> >
> > Thanks
> >
> > >
> > > Thanks & Best Regards
> > > Shi, Xiao-Lei (Bruce)
> > >
> > > Hewlett-Packard Co., Ltd.
> > > HP Servers Core Platform Software China Telephone +86 23 65683093
> > > Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > >
> > > -----Original Message-----
> > > From: Eli Mesika [mailto:emesika@redhat.com]
> > > Sent: Sunday, March 23, 2014 4:44 PM
> > > To: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
> > > Cc: Doron Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun
> > > (David Liang, HPservers-Core-OE-PSC); Shi, Xiao-Lei (Bruce, HP
> > > Servers-PSC-CQ)
> > > Subject: Re: Please help us to review our database schema design with
> > > NUMA feature on ovirt
> > >
> > >
> > >
> > > ----- Original Message -----
> > > > From: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > > > <chuan.liao(a)hp.com>
> > > > To: emesika(a)redhat.com
> > > > Cc: "Doron Fediuck" <dfediuck(a)redhat.com>,
"Gilad Chaplik"
> > > > <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>,
> > > > "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
> > > > <shangchun.liang(a)hp.com>, "Xiao-Lei Shi (Bruce, HP
Servers-PSC-CQ)"
> > > > <xiao-lei.shi(a)hp.com>
> > > > Sent: Friday, March 21, 2014 10:42:33 AM
> > > > Subject: Please help us to review our database schema design with
> > > > NUMA feature on ovirt
> > > >
> > > > Hi Eli,
> > > >
> > > > Please help us to review our database schema design with NUMA
> > > > feature on ovirt
> > > >
https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcmbGWAcyQo_IST
> > > > Y8
> > > > ykDr0I6VY/edit?usp=sharing
> > > >
> > > > Feel free to take comments on document at anywhere
> > >
> > > Done, had commented on the document.
> > > Eli
> > >
> > > >
> > > > Especially, 5.4 The used interface between engine core and
> > > > database(schema)
> > > >
> > > > Your approve and your comments with this section will be much more
> > > > appreciate for us.
> > > >
> > > > Best Regards,
> > > > Jason Liao
> > > >
> > > >
> > >
> >
>
8:31 a.m.
New subject: [Engine-devel] Please help us to review our database schema design with NUMA feature on ovirt
adding Roy & Omer.
why CPU topology is in dynamic?
Thanks,
Gilad.
----- Original Message -----
From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
To: "Eli Mesika" <emesika(a)redhat.com>
Cc: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Roy Golan"
<rgolan(a)redhat.com>, "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>, "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv Dary"
<ydary(a)redhat.com>, engine-devel(a)ovirt.org
Sent: Monday, March 31, 2014 3:20:33 PM
Subject: RE: Please help us to review our database schema design with NUMA feature on
ovirt
Thanks Eli.
I will move the vm level NUMA fields to vm_dynamic, and the related database
schema will be updated accordingly.
Thanks & Best Regards
Shi, Xiao-Lei (Bruce)
Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China
Telephone +86 23 65683093
Mobile +86 18696583447
Email xiao-lei.shi(a)hp.com
-----Original Message-----
From: Eli Mesika [mailto:emesika@redhat.com]
Sent: Monday, March 31, 2014 5:49 PM
To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
Cc: Gilad Chaplik; Roy Golan; Liao, Chuan (Jason Liao,
HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang, Shang-Chun
(David Liang, HPservers-Core-OE-PSC); Yaniv Dary; engine-devel(a)ovirt.org
Subject: Re: Please help us to review our database schema design with NUMA
feature on ovirt
----- Original Message -----
> From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> To: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Eli Mesika"
> <emesika(a)redhat.com>, "Roy Golan" <rgolan(a)redhat.com>
> Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> <chuan.liao(a)hp.com>, "Doron Fediuck" <dfediuck(a)redhat.com>,
"Chegu Vinod"
> <chegu_vinod(a)hp.com>, "Shang-Chun Liang (David Liang,
> HPservers-Core-OE-PSC)"
> <shangchun.liang(a)hp.com>, "Yaniv Dary" <ydary(a)redhat.com>,
> engine-devel(a)ovirt.org
> Sent: Monday, March 31, 2014 12:38:04 PM
> Subject: RE: Please help us to review our database schema design with
> NUMA feature on ovirt
>
> We put host level NUMA fields in vds_dynamic because these information
> are from host itself, and NUMA topology may be changed if the host's
> hardware make a change. NUMA information are similar to the host's cpu
> topology information like cpu_cores and cpu_sockets which are in
> vds_dynamic, we refer to this.
> VM level NUMA fields are configured by user, and actually we
> originally think they should be in vm_dynamic. But we found that the
> field of another feature cpuPin which is similar as NUMA feature is in
> vm_static, so we put vm NUMA fields in vm_static.
> Do you think we need to put VM level NUMA fields in vm_dynamic?
I think that in this case we should fix cpuPin to be in vm_dynamic and put
after that the other NUMA fields in vm_dynamic as well
>
> Thanks & Best Regards
> Shi, Xiao-Lei (Bruce)
>
> Hewlett-Packard Co., Ltd.
> HP Servers Core Platform Software China Telephone +86 23 65683093
> Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
>
>
> -----Original Message-----
> From: Gilad Chaplik [mailto:gchaplik@redhat.com]
> Sent: Monday, March 31, 2014 5:22 PM
> To: Eli Mesika; Roy Golan
> Cc: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Liao, Chuan (Jason Liao,
> HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang, Shang-Chun
> (David Liang, HPservers-Core-OE-PSC); Yaniv Dary; engine-devel(a)ovirt.org
> Subject: Re: Please help us to review our database schema design with NUMA
> feature on ovirt
>
> +1
>
> IMO: vds data should reside in static
> VM need to think about it.
>
> Roy?
>
> Thanks,
> Gilad.
>
>
> ----- Original Message -----
> > From: "Eli Mesika" <emesika(a)redhat.com>
> > To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
<chuan.liao(a)hp.com>,
> > "Doron Fediuck" <dfediuck(a)redhat.com>,
> > "Gilad Chaplik" <gchaplik(a)redhat.com>, "Chegu Vinod"
> > <chegu_vinod(a)hp.com>,
> > "Shang-Chun Liang (David Liang,
> > HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv
Dary"
> > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > Sent: Monday, March 31, 2014 12:12:50 PM
> > Subject: Re: Please help us to review our database schema design with
> > NUMA
> > feature on ovirt
> >
> >
> >
> > ----- Original Message -----
> > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> > > To: "Eli Mesika" <emesika(a)redhat.com>
> > > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > > <chuan.liao(a)hp.com>,
> > > "Doron Fediuck" <dfediuck(a)redhat.com>,
> > > "Gilad Chaplik" <gchaplik(a)redhat.com>, "Chegu
Vinod"
> > > <chegu_vinod(a)hp.com>,
> > > "Shang-Chun Liang (David Liang,
> > > HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv
Dary"
> > > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > > Sent: Monday, March 31, 2014 8:56:20 AM
> > > Subject: RE: Please help us to review our database schema design with
> > > NUMA
> > > feature on ovirt
> > >
> > > Include the devel group.
> > > Thanks Eli for the quick responses for our first design and sorry for
> > > the
> > > nag.
> > > We appreciate any of the comments for our database design and will
> > > follow
> > > the
> > > design to do the implementation if no more comments.
> > > http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
> >
> > Seems OK for me except an unanswered question I had asked in my first
> > review
> > :
> >
> > Why in the Host level NUMA fields are added to vds_dynamic while in the
> > VM
> > level it is added to vm_static ???
> > I would expect it to be in both on static or dynamic , can you please
> > explain
> > ? Thanks
> >
> > >
> > > Thanks & Best Regards
> > > Shi, Xiao-Lei (Bruce)
> > >
> > > Hewlett-Packard Co., Ltd.
> > > HP Servers Core Platform Software China
> > > Telephone +86 23 65683093
> > > Mobile +86 18696583447
> > > Email xiao-lei.shi(a)hp.com
> > >
> > > -----Original Message-----
> > > From: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > Sent: Friday, March 28, 2014 1:30 PM
> > > To: 'Eli Mesika'
> > > Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck;
> > > Gilad
> > > Chaplik; Vinod, Chegu; Liang, Shang-Chun (David Liang,
> > > HPservers-Core-OE-PSC); Yaniv Dary
> > > Subject: RE: Please help us to review our database schema design with
> > > NUMA
> > > feature on ovirt
> > >
> > > Hi Eli,
> > >
> > > After the UX design meeting, we did some modification for the database
> > > schema, and merged some update according to your last review comments.
> > > Now the document has been posted on ovirt wikipage, could you help to
> > > review
> > > the database design again:
> > > http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
> > >
> > >
> > > Thanks & Best Regards
> > > Shi, Xiao-Lei (Bruce)
> > >
> > > Hewlett-Packard Co., Ltd.
> > > HP Servers Core Platform Software China Telephone +86 23 65683093
> > > Mobile
> > > +86
> > > 18696583447 Email xiao-lei.shi(a)hp.com
> > >
> > >
> > > -----Original Message-----
> > > From: Eli Mesika [mailto:emesika@redhat.com]
> > > Sent: Monday, March 24, 2014 6:24 PM
> > > To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck;
> > > Gilad
> > > Chaplik; Vinod, Chegu; Liang, Shang-Chun (David Liang,
> > > HPservers-Core-OE-PSC); Yaniv Dary
> > > Subject: Re: Please help us to review our database schema design with
> > > NUMA
> > > feature on ovirt
> > >
> > >
> > >
> > > ----- Original Message -----
> > > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> > > > To: "Eli Mesika" <emesika(a)redhat.com>, "Chuan
Liao (Jason Liao,
> > > > HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>
> > > > Cc: "Doron Fediuck" <dfediuck(a)redhat.com>,
"Gilad Chaplik"
> > > > <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>,
> > > > "Shang-Chun
> > > > Liang (David Liang, HPservers-Core-OE-PSC)"
<shangchun.liang(a)hp.com>
> > > > Sent: Monday, March 24, 2014 11:23:39 AM
> > > > Subject: RE: Please help us to review our database schema design
with
> > > > NUMA feature on ovirt
> > > >
> > > > Hi Eli,
> > > >
> > > > Thanks for your comments.
> > > > I have updated the document according to your comments except the
> > > > below
> > > > one:
> > > > Missing from here are 2 issues:
> > > >
> > > > 1) Impact on the search engine, which new columns are search-able
and
> > > > which changes are planned in the search engine code to enable that
> > > >
> > > > 2) Impact on engine-reports, are those changed planned to be exposed
> > > > to the engine data warehouse and required new/modified reports?
> > > >
> > > > Could you tell us more detailed information about the modules you
> > > > mentioned above? I mean "search engine" and
"engine-reports". I think
> > > > we missed these two parts in our previous investigation.
> > > > I just find org.ovirt.engine.core.bll.SearchQuery, is that the right
> > > > object for search engine?
> > >
> > > Yes, actually when you are opening the admin UI, there are TABs for
> > > each
> > > entity , i.e. Data Center, Cluster, Host etc.
> > > In each, you can see a text-box in which you can search for by writing
> > > a
> > > search expression My question is
> > > 1) What is the impact of your work on the search on the Fost and VM
> > > TABs
> > > a) Are there any fields that are supported now in the search
> > > expression
> > > and should pop-up when you write the expression by the
> > > auto-completion
> > > mechanism ?
> > > b) Are there any added columns displayed in the result of such a
> > > search
> > > in the grid ?
> > >
> > > > How about the engine-reports, could you give us some hints, like the
> > > > code location and any more detailed information that we can start
> > > > more
> > > > investigation?
> > >
> > > CCing Yaniv D who is in charge of the reports/dwh module Yaniv, any
> > > planned
> > > work for adding Numa features to Host/VM in the reports side ?
> > >
> > > Thanks
> > >
> > > >
> > > > Thanks & Best Regards
> > > > Shi, Xiao-Lei (Bruce)
> > > >
> > > > Hewlett-Packard Co., Ltd.
> > > > HP Servers Core Platform Software China Telephone +86 23 65683093
> > > > Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > > >
> > > > -----Original Message-----
> > > > From: Eli Mesika [mailto:emesika@redhat.com]
> > > > Sent: Sunday, March 23, 2014 4:44 PM
> > > > To: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
> > > > Cc: Doron Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun
> > > > (David Liang, HPservers-Core-OE-PSC); Shi, Xiao-Lei (Bruce, HP
> > > > Servers-PSC-CQ)
> > > > Subject: Re: Please help us to review our database schema design
with
> > > > NUMA feature on ovirt
> > > >
> > > >
> > > >
> > > > ----- Original Message -----
> > > > > From: "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)"
> > > > > <chuan.liao(a)hp.com>
> > > > > To: emesika(a)redhat.com
> > > > > Cc: "Doron Fediuck" <dfediuck(a)redhat.com>,
"Gilad Chaplik"
> > > > > <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>,
> > > > > "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)"
> > > > > <shangchun.liang(a)hp.com>, "Xiao-Lei Shi (Bruce, HP
Servers-PSC-CQ)"
> > > > > <xiao-lei.shi(a)hp.com>
> > > > > Sent: Friday, March 21, 2014 10:42:33 AM
> > > > > Subject: Please help us to review our database schema design
with
> > > > > NUMA feature on ovirt
> > > > >
> > > > > Hi Eli,
> > > > >
> > > > > Please help us to review our database schema design with NUMA
> > > > > feature on ovirt
> > > > >
https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcmbGWAcyQo_IST
> > > > > Y8
> > > > > ykDr0I6VY/edit?usp=sharing
> > > > >
> > > > > Feel free to take comments on document at anywhere
> > > >
> > > > Done, had commented on the document.
> > > > Eli
> > > >
> > > > >
> > > > > Especially, 5.4 The used interface between engine core and
> > > > > database(schema)
> > > > >
> > > > > Your approve and your comments with this section will be much
more
> > > > > appreciate for us.
> > > > >
> > > > > Best Regards,
> > > > > Jason Liao
> > > > >
> > > > >
> > > >
> > >
> >
>
9:51 a.m.
New subject: [Engine-devel] Please help us to review our database schema design with NUMA feature on ovirt
On 3/31/2014 2:38 AM, Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ) wrote:
We put host level NUMA fields in vds_dynamic because these
information are from host itself, and NUMA topology may be changed if the host's
hardware make a change.
Can you please elaborate ? Are you thinking about resource
(cpu and/or
memory) hot plug on the host ?
Vinod
NUMA information are similar to the host's cpu topology
information like cpu_cores and cpu_sockets which are in vds_dynamic, we refer to this.
VM level NUMA fields are configured by user, and actually we originally think they should
be in vm_dynamic. But we found that the field of another feature cpuPin which is similar
as NUMA feature is in vm_static, so we put vm NUMA fields in vm_static.
Do you think we need to put VM level NUMA fields in vm_dynamic?
Thanks & Best Regards
Shi, Xiao-Lei (Bruce)
Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China
Telephone +86 23 65683093
Mobile +86 18696583447
Email xiao-lei.shi(a)hp.com
-----Original Message-----
From: Gilad Chaplik [mailto:gchaplik@redhat.com]
Sent: Monday, March 31, 2014 5:22 PM
To: Eli Mesika; Roy Golan
Cc: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Liao, Chuan (Jason Liao,
HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang, Shang-Chun (David Liang,
HPservers-Core-OE-PSC); Yaniv Dary; engine-devel(a)ovirt.org
Subject: Re: Please help us to review our database schema design with NUMA feature on
ovirt
+1
IMO: vds data should reside in static
VM need to think about it.
Roy?
Thanks,
Gilad.
----- Original Message -----
> From: "Eli Mesika" <emesika(a)redhat.com>
> To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <xiao-lei.shi(a)hp.com>
> Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
<chuan.liao(a)hp.com>, "Doron Fediuck" <dfediuck(a)redhat.com>,
> "Gilad Chaplik" <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>, "Shang-Chun Liang (David Liang,
> HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv Dary"
<ydary(a)redhat.com>, engine-devel(a)ovirt.org
> Sent: Monday, March 31, 2014 12:12:50 PM
> Subject: Re: Please help us to review our database schema design with NUMA feature on
ovirt
>
>
>
> ----- Original Message -----
>> From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
>> To: "Eli Mesika" <emesika(a)redhat.com>
>> Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
<chuan.liao(a)hp.com>,
>> "Doron Fediuck" <dfediuck(a)redhat.com>,
>> "Gilad Chaplik" <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>,
>> "Shang-Chun Liang (David Liang,
>> HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv
Dary"
>> <ydary(a)redhat.com>, engine-devel(a)ovirt.org
>> Sent: Monday, March 31, 2014 8:56:20 AM
>> Subject: RE: Please help us to review our database schema design with NUMA
>> feature on ovirt
>>
>> Include the devel group.
>> Thanks Eli for the quick responses for our first design and sorry for the
>> nag.
>> We appreciate any of the comments for our database design and will follow
>> the
>> design to do the implementation if no more comments.
>> http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
> Seems OK for me except an unanswered question I had asked in my first review
> :
>
> Why in the Host level NUMA fields are added to vds_dynamic while in the VM
> level it is added to vm_static ???
> I would expect it to be in both on static or dynamic , can you please explain
> ? Thanks
>
>> Thanks & Best Regards
>> Shi, Xiao-Lei (Bruce)
>>
>> Hewlett-Packard Co., Ltd.
>> HP Servers Core Platform Software China
>> Telephone +86 23 65683093
>> Mobile +86 18696583447
>> Email xiao-lei.shi(a)hp.com
>>
>> -----Original Message-----
>> From: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
>> Sent: Friday, March 28, 2014 1:30 PM
>> To: 'Eli Mesika'
>> Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck; Gilad
>> Chaplik; Vinod, Chegu; Liang, Shang-Chun (David Liang,
>> HPservers-Core-OE-PSC); Yaniv Dary
>> Subject: RE: Please help us to review our database schema design with NUMA
>> feature on ovirt
>>
>> Hi Eli,
>>
>> After the UX design meeting, we did some modification for the database
>> schema, and merged some update according to your last review comments.
>> Now the document has been posted on ovirt wikipage, could you help to
>> review
>> the database design again:
>> http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
>>
>>
>> Thanks & Best Regards
>> Shi, Xiao-Lei (Bruce)
>>
>> Hewlett-Packard Co., Ltd.
>> HP Servers Core Platform Software China Telephone +86 23 65683093 Mobile
>> +86
>> 18696583447 Email xiao-lei.shi(a)hp.com
>>
>>
>> -----Original Message-----
>> From: Eli Mesika [mailto:emesika@redhat.com]
>> Sent: Monday, March 24, 2014 6:24 PM
>> To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
>> Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck; Gilad
>> Chaplik; Vinod, Chegu; Liang, Shang-Chun (David Liang,
>> HPservers-Core-OE-PSC); Yaniv Dary
>> Subject: Re: Please help us to review our database schema design with NUMA
>> feature on ovirt
>>
>>
>>
>> ----- Original Message -----
>>> From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
>>> To: "Eli Mesika" <emesika(a)redhat.com>, "Chuan Liao
(Jason Liao,
>>> HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>
>>> Cc: "Doron Fediuck" <dfediuck(a)redhat.com>, "Gilad
Chaplik"
>>> <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>, "Shang-Chun
>>> Liang (David Liang, HPservers-Core-OE-PSC)"
<shangchun.liang(a)hp.com>
>>> Sent: Monday, March 24, 2014 11:23:39 AM
>>> Subject: RE: Please help us to review our database schema design with
>>> NUMA feature on ovirt
>>>
>>> Hi Eli,
>>>
>>> Thanks for your comments.
>>> I have updated the document according to your comments except the below
>>> one:
>>> Missing from here are 2 issues:
>>>
>>> 1) Impact on the search engine, which new columns are search-able and
>>> which changes are planned in the search engine code to enable that
>>>
>>> 2) Impact on engine-reports, are those changed planned to be exposed
>>> to the engine data warehouse and required new/modified reports?
>>>
>>> Could you tell us more detailed information about the modules you
>>> mentioned above? I mean "search engine" and
"engine-reports". I think
>>> we missed these two parts in our previous investigation.
>>> I just find org.ovirt.engine.core.bll.SearchQuery, is that the right
>>> object for search engine?
>> Yes, actually when you are opening the admin UI, there are TABs for each
>> entity , i.e. Data Center, Cluster, Host etc.
>> In each, you can see a text-box in which you can search for by writing a
>> search expression My question is
>> 1) What is the impact of your work on the search on the Fost and VM TABs
>> a) Are there any fields that are supported now in the search
>> expression
>> and should pop-up when you write the expression by the
>> auto-completion
>> mechanism ?
>> b) Are there any added columns displayed in the result of such a
>> search
>> in the grid ?
>>
>>> How about the engine-reports, could you give us some hints, like the
>>> code location and any more detailed information that we can start more
>>> investigation?
>> CCing Yaniv D who is in charge of the reports/dwh module Yaniv, any planned
>> work for adding Numa features to Host/VM in the reports side ?
>>
>> Thanks
>>
>>> Thanks & Best Regards
>>> Shi, Xiao-Lei (Bruce)
>>>
>>> Hewlett-Packard Co., Ltd.
>>> HP Servers Core Platform Software China Telephone +86 23 65683093
>>> Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
>>>
>>> -----Original Message-----
>>> From: Eli Mesika [mailto:emesika@redhat.com]
>>> Sent: Sunday, March 23, 2014 4:44 PM
>>> To: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
>>> Cc: Doron Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun
>>> (David Liang, HPservers-Core-OE-PSC); Shi, Xiao-Lei (Bruce, HP
>>> Servers-PSC-CQ)
>>> Subject: Re: Please help us to review our database schema design with
>>> NUMA feature on ovirt
>>>
>>>
>>>
>>> ----- Original Message -----
>>>> From: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
>>>> <chuan.liao(a)hp.com>
>>>> To: emesika(a)redhat.com
>>>> Cc: "Doron Fediuck" <dfediuck(a)redhat.com>, "Gilad
Chaplik"
>>>> <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>,
>>>> "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
>>>> <shangchun.liang(a)hp.com>, "Xiao-Lei Shi (Bruce, HP
Servers-PSC-CQ)"
>>>> <xiao-lei.shi(a)hp.com>
>>>> Sent: Friday, March 21, 2014 10:42:33 AM
>>>> Subject: Please help us to review our database schema design with
>>>> NUMA feature on ovirt
>>>>
>>>> Hi Eli,
>>>>
>>>> Please help us to review our database schema design with NUMA
>>>> feature on ovirt
>>>> https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcmbGWAcyQo_IST
>>>> Y8
>>>> ykDr0I6VY/edit?usp=sharing
>>>>
>>>> Feel free to take comments on document at anywhere
>>> Done, had commented on the document.
>>> Eli
>>>
>>>> Especially, 5.4 The used interface between engine core and
>>>> database(schema)
>>>>
>>>> Your approve and your comments with this section will be much more
>>>> appreciate for us.
>>>>
>>>> Best Regards,
>>>> Jason Liao
>>>>
>>>>
9:13 p.m.
New subject: [Engine-devel] Please help us to review our database schema design with NUMA feature on ovirt
Assemble the related discussions in this mail session.
Hi Vinod,
On 3/31/2014 2:38 AM, Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ) wrote:
We put host level NUMA fields in vds_dynamic because these
information are from host itself, and NUMA topology may be changed if the host's
hardware make a change.
Can you please elaborate ? Are you thinking about resource (cpu and/or
memory) hot plug on the host ?
[Bruce] It's not about resource hot plug. In ovirt engine, there is a scheduled task
which will refresh hosts' and vms' information periodically. Only the dynamic and
statistics data will be updated during the refresh. So I think the resource information,
such as cpu and/or memory, should be in dynamic and statistics. And in my understanding,
the information in dynamic class is the changeable information but with a low varying
frequency, like cpu topology, libvirt/kernel versions, etc. The information in statistics
class is the information with a high varying frequency, like the usage of cpu/memory, etc.
In my opinion, it's reasonable to put host level NUMA information in vds_dynamic and
host level NUMA statistics information in vds_statistics.
Hi Gilad/Roy/Omer,
I don't know if my understanding is correct. But according to this guess, I think
it's also reasonable to put vm cpuPin information in vm_static. Because cpuPin is user
configured information, it will not vary automatically. So we don’t need to refresh this
information periodically. Please correct me if there are any mistakes.
Hi Eli,
Sorry for the nag. If my understanding above is correct, I think we should still put host
level NUMA fields in vds_dynamic/vds_statistics and vm level NUMA fields in vm_static.
Since vm level NUMA fields are configured by user and they will not vary automatically.
Thanks & Best Regards
Shi, Xiao-Lei (Bruce)
Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China
Telephone +86 23 65683093
Mobile +86 18696583447
Email xiao-lei.shi(a)hp.com
-----Original Message-----
From: Gilad Chaplik [mailto:gchaplik@redhat.com]
Sent: Monday, March 31, 2014 9:31 PM
To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Roy Golan; Omer Frenkel
Cc: Eli Mesika; Roy Golan; Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck;
Vinod, Chegu; Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
engine-devel(a)ovirt.org
Subject: Re: Please help us to review our database schema design with NUMA feature on
ovirt
adding Roy & Omer.
why CPU topology is in dynamic?
Thanks,
Gilad.
----- Original Message -----
From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
To: "Eli Mesika" <emesika(a)redhat.com>
Cc: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Roy Golan"
<rgolan(a)redhat.com>, "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
<chuan.liao(a)hp.com>, "Doron Fediuck" <dfediuck(a)redhat.com>,
"Chegu Vinod"
<chegu_vinod(a)hp.com>, "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv Dary"
<ydary(a)redhat.com>, engine-devel(a)ovirt.org
Sent: Monday, March 31, 2014 3:20:33 PM
Subject: RE: Please help us to review our database schema design with
NUMA feature on ovirt
Thanks Eli.
I will move the vm level NUMA fields to vm_dynamic, and the related
database schema will be updated accordingly.
Thanks & Best Regards
Shi, Xiao-Lei (Bruce)
Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China Telephone +86 23 65683093
Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
-----Original Message-----
From: Eli Mesika [mailto:emesika@redhat.com]
Sent: Monday, March 31, 2014 5:49 PM
To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
Cc: Gilad Chaplik; Roy Golan; Liao, Chuan (Jason Liao,
HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang, Shang-Chun
(David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
engine-devel(a)ovirt.org
Subject: Re: Please help us to review our database schema design with
NUMA feature on ovirt
----- Original Message -----
> From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> <xiao-lei.shi(a)hp.com>
> To: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Eli Mesika"
> <emesika(a)redhat.com>, "Roy Golan" <rgolan(a)redhat.com>
> Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> <chuan.liao(a)hp.com>, "Doron Fediuck" <dfediuck(a)redhat.com>,
"Chegu Vinod"
> <chegu_vinod(a)hp.com>, "Shang-Chun Liang (David Liang,
> HPservers-Core-OE-PSC)"
> <shangchun.liang(a)hp.com>, "Yaniv Dary" <ydary(a)redhat.com>,
> engine-devel(a)ovirt.org
> Sent: Monday, March 31, 2014 12:38:04 PM
> Subject: RE: Please help us to review our database schema design
> with NUMA feature on ovirt
>
> We put host level NUMA fields in vds_dynamic because these
> information are from host itself, and NUMA topology may be changed
> if the host's hardware make a change. NUMA information are similar
> to the host's cpu topology information like cpu_cores and
> cpu_sockets which are in vds_dynamic, we refer to this.
> VM level NUMA fields are configured by user, and actually we
> originally think they should be in vm_dynamic. But we found that the
> field of another feature cpuPin which is similar as NUMA feature is
> in vm_static, so we put vm NUMA fields in vm_static.
> Do you think we need to put VM level NUMA fields in vm_dynamic?
I think that in this case we should fix cpuPin to be in vm_dynamic and
put after that the other NUMA fields in vm_dynamic as well
>
> Thanks & Best Regards
> Shi, Xiao-Lei (Bruce)
>
> Hewlett-Packard Co., Ltd.
> HP Servers Core Platform Software China Telephone +86 23 65683093
> Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
>
>
> -----Original Message-----
> From: Gilad Chaplik [mailto:gchaplik@redhat.com]
> Sent: Monday, March 31, 2014 5:22 PM
> To: Eli Mesika; Roy Golan
> Cc: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Liao, Chuan (Jason
> Liao, HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang,
> Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
> engine-devel(a)ovirt.org
> Subject: Re: Please help us to review our database schema design
> with NUMA feature on ovirt
>
> +1
>
> IMO: vds data should reside in static VM need to think about it.
>
> Roy?
>
> Thanks,
> Gilad.
>
>
> ----- Original Message -----
> > From: "Eli Mesika" <emesika(a)redhat.com>
> > To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > <xiao-lei.shi(a)hp.com>
> > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>, "Gilad
> > Chaplik" <gchaplik(a)redhat.com>, "Chegu Vinod"
> > <chegu_vinod(a)hp.com>,
> > "Shang-Chun Liang (David Liang,
> > HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv
Dary"
> > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > Sent: Monday, March 31, 2014 12:12:50 PM
> > Subject: Re: Please help us to review our database schema design
> > with NUMA feature on ovirt
> >
> >
> >
> > ----- Original Message -----
> > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > <xiao-lei.shi(a)hp.com>
> > > To: "Eli Mesika" <emesika(a)redhat.com>
> > > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > > <chuan.liao(a)hp.com>,
> > > "Doron Fediuck" <dfediuck(a)redhat.com>, "Gilad
Chaplik"
> > > <gchaplik(a)redhat.com>, "Chegu Vinod"
> > > <chegu_vinod(a)hp.com>,
> > > "Shang-Chun Liang (David Liang,
> > > HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv
Dary"
> > > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > > Sent: Monday, March 31, 2014 8:56:20 AM
> > > Subject: RE: Please help us to review our database schema design
> > > with NUMA feature on ovirt
> > >
> > > Include the devel group.
> > > Thanks Eli for the quick responses for our first design and
> > > sorry for the nag.
> > > We appreciate any of the comments for our database design and
> > > will follow the design to do the implementation if no more
> > > comments.
> > > http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
> >
> > Seems OK for me except an unanswered question I had asked in my
> > first review
> > :
> >
> > Why in the Host level NUMA fields are added to vds_dynamic while
> > in the VM level it is added to vm_static ???
> > I would expect it to be in both on static or dynamic , can you
> > please explain ? Thanks
> >
> > >
> > > Thanks & Best Regards
> > > Shi, Xiao-Lei (Bruce)
> > >
> > > Hewlett-Packard Co., Ltd.
> > > HP Servers Core Platform Software China Telephone +86 23
> > > 65683093 Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > >
> > > -----Original Message-----
> > > From: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > Sent: Friday, March 28, 2014 1:30 PM
> > > To: 'Eli Mesika'
> > > Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron
> > > Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun (David
> > > Liang, HPservers-Core-OE-PSC); Yaniv Dary
> > > Subject: RE: Please help us to review our database schema design
> > > with NUMA feature on ovirt
> > >
> > > Hi Eli,
> > >
> > > After the UX design meeting, we did some modification for the
> > > database schema, and merged some update according to your last review
comments.
> > > Now the document has been posted on ovirt wikipage, could you
> > > help to review the database design again:
> > > http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
> > >
> > >
> > > Thanks & Best Regards
> > > Shi, Xiao-Lei (Bruce)
> > >
> > > Hewlett-Packard Co., Ltd.
> > > HP Servers Core Platform Software China Telephone +86 23
> > > 65683093 Mobile
> > > +86
> > > 18696583447 Email xiao-lei.shi(a)hp.com
> > >
> > >
> > > -----Original Message-----
> > > From: Eli Mesika [mailto:emesika@redhat.com]
> > > Sent: Monday, March 24, 2014 6:24 PM
> > > To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron
> > > Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun (David
> > > Liang, HPservers-Core-OE-PSC); Yaniv Dary
> > > Subject: Re: Please help us to review our database schema design
> > > with NUMA feature on ovirt
> > >
> > >
> > >
> > > ----- Original Message -----
> > > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > > <xiao-lei.shi(a)hp.com>
> > > > To: "Eli Mesika" <emesika(a)redhat.com>, "Chuan
Liao (Jason
> > > > Liao, HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>
> > > > Cc: "Doron Fediuck" <dfediuck(a)redhat.com>,
"Gilad Chaplik"
> > > > <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>,
> > > > "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
> > > > <shangchun.liang(a)hp.com>
> > > > Sent: Monday, March 24, 2014 11:23:39 AM
> > > > Subject: RE: Please help us to review our database schema
> > > > design with NUMA feature on ovirt
> > > >
> > > > Hi Eli,
> > > >
> > > > Thanks for your comments.
> > > > I have updated the document according to your comments except
> > > > the below
> > > > one:
> > > > Missing from here are 2 issues:
> > > >
> > > > 1) Impact on the search engine, which new columns are
> > > > search-able and which changes are planned in the search engine
> > > > code to enable that
> > > >
> > > > 2) Impact on engine-reports, are those changed planned to be
> > > > exposed to the engine data warehouse and required new/modified
reports?
> > > >
> > > > Could you tell us more detailed information about the modules
> > > > you mentioned above? I mean "search engine" and
> > > > "engine-reports". I think we missed these two parts in our
previous investigation.
> > > > I just find org.ovirt.engine.core.bll.SearchQuery, is that the
> > > > right object for search engine?
> > >
> > > Yes, actually when you are opening the admin UI, there are TABs
> > > for each entity , i.e. Data Center, Cluster, Host etc.
> > > In each, you can see a text-box in which you can search for by
> > > writing a search expression My question is
> > > 1) What is the impact of your work on the search on the Fost and VM
> > > TABs
> > > a) Are there any fields that are supported now in the search
> > > expression
> > > and should pop-up when you write the expression by the
> > > auto-completion
> > > mechanism ?
> > > b) Are there any added columns displayed in the result of such a
> > > search
> > > in the grid ?
> > >
> > > > How about the engine-reports, could you give us some hints,
> > > > like the code location and any more detailed information that
> > > > we can start more investigation?
> > >
> > > CCing Yaniv D who is in charge of the reports/dwh module Yaniv,
> > > any planned work for adding Numa features to Host/VM in the
> > > reports side ?
> > >
> > > Thanks
> > >
> > > >
> > > > Thanks & Best Regards
> > > > Shi, Xiao-Lei (Bruce)
> > > >
> > > > Hewlett-Packard Co., Ltd.
> > > > HP Servers Core Platform Software China Telephone +86 23
> > > > 65683093 Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > > >
> > > > -----Original Message-----
> > > > From: Eli Mesika [mailto:emesika@redhat.com]
> > > > Sent: Sunday, March 23, 2014 4:44 PM
> > > > To: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
> > > > Cc: Doron Fediuck; Gilad Chaplik; Vinod, Chegu; Liang,
> > > > Shang-Chun (David Liang, HPservers-Core-OE-PSC); Shi, Xiao-Lei
> > > > (Bruce, HP
> > > > Servers-PSC-CQ)
> > > > Subject: Re: Please help us to review our database schema
> > > > design with NUMA feature on ovirt
> > > >
> > > >
> > > >
> > > > ----- Original Message -----
> > > > > From: "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)"
> > > > > <chuan.liao(a)hp.com>
> > > > > To: emesika(a)redhat.com
> > > > > Cc: "Doron Fediuck" <dfediuck(a)redhat.com>,
"Gilad Chaplik"
> > > > > <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>,
> > > > > "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)"
> > > > > <shangchun.liang(a)hp.com>, "Xiao-Lei Shi (Bruce, HP
Servers-PSC-CQ)"
> > > > > <xiao-lei.shi(a)hp.com>
> > > > > Sent: Friday, March 21, 2014 10:42:33 AM
> > > > > Subject: Please help us to review our database schema design
> > > > > with NUMA feature on ovirt
> > > > >
> > > > > Hi Eli,
> > > > >
> > > > > Please help us to review our database schema design with
> > > > > NUMA feature on ovirt
> > > > > https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcmbGWA
> > > > > cyQo_IST
> > > > > Y8
> > > > > ykDr0I6VY/edit?usp=sharing
> > > > >
> > > > > Feel free to take comments on document at anywhere
> > > >
> > > > Done, had commented on the document.
> > > > Eli
> > > >
> > > > >
> > > > > Especially, 5.4 The used interface between engine core and
> > > > > database(schema)
> > > > >
> > > > > Your approve and your comments with this section will be
> > > > > much more appreciate for us.
> > > > >
> > > > > Best Regards,
> > > > > Jason Liao
> > > > >
> > > > >
> > > >
> > >
> >
>
9:25 p.m.
New subject: [Engine-devel] Please help us to review our database schema design with NUMA feature on ovirt
On 3/31/2014 7:13 PM, Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ) wrote:
Assemble the related discussions in this mail session.
Hi Vinod,
On 3/31/2014 2:38 AM, Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ) wrote:
> We put host level NUMA fields in vds_dynamic because these information are from host
itself, and NUMA topology may be changed if the host's hardware make a change.
Can you please elaborate ? Are you thinking about resource (cpu and/or
memory) hot plug on the host ?
[Bruce] It's not about resource hot plug. In ovirt engine, there is a scheduled task
which will refresh hosts' and vms' information periodically. Only the dynamic and
statistics data will be updated during the refresh. So I think the resource information,
such as cpu and/or memory, should be in dynamic and statistics. And in my understanding,
the information in dynamic class is the changeable information but with a low varying
frequency, like cpu topology, libvirt/kernel versions, etc.
Hmm...just to be clear.
If one were to exclude resource hot-plug scenarios on the Host...then I
would consider the following to be static and not dynamic :
- # of NUMA nodes,
- # of CPUs in each of the NUMA node
- Amount of "installed" memory in each of the NUMA node
- The NUMA node distances.
I don't know enough about oVirt features of being able to keep track of
(or) orchestrating host level resource hot plug..but
If resource hot plug is to be included in the mix then... # of CPUs in a
NUMA node and the amount of memory in a given NUMA node could change...
(i.e. some CPUs or some sections of memory ranges could be offlined or
onlined using hot plug features on the host).
I can see the libvirt, qemu versions etc. changing (with less frequency
based on user updates etc.)..but for host kernel versions to actually
change one would most likely require a reboot of the host at which point
I would guess that all of the rebooted host information would have to be
synch'd up as part of handshakes between VDSM and oVirt engine.
The information in statistics class is the information with a high
varying frequency, like the usage of cpu/memory, etc. In my opinion, it's reasonable
to put host level NUMA information in vds_dynamic and host level NUMA statistics
information in vds_statistics.
Got that part...
Thanks
Vinod
Hi Gilad/Roy/Omer,
I don't know if my understanding is correct. But according to this guess, I think
it's also reasonable to put vm cpuPin information in vm_static. Because cpuPin is user
configured information, it will not vary automatically. So we don’t need to refresh this
information periodically. Please correct me if there are any mistakes.
Hi Eli,
Sorry for the nag. If my understanding above is correct, I think we should still put host
level NUMA fields in vds_dynamic/vds_statistics and vm level NUMA fields in vm_static.
Since vm level NUMA fields are configured by user and they will not vary automatically.
Thanks & Best Regards
Shi, Xiao-Lei (Bruce)
Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China
Telephone +86 23 65683093
Mobile +86 18696583447
Email xiao-lei.shi(a)hp.com
-----Original Message-----
From: Gilad Chaplik [mailto:gchaplik@redhat.com]
Sent: Monday, March 31, 2014 9:31 PM
To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Roy Golan; Omer Frenkel
Cc: Eli Mesika; Roy Golan; Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron
Fediuck; Vinod, Chegu; Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
engine-devel(a)ovirt.org
Subject: Re: Please help us to review our database schema design with NUMA feature on
ovirt
adding Roy & Omer.
why CPU topology is in dynamic?
Thanks,
Gilad.
----- Original Message -----
> From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> To: "Eli Mesika" <emesika(a)redhat.com>
> Cc: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Roy Golan"
> <rgolan(a)redhat.com>, "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
<chuan.liao(a)hp.com>, "Doron Fediuck" <dfediuck(a)redhat.com>,
"Chegu Vinod"
> <chegu_vinod(a)hp.com>, "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv Dary"
> <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> Sent: Monday, March 31, 2014 3:20:33 PM
> Subject: RE: Please help us to review our database schema design with
> NUMA feature on ovirt
>
> Thanks Eli.
> I will move the vm level NUMA fields to vm_dynamic, and the related
> database schema will be updated accordingly.
>
> Thanks & Best Regards
> Shi, Xiao-Lei (Bruce)
>
> Hewlett-Packard Co., Ltd.
> HP Servers Core Platform Software China Telephone +86 23 65683093
> Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
>
> -----Original Message-----
> From: Eli Mesika [mailto:emesika@redhat.com]
> Sent: Monday, March 31, 2014 5:49 PM
> To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> Cc: Gilad Chaplik; Roy Golan; Liao, Chuan (Jason Liao,
> HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang, Shang-Chun
> (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
> engine-devel(a)ovirt.org
> Subject: Re: Please help us to review our database schema design with
> NUMA feature on ovirt
>
>
>
> ----- Original Message -----
>> From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
>> <xiao-lei.shi(a)hp.com>
>> To: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Eli
Mesika"
>> <emesika(a)redhat.com>, "Roy Golan" <rgolan(a)redhat.com>
>> Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
>> <chuan.liao(a)hp.com>, "Doron Fediuck" <dfediuck(a)redhat.com>,
"Chegu Vinod"
>> <chegu_vinod(a)hp.com>, "Shang-Chun Liang (David Liang,
>> HPservers-Core-OE-PSC)"
>> <shangchun.liang(a)hp.com>, "Yaniv Dary" <ydary(a)redhat.com>,
>> engine-devel(a)ovirt.org
>> Sent: Monday, March 31, 2014 12:38:04 PM
>> Subject: RE: Please help us to review our database schema design
>> with NUMA feature on ovirt
>>
>> We put host level NUMA fields in vds_dynamic because these
>> information are from host itself, and NUMA topology may be changed
>> if the host's hardware make a change. NUMA information are similar
>> to the host's cpu topology information like cpu_cores and
>> cpu_sockets which are in vds_dynamic, we refer to this.
>> VM level NUMA fields are configured by user, and actually we
>> originally think they should be in vm_dynamic. But we found that the
>> field of another feature cpuPin which is similar as NUMA feature is
>> in vm_static, so we put vm NUMA fields in vm_static.
>> Do you think we need to put VM level NUMA fields in vm_dynamic?
> I think that in this case we should fix cpuPin to be in vm_dynamic and
> put after that the other NUMA fields in vm_dynamic as well
>
>> Thanks & Best Regards
>> Shi, Xiao-Lei (Bruce)
>>
>> Hewlett-Packard Co., Ltd.
>> HP Servers Core Platform Software China Telephone +86 23 65683093
>> Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
>>
>>
>> -----Original Message-----
>> From: Gilad Chaplik [mailto:gchaplik@redhat.com]
>> Sent: Monday, March 31, 2014 5:22 PM
>> To: Eli Mesika; Roy Golan
>> Cc: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Liao, Chuan (Jason
>> Liao, HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang,
>> Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
>> engine-devel(a)ovirt.org
>> Subject: Re: Please help us to review our database schema design
>> with NUMA feature on ovirt
>>
>> +1
>>
>> IMO: vds data should reside in static VM need to think about it.
>>
>> Roy?
>>
>> Thanks,
>> Gilad.
>>
>>
>> ----- Original Message -----
>>> From: "Eli Mesika" <emesika(a)redhat.com>
>>> To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
>>> <xiao-lei.shi(a)hp.com>
>>> Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
>>> <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>, "Gilad
>>> Chaplik" <gchaplik(a)redhat.com>, "Chegu Vinod"
>>> <chegu_vinod(a)hp.com>,
>>> "Shang-Chun Liang (David Liang,
>>> HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv
Dary"
>>> <ydary(a)redhat.com>, engine-devel(a)ovirt.org
>>> Sent: Monday, March 31, 2014 12:12:50 PM
>>> Subject: Re: Please help us to review our database schema design
>>> with NUMA feature on ovirt
>>>
>>>
>>>
>>> ----- Original Message -----
>>>> From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
>>>> <xiao-lei.shi(a)hp.com>
>>>> To: "Eli Mesika" <emesika(a)redhat.com>
>>>> Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
>>>> <chuan.liao(a)hp.com>,
>>>> "Doron Fediuck" <dfediuck(a)redhat.com>, "Gilad
Chaplik"
>>>> <gchaplik(a)redhat.com>, "Chegu Vinod"
>>>> <chegu_vinod(a)hp.com>,
>>>> "Shang-Chun Liang (David Liang,
>>>> HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv
Dary"
>>>> <ydary(a)redhat.com>, engine-devel(a)ovirt.org
>>>> Sent: Monday, March 31, 2014 8:56:20 AM
>>>> Subject: RE: Please help us to review our database schema design
>>>> with NUMA feature on ovirt
>>>>
>>>> Include the devel group.
>>>> Thanks Eli for the quick responses for our first design and
>>>> sorry for the nag.
>>>> We appreciate any of the comments for our database design and
>>>> will follow the design to do the implementation if no more
>>>> comments.
>>>> http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
>>> Seems OK for me except an unanswered question I had asked in my
>>> first review
>>> :
>>>
>>> Why in the Host level NUMA fields are added to vds_dynamic while
>>> in the VM level it is added to vm_static ???
>>> I would expect it to be in both on static or dynamic , can you
>>> please explain ? Thanks
>>>
>>>> Thanks & Best Regards
>>>> Shi, Xiao-Lei (Bruce)
>>>>
>>>> Hewlett-Packard Co., Ltd.
>>>> HP Servers Core Platform Software China Telephone +86 23
>>>> 65683093 Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
>>>>
>>>> -----Original Message-----
>>>> From: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
>>>> Sent: Friday, March 28, 2014 1:30 PM
>>>> To: 'Eli Mesika'
>>>> Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron
>>>> Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun (David
>>>> Liang, HPservers-Core-OE-PSC); Yaniv Dary
>>>> Subject: RE: Please help us to review our database schema design
>>>> with NUMA feature on ovirt
>>>>
>>>> Hi Eli,
>>>>
>>>> After the UX design meeting, we did some modification for the
>>>> database schema, and merged some update according to your last review
comments.
>>>> Now the document has been posted on ovirt wikipage, could you
>>>> help to review the database design again:
>>>> http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
>>>>
>>>>
>>>> Thanks & Best Regards
>>>> Shi, Xiao-Lei (Bruce)
>>>>
>>>> Hewlett-Packard Co., Ltd.
>>>> HP Servers Core Platform Software China Telephone +86 23
>>>> 65683093 Mobile
>>>> +86
>>>> 18696583447 Email xiao-lei.shi(a)hp.com
>>>>
>>>>
>>>> -----Original Message-----
>>>> From: Eli Mesika [mailto:emesika@redhat.com]
>>>> Sent: Monday, March 24, 2014 6:24 PM
>>>> To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
>>>> Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron
>>>> Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun (David
>>>> Liang, HPservers-Core-OE-PSC); Yaniv Dary
>>>> Subject: Re: Please help us to review our database schema design
>>>> with NUMA feature on ovirt
>>>>
>>>>
>>>>
>>>> ----- Original Message -----
>>>>> From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
>>>>> <xiao-lei.shi(a)hp.com>
>>>>> To: "Eli Mesika" <emesika(a)redhat.com>, "Chuan
Liao (Jason
>>>>> Liao, HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>
>>>>> Cc: "Doron Fediuck" <dfediuck(a)redhat.com>,
"Gilad Chaplik"
>>>>> <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>,
>>>>> "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
>>>>> <shangchun.liang(a)hp.com>
>>>>> Sent: Monday, March 24, 2014 11:23:39 AM
>>>>> Subject: RE: Please help us to review our database schema
>>>>> design with NUMA feature on ovirt
>>>>>
>>>>> Hi Eli,
>>>>>
>>>>> Thanks for your comments.
>>>>> I have updated the document according to your comments except
>>>>> the below
>>>>> one:
>>>>> Missing from here are 2 issues:
>>>>>
>>>>> 1) Impact on the search engine, which new columns are
>>>>> search-able and which changes are planned in the search engine
>>>>> code to enable that
>>>>>
>>>>> 2) Impact on engine-reports, are those changed planned to be
>>>>> exposed to the engine data warehouse and required new/modified
reports?
>>>>>
>>>>> Could you tell us more detailed information about the modules
>>>>> you mentioned above? I mean "search engine" and
>>>>> "engine-reports". I think we missed these two parts in our
previous investigation.
>>>>> I just find org.ovirt.engine.core.bll.SearchQuery, is that the
>>>>> right object for search engine?
>>>> Yes, actually when you are opening the admin UI, there are TABs
>>>> for each entity , i.e. Data Center, Cluster, Host etc.
>>>> In each, you can see a text-box in which you can search for by
>>>> writing a search expression My question is
>>>> 1) What is the impact of your work on the search on the Fost and VM
>>>> TABs
>>>> a) Are there any fields that are supported now in the search
>>>> expression
>>>> and should pop-up when you write the expression by the
>>>> auto-completion
>>>> mechanism ?
>>>> b) Are there any added columns displayed in the result of such a
>>>> search
>>>> in the grid ?
>>>>
>>>>> How about the engine-reports, could you give us some hints,
>>>>> like the code location and any more detailed information that
>>>>> we can start more investigation?
>>>> CCing Yaniv D who is in charge of the reports/dwh module Yaniv,
>>>> any planned work for adding Numa features to Host/VM in the
>>>> reports side ?
>>>>
>>>> Thanks
>>>>
>>>>> Thanks & Best Regards
>>>>> Shi, Xiao-Lei (Bruce)
>>>>>
>>>>> Hewlett-Packard Co., Ltd.
>>>>> HP Servers Core Platform Software China Telephone +86 23
>>>>> 65683093 Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
>>>>>
>>>>> -----Original Message-----
>>>>> From: Eli Mesika [mailto:emesika@redhat.com]
>>>>> Sent: Sunday, March 23, 2014 4:44 PM
>>>>> To: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
>>>>> Cc: Doron Fediuck; Gilad Chaplik; Vinod, Chegu; Liang,
>>>>> Shang-Chun (David Liang, HPservers-Core-OE-PSC); Shi, Xiao-Lei
>>>>> (Bruce, HP
>>>>> Servers-PSC-CQ)
>>>>> Subject: Re: Please help us to review our database schema
>>>>> design with NUMA feature on ovirt
>>>>>
>>>>>
>>>>>
>>>>> ----- Original Message -----
>>>>>> From: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
>>>>>> <chuan.liao(a)hp.com>
>>>>>> To: emesika(a)redhat.com
>>>>>> Cc: "Doron Fediuck" <dfediuck(a)redhat.com>,
"Gilad Chaplik"
>>>>>> <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>,
>>>>>> "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)"
>>>>>> <shangchun.liang(a)hp.com>, "Xiao-Lei Shi (Bruce, HP
Servers-PSC-CQ)"
>>>>>> <xiao-lei.shi(a)hp.com>
>>>>>> Sent: Friday, March 21, 2014 10:42:33 AM
>>>>>> Subject: Please help us to review our database schema design
>>>>>> with NUMA feature on ovirt
>>>>>>
>>>>>> Hi Eli,
>>>>>>
>>>>>> Please help us to review our database schema design with
>>>>>> NUMA feature on ovirt
>>>>>> https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcmbGWA
>>>>>> cyQo_IST
>>>>>> Y8
>>>>>> ykDr0I6VY/edit?usp=sharing
>>>>>>
>>>>>> Feel free to take comments on document at anywhere
>>>>> Done, had commented on the document.
>>>>> Eli
>>>>>
>>>>>> Especially, 5.4 The used interface between engine core and
>>>>>> database(schema)
>>>>>>
>>>>>> Your approve and your comments with this section will be
>>>>>> much more appreciate for us.
>>>>>>
>>>>>> Best Regards,
>>>>>> Jason Liao
>>>>>>
>>>>>>
2:10 a.m.
New subject: [Engine-devel] Please help us to review our database schema design with NUMA feature on ovirt
----- Original Message -----
From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
To: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Roy Golan"
<rgolan(a)redhat.com>, "Omer Frenkel" <ofrenkel(a)redhat.com>,
"Eli Mesika" <emesika(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>
Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>,
"Doron Fediuck" <dfediuck(a)redhat.com>,
"Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
<shangchun.liang(a)hp.com>, "Yaniv Dary" <ydary(a)redhat.com>,
engine-devel(a)ovirt.org
Sent: Tuesday, April 1, 2014 5:13:34 AM
Subject: RE: Please help us to review our database schema design with NUMA feature on
ovirt
Assemble the related discussions in this mail session.
Hi Vinod,
On 3/31/2014 2:38 AM, Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ) wrote:
> We put host level NUMA fields in vds_dynamic because these information are
> from host itself, and NUMA topology may be changed if the host's hardware
> make a change.
Can you please elaborate ? Are you thinking about resource (cpu and/or
memory) hot plug on the host ?
[Bruce] It's not about resource hot plug. In ovirt engine, there is a
scheduled task which will refresh hosts' and vms' information periodically.
Only the dynamic and statistics data will be updated during the refresh. So
I think the resource information, such as cpu and/or memory, should be in
dynamic and statistics. And in my understanding, the information in dynamic
class is the changeable information but with a low varying frequency, like
cpu topology, libvirt/kernel versions, etc. The information in statistics
class is the information with a high varying frequency, like the usage of
cpu/memory, etc. In my opinion, it's reasonable to put host level NUMA
information in vds_dynamic and host level NUMA statistics information in
vds_statistics.
Hi Gilad/Roy/Omer,
I don't know if my understanding is correct. But according to this guess, I
think it's also reasonable to put vm cpuPin information in vm_static.
Because cpuPin is user configured information, it will not vary
automatically. So we don’t need to refresh this information periodically.
Please correct me if there are any mistakes.
Hi Eli,
Sorry for the nag. If my understanding above is correct, I think we should
still put host level NUMA fields in vds_dynamic/vds_statistics and vm level
NUMA fields in vm_static. Since vm level NUMA fields are configured by user
and they will not vary automatically.
Sorry, I had understood from Gilad that the NUMA fields in the host level are relatively
static and the NUMA fields on the VM level are dynamic.
I have no problem of having hybrid static/dynamic fields for Host/VM as long as it has a
good reason and fully documented :-)
Thanks & Best Regards
Shi, Xiao-Lei (Bruce)
Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China
Telephone +86 23 65683093
Mobile +86 18696583447
Email xiao-lei.shi(a)hp.com
-----Original Message-----
From: Gilad Chaplik [mailto:gchaplik@redhat.com]
Sent: Monday, March 31, 2014 9:31 PM
To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Roy Golan; Omer Frenkel
Cc: Eli Mesika; Roy Golan; Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC);
Doron Fediuck; Vinod, Chegu; Liang, Shang-Chun (David Liang,
HPservers-Core-OE-PSC); Yaniv Dary; engine-devel(a)ovirt.org
Subject: Re: Please help us to review our database schema design with NUMA
feature on ovirt
adding Roy & Omer.
why CPU topology is in dynamic?
Thanks,
Gilad.
----- Original Message -----
> From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> To: "Eli Mesika" <emesika(a)redhat.com>
> Cc: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Roy Golan"
> <rgolan(a)redhat.com>, "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)"
> <chuan.liao(a)hp.com>, "Doron Fediuck" <dfediuck(a)redhat.com>,
"Chegu Vinod"
> <chegu_vinod(a)hp.com>, "Shang-Chun Liang (David Liang,
> HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv Dary"
> <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> Sent: Monday, March 31, 2014 3:20:33 PM
> Subject: RE: Please help us to review our database schema design with
> NUMA feature on ovirt
>
> Thanks Eli.
> I will move the vm level NUMA fields to vm_dynamic, and the related
> database schema will be updated accordingly.
>
> Thanks & Best Regards
> Shi, Xiao-Lei (Bruce)
>
> Hewlett-Packard Co., Ltd.
> HP Servers Core Platform Software China Telephone +86 23 65683093
> Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
>
> -----Original Message-----
> From: Eli Mesika [mailto:emesika@redhat.com]
> Sent: Monday, March 31, 2014 5:49 PM
> To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> Cc: Gilad Chaplik; Roy Golan; Liao, Chuan (Jason Liao,
> HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang, Shang-Chun
> (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
> engine-devel(a)ovirt.org
> Subject: Re: Please help us to review our database schema design with
> NUMA feature on ovirt
>
>
>
> ----- Original Message -----
> > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > <xiao-lei.shi(a)hp.com>
> > To: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Eli
Mesika"
> > <emesika(a)redhat.com>, "Roy Golan" <rgolan(a)redhat.com>
> > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>, "Chegu Vinod"
> > <chegu_vinod(a)hp.com>, "Shang-Chun Liang (David Liang,
> > HPservers-Core-OE-PSC)"
> > <shangchun.liang(a)hp.com>, "Yaniv Dary"
<ydary(a)redhat.com>,
> > engine-devel(a)ovirt.org
> > Sent: Monday, March 31, 2014 12:38:04 PM
> > Subject: RE: Please help us to review our database schema design
> > with NUMA feature on ovirt
> >
> > We put host level NUMA fields in vds_dynamic because these
> > information are from host itself, and NUMA topology may be changed
> > if the host's hardware make a change. NUMA information are similar
> > to the host's cpu topology information like cpu_cores and
> > cpu_sockets which are in vds_dynamic, we refer to this.
> > VM level NUMA fields are configured by user, and actually we
> > originally think they should be in vm_dynamic. But we found that the
> > field of another feature cpuPin which is similar as NUMA feature is
> > in vm_static, so we put vm NUMA fields in vm_static.
> > Do you think we need to put VM level NUMA fields in vm_dynamic?
>
> I think that in this case we should fix cpuPin to be in vm_dynamic and
> put after that the other NUMA fields in vm_dynamic as well
>
> >
> > Thanks & Best Regards
> > Shi, Xiao-Lei (Bruce)
> >
> > Hewlett-Packard Co., Ltd.
> > HP Servers Core Platform Software China Telephone +86 23 65683093
> > Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> >
> >
> > -----Original Message-----
> > From: Gilad Chaplik [mailto:gchaplik@redhat.com]
> > Sent: Monday, March 31, 2014 5:22 PM
> > To: Eli Mesika; Roy Golan
> > Cc: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Liao, Chuan (Jason
> > Liao, HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang,
> > Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
> > engine-devel(a)ovirt.org
> > Subject: Re: Please help us to review our database schema design
> > with NUMA feature on ovirt
> >
> > +1
> >
> > IMO: vds data should reside in static VM need to think about it.
> >
> > Roy?
> >
> > Thanks,
> > Gilad.
> >
> >
> > ----- Original Message -----
> > > From: "Eli Mesika" <emesika(a)redhat.com>
> > > To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > <xiao-lei.shi(a)hp.com>
> > > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > > <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>, "Gilad
> > > Chaplik" <gchaplik(a)redhat.com>, "Chegu Vinod"
> > > <chegu_vinod(a)hp.com>,
> > > "Shang-Chun Liang (David Liang,
> > > HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv
Dary"
> > > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > > Sent: Monday, March 31, 2014 12:12:50 PM
> > > Subject: Re: Please help us to review our database schema design
> > > with NUMA feature on ovirt
> > >
> > >
> > >
> > > ----- Original Message -----
> > > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > > <xiao-lei.shi(a)hp.com>
> > > > To: "Eli Mesika" <emesika(a)redhat.com>
> > > > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > > > <chuan.liao(a)hp.com>,
> > > > "Doron Fediuck" <dfediuck(a)redhat.com>, "Gilad
Chaplik"
> > > > <gchaplik(a)redhat.com>, "Chegu Vinod"
> > > > <chegu_vinod(a)hp.com>,
> > > > "Shang-Chun Liang (David Liang,
> > > > HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>,
"Yaniv Dary"
> > > > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > > > Sent: Monday, March 31, 2014 8:56:20 AM
> > > > Subject: RE: Please help us to review our database schema design
> > > > with NUMA feature on ovirt
> > > >
> > > > Include the devel group.
> > > > Thanks Eli for the quick responses for our first design and
> > > > sorry for the nag.
> > > > We appreciate any of the comments for our database design and
> > > > will follow the design to do the implementation if no more
> > > > comments.
> > > > http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
> > >
> > > Seems OK for me except an unanswered question I had asked in my
> > > first review
> > > :
> > >
> > > Why in the Host level NUMA fields are added to vds_dynamic while
> > > in the VM level it is added to vm_static ???
> > > I would expect it to be in both on static or dynamic , can you
> > > please explain ? Thanks
> > >
> > > >
> > > > Thanks & Best Regards
> > > > Shi, Xiao-Lei (Bruce)
> > > >
> > > > Hewlett-Packard Co., Ltd.
> > > > HP Servers Core Platform Software China Telephone +86 23
> > > > 65683093 Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > > >
> > > > -----Original Message-----
> > > > From: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > > Sent: Friday, March 28, 2014 1:30 PM
> > > > To: 'Eli Mesika'
> > > > Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron
> > > > Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun (David
> > > > Liang, HPservers-Core-OE-PSC); Yaniv Dary
> > > > Subject: RE: Please help us to review our database schema design
> > > > with NUMA feature on ovirt
> > > >
> > > > Hi Eli,
> > > >
> > > > After the UX design meeting, we did some modification for the
> > > > database schema, and merged some update according to your last
review
> > > > comments.
> > > > Now the document has been posted on ovirt wikipage, could you
> > > > help to review the database design again:
> > > > http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
> > > >
> > > >
> > > > Thanks & Best Regards
> > > > Shi, Xiao-Lei (Bruce)
> > > >
> > > > Hewlett-Packard Co., Ltd.
> > > > HP Servers Core Platform Software China Telephone +86 23
> > > > 65683093 Mobile
> > > > +86
> > > > 18696583447 Email xiao-lei.shi(a)hp.com
> > > >
> > > >
> > > > -----Original Message-----
> > > > From: Eli Mesika [mailto:emesika@redhat.com]
> > > > Sent: Monday, March 24, 2014 6:24 PM
> > > > To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > > Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron
> > > > Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun (David
> > > > Liang, HPservers-Core-OE-PSC); Yaniv Dary
> > > > Subject: Re: Please help us to review our database schema design
> > > > with NUMA feature on ovirt
> > > >
> > > >
> > > >
> > > > ----- Original Message -----
> > > > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > > > <xiao-lei.shi(a)hp.com>
> > > > > To: "Eli Mesika" <emesika(a)redhat.com>,
"Chuan Liao (Jason
> > > > > Liao, HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>
> > > > > Cc: "Doron Fediuck" <dfediuck(a)redhat.com>,
"Gilad Chaplik"
> > > > > <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>,
> > > > > "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)"
> > > > > <shangchun.liang(a)hp.com>
> > > > > Sent: Monday, March 24, 2014 11:23:39 AM
> > > > > Subject: RE: Please help us to review our database schema
> > > > > design with NUMA feature on ovirt
> > > > >
> > > > > Hi Eli,
> > > > >
> > > > > Thanks for your comments.
> > > > > I have updated the document according to your comments except
> > > > > the below
> > > > > one:
> > > > > Missing from here are 2 issues:
> > > > >
> > > > > 1) Impact on the search engine, which new columns are
> > > > > search-able and which changes are planned in the search engine
> > > > > code to enable that
> > > > >
> > > > > 2) Impact on engine-reports, are those changed planned to be
> > > > > exposed to the engine data warehouse and required new/modified
> > > > > reports?
> > > > >
> > > > > Could you tell us more detailed information about the modules
> > > > > you mentioned above? I mean "search engine" and
> > > > > "engine-reports". I think we missed these two parts in
our previous
> > > > > investigation.
> > > > > I just find org.ovirt.engine.core.bll.SearchQuery, is that the
> > > > > right object for search engine?
> > > >
> > > > Yes, actually when you are opening the admin UI, there are TABs
> > > > for each entity , i.e. Data Center, Cluster, Host etc.
> > > > In each, you can see a text-box in which you can search for by
> > > > writing a search expression My question is
> > > > 1) What is the impact of your work on the search on the Fost and
> > > > VM
> > > > TABs
> > > > a) Are there any fields that are supported now in the search
> > > > expression
> > > > and should pop-up when you write the expression by the
> > > > auto-completion
> > > > mechanism ?
> > > > b) Are there any added columns displayed in the result of such
> > > > a
> > > > search
> > > > in the grid ?
> > > >
> > > > > How about the engine-reports, could you give us some hints,
> > > > > like the code location and any more detailed information that
> > > > > we can start more investigation?
> > > >
> > > > CCing Yaniv D who is in charge of the reports/dwh module Yaniv,
> > > > any planned work for adding Numa features to Host/VM in the
> > > > reports side ?
> > > >
> > > > Thanks
> > > >
> > > > >
> > > > > Thanks & Best Regards
> > > > > Shi, Xiao-Lei (Bruce)
> > > > >
> > > > > Hewlett-Packard Co., Ltd.
> > > > > HP Servers Core Platform Software China Telephone +86 23
> > > > > 65683093 Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > > > >
> > > > > -----Original Message-----
> > > > > From: Eli Mesika [mailto:emesika@redhat.com]
> > > > > Sent: Sunday, March 23, 2014 4:44 PM
> > > > > To: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
> > > > > Cc: Doron Fediuck; Gilad Chaplik; Vinod, Chegu; Liang,
> > > > > Shang-Chun (David Liang, HPservers-Core-OE-PSC); Shi, Xiao-Lei
> > > > > (Bruce, HP
> > > > > Servers-PSC-CQ)
> > > > > Subject: Re: Please help us to review our database schema
> > > > > design with NUMA feature on ovirt
> > > > >
> > > > >
> > > > >
> > > > > ----- Original Message -----
> > > > > > From: "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)"
> > > > > > <chuan.liao(a)hp.com>
> > > > > > To: emesika(a)redhat.com
> > > > > > Cc: "Doron Fediuck" <dfediuck(a)redhat.com>,
"Gilad Chaplik"
> > > > > > <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>,
> > > > > > "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)"
> > > > > > <shangchun.liang(a)hp.com>, "Xiao-Lei Shi (Bruce,
HP
> > > > > > Servers-PSC-CQ)"
> > > > > > <xiao-lei.shi(a)hp.com>
> > > > > > Sent: Friday, March 21, 2014 10:42:33 AM
> > > > > > Subject: Please help us to review our database schema
design
> > > > > > with NUMA feature on ovirt
> > > > > >
> > > > > > Hi Eli,
> > > > > >
> > > > > > Please help us to review our database schema design with
> > > > > > NUMA feature on ovirt
> > > > > >
https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcmbGWA
> > > > > > cyQo_IST
> > > > > > Y8
> > > > > > ykDr0I6VY/edit?usp=sharing
> > > > > >
> > > > > > Feel free to take comments on document at anywhere
> > > > >
> > > > > Done, had commented on the document.
> > > > > Eli
> > > > >
> > > > > >
> > > > > > Especially, 5.4 The used interface between engine core and
> > > > > > database(schema)
> > > > > >
> > > > > > Your approve and your comments with this section will be
> > > > > > much more appreciate for us.
> > > > > >
> > > > > > Best Regards,
> > > > > > Jason Liao
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
8:04 p.m.
New subject: [Engine-devel] Please help us to review our database schema design with NUMA feature on ovirt
Hi all,
Sorry for joining-in late.
My comments (according to the db diagram section in
https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcmbGWAcyQo_ISTY8ykD...):
1) Join vm_numa_node and vds_numa_node to a single table (almost identical), one of the
FKs can be null.
2) No templates reference in the design, need to check it out (it might be inherently
designed already :-) ); vNode can be linked to a template.
3) The reason I want host's NUMA data to be in static is because it updates only once
(on boot). "engineerically" speaking, dynamic table has a lot of traffic and
that's not the case for NUMA info. Its feels to me like 'a hybrid' of static
and dynamic, 3 suggestions comes to mind:
- leave it in dynamic (maybe in a separate process).
- have a separate flow that updates static.
- come up with a third 'vds_on_boot' table (my favorite ;-P ).
I will get back to you on that.
4) vm_vds_numa_node_map is connected to vds_numa_node_statistics, why to split the tables
(vds_numa_node & vds_numa_node_statistics), going back to comment #1, don't we
want vNode stats as well, it can be nice to show it :-) (have a vNUMA overview of the VM
using guest-agent or sth, in a future phase).
5) IMO vds_cpu_statistics shouldn't include any reference to NUMA, I gave that comment
in the BE patch as well (remove vds_numa_node_id FK in vds_cpu_statistics), for that you
should extract cpu_list to a connection table (anyway I don't like lists as a
text/strings/etc.)
6) vm_numatune_nodeset can be removed - the vNode should hold it's pinning info; I
think that vNode (node according to comment #1) should be connected to a connection table
that points to vdsNode (also Node table) itself (kinda complicated but does the trick -
nested link).
7) Please add delete-cascade info all over, i.e. what happens when we remove a
host/vm/node.
8) Is it possible to put a db constraint that mapping between vNode and Node will be
deleted once the VM isn't UP?
Thanks,
Gilad.
----- Original Message -----
From: "Eli Mesika" <emesika(a)redhat.com>
To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <xiao-lei.shi(a)hp.com>
Cc: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Roy Golan"
<rgolan(a)redhat.com>, "Omer Frenkel" <ofrenkel(a)redhat.com>,
"Chegu Vinod" <chegu_vinod(a)hp.com>, "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>, "Doron
Fediuck" <dfediuck(a)redhat.com>, "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>,
"Yaniv Dary" <ydary(a)redhat.com>, engine-devel(a)ovirt.org
Sent: Tuesday, April 1, 2014 10:10:37 AM
Subject: Re: Please help us to review our database schema design with NUMA feature on
ovirt
----- Original Message -----
> From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> To: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Roy Golan"
<rgolan(a)redhat.com>,
> "Omer Frenkel" <ofrenkel(a)redhat.com>,
> "Eli Mesika" <emesika(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>
> Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
<chuan.liao(a)hp.com>,
> "Doron Fediuck" <dfediuck(a)redhat.com>,
> "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
> <shangchun.liang(a)hp.com>, "Yaniv Dary" <ydary(a)redhat.com>,
> engine-devel(a)ovirt.org
> Sent: Tuesday, April 1, 2014 5:13:34 AM
> Subject: RE: Please help us to review our database schema design with NUMA
> feature on ovirt
>
> Assemble the related discussions in this mail session.
>
> Hi Vinod,
> On 3/31/2014 2:38 AM, Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ) wrote:
> > We put host level NUMA fields in vds_dynamic because these information
> > are
> > from host itself, and NUMA topology may be changed if the host's hardware
> > make a change.
> Can you please elaborate ? Are you thinking about resource (cpu and/or
> memory) hot plug on the host ?
> [Bruce] It's not about resource hot plug. In ovirt engine, there is a
> scheduled task which will refresh hosts' and vms' information periodically.
> Only the dynamic and statistics data will be updated during the refresh. So
> I think the resource information, such as cpu and/or memory, should be in
> dynamic and statistics. And in my understanding, the information in dynamic
> class is the changeable information but with a low varying frequency, like
> cpu topology, libvirt/kernel versions, etc. The information in statistics
> class is the information with a high varying frequency, like the usage of
> cpu/memory, etc. In my opinion, it's reasonable to put host level NUMA
> information in vds_dynamic and host level NUMA statistics information in
> vds_statistics.
>
> Hi Gilad/Roy/Omer,
> I don't know if my understanding is correct. But according to this guess, I
> think it's also reasonable to put vm cpuPin information in vm_static.
> Because cpuPin is user configured information, it will not vary
> automatically. So we don’t need to refresh this information periodically.
> Please correct me if there are any mistakes.
>
> Hi Eli,
> Sorry for the nag. If my understanding above is correct, I think we should
> still put host level NUMA fields in vds_dynamic/vds_statistics and vm level
> NUMA fields in vm_static. Since vm level NUMA fields are configured by user
> and they will not vary automatically.
Sorry, I had understood from Gilad that the NUMA fields in the host level are
relatively static and the NUMA fields on the VM level are dynamic.
I have no problem of having hybrid static/dynamic fields for Host/VM as long
as it has a good reason and fully documented :-)
>
>
> Thanks & Best Regards
> Shi, Xiao-Lei (Bruce)
>
> Hewlett-Packard Co., Ltd.
> HP Servers Core Platform Software China
> Telephone +86 23 65683093
> Mobile +86 18696583447
> Email xiao-lei.shi(a)hp.com
>
>
> -----Original Message-----
> From: Gilad Chaplik [mailto:gchaplik@redhat.com]
> Sent: Monday, March 31, 2014 9:31 PM
> To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Roy Golan; Omer Frenkel
> Cc: Eli Mesika; Roy Golan; Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC);
> Doron Fediuck; Vinod, Chegu; Liang, Shang-Chun (David Liang,
> HPservers-Core-OE-PSC); Yaniv Dary; engine-devel(a)ovirt.org
> Subject: Re: Please help us to review our database schema design with NUMA
> feature on ovirt
>
> adding Roy & Omer.
>
> why CPU topology is in dynamic?
>
> Thanks,
> Gilad.
>
> ----- Original Message -----
> > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> > To: "Eli Mesika" <emesika(a)redhat.com>
> > Cc: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Roy
Golan"
> > <rgolan(a)redhat.com>, "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)"
> > <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>, "Chegu Vinod"
> > <chegu_vinod(a)hp.com>, "Shang-Chun Liang (David Liang,
> > HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv
Dary"
> > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > Sent: Monday, March 31, 2014 3:20:33 PM
> > Subject: RE: Please help us to review our database schema design with
> > NUMA feature on ovirt
> >
> > Thanks Eli.
> > I will move the vm level NUMA fields to vm_dynamic, and the related
> > database schema will be updated accordingly.
> >
> > Thanks & Best Regards
> > Shi, Xiao-Lei (Bruce)
> >
> > Hewlett-Packard Co., Ltd.
> > HP Servers Core Platform Software China Telephone +86 23 65683093
> > Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> >
> > -----Original Message-----
> > From: Eli Mesika [mailto:emesika@redhat.com]
> > Sent: Monday, March 31, 2014 5:49 PM
> > To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > Cc: Gilad Chaplik; Roy Golan; Liao, Chuan (Jason Liao,
> > HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang, Shang-Chun
> > (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
> > engine-devel(a)ovirt.org
> > Subject: Re: Please help us to review our database schema design with
> > NUMA feature on ovirt
> >
> >
> >
> > ----- Original Message -----
> > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > <xiao-lei.shi(a)hp.com>
> > > To: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Eli
Mesika"
> > > <emesika(a)redhat.com>, "Roy Golan"
<rgolan(a)redhat.com>
> > > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > > <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>, "Chegu
> > > Vinod"
> > > <chegu_vinod(a)hp.com>, "Shang-Chun Liang (David Liang,
> > > HPservers-Core-OE-PSC)"
> > > <shangchun.liang(a)hp.com>, "Yaniv Dary"
<ydary(a)redhat.com>,
> > > engine-devel(a)ovirt.org
> > > Sent: Monday, March 31, 2014 12:38:04 PM
> > > Subject: RE: Please help us to review our database schema design
> > > with NUMA feature on ovirt
> > >
> > > We put host level NUMA fields in vds_dynamic because these
> > > information are from host itself, and NUMA topology may be changed
> > > if the host's hardware make a change. NUMA information are similar
> > > to the host's cpu topology information like cpu_cores and
> > > cpu_sockets which are in vds_dynamic, we refer to this.
> > > VM level NUMA fields are configured by user, and actually we
> > > originally think they should be in vm_dynamic. But we found that the
> > > field of another feature cpuPin which is similar as NUMA feature is
> > > in vm_static, so we put vm NUMA fields in vm_static.
> > > Do you think we need to put VM level NUMA fields in vm_dynamic?
> >
> > I think that in this case we should fix cpuPin to be in vm_dynamic and
> > put after that the other NUMA fields in vm_dynamic as well
> >
> > >
> > > Thanks & Best Regards
> > > Shi, Xiao-Lei (Bruce)
> > >
> > > Hewlett-Packard Co., Ltd.
> > > HP Servers Core Platform Software China Telephone +86 23 65683093
> > > Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > >
> > >
> > > -----Original Message-----
> > > From: Gilad Chaplik [mailto:gchaplik@redhat.com]
> > > Sent: Monday, March 31, 2014 5:22 PM
> > > To: Eli Mesika; Roy Golan
> > > Cc: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Liao, Chuan (Jason
> > > Liao, HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang,
> > > Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
> > > engine-devel(a)ovirt.org
> > > Subject: Re: Please help us to review our database schema design
> > > with NUMA feature on ovirt
> > >
> > > +1
> > >
> > > IMO: vds data should reside in static VM need to think about it.
> > >
> > > Roy?
> > >
> > > Thanks,
> > > Gilad.
> > >
> > >
> > > ----- Original Message -----
> > > > From: "Eli Mesika" <emesika(a)redhat.com>
> > > > To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > > <xiao-lei.shi(a)hp.com>
> > > > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > > > <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>, "Gilad
> > > > Chaplik" <gchaplik(a)redhat.com>, "Chegu Vinod"
> > > > <chegu_vinod(a)hp.com>,
> > > > "Shang-Chun Liang (David Liang,
> > > > HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>,
"Yaniv Dary"
> > > > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > > > Sent: Monday, March 31, 2014 12:12:50 PM
> > > > Subject: Re: Please help us to review our database schema design
> > > > with NUMA feature on ovirt
> > > >
> > > >
> > > >
> > > > ----- Original Message -----
> > > > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > > > <xiao-lei.shi(a)hp.com>
> > > > > To: "Eli Mesika" <emesika(a)redhat.com>
> > > > > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > > > > <chuan.liao(a)hp.com>,
> > > > > "Doron Fediuck" <dfediuck(a)redhat.com>,
"Gilad Chaplik"
> > > > > <gchaplik(a)redhat.com>, "Chegu Vinod"
> > > > > <chegu_vinod(a)hp.com>,
> > > > > "Shang-Chun Liang (David Liang,
> > > > > HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>,
"Yaniv Dary"
> > > > > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > > > > Sent: Monday, March 31, 2014 8:56:20 AM
> > > > > Subject: RE: Please help us to review our database schema
design
> > > > > with NUMA feature on ovirt
> > > > >
> > > > > Include the devel group.
> > > > > Thanks Eli for the quick responses for our first design and
> > > > > sorry for the nag.
> > > > > We appreciate any of the comments for our database design and
> > > > > will follow the design to do the implementation if no more
> > > > > comments.
> > > > > http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
> > > >
> > > > Seems OK for me except an unanswered question I had asked in my
> > > > first review
> > > > :
> > > >
> > > > Why in the Host level NUMA fields are added to vds_dynamic while
> > > > in the VM level it is added to vm_static ???
> > > > I would expect it to be in both on static or dynamic , can you
> > > > please explain ? Thanks
> > > >
> > > > >
> > > > > Thanks & Best Regards
> > > > > Shi, Xiao-Lei (Bruce)
> > > > >
> > > > > Hewlett-Packard Co., Ltd.
> > > > > HP Servers Core Platform Software China Telephone +86 23
> > > > > 65683093 Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > > > >
> > > > > -----Original Message-----
> > > > > From: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > > > Sent: Friday, March 28, 2014 1:30 PM
> > > > > To: 'Eli Mesika'
> > > > > Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron
> > > > > Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun (David
> > > > > Liang, HPservers-Core-OE-PSC); Yaniv Dary
> > > > > Subject: RE: Please help us to review our database schema
design
> > > > > with NUMA feature on ovirt
> > > > >
> > > > > Hi Eli,
> > > > >
> > > > > After the UX design meeting, we did some modification for the
> > > > > database schema, and merged some update according to your last
> > > > > review
> > > > > comments.
> > > > > Now the document has been posted on ovirt wikipage, could you
> > > > > help to review the database design again:
> > > > > http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
> > > > >
> > > > >
> > > > > Thanks & Best Regards
> > > > > Shi, Xiao-Lei (Bruce)
> > > > >
> > > > > Hewlett-Packard Co., Ltd.
> > > > > HP Servers Core Platform Software China Telephone +86 23
> > > > > 65683093 Mobile
> > > > > +86
> > > > > 18696583447 Email xiao-lei.shi(a)hp.com
> > > > >
> > > > >
> > > > > -----Original Message-----
> > > > > From: Eli Mesika [mailto:emesika@redhat.com]
> > > > > Sent: Monday, March 24, 2014 6:24 PM
> > > > > To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > > > Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron
> > > > > Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun (David
> > > > > Liang, HPservers-Core-OE-PSC); Yaniv Dary
> > > > > Subject: Re: Please help us to review our database schema
design
> > > > > with NUMA feature on ovirt
> > > > >
> > > > >
> > > > >
> > > > > ----- Original Message -----
> > > > > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > > > > <xiao-lei.shi(a)hp.com>
> > > > > > To: "Eli Mesika" <emesika(a)redhat.com>,
"Chuan Liao (Jason
> > > > > > Liao, HPservers-Core-OE-PSC)"
<chuan.liao(a)hp.com>
> > > > > > Cc: "Doron Fediuck" <dfediuck(a)redhat.com>,
"Gilad Chaplik"
> > > > > > <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>,
> > > > > > "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)"
> > > > > > <shangchun.liang(a)hp.com>
> > > > > > Sent: Monday, March 24, 2014 11:23:39 AM
> > > > > > Subject: RE: Please help us to review our database schema
> > > > > > design with NUMA feature on ovirt
> > > > > >
> > > > > > Hi Eli,
> > > > > >
> > > > > > Thanks for your comments.
> > > > > > I have updated the document according to your comments
except
> > > > > > the below
> > > > > > one:
> > > > > > Missing from here are 2 issues:
> > > > > >
> > > > > > 1) Impact on the search engine, which new columns are
> > > > > > search-able and which changes are planned in the search
engine
> > > > > > code to enable that
> > > > > >
> > > > > > 2) Impact on engine-reports, are those changed planned to
be
> > > > > > exposed to the engine data warehouse and required
new/modified
> > > > > > reports?
> > > > > >
> > > > > > Could you tell us more detailed information about the
modules
> > > > > > you mentioned above? I mean "search engine" and
> > > > > > "engine-reports". I think we missed these two
parts in our
> > > > > > previous
> > > > > > investigation.
> > > > > > I just find org.ovirt.engine.core.bll.SearchQuery, is that
the
> > > > > > right object for search engine?
> > > > >
> > > > > Yes, actually when you are opening the admin UI, there are TABs
> > > > > for each entity , i.e. Data Center, Cluster, Host etc.
> > > > > In each, you can see a text-box in which you can search for by
> > > > > writing a search expression My question is
> > > > > 1) What is the impact of your work on the search on the Fost
and
> > > > > VM
> > > > > TABs
> > > > > a) Are there any fields that are supported now in the
search
> > > > > expression
> > > > > and should pop-up when you write the expression by the
> > > > > auto-completion
> > > > > mechanism ?
> > > > > b) Are there any added columns displayed in the result of
> > > > > such
> > > > > a
> > > > > search
> > > > > in the grid ?
> > > > >
> > > > > > How about the engine-reports, could you give us some
hints,
> > > > > > like the code location and any more detailed information
that
> > > > > > we can start more investigation?
> > > > >
> > > > > CCing Yaniv D who is in charge of the reports/dwh module Yaniv,
> > > > > any planned work for adding Numa features to Host/VM in the
> > > > > reports side ?
> > > > >
> > > > > Thanks
> > > > >
> > > > > >
> > > > > > Thanks & Best Regards
> > > > > > Shi, Xiao-Lei (Bruce)
> > > > > >
> > > > > > Hewlett-Packard Co., Ltd.
> > > > > > HP Servers Core Platform Software China Telephone +86 23
> > > > > > 65683093 Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > > > > >
> > > > > > -----Original Message-----
> > > > > > From: Eli Mesika [mailto:emesika@redhat.com]
> > > > > > Sent: Sunday, March 23, 2014 4:44 PM
> > > > > > To: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
> > > > > > Cc: Doron Fediuck; Gilad Chaplik; Vinod, Chegu; Liang,
> > > > > > Shang-Chun (David Liang, HPservers-Core-OE-PSC); Shi,
Xiao-Lei
> > > > > > (Bruce, HP
> > > > > > Servers-PSC-CQ)
> > > > > > Subject: Re: Please help us to review our database schema
> > > > > > design with NUMA feature on ovirt
> > > > > >
> > > > > >
> > > > > >
> > > > > > ----- Original Message -----
> > > > > > > From: "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)"
> > > > > > > <chuan.liao(a)hp.com>
> > > > > > > To: emesika(a)redhat.com
> > > > > > > Cc: "Doron Fediuck"
<dfediuck(a)redhat.com>, "Gilad Chaplik"
> > > > > > > <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>,
> > > > > > > "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)"
> > > > > > > <shangchun.liang(a)hp.com>, "Xiao-Lei Shi
(Bruce, HP
> > > > > > > Servers-PSC-CQ)"
> > > > > > > <xiao-lei.shi(a)hp.com>
> > > > > > > Sent: Friday, March 21, 2014 10:42:33 AM
> > > > > > > Subject: Please help us to review our database schema
design
> > > > > > > with NUMA feature on ovirt
> > > > > > >
> > > > > > > Hi Eli,
> > > > > > >
> > > > > > > Please help us to review our database schema design
with
> > > > > > > NUMA feature on ovirt
> > > > > > >
https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcmbGWA
> > > > > > > cyQo_IST
> > > > > > > Y8
> > > > > > > ykDr0I6VY/edit?usp=sharing
> > > > > > >
> > > > > > > Feel free to take comments on document at anywhere
> > > > > >
> > > > > > Done, had commented on the document.
> > > > > > Eli
> > > > > >
> > > > > > >
> > > > > > > Especially, 5.4 The used interface between engine core
and
> > > > > > > database(schema)
> > > > > > >
> > > > > > > Your approve and your comments with this section will
be
> > > > > > > much more appreciate for us.
> > > > > > >
> > > > > > > Best Regards,
> > > > > > > Jason Liao
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
8:11 p.m.
New subject: [Engine-devel] Please help us to review our database schema design with NUMA feature on ovirt
----- Original Message -----
From: "Gilad Chaplik" <gchaplik(a)redhat.com>
To: "Eli Mesika" <emesika(a)redhat.com>
Cc: engine-devel(a)ovirt.org, "Chegu Vinod" <chegu_vinod(a)hp.com>,
"Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>
Sent: Thursday, April 3, 2014 4:04:55 AM
Subject: Re: [Engine-devel] Please help us to review our database schema design with NUMA
feature on ovirt
Hi all,
Sorry for joining-in late.
My comments (according to the db diagram section in
https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcmbGWAcyQo_ISTY8ykD...):
1) Join vm_numa_node and vds_numa_node to a single table (almost identical),
one of the FKs can be null.
2) No templates reference in the design, need to check it out (it might be
inherently designed already :-) ); vNode can be linked to a template.
3) The reason I want host's NUMA data to be in static is because it updates
only once (on boot). "engineerically" speaking, dynamic table has a lot of
traffic and that's not the case for NUMA info. Its feels to me like 'a
hybrid' of static and dynamic, 3 suggestions comes to mind:
- leave it in dynamic (maybe in a separate process).
- have a separate flow that updates static.
- come up with a third 'vds_on_boot' table (my favorite ;-P ).
I will get back to you on that.
4) vm_vds_numa_node_map is connected to vds_numa_node_statistics, why to
split the tables (vds_numa_node & vds_numa_node_statistics), going back to
comment #1, don't we want vNode stats as well, it can be nice to show it :-)
(have a vNUMA overview of the VM using guest-agent or sth, in a future
phase).
5) IMO vds_cpu_statistics shouldn't include any reference to NUMA, I gave
that comment in the BE patch as well (remove vds_numa_node_id FK in
vds_cpu_statistics), for that you should extract cpu_list to a connection
table (anyway I don't like lists as a text/strings/etc.)
6) vm_numatune_nodeset can be removed - the vNode should hold it's pinning
info; I think that vNode (node according to comment #1) should be connected
to a connection table that points to vdsNode (also Node table) itself (kinda
complicated but does the trick - nested link).
correction: no need for another connection table, use vm_vds_numa_node_map with a flag
(is_pinned)
7) Please add delete-cascade info all over, i.e. what happens when we
remove
a host/vm/node.
8) Is it possible to put a db constraint that mapping between vNode and Node
will be deleted once the VM isn't UP?
Thanks,
Gilad.
----- Original Message -----
> From: "Eli Mesika" <emesika(a)redhat.com>
> To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <xiao-lei.shi(a)hp.com>
> Cc: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Roy Golan"
<rgolan(a)redhat.com>,
> "Omer Frenkel" <ofrenkel(a)redhat.com>,
> "Chegu Vinod" <chegu_vinod(a)hp.com>, "Chuan Liao (Jason Liao,
> HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>, "Doron
> Fediuck" <dfediuck(a)redhat.com>, "Shang-Chun Liang (David Liang,
> HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>,
> "Yaniv Dary" <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> Sent: Tuesday, April 1, 2014 10:10:37 AM
> Subject: Re: Please help us to review our database schema design with NUMA
> feature on ovirt
>
>
>
> ----- Original Message -----
> > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> > To: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Roy
Golan"
> > <rgolan(a)redhat.com>,
> > "Omer Frenkel" <ofrenkel(a)redhat.com>,
> > "Eli Mesika" <emesika(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>
> > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
<chuan.liao(a)hp.com>,
> > "Doron Fediuck" <dfediuck(a)redhat.com>,
> > "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
> > <shangchun.liang(a)hp.com>, "Yaniv Dary"
<ydary(a)redhat.com>,
> > engine-devel(a)ovirt.org
> > Sent: Tuesday, April 1, 2014 5:13:34 AM
> > Subject: RE: Please help us to review our database schema design with
> > NUMA
> > feature on ovirt
> >
> > Assemble the related discussions in this mail session.
> >
> > Hi Vinod,
> > On 3/31/2014 2:38 AM, Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ) wrote:
> > > We put host level NUMA fields in vds_dynamic because these information
> > > are
> > > from host itself, and NUMA topology may be changed if the host's
> > > hardware
> > > make a change.
> > Can you please elaborate ? Are you thinking about resource (cpu and/or
> > memory) hot plug on the host ?
> > [Bruce] It's not about resource hot plug. In ovirt engine, there is a
> > scheduled task which will refresh hosts' and vms' information
> > periodically.
> > Only the dynamic and statistics data will be updated during the refresh.
> > So
> > I think the resource information, such as cpu and/or memory, should be in
> > dynamic and statistics. And in my understanding, the information in
> > dynamic
> > class is the changeable information but with a low varying frequency,
> > like
> > cpu topology, libvirt/kernel versions, etc. The information in statistics
> > class is the information with a high varying frequency, like the usage of
> > cpu/memory, etc. In my opinion, it's reasonable to put host level NUMA
> > information in vds_dynamic and host level NUMA statistics information in
> > vds_statistics.
> >
> > Hi Gilad/Roy/Omer,
> > I don't know if my understanding is correct. But according to this guess,
> > I
> > think it's also reasonable to put vm cpuPin information in vm_static.
> > Because cpuPin is user configured information, it will not vary
> > automatically. So we don’t need to refresh this information periodically.
> > Please correct me if there are any mistakes.
> >
> > Hi Eli,
> > Sorry for the nag. If my understanding above is correct, I think we
> > should
> > still put host level NUMA fields in vds_dynamic/vds_statistics and vm
> > level
> > NUMA fields in vm_static. Since vm level NUMA fields are configured by
> > user
> > and they will not vary automatically.
>
> Sorry, I had understood from Gilad that the NUMA fields in the host level
> are
> relatively static and the NUMA fields on the VM level are dynamic.
> I have no problem of having hybrid static/dynamic fields for Host/VM as
> long
> as it has a good reason and fully documented :-)
>
>
> >
> >
> > Thanks & Best Regards
> > Shi, Xiao-Lei (Bruce)
> >
> > Hewlett-Packard Co., Ltd.
> > HP Servers Core Platform Software China
> > Telephone +86 23 65683093
> > Mobile +86 18696583447
> > Email xiao-lei.shi(a)hp.com
> >
> >
> > -----Original Message-----
> > From: Gilad Chaplik [mailto:gchaplik@redhat.com]
> > Sent: Monday, March 31, 2014 9:31 PM
> > To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Roy Golan; Omer Frenkel
> > Cc: Eli Mesika; Roy Golan; Liao, Chuan (Jason Liao,
> > HPservers-Core-OE-PSC);
> > Doron Fediuck; Vinod, Chegu; Liang, Shang-Chun (David Liang,
> > HPservers-Core-OE-PSC); Yaniv Dary; engine-devel(a)ovirt.org
> > Subject: Re: Please help us to review our database schema design with
> > NUMA
> > feature on ovirt
> >
> > adding Roy & Omer.
> >
> > why CPU topology is in dynamic?
> >
> > Thanks,
> > Gilad.
> >
> > ----- Original Message -----
> > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> > > To: "Eli Mesika" <emesika(a)redhat.com>
> > > Cc: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Roy
Golan"
> > > <rgolan(a)redhat.com>, "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)"
> > > <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>, "Chegu
> > > Vinod"
> > > <chegu_vinod(a)hp.com>, "Shang-Chun Liang (David Liang,
> > > HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv
Dary"
> > > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > > Sent: Monday, March 31, 2014 3:20:33 PM
> > > Subject: RE: Please help us to review our database schema design with
> > > NUMA feature on ovirt
> > >
> > > Thanks Eli.
> > > I will move the vm level NUMA fields to vm_dynamic, and the related
> > > database schema will be updated accordingly.
> > >
> > > Thanks & Best Regards
> > > Shi, Xiao-Lei (Bruce)
> > >
> > > Hewlett-Packard Co., Ltd.
> > > HP Servers Core Platform Software China Telephone +86 23 65683093
> > > Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > >
> > > -----Original Message-----
> > > From: Eli Mesika [mailto:emesika@redhat.com]
> > > Sent: Monday, March 31, 2014 5:49 PM
> > > To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > Cc: Gilad Chaplik; Roy Golan; Liao, Chuan (Jason Liao,
> > > HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang, Shang-Chun
> > > (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
> > > engine-devel(a)ovirt.org
> > > Subject: Re: Please help us to review our database schema design with
> > > NUMA feature on ovirt
> > >
> > >
> > >
> > > ----- Original Message -----
> > > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > > <xiao-lei.shi(a)hp.com>
> > > > To: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Eli
Mesika"
> > > > <emesika(a)redhat.com>, "Roy Golan"
<rgolan(a)redhat.com>
> > > > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > > > <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>, "Chegu
> > > > Vinod"
> > > > <chegu_vinod(a)hp.com>, "Shang-Chun Liang (David Liang,
> > > > HPservers-Core-OE-PSC)"
> > > > <shangchun.liang(a)hp.com>, "Yaniv Dary"
<ydary(a)redhat.com>,
> > > > engine-devel(a)ovirt.org
> > > > Sent: Monday, March 31, 2014 12:38:04 PM
> > > > Subject: RE: Please help us to review our database schema design
> > > > with NUMA feature on ovirt
> > > >
> > > > We put host level NUMA fields in vds_dynamic because these
> > > > information are from host itself, and NUMA topology may be changed
> > > > if the host's hardware make a change. NUMA information are
similar
> > > > to the host's cpu topology information like cpu_cores and
> > > > cpu_sockets which are in vds_dynamic, we refer to this.
> > > > VM level NUMA fields are configured by user, and actually we
> > > > originally think they should be in vm_dynamic. But we found that the
> > > > field of another feature cpuPin which is similar as NUMA feature is
> > > > in vm_static, so we put vm NUMA fields in vm_static.
> > > > Do you think we need to put VM level NUMA fields in vm_dynamic?
> > >
> > > I think that in this case we should fix cpuPin to be in vm_dynamic and
> > > put after that the other NUMA fields in vm_dynamic as well
> > >
> > > >
> > > > Thanks & Best Regards
> > > > Shi, Xiao-Lei (Bruce)
> > > >
> > > > Hewlett-Packard Co., Ltd.
> > > > HP Servers Core Platform Software China Telephone +86 23 65683093
> > > > Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > > >
> > > >
> > > > -----Original Message-----
> > > > From: Gilad Chaplik [mailto:gchaplik@redhat.com]
> > > > Sent: Monday, March 31, 2014 5:22 PM
> > > > To: Eli Mesika; Roy Golan
> > > > Cc: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Liao, Chuan (Jason
> > > > Liao, HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang,
> > > > Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
> > > > engine-devel(a)ovirt.org
> > > > Subject: Re: Please help us to review our database schema design
> > > > with NUMA feature on ovirt
> > > >
> > > > +1
> > > >
> > > > IMO: vds data should reside in static VM need to think about it.
> > > >
> > > > Roy?
> > > >
> > > > Thanks,
> > > > Gilad.
> > > >
> > > >
> > > > ----- Original Message -----
> > > > > From: "Eli Mesika" <emesika(a)redhat.com>
> > > > > To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > > > <xiao-lei.shi(a)hp.com>
> > > > > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > > > > <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>, "Gilad
> > > > > Chaplik" <gchaplik(a)redhat.com>, "Chegu
Vinod"
> > > > > <chegu_vinod(a)hp.com>,
> > > > > "Shang-Chun Liang (David Liang,
> > > > > HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>,
"Yaniv Dary"
> > > > > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > > > > Sent: Monday, March 31, 2014 12:12:50 PM
> > > > > Subject: Re: Please help us to review our database schema
design
> > > > > with NUMA feature on ovirt
> > > > >
> > > > >
> > > > >
> > > > > ----- Original Message -----
> > > > > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > > > > <xiao-lei.shi(a)hp.com>
> > > > > > To: "Eli Mesika" <emesika(a)redhat.com>
> > > > > > Cc: "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)"
> > > > > > <chuan.liao(a)hp.com>,
> > > > > > "Doron Fediuck" <dfediuck(a)redhat.com>,
"Gilad Chaplik"
> > > > > > <gchaplik(a)redhat.com>, "Chegu Vinod"
> > > > > > <chegu_vinod(a)hp.com>,
> > > > > > "Shang-Chun Liang (David Liang,
> > > > > > HPservers-Core-OE-PSC)"
<shangchun.liang(a)hp.com>, "Yaniv Dary"
> > > > > > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > > > > > Sent: Monday, March 31, 2014 8:56:20 AM
> > > > > > Subject: RE: Please help us to review our database schema
design
> > > > > > with NUMA feature on ovirt
> > > > > >
> > > > > > Include the devel group.
> > > > > > Thanks Eli for the quick responses for our first design
and
> > > > > > sorry for the nag.
> > > > > > We appreciate any of the comments for our database design
and
> > > > > > will follow the design to do the implementation if no more
> > > > > > comments.
> > > > > >
http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
> > > > >
> > > > > Seems OK for me except an unanswered question I had asked in my
> > > > > first review
> > > > > :
> > > > >
> > > > > Why in the Host level NUMA fields are added to vds_dynamic
while
> > > > > in the VM level it is added to vm_static ???
> > > > > I would expect it to be in both on static or dynamic , can you
> > > > > please explain ? Thanks
> > > > >
> > > > > >
> > > > > > Thanks & Best Regards
> > > > > > Shi, Xiao-Lei (Bruce)
> > > > > >
> > > > > > Hewlett-Packard Co., Ltd.
> > > > > > HP Servers Core Platform Software China Telephone +86 23
> > > > > > 65683093 Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > > > > >
> > > > > > -----Original Message-----
> > > > > > From: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > > > > Sent: Friday, March 28, 2014 1:30 PM
> > > > > > To: 'Eli Mesika'
> > > > > > Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron
> > > > > > Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun
(David
> > > > > > Liang, HPservers-Core-OE-PSC); Yaniv Dary
> > > > > > Subject: RE: Please help us to review our database schema
design
> > > > > > with NUMA feature on ovirt
> > > > > >
> > > > > > Hi Eli,
> > > > > >
> > > > > > After the UX design meeting, we did some modification for
the
> > > > > > database schema, and merged some update according to your
last
> > > > > > review
> > > > > > comments.
> > > > > > Now the document has been posted on ovirt wikipage, could
you
> > > > > > help to review the database design again:
> > > > > >
http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
> > > > > >
> > > > > >
> > > > > > Thanks & Best Regards
> > > > > > Shi, Xiao-Lei (Bruce)
> > > > > >
> > > > > > Hewlett-Packard Co., Ltd.
> > > > > > HP Servers Core Platform Software China Telephone +86 23
> > > > > > 65683093 Mobile
> > > > > > +86
> > > > > > 18696583447 Email xiao-lei.shi(a)hp.com
> > > > > >
> > > > > >
> > > > > > -----Original Message-----
> > > > > > From: Eli Mesika [mailto:emesika@redhat.com]
> > > > > > Sent: Monday, March 24, 2014 6:24 PM
> > > > > > To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > > > > Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron
> > > > > > Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun
(David
> > > > > > Liang, HPservers-Core-OE-PSC); Yaniv Dary
> > > > > > Subject: Re: Please help us to review our database schema
design
> > > > > > with NUMA feature on ovirt
> > > > > >
> > > > > >
> > > > > >
> > > > > > ----- Original Message -----
> > > > > > > From: "Xiao-Lei Shi (Bruce, HP
Servers-PSC-CQ)"
> > > > > > > <xiao-lei.shi(a)hp.com>
> > > > > > > To: "Eli Mesika" <emesika(a)redhat.com>,
"Chuan Liao (Jason
> > > > > > > Liao, HPservers-Core-OE-PSC)"
<chuan.liao(a)hp.com>
> > > > > > > Cc: "Doron Fediuck"
<dfediuck(a)redhat.com>, "Gilad Chaplik"
> > > > > > > <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>,
> > > > > > > "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)"
> > > > > > > <shangchun.liang(a)hp.com>
> > > > > > > Sent: Monday, March 24, 2014 11:23:39 AM
> > > > > > > Subject: RE: Please help us to review our database
schema
> > > > > > > design with NUMA feature on ovirt
> > > > > > >
> > > > > > > Hi Eli,
> > > > > > >
> > > > > > > Thanks for your comments.
> > > > > > > I have updated the document according to your comments
except
> > > > > > > the below
> > > > > > > one:
> > > > > > > Missing from here are 2 issues:
> > > > > > >
> > > > > > > 1) Impact on the search engine, which new columns are
> > > > > > > search-able and which changes are planned in the
search engine
> > > > > > > code to enable that
> > > > > > >
> > > > > > > 2) Impact on engine-reports, are those changed planned
to be
> > > > > > > exposed to the engine data warehouse and required
new/modified
> > > > > > > reports?
> > > > > > >
> > > > > > > Could you tell us more detailed information about the
modules
> > > > > > > you mentioned above? I mean "search engine"
and
> > > > > > > "engine-reports". I think we missed these
two parts in our
> > > > > > > previous
> > > > > > > investigation.
> > > > > > > I just find org.ovirt.engine.core.bll.SearchQuery, is
that the
> > > > > > > right object for search engine?
> > > > > >
> > > > > > Yes, actually when you are opening the admin UI, there are
TABs
> > > > > > for each entity , i.e. Data Center, Cluster, Host etc.
> > > > > > In each, you can see a text-box in which you can search for
by
> > > > > > writing a search expression My question is
> > > > > > 1) What is the impact of your work on the search on the
Fost
> > > > > > and
> > > > > > VM
> > > > > > TABs
> > > > > > a) Are there any fields that are supported now in
the
> > > > > > search
> > > > > > expression
> > > > > > and should pop-up when you write the expression by
the
> > > > > > auto-completion
> > > > > > mechanism ?
> > > > > > b) Are there any added columns displayed in the
result of
> > > > > > such
> > > > > > a
> > > > > > search
> > > > > > in the grid ?
> > > > > >
> > > > > > > How about the engine-reports, could you give us some
hints,
> > > > > > > like the code location and any more detailed
information that
> > > > > > > we can start more investigation?
> > > > > >
> > > > > > CCing Yaniv D who is in charge of the reports/dwh module
Yaniv,
> > > > > > any planned work for adding Numa features to Host/VM in
the
> > > > > > reports side ?
> > > > > >
> > > > > > Thanks
> > > > > >
> > > > > > >
> > > > > > > Thanks & Best Regards
> > > > > > > Shi, Xiao-Lei (Bruce)
> > > > > > >
> > > > > > > Hewlett-Packard Co., Ltd.
> > > > > > > HP Servers Core Platform Software China Telephone +86
23
> > > > > > > 65683093 Mobile +86 18696583447 Email
xiao-lei.shi(a)hp.com
> > > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: Eli Mesika [mailto:emesika@redhat.com]
> > > > > > > Sent: Sunday, March 23, 2014 4:44 PM
> > > > > > > To: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
> > > > > > > Cc: Doron Fediuck; Gilad Chaplik; Vinod, Chegu;
Liang,
> > > > > > > Shang-Chun (David Liang, HPservers-Core-OE-PSC); Shi,
Xiao-Lei
> > > > > > > (Bruce, HP
> > > > > > > Servers-PSC-CQ)
> > > > > > > Subject: Re: Please help us to review our database
schema
> > > > > > > design with NUMA feature on ovirt
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > ----- Original Message -----
> > > > > > > > From: "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)"
> > > > > > > > <chuan.liao(a)hp.com>
> > > > > > > > To: emesika(a)redhat.com
> > > > > > > > Cc: "Doron Fediuck"
<dfediuck(a)redhat.com>, "Gilad Chaplik"
> > > > > > > > <gchaplik(a)redhat.com>, "Chegu
Vinod" <chegu_vinod(a)hp.com>,
> > > > > > > > "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)"
> > > > > > > > <shangchun.liang(a)hp.com>, "Xiao-Lei
Shi (Bruce, HP
> > > > > > > > Servers-PSC-CQ)"
> > > > > > > > <xiao-lei.shi(a)hp.com>
> > > > > > > > Sent: Friday, March 21, 2014 10:42:33 AM
> > > > > > > > Subject: Please help us to review our database
schema design
> > > > > > > > with NUMA feature on ovirt
> > > > > > > >
> > > > > > > > Hi Eli,
> > > > > > > >
> > > > > > > > Please help us to review our database schema
design with
> > > > > > > > NUMA feature on ovirt
> > > > > > > >
https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcmbGWA
> > > > > > > > cyQo_IST
> > > > > > > > Y8
> > > > > > > > ykDr0I6VY/edit?usp=sharing
> > > > > > > >
> > > > > > > > Feel free to take comments on document at
anywhere
> > > > > > >
> > > > > > > Done, had commented on the document.
> > > > > > > Eli
> > > > > > >
> > > > > > > >
> > > > > > > > Especially, 5.4 The used interface between engine
core and
> > > > > > > > database(schema)
> > > > > > > >
> > > > > > > > Your approve and your comments with this section
will be
> > > > > > > > much more appreciate for us.
> > > > > > > >
> > > > > > > > Best Regards,
> > > > > > > > Jason Liao
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
11:25 p.m.
New subject: [Engine-devel] Please help us to review our database schema design with NUMA feature on ovirt
Hi all,
Please see my comments in line.
Thanks & Best Regards
Shi, Xiao-Lei (Bruce)
Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China
Telephone +86 23 65683093
Mobile +86 18696583447
Email xiao-lei.shi(a)hp.com
-----Original Message-----
From: Gilad Chaplik [mailto:gchaplik@redhat.com]
Sent: Thursday, April 03, 2014 9:05 AM
To: Eli Mesika
Cc: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Roy Golan; Omer Frenkel; Vinod, Chegu; Liao,
Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck; Liang, Shang-Chun (David Liang,
HPservers-Core-OE-PSC); Yaniv Dary; engine-devel(a)ovirt.org
Subject: Re: Please help us to review our database schema design with NUMA feature on
ovirt
Hi all,
Sorry for joining-in late.
My comments (according to the db diagram section in
https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcmbGWAcyQo_ISTY8ykD...):
1) Join vm_numa_node and vds_numa_node to a single table (almost identical), one of the
FKs can be null.
[Bruce] I prefer two tables. Actually host level NUMA node and vm level NUMA node are
different objects. In my understanding, vm level NUMA node is just a simulation of host
level NUMA node, and host level NUMA node has more features that not in vm NUMA (like
several levels of host NUMA topology mentioned by Vinod). We need to consider the
extensions of host NUMA in the future.
2) No templates reference in the design, need to check it out (it might be inherently
designed already :-) ); vNode can be linked to a template.
[Bruce] IMO, we can consider template as a special vm, our current design supports to
create vNodes in a template just like what it does in a vm.
3) The reason I want host's NUMA data to be in static is because it updates only once
(on boot). "engineerically" speaking, dynamic table has a lot of traffic and
that's not the case for NUMA info. Its feels to me like 'a hybrid' of static
and dynamic, 3 suggestions comes to mind:
- leave it in dynamic (maybe in a separate process).
- have a separate flow that updates static.
- come up with a third 'vds_on_boot' table (my favorite ;-P ).
I will get back to you on that.
[Bruce] From the onTimer codes in vdsManager (IMO it's the scheduled vds refresh
action), when vds is in normal running status (up status), only statistics data will be
refreshed, so I think maybe dynamic table doesn't have so much traffic, and the varied
data (I mean the data varied through a power reload, like cpu topology, numa topology,
...etc) can be refreshed meanwhile.
4) vm_vds_numa_node_map is connected to vds_numa_node_statistics, why to split the tables
(vds_numa_node & vds_numa_node_statistics), going back to comment #1, don't we
want vNode stats as well, it can be nice to show it :-) (have a vNUMA overview of the VM
using guest-agent or sth, in a future phase).
[Bruce] Split the tables is referring to vds_interface (vds_interface_statistics) and
vm_interface (vm_interface_statistics), the statistics table will be refreshed with a high
frequency.
I will update the design to add the vNuma statistics for the future phase, and according
to my feedback in comment #1, vNuma statistics will also in an independent table since I
think there will be more statistics fields for host NUMA than for vNuma.
5) IMO vds_cpu_statistics shouldn't include any reference to NUMA, I gave that comment
in the BE patch as well (remove vds_numa_node_id FK in vds_cpu_statistics), for that you
should extract cpu_list to a connection table (anyway I don't like lists as a
text/strings/etc.)
[Bruce] Yes, I agree with you to remove the reference between vds_cpu_statistics and NUMA.
Actually cpu_list is enough for current requirements. I think the connection table is
needed when we consider to collect more cpu related information and do more cpu related
actions in the future.
6) vm_numatune_nodeset can be removed - the vNode should hold it's pinning info; I
think that vNode (node according to comment #1) should be connected to a connection table
that points to vdsNode (also Node table) itself (kinda complicated but does the trick -
nested link).
[Bruce] Yes, I will remove vm_numatune_nodeset, but according to my feedback in comment
#1, vm_vds_numa_node_map table will be retained to hold the references between host nodes
and vNode, since they are "m:n" relations.
7) Please add delete-cascade info all over, i.e. what happens when we remove a
host/vm/node.
[Bruce] Yes, I will update the design.
8) Is it possible to put a db constraint that mapping between vNode and Node will be
deleted once the VM isn't UP?
[Bruce] I have a question here. IMO, the mapping between vNode and Node is a user
configuration, why it is related with the vm status? If the mapping is deleted, that means
the user configuration is deleted. I don't think it's reasonable.
Thanks,
Gilad.
----- Original Message -----
From: "Eli Mesika" <emesika(a)redhat.com>
To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <xiao-lei.shi(a)hp.com>
Cc: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Roy Golan"
<rgolan(a)redhat.com>, "Omer Frenkel" <ofrenkel(a)redhat.com>,
"Chegu
Vinod" <chegu_vinod(a)hp.com>, "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>, "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv Dary"
<ydary(a)redhat.com>, engine-devel(a)ovirt.org
Sent: Tuesday, April 1, 2014 10:10:37 AM
Subject: Re: Please help us to review our database schema design with
NUMA feature on ovirt
----- Original Message -----
> From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> <xiao-lei.shi(a)hp.com>
> To: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Roy Golan"
> <rgolan(a)redhat.com>, "Omer Frenkel" <ofrenkel(a)redhat.com>,
"Eli
> Mesika" <emesika(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>
> Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> <chuan.liao(a)hp.com>, "Doron Fediuck" <dfediuck(a)redhat.com>,
> "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
> <shangchun.liang(a)hp.com>, "Yaniv Dary" <ydary(a)redhat.com>,
> engine-devel(a)ovirt.org
> Sent: Tuesday, April 1, 2014 5:13:34 AM
> Subject: RE: Please help us to review our database schema design
> with NUMA feature on ovirt
>
> Assemble the related discussions in this mail session.
>
> Hi Vinod,
> On 3/31/2014 2:38 AM, Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ) wrote:
> > We put host level NUMA fields in vds_dynamic because these
> > information are from host itself, and NUMA topology may be changed
> > if the host's hardware make a change.
> Can you please elaborate ? Are you thinking about resource (cpu
> and/or
> memory) hot plug on the host ?
> [Bruce] It's not about resource hot plug. In ovirt engine, there is
> a scheduled task which will refresh hosts' and vms' information
periodically.
> Only the dynamic and statistics data will be updated during the
> refresh. So I think the resource information, such as cpu and/or
> memory, should be in dynamic and statistics. And in my
> understanding, the information in dynamic class is the changeable
> information but with a low varying frequency, like cpu topology,
> libvirt/kernel versions, etc. The information in statistics class is
> the information with a high varying frequency, like the usage of
> cpu/memory, etc. In my opinion, it's reasonable to put host level
> NUMA information in vds_dynamic and host level NUMA statistics information in
vds_statistics.
>
> Hi Gilad/Roy/Omer,
> I don't know if my understanding is correct. But according to this
> guess, I think it's also reasonable to put vm cpuPin information in vm_static.
> Because cpuPin is user configured information, it will not vary
> automatically. So we don’t need to refresh this information periodically.
> Please correct me if there are any mistakes.
>
> Hi Eli,
> Sorry for the nag. If my understanding above is correct, I think we
> should still put host level NUMA fields in
> vds_dynamic/vds_statistics and vm level NUMA fields in vm_static.
> Since vm level NUMA fields are configured by user and they will not vary
automatically.
Sorry, I had understood from Gilad that the NUMA fields in the host
level are relatively static and the NUMA fields on the VM level are dynamic.
I have no problem of having hybrid static/dynamic fields for Host/VM
as long as it has a good reason and fully documented :-)
>
>
> Thanks & Best Regards
> Shi, Xiao-Lei (Bruce)
>
> Hewlett-Packard Co., Ltd.
> HP Servers Core Platform Software China Telephone +86 23 65683093
> Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
>
>
> -----Original Message-----
> From: Gilad Chaplik [mailto:gchaplik@redhat.com]
> Sent: Monday, March 31, 2014 9:31 PM
> To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Roy Golan; Omer
> Frenkel
> Cc: Eli Mesika; Roy Golan; Liao, Chuan (Jason Liao,
> HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang,
> Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
> engine-devel(a)ovirt.org
> Subject: Re: Please help us to review our database schema design
> with NUMA feature on ovirt
>
> adding Roy & Omer.
>
> why CPU topology is in dynamic?
>
> Thanks,
> Gilad.
>
> ----- Original Message -----
> > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > <xiao-lei.shi(a)hp.com>
> > To: "Eli Mesika" <emesika(a)redhat.com>
> > Cc: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Roy
Golan"
> > <rgolan(a)redhat.com>, "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)"
> > <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>, "Chegu Vinod"
> > <chegu_vinod(a)hp.com>, "Shang-Chun Liang (David Liang,
> > HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv
Dary"
> > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > Sent: Monday, March 31, 2014 3:20:33 PM
> > Subject: RE: Please help us to review our database schema design
> > with NUMA feature on ovirt
> >
> > Thanks Eli.
> > I will move the vm level NUMA fields to vm_dynamic, and the
> > related database schema will be updated accordingly.
> >
> > Thanks & Best Regards
> > Shi, Xiao-Lei (Bruce)
> >
> > Hewlett-Packard Co., Ltd.
> > HP Servers Core Platform Software China Telephone +86 23 65683093
> > Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> >
> > -----Original Message-----
> > From: Eli Mesika [mailto:emesika@redhat.com]
> > Sent: Monday, March 31, 2014 5:49 PM
> > To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > Cc: Gilad Chaplik; Roy Golan; Liao, Chuan (Jason Liao,
> > HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang,
> > Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
> > engine-devel(a)ovirt.org
> > Subject: Re: Please help us to review our database schema design
> > with NUMA feature on ovirt
> >
> >
> >
> > ----- Original Message -----
> > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > <xiao-lei.shi(a)hp.com>
> > > To: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Eli
Mesika"
> > > <emesika(a)redhat.com>, "Roy Golan"
<rgolan(a)redhat.com>
> > > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > > <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>,
> > > "Chegu Vinod"
> > > <chegu_vinod(a)hp.com>, "Shang-Chun Liang (David Liang,
> > > HPservers-Core-OE-PSC)"
> > > <shangchun.liang(a)hp.com>, "Yaniv Dary"
<ydary(a)redhat.com>,
> > > engine-devel(a)ovirt.org
> > > Sent: Monday, March 31, 2014 12:38:04 PM
> > > Subject: RE: Please help us to review our database schema design
> > > with NUMA feature on ovirt
> > >
> > > We put host level NUMA fields in vds_dynamic because these
> > > information are from host itself, and NUMA topology may be
> > > changed if the host's hardware make a change. NUMA information
> > > are similar to the host's cpu topology information like
> > > cpu_cores and cpu_sockets which are in vds_dynamic, we refer to this.
> > > VM level NUMA fields are configured by user, and actually we
> > > originally think they should be in vm_dynamic. But we found that
> > > the field of another feature cpuPin which is similar as NUMA
> > > feature is in vm_static, so we put vm NUMA fields in vm_static.
> > > Do you think we need to put VM level NUMA fields in vm_dynamic?
> >
> > I think that in this case we should fix cpuPin to be in vm_dynamic
> > and put after that the other NUMA fields in vm_dynamic as well
> >
> > >
> > > Thanks & Best Regards
> > > Shi, Xiao-Lei (Bruce)
> > >
> > > Hewlett-Packard Co., Ltd.
> > > HP Servers Core Platform Software China Telephone +86 23
> > > 65683093 Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > >
> > >
> > > -----Original Message-----
> > > From: Gilad Chaplik [mailto:gchaplik@redhat.com]
> > > Sent: Monday, March 31, 2014 5:22 PM
> > > To: Eli Mesika; Roy Golan
> > > Cc: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Liao, Chuan (Jason
> > > Liao, HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu;
> > > Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv
> > > Dary; engine-devel(a)ovirt.org
> > > Subject: Re: Please help us to review our database schema design
> > > with NUMA feature on ovirt
> > >
> > > +1
> > >
> > > IMO: vds data should reside in static VM need to think about it.
> > >
> > > Roy?
> > >
> > > Thanks,
> > > Gilad.
> > >
> > >
> > > ----- Original Message -----
> > > > From: "Eli Mesika" <emesika(a)redhat.com>
> > > > To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > > <xiao-lei.shi(a)hp.com>
> > > > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > > > <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>,
> > > > "Gilad Chaplik" <gchaplik(a)redhat.com>, "Chegu
Vinod"
> > > > <chegu_vinod(a)hp.com>,
> > > > "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
> > > > <shangchun.liang(a)hp.com>, "Yaniv Dary"
> > > > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > > > Sent: Monday, March 31, 2014 12:12:50 PM
> > > > Subject: Re: Please help us to review our database schema
> > > > design with NUMA feature on ovirt
> > > >
> > > >
> > > >
> > > > ----- Original Message -----
> > > > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > > > <xiao-lei.shi(a)hp.com>
> > > > > To: "Eli Mesika" <emesika(a)redhat.com>
> > > > > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > > > > <chuan.liao(a)hp.com>,
> > > > > "Doron Fediuck" <dfediuck(a)redhat.com>,
"Gilad Chaplik"
> > > > > <gchaplik(a)redhat.com>, "Chegu Vinod"
> > > > > <chegu_vinod(a)hp.com>,
> > > > > "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)"
> > > > > <shangchun.liang(a)hp.com>, "Yaniv Dary"
> > > > > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > > > > Sent: Monday, March 31, 2014 8:56:20 AM
> > > > > Subject: RE: Please help us to review our database schema
> > > > > design with NUMA feature on ovirt
> > > > >
> > > > > Include the devel group.
> > > > > Thanks Eli for the quick responses for our first design and
> > > > > sorry for the nag.
> > > > > We appreciate any of the comments for our database design
> > > > > and will follow the design to do the implementation if no
> > > > > more comments.
> > > > >
> > > > > http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
> > > >
> > > > Seems OK for me except an unanswered question I had asked in
> > > > my first review
> > > > :
> > > >
> > > > Why in the Host level NUMA fields are added to vds_dynamic
> > > > while in the VM level it is added to vm_static ???
> > > > I would expect it to be in both on static or dynamic , can you
> > > > please explain ? Thanks
> > > >
> > > > >
> > > > > Thanks & Best Regards
> > > > > Shi, Xiao-Lei (Bruce)
> > > > >
> > > > > Hewlett-Packard Co., Ltd.
> > > > > HP Servers Core Platform Software China Telephone +86 23
> > > > > 65683093 Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > > > >
> > > > > -----Original Message-----
> > > > > From: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > > > Sent: Friday, March 28, 2014 1:30 PM
> > > > > To: 'Eli Mesika'
> > > > > Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron
> > > > > Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun
> > > > > (David Liang, HPservers-Core-OE-PSC); Yaniv Dary
> > > > > Subject: RE: Please help us to review our database schema
> > > > > design with NUMA feature on ovirt
> > > > >
> > > > > Hi Eli,
> > > > >
> > > > > After the UX design meeting, we did some modification for
> > > > > the database schema, and merged some update according to
> > > > > your last review comments.
> > > > > Now the document has been posted on ovirt wikipage, could
> > > > > you help to review the database design again:
> > > > > http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
> > > > >
> > > > >
> > > > > Thanks & Best Regards
> > > > > Shi, Xiao-Lei (Bruce)
> > > > >
> > > > > Hewlett-Packard Co., Ltd.
> > > > > HP Servers Core Platform Software China Telephone +86 23
> > > > > 65683093 Mobile
> > > > > +86
> > > > > 18696583447 Email xiao-lei.shi(a)hp.com
> > > > >
> > > > >
> > > > > -----Original Message-----
> > > > > From: Eli Mesika [mailto:emesika@redhat.com]
> > > > > Sent: Monday, March 24, 2014 6:24 PM
> > > > > To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > > > Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron
> > > > > Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun
> > > > > (David Liang, HPservers-Core-OE-PSC); Yaniv Dary
> > > > > Subject: Re: Please help us to review our database schema
> > > > > design with NUMA feature on ovirt
> > > > >
> > > > >
> > > > >
> > > > > ----- Original Message -----
> > > > > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > > > > <xiao-lei.shi(a)hp.com>
> > > > > > To: "Eli Mesika" <emesika(a)redhat.com>,
"Chuan Liao (Jason
> > > > > > Liao, HPservers-Core-OE-PSC)"
<chuan.liao(a)hp.com>
> > > > > > Cc: "Doron Fediuck" <dfediuck(a)redhat.com>,
"Gilad Chaplik"
> > > > > > <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>,
> > > > > > "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)"
> > > > > > <shangchun.liang(a)hp.com>
> > > > > > Sent: Monday, March 24, 2014 11:23:39 AM
> > > > > > Subject: RE: Please help us to review our database schema
> > > > > > design with NUMA feature on ovirt
> > > > > >
> > > > > > Hi Eli,
> > > > > >
> > > > > > Thanks for your comments.
> > > > > > I have updated the document according to your comments
> > > > > > except the below
> > > > > > one:
> > > > > > Missing from here are 2 issues:
> > > > > >
> > > > > > 1) Impact on the search engine, which new columns are
> > > > > > search-able and which changes are planned in the search
> > > > > > engine code to enable that
> > > > > >
> > > > > > 2) Impact on engine-reports, are those changed planned to
> > > > > > be exposed to the engine data warehouse and required
> > > > > > new/modified reports?
> > > > > >
> > > > > > Could you tell us more detailed information about the
> > > > > > modules you mentioned above? I mean "search
engine" and
> > > > > > "engine-reports". I think we missed these two
parts in our
> > > > > > previous investigation.
> > > > > > I just find org.ovirt.engine.core.bll.SearchQuery, is that
> > > > > > the right object for search engine?
> > > > >
> > > > > Yes, actually when you are opening the admin UI, there are
> > > > > TABs for each entity , i.e. Data Center, Cluster, Host etc.
> > > > > In each, you can see a text-box in which you can search for
> > > > > by writing a search expression My question is
> > > > > 1) What is the impact of your work on the search on the Fost
and
> > > > > VM
> > > > > TABs
> > > > > a) Are there any fields that are supported now in the
search
> > > > > expression
> > > > > and should pop-up when you write the expression by the
> > > > > auto-completion
> > > > > mechanism ?
> > > > > b) Are there any added columns displayed in the result
of
> > > > > such
> > > > > a
> > > > > search
> > > > > in the grid ?
> > > > >
> > > > > > How about the engine-reports, could you give us some
> > > > > > hints, like the code location and any more detailed
> > > > > > information that we can start more investigation?
> > > > >
> > > > > CCing Yaniv D who is in charge of the reports/dwh module
> > > > > Yaniv, any planned work for adding Numa features to Host/VM
> > > > > in the reports side ?
> > > > >
> > > > > Thanks
> > > > >
> > > > > >
> > > > > > Thanks & Best Regards
> > > > > > Shi, Xiao-Lei (Bruce)
> > > > > >
> > > > > > Hewlett-Packard Co., Ltd.
> > > > > > HP Servers Core Platform Software China Telephone +86 23
> > > > > > 65683093 Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > > > > >
> > > > > > -----Original Message-----
> > > > > > From: Eli Mesika [mailto:emesika@redhat.com]
> > > > > > Sent: Sunday, March 23, 2014 4:44 PM
> > > > > > To: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
> > > > > > Cc: Doron Fediuck; Gilad Chaplik; Vinod, Chegu; Liang,
> > > > > > Shang-Chun (David Liang, HPservers-Core-OE-PSC); Shi,
> > > > > > Xiao-Lei (Bruce, HP
> > > > > > Servers-PSC-CQ)
> > > > > > Subject: Re: Please help us to review our database schema
> > > > > > design with NUMA feature on ovirt
> > > > > >
> > > > > >
> > > > > >
> > > > > > ----- Original Message -----
> > > > > > > From: "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)"
> > > > > > > <chuan.liao(a)hp.com>
> > > > > > > To: emesika(a)redhat.com
> > > > > > > Cc: "Doron Fediuck"
<dfediuck(a)redhat.com>, "Gilad Chaplik"
> > > > > > > <gchaplik(a)redhat.com>, "Chegu Vinod"
> > > > > > > <chegu_vinod(a)hp.com>, "Shang-Chun Liang
(David Liang, HPservers-Core-OE-PSC)"
> > > > > > > <shangchun.liang(a)hp.com>, "Xiao-Lei Shi
(Bruce, HP
> > > > > > > Servers-PSC-CQ)"
> > > > > > > <xiao-lei.shi(a)hp.com>
> > > > > > > Sent: Friday, March 21, 2014 10:42:33 AM
> > > > > > > Subject: Please help us to review our database schema
> > > > > > > design with NUMA feature on ovirt
> > > > > > >
> > > > > > > Hi Eli,
> > > > > > >
> > > > > > > Please help us to review our database schema design
with
> > > > > > > NUMA feature on ovirt
> > > > > > >
https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcm
> > > > > > > bGWA
> > > > > > > cyQo_IST
> > > > > > > Y8
> > > > > > > ykDr0I6VY/edit?usp=sharing
> > > > > > >
> > > > > > > Feel free to take comments on document at anywhere
> > > > > >
> > > > > > Done, had commented on the document.
> > > > > > Eli
> > > > > >
> > > > > > >
> > > > > > > Especially, 5.4 The used interface between engine core
> > > > > > > and
> > > > > > > database(schema)
> > > > > > >
> > > > > > > Your approve and your comments with this section will
be
> > > > > > > much more appreciate for us.
> > > > > > >
> > > > > > > Best Regards,
> > > > > > > Jason Liao
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
2:54 a.m.
New subject: [Engine-devel] Please help us to review our database schema design with NUMA feature on ovirt
----- Original Message -----
From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
To: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Eli Mesika"
<emesika(a)redhat.com>
Cc: "Roy Golan" <rgolan(a)redhat.com>, "Omer Frenkel"
<ofrenkel(a)redhat.com>, "Chegu Vinod" <chegu_vinod(a)hp.com>,
"Chuan
Liao (Jason Liao, HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>, "Doron
Fediuck" <dfediuck(a)redhat.com>, "Shang-Chun
Liang (David Liang, HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>,
"Yaniv Dary" <ydary(a)redhat.com>,
engine-devel(a)ovirt.org
Sent: Thursday, April 3, 2014 7:25:11 AM
Subject: RE: Please help us to review our database schema design with NUMA feature on
ovirt
Hi all,
Please see my comments in line.
Thanks & Best Regards
Shi, Xiao-Lei (Bruce)
Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China
Telephone +86 23 65683093
Mobile +86 18696583447
Email xiao-lei.shi(a)hp.com
-----Original Message-----
From: Gilad Chaplik [mailto:gchaplik@redhat.com]
Sent: Thursday, April 03, 2014 9:05 AM
To: Eli Mesika
Cc: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Roy Golan; Omer Frenkel; Vinod,
Chegu; Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck;
Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
engine-devel(a)ovirt.org
Subject: Re: Please help us to review our database schema design with NUMA
feature on ovirt
Hi all,
Sorry for joining-in late.
My comments (according to the db diagram section in
https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcmbGWAcyQo_ISTY8ykD...):
1) Join vm_numa_node and vds_numa_node to a single table (almost identical),
one of the FKs can be null.
[Bruce] I prefer two tables. Actually host level NUMA node and vm level NUMA
node are different objects. In my understanding, vm level NUMA node is just
a simulation of host level NUMA node, and host level NUMA node has more
features that not in vm NUMA (like several levels of host NUMA topology
mentioned by Vinod). We need to consider the extensions of host NUMA in the
future.
I agree with Bruce, we have no problem with more tables and constrains should work as
expected and remove entries when a Host or VM is removed.
I do not like tables that have 2 UUIDs when one of them is null , this is against simple
DB normalization
2) No templates reference in the design, need to check it out (it might be
inherently designed already :-) ); vNode can be linked to a template.
[Bruce] IMO, we can consider template as a special vm, our current design
supports to create vNodes in a template just like what it does in a vm.
We also store today templates in the VM* tables as special entities defined by the
entity_type column
3) The reason I want host's NUMA data to be in static is because it updates
only once (on boot). "engineerically" speaking, dynamic table has a lot of
traffic and that's not the case for NUMA info. Its feels to me like 'a
hybrid' of static and dynamic, 3 suggestions comes to mind:
- leave it in dynamic (maybe in a separate process).
- have a separate flow that updates static.
- come up with a third 'vds_on_boot' table (my favorite ;-P ).
I will get back to you on that.
[Bruce] From the onTimer codes in vdsManager (IMO it's the scheduled vds
refresh action), when vds is in normal running status (up status), only
statistics data will be refreshed, so I think maybe dynamic table doesn't
have so much traffic, and the varied data (I mean the data varied through a
power reload, like cpu topology, numa topology, ...etc) can be refreshed
meanwhile.
4) vm_vds_numa_node_map is connected to vds_numa_node_statistics, why to
split the tables (vds_numa_node & vds_numa_node_statistics), going back to
comment #1, don't we want vNode stats as well, it can be nice to show it :-)
(have a vNUMA overview of the VM using guest-agent or sth, in a future
phase).
[Bruce] Split the tables is referring to vds_interface
(vds_interface_statistics) and vm_interface (vm_interface_statistics), the
statistics table will be refreshed with a high frequency.
I will update the design to add the vNuma statistics for the future phase,
and according to my feedback in comment #1, vNuma statistics will also in an
independent table since I think there will be more statistics fields for
host NUMA than for vNuma.
Agree with Bruce
5) IMO vds_cpu_statistics shouldn't include any reference to NUMA, I gave
that comment in the BE patch as well (remove vds_numa_node_id FK in
vds_cpu_statistics), for that you should extract cpu_list to a connection
table (anyway I don't like lists as a text/strings/etc.)
[Bruce] Yes, I agree with you to remove the reference between
vds_cpu_statistics and NUMA. Actually cpu_list is enough for current
requirements. I think the connection table is needed when we consider to
collect more cpu related information and do more cpu related actions in the
future.
6) vm_numatune_nodeset can be removed - the vNode should hold it's pinning
info; I think that vNode (node according to comment #1) should be connected
to a connection table that points to vdsNode (also Node table) itself (kinda
complicated but does the trick - nested link).
[Bruce] Yes, I will remove vm_numatune_nodeset, but according to my feedback
in comment #1, vm_vds_numa_node_map table will be retained to hold the
references between host nodes and vNode, since they are "m:n" relations.
7) Please add delete-cascade info all over, i.e. what happens when we remove
a host/vm/node.
[Bruce] Yes, I will update the design.
8) Is it possible to put a db constraint that mapping between vNode and Node
will be deleted once the VM isn't UP?
[Bruce] I have a question here. IMO, the mapping between vNode and Node is a
user configuration, why it is related with the vm status? If the mapping is
deleted, that means the user configuration is deleted. I don't think it's
reasonable.
Thanks,
Gilad.
----- Original Message -----
> From: "Eli Mesika" <emesika(a)redhat.com>
> To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <xiao-lei.shi(a)hp.com>
> Cc: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Roy Golan"
> <rgolan(a)redhat.com>, "Omer Frenkel" <ofrenkel(a)redhat.com>,
"Chegu
> Vinod" <chegu_vinod(a)hp.com>, "Chuan Liao (Jason Liao,
> HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>, "Doron Fediuck"
> <dfediuck(a)redhat.com>, "Shang-Chun Liang (David Liang,
> HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv Dary"
> <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> Sent: Tuesday, April 1, 2014 10:10:37 AM
> Subject: Re: Please help us to review our database schema design with
> NUMA feature on ovirt
>
>
>
> ----- Original Message -----
> > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > <xiao-lei.shi(a)hp.com>
> > To: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Roy
Golan"
> > <rgolan(a)redhat.com>, "Omer Frenkel"
<ofrenkel(a)redhat.com>, "Eli
> > Mesika" <emesika(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>
> > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>,
> > "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
> > <shangchun.liang(a)hp.com>, "Yaniv Dary"
<ydary(a)redhat.com>,
> > engine-devel(a)ovirt.org
> > Sent: Tuesday, April 1, 2014 5:13:34 AM
> > Subject: RE: Please help us to review our database schema design
> > with NUMA feature on ovirt
> >
> > Assemble the related discussions in this mail session.
> >
> > Hi Vinod,
> > On 3/31/2014 2:38 AM, Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ) wrote:
> > > We put host level NUMA fields in vds_dynamic because these
> > > information are from host itself, and NUMA topology may be changed
> > > if the host's hardware make a change.
> > Can you please elaborate ? Are you thinking about resource (cpu
> > and/or
> > memory) hot plug on the host ?
> > [Bruce] It's not about resource hot plug. In ovirt engine, there is
> > a scheduled task which will refresh hosts' and vms' information
> > periodically.
> > Only the dynamic and statistics data will be updated during the
> > refresh. So I think the resource information, such as cpu and/or
> > memory, should be in dynamic and statistics. And in my
> > understanding, the information in dynamic class is the changeable
> > information but with a low varying frequency, like cpu topology,
> > libvirt/kernel versions, etc. The information in statistics class is
> > the information with a high varying frequency, like the usage of
> > cpu/memory, etc. In my opinion, it's reasonable to put host level
> > NUMA information in vds_dynamic and host level NUMA statistics
> > information in vds_statistics.
> >
> > Hi Gilad/Roy/Omer,
> > I don't know if my understanding is correct. But according to this
> > guess, I think it's also reasonable to put vm cpuPin information in
> > vm_static.
> > Because cpuPin is user configured information, it will not vary
> > automatically. So we don’t need to refresh this information periodically.
> > Please correct me if there are any mistakes.
> >
> > Hi Eli,
> > Sorry for the nag. If my understanding above is correct, I think we
> > should still put host level NUMA fields in
> > vds_dynamic/vds_statistics and vm level NUMA fields in vm_static.
> > Since vm level NUMA fields are configured by user and they will not vary
> > automatically.
>
> Sorry, I had understood from Gilad that the NUMA fields in the host
> level are relatively static and the NUMA fields on the VM level are
> dynamic.
> I have no problem of having hybrid static/dynamic fields for Host/VM
> as long as it has a good reason and fully documented :-)
>
>
> >
> >
> > Thanks & Best Regards
> > Shi, Xiao-Lei (Bruce)
> >
> > Hewlett-Packard Co., Ltd.
> > HP Servers Core Platform Software China Telephone +86 23 65683093
> > Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> >
> >
> > -----Original Message-----
> > From: Gilad Chaplik [mailto:gchaplik@redhat.com]
> > Sent: Monday, March 31, 2014 9:31 PM
> > To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Roy Golan; Omer
> > Frenkel
> > Cc: Eli Mesika; Roy Golan; Liao, Chuan (Jason Liao,
> > HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang,
> > Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
> > engine-devel(a)ovirt.org
> > Subject: Re: Please help us to review our database schema design
> > with NUMA feature on ovirt
> >
> > adding Roy & Omer.
> >
> > why CPU topology is in dynamic?
> >
> > Thanks,
> > Gilad.
> >
> > ----- Original Message -----
> > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > <xiao-lei.shi(a)hp.com>
> > > To: "Eli Mesika" <emesika(a)redhat.com>
> > > Cc: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Roy
Golan"
> > > <rgolan(a)redhat.com>, "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)"
> > > <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>, "Chegu
> > > Vinod"
> > > <chegu_vinod(a)hp.com>, "Shang-Chun Liang (David Liang,
> > > HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv
Dary"
> > > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > > Sent: Monday, March 31, 2014 3:20:33 PM
> > > Subject: RE: Please help us to review our database schema design
> > > with NUMA feature on ovirt
> > >
> > > Thanks Eli.
> > > I will move the vm level NUMA fields to vm_dynamic, and the
> > > related database schema will be updated accordingly.
> > >
> > > Thanks & Best Regards
> > > Shi, Xiao-Lei (Bruce)
> > >
> > > Hewlett-Packard Co., Ltd.
> > > HP Servers Core Platform Software China Telephone +86 23 65683093
> > > Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > >
> > > -----Original Message-----
> > > From: Eli Mesika [mailto:emesika@redhat.com]
> > > Sent: Monday, March 31, 2014 5:49 PM
> > > To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > Cc: Gilad Chaplik; Roy Golan; Liao, Chuan (Jason Liao,
> > > HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang,
> > > Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
> > > engine-devel(a)ovirt.org
> > > Subject: Re: Please help us to review our database schema design
> > > with NUMA feature on ovirt
> > >
> > >
> > >
> > > ----- Original Message -----
> > > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > > <xiao-lei.shi(a)hp.com>
> > > > To: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Eli
Mesika"
> > > > <emesika(a)redhat.com>, "Roy Golan"
<rgolan(a)redhat.com>
> > > > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > > > <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>,
> > > > "Chegu Vinod"
> > > > <chegu_vinod(a)hp.com>, "Shang-Chun Liang (David Liang,
> > > > HPservers-Core-OE-PSC)"
> > > > <shangchun.liang(a)hp.com>, "Yaniv Dary"
<ydary(a)redhat.com>,
> > > > engine-devel(a)ovirt.org
> > > > Sent: Monday, March 31, 2014 12:38:04 PM
> > > > Subject: RE: Please help us to review our database schema design
> > > > with NUMA feature on ovirt
> > > >
> > > > We put host level NUMA fields in vds_dynamic because these
> > > > information are from host itself, and NUMA topology may be
> > > > changed if the host's hardware make a change. NUMA information
> > > > are similar to the host's cpu topology information like
> > > > cpu_cores and cpu_sockets which are in vds_dynamic, we refer to
this.
> > > > VM level NUMA fields are configured by user, and actually we
> > > > originally think they should be in vm_dynamic. But we found that
> > > > the field of another feature cpuPin which is similar as NUMA
> > > > feature is in vm_static, so we put vm NUMA fields in vm_static.
> > > > Do you think we need to put VM level NUMA fields in vm_dynamic?
> > >
> > > I think that in this case we should fix cpuPin to be in vm_dynamic
> > > and put after that the other NUMA fields in vm_dynamic as well
> > >
> > > >
> > > > Thanks & Best Regards
> > > > Shi, Xiao-Lei (Bruce)
> > > >
> > > > Hewlett-Packard Co., Ltd.
> > > > HP Servers Core Platform Software China Telephone +86 23
> > > > 65683093 Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > > >
> > > >
> > > > -----Original Message-----
> > > > From: Gilad Chaplik [mailto:gchaplik@redhat.com]
> > > > Sent: Monday, March 31, 2014 5:22 PM
> > > > To: Eli Mesika; Roy Golan
> > > > Cc: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Liao, Chuan (Jason
> > > > Liao, HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu;
> > > > Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv
> > > > Dary; engine-devel(a)ovirt.org
> > > > Subject: Re: Please help us to review our database schema design
> > > > with NUMA feature on ovirt
> > > >
> > > > +1
> > > >
> > > > IMO: vds data should reside in static VM need to think about it.
> > > >
> > > > Roy?
> > > >
> > > > Thanks,
> > > > Gilad.
> > > >
> > > >
> > > > ----- Original Message -----
> > > > > From: "Eli Mesika" <emesika(a)redhat.com>
> > > > > To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > > > <xiao-lei.shi(a)hp.com>
> > > > > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > > > > <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>,
> > > > > "Gilad Chaplik" <gchaplik(a)redhat.com>,
"Chegu Vinod"
> > > > > <chegu_vinod(a)hp.com>,
> > > > > "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)"
> > > > > <shangchun.liang(a)hp.com>, "Yaniv Dary"
> > > > > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > > > > Sent: Monday, March 31, 2014 12:12:50 PM
> > > > > Subject: Re: Please help us to review our database schema
> > > > > design with NUMA feature on ovirt
> > > > >
> > > > >
> > > > >
> > > > > ----- Original Message -----
> > > > > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > > > > <xiao-lei.shi(a)hp.com>
> > > > > > To: "Eli Mesika" <emesika(a)redhat.com>
> > > > > > Cc: "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)"
> > > > > > <chuan.liao(a)hp.com>,
> > > > > > "Doron Fediuck" <dfediuck(a)redhat.com>,
"Gilad Chaplik"
> > > > > > <gchaplik(a)redhat.com>, "Chegu Vinod"
> > > > > > <chegu_vinod(a)hp.com>,
> > > > > > "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)"
> > > > > > <shangchun.liang(a)hp.com>, "Yaniv Dary"
> > > > > > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > > > > > Sent: Monday, March 31, 2014 8:56:20 AM
> > > > > > Subject: RE: Please help us to review our database schema
> > > > > > design with NUMA feature on ovirt
> > > > > >
> > > > > > Include the devel group.
> > > > > > Thanks Eli for the quick responses for our first design
and
> > > > > > sorry for the nag.
> > > > > > We appreciate any of the comments for our database design
> > > > > > and will follow the design to do the implementation if no
> > > > > > more comments.
> > > > > >
> > > > > >
http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
> > > > >
> > > > > Seems OK for me except an unanswered question I had asked in
> > > > > my first review
> > > > > :
> > > > >
> > > > > Why in the Host level NUMA fields are added to vds_dynamic
> > > > > while in the VM level it is added to vm_static ???
> > > > > I would expect it to be in both on static or dynamic , can you
> > > > > please explain ? Thanks
> > > > >
> > > > > >
> > > > > > Thanks & Best Regards
> > > > > > Shi, Xiao-Lei (Bruce)
> > > > > >
> > > > > > Hewlett-Packard Co., Ltd.
> > > > > > HP Servers Core Platform Software China Telephone +86 23
> > > > > > 65683093 Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > > > > >
> > > > > > -----Original Message-----
> > > > > > From: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > > > > Sent: Friday, March 28, 2014 1:30 PM
> > > > > > To: 'Eli Mesika'
> > > > > > Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron
> > > > > > Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun
> > > > > > (David Liang, HPservers-Core-OE-PSC); Yaniv Dary
> > > > > > Subject: RE: Please help us to review our database schema
> > > > > > design with NUMA feature on ovirt
> > > > > >
> > > > > > Hi Eli,
> > > > > >
> > > > > > After the UX design meeting, we did some modification for
> > > > > > the database schema, and merged some update according to
> > > > > > your last review comments.
> > > > > > Now the document has been posted on ovirt wikipage, could
> > > > > > you help to review the database design again:
> > > > > >
http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
> > > > > >
> > > > > >
> > > > > > Thanks & Best Regards
> > > > > > Shi, Xiao-Lei (Bruce)
> > > > > >
> > > > > > Hewlett-Packard Co., Ltd.
> > > > > > HP Servers Core Platform Software China Telephone +86 23
> > > > > > 65683093 Mobile
> > > > > > +86
> > > > > > 18696583447 Email xiao-lei.shi(a)hp.com
> > > > > >
> > > > > >
> > > > > > -----Original Message-----
> > > > > > From: Eli Mesika [mailto:emesika@redhat.com]
> > > > > > Sent: Monday, March 24, 2014 6:24 PM
> > > > > > To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > > > > Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron
> > > > > > Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun
> > > > > > (David Liang, HPservers-Core-OE-PSC); Yaniv Dary
> > > > > > Subject: Re: Please help us to review our database schema
> > > > > > design with NUMA feature on ovirt
> > > > > >
> > > > > >
> > > > > >
> > > > > > ----- Original Message -----
> > > > > > > From: "Xiao-Lei Shi (Bruce, HP
Servers-PSC-CQ)"
> > > > > > > <xiao-lei.shi(a)hp.com>
> > > > > > > To: "Eli Mesika" <emesika(a)redhat.com>,
"Chuan Liao (Jason
> > > > > > > Liao, HPservers-Core-OE-PSC)"
<chuan.liao(a)hp.com>
> > > > > > > Cc: "Doron Fediuck"
<dfediuck(a)redhat.com>, "Gilad Chaplik"
> > > > > > > <gchaplik(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>,
> > > > > > > "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)"
> > > > > > > <shangchun.liang(a)hp.com>
> > > > > > > Sent: Monday, March 24, 2014 11:23:39 AM
> > > > > > > Subject: RE: Please help us to review our database
schema
> > > > > > > design with NUMA feature on ovirt
> > > > > > >
> > > > > > > Hi Eli,
> > > > > > >
> > > > > > > Thanks for your comments.
> > > > > > > I have updated the document according to your
comments
> > > > > > > except the below
> > > > > > > one:
> > > > > > > Missing from here are 2 issues:
> > > > > > >
> > > > > > > 1) Impact on the search engine, which new columns are
> > > > > > > search-able and which changes are planned in the
search
> > > > > > > engine code to enable that
> > > > > > >
> > > > > > > 2) Impact on engine-reports, are those changed planned
to
> > > > > > > be exposed to the engine data warehouse and required
> > > > > > > new/modified reports?
> > > > > > >
> > > > > > > Could you tell us more detailed information about the
> > > > > > > modules you mentioned above? I mean "search
engine" and
> > > > > > > "engine-reports". I think we missed these
two parts in our
> > > > > > > previous investigation.
> > > > > > > I just find org.ovirt.engine.core.bll.SearchQuery, is
that
> > > > > > > the right object for search engine?
> > > > > >
> > > > > > Yes, actually when you are opening the admin UI, there are
> > > > > > TABs for each entity , i.e. Data Center, Cluster, Host
etc.
> > > > > > In each, you can see a text-box in which you can search
for
> > > > > > by writing a search expression My question is
> > > > > > 1) What is the impact of your work on the search on the
Fost
> > > > > > and
> > > > > > VM
> > > > > > TABs
> > > > > > a) Are there any fields that are supported now in
the
> > > > > > search
> > > > > > expression
> > > > > > and should pop-up when you write the expression by
the
> > > > > > auto-completion
> > > > > > mechanism ?
> > > > > > b) Are there any added columns displayed in the
result of
> > > > > > such
> > > > > > a
> > > > > > search
> > > > > > in the grid ?
> > > > > >
> > > > > > > How about the engine-reports, could you give us some
> > > > > > > hints, like the code location and any more detailed
> > > > > > > information that we can start more investigation?
> > > > > >
> > > > > > CCing Yaniv D who is in charge of the reports/dwh module
> > > > > > Yaniv, any planned work for adding Numa features to
Host/VM
> > > > > > in the reports side ?
> > > > > >
> > > > > > Thanks
> > > > > >
> > > > > > >
> > > > > > > Thanks & Best Regards
> > > > > > > Shi, Xiao-Lei (Bruce)
> > > > > > >
> > > > > > > Hewlett-Packard Co., Ltd.
> > > > > > > HP Servers Core Platform Software China Telephone +86
23
> > > > > > > 65683093 Mobile +86 18696583447 Email
xiao-lei.shi(a)hp.com
> > > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: Eli Mesika [mailto:emesika@redhat.com]
> > > > > > > Sent: Sunday, March 23, 2014 4:44 PM
> > > > > > > To: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
> > > > > > > Cc: Doron Fediuck; Gilad Chaplik; Vinod, Chegu;
Liang,
> > > > > > > Shang-Chun (David Liang, HPservers-Core-OE-PSC); Shi,
> > > > > > > Xiao-Lei (Bruce, HP
> > > > > > > Servers-PSC-CQ)
> > > > > > > Subject: Re: Please help us to review our database
schema
> > > > > > > design with NUMA feature on ovirt
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > ----- Original Message -----
> > > > > > > > From: "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)"
> > > > > > > > <chuan.liao(a)hp.com>
> > > > > > > > To: emesika(a)redhat.com
> > > > > > > > Cc: "Doron Fediuck"
<dfediuck(a)redhat.com>, "Gilad Chaplik"
> > > > > > > > <gchaplik(a)redhat.com>, "Chegu
Vinod"
> > > > > > > > <chegu_vinod(a)hp.com>, "Shang-Chun
Liang (David Liang,
> > > > > > > > HPservers-Core-OE-PSC)"
> > > > > > > > <shangchun.liang(a)hp.com>, "Xiao-Lei
Shi (Bruce, HP
> > > > > > > > Servers-PSC-CQ)"
> > > > > > > > <xiao-lei.shi(a)hp.com>
> > > > > > > > Sent: Friday, March 21, 2014 10:42:33 AM
> > > > > > > > Subject: Please help us to review our database
schema
> > > > > > > > design with NUMA feature on ovirt
> > > > > > > >
> > > > > > > > Hi Eli,
> > > > > > > >
> > > > > > > > Please help us to review our database schema
design with
> > > > > > > > NUMA feature on ovirt
> > > > > > > >
https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcm
> > > > > > > > bGWA
> > > > > > > > cyQo_IST
> > > > > > > > Y8
> > > > > > > > ykDr0I6VY/edit?usp=sharing
> > > > > > > >
> > > > > > > > Feel free to take comments on document at
anywhere
> > > > > > >
> > > > > > > Done, had commented on the document.
> > > > > > > Eli
> > > > > > >
> > > > > > > >
> > > > > > > > Especially, 5.4 The used interface between engine
core
> > > > > > > > and
> > > > > > > > database(schema)
> > > > > > > >
> > > > > > > > Your approve and your comments with this section
will be
> > > > > > > > much more appreciate for us.
> > > > > > > >
> > > > > > > > Best Regards,
> > > > > > > > Jason Liao
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
5:46 a.m.
New subject: [Engine-devel] Please help us to review our database schema design with NUMA feature on ovirt
----- Original Message -----
From: "Eli Mesika" <emesika(a)redhat.com>
To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <xiao-lei.shi(a)hp.com>
Cc: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Roy Golan"
<rgolan(a)redhat.com>, "Omer Frenkel" <ofrenkel(a)redhat.com>,
"Chegu Vinod" <chegu_vinod(a)hp.com>, "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>, "Doron
Fediuck" <dfediuck(a)redhat.com>, "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>,
"Yaniv Dary" <ydary(a)redhat.com>, engine-devel(a)ovirt.org
Sent: Thursday, April 3, 2014 10:54:54 AM
Subject: Re: Please help us to review our database schema design with NUMA feature on
ovirt
----- Original Message -----
> From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> To: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Eli Mesika"
> <emesika(a)redhat.com>
> Cc: "Roy Golan" <rgolan(a)redhat.com>, "Omer Frenkel"
<ofrenkel(a)redhat.com>,
> "Chegu Vinod" <chegu_vinod(a)hp.com>, "Chuan
> Liao (Jason Liao, HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>,
"Doron
> Fediuck" <dfediuck(a)redhat.com>, "Shang-Chun
> Liang (David Liang, HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>,
> "Yaniv Dary" <ydary(a)redhat.com>,
> engine-devel(a)ovirt.org
> Sent: Thursday, April 3, 2014 7:25:11 AM
> Subject: RE: Please help us to review our database schema design with NUMA
> feature on ovirt
>
> Hi all,
> Please see my comments in line.
>
> Thanks & Best Regards
> Shi, Xiao-Lei (Bruce)
>
> Hewlett-Packard Co., Ltd.
> HP Servers Core Platform Software China
> Telephone +86 23 65683093
> Mobile +86 18696583447
> Email xiao-lei.shi(a)hp.com
>
> -----Original Message-----
> From: Gilad Chaplik [mailto:gchaplik@redhat.com]
> Sent: Thursday, April 03, 2014 9:05 AM
> To: Eli Mesika
> Cc: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Roy Golan; Omer Frenkel;
> Vinod,
> Chegu; Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck;
> Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
> engine-devel(a)ovirt.org
> Subject: Re: Please help us to review our database schema design with NUMA
> feature on ovirt
>
> Hi all,
> Sorry for joining-in late.
>
> My comments (according to the db diagram section in
> https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcmbGWAcyQo_ISTY8ykD...):
> 1) Join vm_numa_node and vds_numa_node to a single table (almost
> identical),
> one of the FKs can be null.
> [Bruce] I prefer two tables. Actually host level NUMA node and vm level
> NUMA
> node are different objects. In my understanding, vm level NUMA node is just
> a simulation of host level NUMA node, and host level NUMA node has more
> features that not in vm NUMA (like several levels of host NUMA topology
> mentioned by Vinod). We need to consider the extensions of host NUMA in the
> future.
Let's open the discussion and consider them right now. vNode and Node are the same.
Vinod?
I agree with Bruce, we have no problem with more tables and constrains should
work as expected and remove entries when a Host or VM is removed.
I do not like tables that have 2 UUIDs when one of them is null , this is
against simple DB normalization
We are going to maintain and develop this feature. there is a huge overhead in 6 table
design in compare to 4.
>
> 2) No templates reference in the design, need to check it out (it might be
> inherently designed already :-) ); vNode can be linked to a template.
> [Bruce] IMO, we can consider template as a special vm, our current design
> supports to create vNodes in a template just like what it does in a vm.
We also store today templates in the VM* tables as special entities defined
by the entity_type column
+1, just need to see that this is taken care of.
>
> 3) The reason I want host's NUMA data to be in static is because it updates
> only once (on boot). "engineerically" speaking, dynamic table has a lot
of
> traffic and that's not the case for NUMA info. Its feels to me like 'a
> hybrid' of static and dynamic, 3 suggestions comes to mind:
> - leave it in dynamic (maybe in a separate process).
> - have a separate flow that updates static.
> - come up with a third 'vds_on_boot' table (my favorite ;-P ).
> I will get back to you on that.
> [Bruce] From the onTimer codes in vdsManager (IMO it's the scheduled vds
> refresh action), when vds is in normal running status (up status), only
> statistics data will be refreshed, so I think maybe dynamic table doesn't
> have so much traffic, and the varied data (I mean the data varied through a
> power reload, like cpu topology, numa topology, ...etc) can be refreshed
> meanwhile.
>
I beg to differ, dynamic table contains a lot of dynamic data:
host status, used memory and pending resources (maybe more).
still need to think about it, and get back to you.
> 4) vm_vds_numa_node_map is connected to
vds_numa_node_statistics, why to
> split the tables (vds_numa_node & vds_numa_node_statistics), going back to
> comment #1, don't we want vNode stats as well, it can be nice to show it
> :-)
> (have a vNUMA overview of the VM using guest-agent or sth, in a future
> phase).
> [Bruce] Split the tables is referring to vds_interface
> (vds_interface_statistics) and vm_interface (vm_interface_statistics), the
> statistics table will be refreshed with a high frequency.
> I will update the design to add the vNuma statistics for the future phase,
> and according to my feedback in comment #1, vNuma statistics will also in
> an
> independent table since I think there will be more statistics fields for
> host NUMA than for vNuma.
Agree with Bruce
I disagree with both:
a) don't compare interface to NUMA; interface is a key element in the system.
b) if you care about high frequency, you can separate the update flows to the same table.
c) see my comment about 1, overhead.
d) vNuma = Numa, as I said we can open it now for discussion.
>
> 5) IMO vds_cpu_statistics shouldn't include any reference to NUMA, I gave
> that comment in the BE patch as well (remove vds_numa_node_id FK in
> vds_cpu_statistics), for that you should extract cpu_list to a connection
> table (anyway I don't like lists as a text/strings/etc.)
> [Bruce] Yes, I agree with you to remove the reference between
> vds_cpu_statistics and NUMA. Actually cpu_list is enough for current
> requirements. I think the connection table is needed when we consider to
> collect more cpu related information and do more cpu related actions in the
> future.
fine, can be done in a later phase. Please document with a bug/RFE enhancement and mark
infra in whiteboard.
>
> 6) vm_numatune_nodeset can be removed - the vNode should hold it's pinning
> info; I think that vNode (node according to comment #1) should be connected
> to a connection table that points to vdsNode (also Node table) itself
> (kinda
> complicated but does the trick - nested link).
> [Bruce] Yes, I will remove vm_numatune_nodeset, but according to my
> feedback
> in comment #1, vm_vds_numa_node_map table will be retained to hold the
> references between host nodes and vNode, since they are "m:n" relations.
repeating my later comment:
correction: no need for another connection table, use vm_vds_numa_node_map with a flag
(is_pinned)
>
> 7) Please add delete-cascade info all over, i.e. what happens when we
> remove
> a host/vm/node.
> [Bruce] Yes, I will update the design.
:-) thanks!
>
> 8) Is it possible to put a db constraint that mapping between vNode and
> Node
> will be deleted once the VM isn't UP?
> [Bruce] I have a question here. IMO, the mapping between vNode and Node is
> a
> user configuration, why it is related with the vm status? If the mapping is
> deleted, that means the user configuration is deleted. I don't think it's
> reasonable.
see comment #6 (including the correction). there is actual real-life NUMA mapping
retrieved by the host, and there is pinning info.
when a VM is down, the actual real-life mapping can be removed.
>
> Thanks,
> Gilad.
>
> ----- Original Message -----
> > From: "Eli Mesika" <emesika(a)redhat.com>
> > To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> > Cc: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Roy
Golan"
> > <rgolan(a)redhat.com>, "Omer Frenkel"
<ofrenkel(a)redhat.com>, "Chegu
> > Vinod" <chegu_vinod(a)hp.com>, "Chuan Liao (Jason Liao,
> > HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>, "Doron
Fediuck"
> > <dfediuck(a)redhat.com>, "Shang-Chun Liang (David Liang,
> > HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv
Dary"
> > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > Sent: Tuesday, April 1, 2014 10:10:37 AM
> > Subject: Re: Please help us to review our database schema design with
> > NUMA feature on ovirt
> >
> >
> >
> > ----- Original Message -----
> > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > <xiao-lei.shi(a)hp.com>
> > > To: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Roy
Golan"
> > > <rgolan(a)redhat.com>, "Omer Frenkel"
<ofrenkel(a)redhat.com>, "Eli
> > > Mesika" <emesika(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>
> > > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > > <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>,
> > > "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
> > > <shangchun.liang(a)hp.com>, "Yaniv Dary"
<ydary(a)redhat.com>,
> > > engine-devel(a)ovirt.org
> > > Sent: Tuesday, April 1, 2014 5:13:34 AM
> > > Subject: RE: Please help us to review our database schema design
> > > with NUMA feature on ovirt
> > >
> > > Assemble the related discussions in this mail session.
> > >
> > > Hi Vinod,
> > > On 3/31/2014 2:38 AM, Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ) wrote:
> > > > We put host level NUMA fields in vds_dynamic because these
> > > > information are from host itself, and NUMA topology may be changed
> > > > if the host's hardware make a change.
> > > Can you please elaborate ? Are you thinking about resource (cpu
> > > and/or
> > > memory) hot plug on the host ?
> > > [Bruce] It's not about resource hot plug. In ovirt engine, there is
> > > a scheduled task which will refresh hosts' and vms' information
> > > periodically.
> > > Only the dynamic and statistics data will be updated during the
> > > refresh. So I think the resource information, such as cpu and/or
> > > memory, should be in dynamic and statistics. And in my
> > > understanding, the information in dynamic class is the changeable
> > > information but with a low varying frequency, like cpu topology,
> > > libvirt/kernel versions, etc. The information in statistics class is
> > > the information with a high varying frequency, like the usage of
> > > cpu/memory, etc. In my opinion, it's reasonable to put host level
> > > NUMA information in vds_dynamic and host level NUMA statistics
> > > information in vds_statistics.
> > >
> > > Hi Gilad/Roy/Omer,
> > > I don't know if my understanding is correct. But according to this
> > > guess, I think it's also reasonable to put vm cpuPin information in
> > > vm_static.
> > > Because cpuPin is user configured information, it will not vary
> > > automatically. So we don’t need to refresh this information
> > > periodically.
> > > Please correct me if there are any mistakes.
> > >
> > > Hi Eli,
> > > Sorry for the nag. If my understanding above is correct, I think we
> > > should still put host level NUMA fields in
> > > vds_dynamic/vds_statistics and vm level NUMA fields in vm_static.
> > > Since vm level NUMA fields are configured by user and they will not
> > > vary
> > > automatically.
> >
> > Sorry, I had understood from Gilad that the NUMA fields in the host
> > level are relatively static and the NUMA fields on the VM level are
> > dynamic.
> > I have no problem of having hybrid static/dynamic fields for Host/VM
> > as long as it has a good reason and fully documented :-)
> >
> >
> > >
> > >
> > > Thanks & Best Regards
> > > Shi, Xiao-Lei (Bruce)
> > >
> > > Hewlett-Packard Co., Ltd.
> > > HP Servers Core Platform Software China Telephone +86 23 65683093
> > > Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > >
> > >
> > > -----Original Message-----
> > > From: Gilad Chaplik [mailto:gchaplik@redhat.com]
> > > Sent: Monday, March 31, 2014 9:31 PM
> > > To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Roy Golan; Omer
> > > Frenkel
> > > Cc: Eli Mesika; Roy Golan; Liao, Chuan (Jason Liao,
> > > HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang,
> > > Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
> > > engine-devel(a)ovirt.org
> > > Subject: Re: Please help us to review our database schema design
> > > with NUMA feature on ovirt
> > >
> > > adding Roy & Omer.
> > >
> > > why CPU topology is in dynamic?
> > >
> > > Thanks,
> > > Gilad.
> > >
> > > ----- Original Message -----
> > > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > > <xiao-lei.shi(a)hp.com>
> > > > To: "Eli Mesika" <emesika(a)redhat.com>
> > > > Cc: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Roy
Golan"
> > > > <rgolan(a)redhat.com>, "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)"
> > > > <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>, "Chegu
> > > > Vinod"
> > > > <chegu_vinod(a)hp.com>, "Shang-Chun Liang (David Liang,
> > > > HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>,
"Yaniv Dary"
> > > > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > > > Sent: Monday, March 31, 2014 3:20:33 PM
> > > > Subject: RE: Please help us to review our database schema design
> > > > with NUMA feature on ovirt
> > > >
> > > > Thanks Eli.
> > > > I will move the vm level NUMA fields to vm_dynamic, and the
> > > > related database schema will be updated accordingly.
> > > >
> > > > Thanks & Best Regards
> > > > Shi, Xiao-Lei (Bruce)
> > > >
> > > > Hewlett-Packard Co., Ltd.
> > > > HP Servers Core Platform Software China Telephone +86 23 65683093
> > > > Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > > >
> > > > -----Original Message-----
> > > > From: Eli Mesika [mailto:emesika@redhat.com]
> > > > Sent: Monday, March 31, 2014 5:49 PM
> > > > To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > > Cc: Gilad Chaplik; Roy Golan; Liao, Chuan (Jason Liao,
> > > > HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang,
> > > > Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
> > > > engine-devel(a)ovirt.org
> > > > Subject: Re: Please help us to review our database schema design
> > > > with NUMA feature on ovirt
> > > >
> > > >
> > > >
> > > > ----- Original Message -----
> > > > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > > > <xiao-lei.shi(a)hp.com>
> > > > > To: "Gilad Chaplik" <gchaplik(a)redhat.com>,
"Eli Mesika"
> > > > > <emesika(a)redhat.com>, "Roy Golan"
<rgolan(a)redhat.com>
> > > > > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > > > > <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>,
> > > > > "Chegu Vinod"
> > > > > <chegu_vinod(a)hp.com>, "Shang-Chun Liang (David
Liang,
> > > > > HPservers-Core-OE-PSC)"
> > > > > <shangchun.liang(a)hp.com>, "Yaniv Dary"
<ydary(a)redhat.com>,
> > > > > engine-devel(a)ovirt.org
> > > > > Sent: Monday, March 31, 2014 12:38:04 PM
> > > > > Subject: RE: Please help us to review our database schema
design
> > > > > with NUMA feature on ovirt
> > > > >
> > > > > We put host level NUMA fields in vds_dynamic because these
> > > > > information are from host itself, and NUMA topology may be
> > > > > changed if the host's hardware make a change. NUMA
information
> > > > > are similar to the host's cpu topology information like
> > > > > cpu_cores and cpu_sockets which are in vds_dynamic, we refer to
> > > > > this.
> > > > > VM level NUMA fields are configured by user, and actually we
> > > > > originally think they should be in vm_dynamic. But we found
that
> > > > > the field of another feature cpuPin which is similar as NUMA
> > > > > feature is in vm_static, so we put vm NUMA fields in vm_static.
> > > > > Do you think we need to put VM level NUMA fields in vm_dynamic?
> > > >
> > > > I think that in this case we should fix cpuPin to be in vm_dynamic
> > > > and put after that the other NUMA fields in vm_dynamic as well
> > > >
> > > > >
> > > > > Thanks & Best Regards
> > > > > Shi, Xiao-Lei (Bruce)
> > > > >
> > > > > Hewlett-Packard Co., Ltd.
> > > > > HP Servers Core Platform Software China Telephone +86 23
> > > > > 65683093 Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > > > >
> > > > >
> > > > > -----Original Message-----
> > > > > From: Gilad Chaplik [mailto:gchaplik@redhat.com]
> > > > > Sent: Monday, March 31, 2014 5:22 PM
> > > > > To: Eli Mesika; Roy Golan
> > > > > Cc: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Liao, Chuan
(Jason
> > > > > Liao, HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu;
> > > > > Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv
> > > > > Dary; engine-devel(a)ovirt.org
> > > > > Subject: Re: Please help us to review our database schema
design
> > > > > with NUMA feature on ovirt
> > > > >
> > > > > +1
> > > > >
> > > > > IMO: vds data should reside in static VM need to think about
it.
> > > > >
> > > > > Roy?
> > > > >
> > > > > Thanks,
> > > > > Gilad.
> > > > >
> > > > >
> > > > > ----- Original Message -----
> > > > > > From: "Eli Mesika" <emesika(a)redhat.com>
> > > > > > To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > > > > <xiao-lei.shi(a)hp.com>
> > > > > > Cc: "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)"
> > > > > > <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>,
> > > > > > "Gilad Chaplik" <gchaplik(a)redhat.com>,
"Chegu Vinod"
> > > > > > <chegu_vinod(a)hp.com>,
> > > > > > "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)"
> > > > > > <shangchun.liang(a)hp.com>, "Yaniv Dary"
> > > > > > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > > > > > Sent: Monday, March 31, 2014 12:12:50 PM
> > > > > > Subject: Re: Please help us to review our database schema
> > > > > > design with NUMA feature on ovirt
> > > > > >
> > > > > >
> > > > > >
> > > > > > ----- Original Message -----
> > > > > > > From: "Xiao-Lei Shi (Bruce, HP
Servers-PSC-CQ)"
> > > > > > > <xiao-lei.shi(a)hp.com>
> > > > > > > To: "Eli Mesika" <emesika(a)redhat.com>
> > > > > > > Cc: "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)"
> > > > > > > <chuan.liao(a)hp.com>,
> > > > > > > "Doron Fediuck" <dfediuck(a)redhat.com>,
"Gilad Chaplik"
> > > > > > > <gchaplik(a)redhat.com>, "Chegu Vinod"
> > > > > > > <chegu_vinod(a)hp.com>,
> > > > > > > "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)"
> > > > > > > <shangchun.liang(a)hp.com>, "Yaniv
Dary"
> > > > > > > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > > > > > > Sent: Monday, March 31, 2014 8:56:20 AM
> > > > > > > Subject: RE: Please help us to review our database
schema
> > > > > > > design with NUMA feature on ovirt
> > > > > > >
> > > > > > > Include the devel group.
> > > > > > > Thanks Eli for the quick responses for our first
design and
> > > > > > > sorry for the nag.
> > > > > > > We appreciate any of the comments for our database
design
> > > > > > > and will follow the design to do the implementation if
no
> > > > > > > more comments.
> > > > > > >
> > > > > > >
http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
> > > > > >
> > > > > > Seems OK for me except an unanswered question I had asked
in
> > > > > > my first review
> > > > > > :
> > > > > >
> > > > > > Why in the Host level NUMA fields are added to vds_dynamic
> > > > > > while in the VM level it is added to vm_static ???
> > > > > > I would expect it to be in both on static or dynamic , can
you
> > > > > > please explain ? Thanks
> > > > > >
> > > > > > >
> > > > > > > Thanks & Best Regards
> > > > > > > Shi, Xiao-Lei (Bruce)
> > > > > > >
> > > > > > > Hewlett-Packard Co., Ltd.
> > > > > > > HP Servers Core Platform Software China Telephone +86
23
> > > > > > > 65683093 Mobile +86 18696583447 Email
xiao-lei.shi(a)hp.com
> > > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > > > > > Sent: Friday, March 28, 2014 1:30 PM
> > > > > > > To: 'Eli Mesika'
> > > > > > > Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC);
Doron
> > > > > > > Fediuck; Gilad Chaplik; Vinod, Chegu; Liang,
Shang-Chun
> > > > > > > (David Liang, HPservers-Core-OE-PSC); Yaniv Dary
> > > > > > > Subject: RE: Please help us to review our database
schema
> > > > > > > design with NUMA feature on ovirt
> > > > > > >
> > > > > > > Hi Eli,
> > > > > > >
> > > > > > > After the UX design meeting, we did some modification
for
> > > > > > > the database schema, and merged some update according
to
> > > > > > > your last review comments.
> > > > > > > Now the document has been posted on ovirt wikipage,
could
> > > > > > > you help to review the database design again:
> > > > > > >
http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
> > > > > > >
> > > > > > >
> > > > > > > Thanks & Best Regards
> > > > > > > Shi, Xiao-Lei (Bruce)
> > > > > > >
> > > > > > > Hewlett-Packard Co., Ltd.
> > > > > > > HP Servers Core Platform Software China Telephone +86
23
> > > > > > > 65683093 Mobile
> > > > > > > +86
> > > > > > > 18696583447 Email xiao-lei.shi(a)hp.com
> > > > > > >
> > > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: Eli Mesika [mailto:emesika@redhat.com]
> > > > > > > Sent: Monday, March 24, 2014 6:24 PM
> > > > > > > To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > > > > > Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC);
Doron
> > > > > > > Fediuck; Gilad Chaplik; Vinod, Chegu; Liang,
Shang-Chun
> > > > > > > (David Liang, HPservers-Core-OE-PSC); Yaniv Dary
> > > > > > > Subject: Re: Please help us to review our database
schema
> > > > > > > design with NUMA feature on ovirt
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > ----- Original Message -----
> > > > > > > > From: "Xiao-Lei Shi (Bruce, HP
Servers-PSC-CQ)"
> > > > > > > > <xiao-lei.shi(a)hp.com>
> > > > > > > > To: "Eli Mesika"
<emesika(a)redhat.com>, "Chuan Liao (Jason
> > > > > > > > Liao, HPservers-Core-OE-PSC)"
<chuan.liao(a)hp.com>
> > > > > > > > Cc: "Doron Fediuck"
<dfediuck(a)redhat.com>, "Gilad Chaplik"
> > > > > > > > <gchaplik(a)redhat.com>, "Chegu
Vinod" <chegu_vinod(a)hp.com>,
> > > > > > > > "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)"
> > > > > > > > <shangchun.liang(a)hp.com>
> > > > > > > > Sent: Monday, March 24, 2014 11:23:39 AM
> > > > > > > > Subject: RE: Please help us to review our
database schema
> > > > > > > > design with NUMA feature on ovirt
> > > > > > > >
> > > > > > > > Hi Eli,
> > > > > > > >
> > > > > > > > Thanks for your comments.
> > > > > > > > I have updated the document according to your
comments
> > > > > > > > except the below
> > > > > > > > one:
> > > > > > > > Missing from here are 2 issues:
> > > > > > > >
> > > > > > > > 1) Impact on the search engine, which new columns
are
> > > > > > > > search-able and which changes are planned in the
search
> > > > > > > > engine code to enable that
> > > > > > > >
> > > > > > > > 2) Impact on engine-reports, are those changed
planned to
> > > > > > > > be exposed to the engine data warehouse and
required
> > > > > > > > new/modified reports?
> > > > > > > >
> > > > > > > > Could you tell us more detailed information about
the
> > > > > > > > modules you mentioned above? I mean "search
engine" and
> > > > > > > > "engine-reports". I think we missed
these two parts in our
> > > > > > > > previous investigation.
> > > > > > > > I just find
org.ovirt.engine.core.bll.SearchQuery, is that
> > > > > > > > the right object for search engine?
> > > > > > >
> > > > > > > Yes, actually when you are opening the admin UI, there
are
> > > > > > > TABs for each entity , i.e. Data Center, Cluster, Host
etc.
> > > > > > > In each, you can see a text-box in which you can
search for
> > > > > > > by writing a search expression My question is
> > > > > > > 1) What is the impact of your work on the search on
the Fost
> > > > > > > and
> > > > > > > VM
> > > > > > > TABs
> > > > > > > a) Are there any fields that are supported now
in the
> > > > > > > search
> > > > > > > expression
> > > > > > > and should pop-up when you write the expression
by the
> > > > > > > auto-completion
> > > > > > > mechanism ?
> > > > > > > b) Are there any added columns displayed in the
result of
> > > > > > > such
> > > > > > > a
> > > > > > > search
> > > > > > > in the grid ?
> > > > > > >
> > > > > > > > How about the engine-reports, could you give us
some
> > > > > > > > hints, like the code location and any more
detailed
> > > > > > > > information that we can start more
investigation?
> > > > > > >
> > > > > > > CCing Yaniv D who is in charge of the reports/dwh
module
> > > > > > > Yaniv, any planned work for adding Numa features to
Host/VM
> > > > > > > in the reports side ?
> > > > > > >
> > > > > > > Thanks
> > > > > > >
> > > > > > > >
> > > > > > > > Thanks & Best Regards
> > > > > > > > Shi, Xiao-Lei (Bruce)
> > > > > > > >
> > > > > > > > Hewlett-Packard Co., Ltd.
> > > > > > > > HP Servers Core Platform Software China Telephone
+86 23
> > > > > > > > 65683093 Mobile +86 18696583447 Email
xiao-lei.shi(a)hp.com
> > > > > > > >
> > > > > > > > -----Original Message-----
> > > > > > > > From: Eli Mesika [mailto:emesika@redhat.com]
> > > > > > > > Sent: Sunday, March 23, 2014 4:44 PM
> > > > > > > > To: Liao, Chuan (Jason Liao,
HPservers-Core-OE-PSC)
> > > > > > > > Cc: Doron Fediuck; Gilad Chaplik; Vinod, Chegu;
Liang,
> > > > > > > > Shang-Chun (David Liang, HPservers-Core-OE-PSC);
Shi,
> > > > > > > > Xiao-Lei (Bruce, HP
> > > > > > > > Servers-PSC-CQ)
> > > > > > > > Subject: Re: Please help us to review our
database schema
> > > > > > > > design with NUMA feature on ovirt
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > ----- Original Message -----
> > > > > > > > > From: "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)"
> > > > > > > > > <chuan.liao(a)hp.com>
> > > > > > > > > To: emesika(a)redhat.com
> > > > > > > > > Cc: "Doron Fediuck"
<dfediuck(a)redhat.com>, "Gilad Chaplik"
> > > > > > > > > <gchaplik(a)redhat.com>, "Chegu
Vinod"
> > > > > > > > > <chegu_vinod(a)hp.com>, "Shang-Chun
Liang (David Liang,
> > > > > > > > > HPservers-Core-OE-PSC)"
> > > > > > > > > <shangchun.liang(a)hp.com>,
"Xiao-Lei Shi (Bruce, HP
> > > > > > > > > Servers-PSC-CQ)"
> > > > > > > > > <xiao-lei.shi(a)hp.com>
> > > > > > > > > Sent: Friday, March 21, 2014 10:42:33 AM
> > > > > > > > > Subject: Please help us to review our
database schema
> > > > > > > > > design with NUMA feature on ovirt
> > > > > > > > >
> > > > > > > > > Hi Eli,
> > > > > > > > >
> > > > > > > > > Please help us to review our database schema
design with
> > > > > > > > > NUMA feature on ovirt
> > > > > > > > >
https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcm
> > > > > > > > > bGWA
> > > > > > > > > cyQo_IST
> > > > > > > > > Y8
> > > > > > > > > ykDr0I6VY/edit?usp=sharing
> > > > > > > > >
> > > > > > > > > Feel free to take comments on document at
anywhere
> > > > > > > >
> > > > > > > > Done, had commented on the document.
> > > > > > > > Eli
> > > > > > > >
> > > > > > > > >
> > > > > > > > > Especially, 5.4 The used interface between
engine core
> > > > > > > > > and
> > > > > > > > > database(schema)
> > > > > > > > >
> > > > > > > > > Your approve and your comments with this
section will be
> > > > > > > > > much more appreciate for us.
> > > > > > > > >
> > > > > > > > > Best Regards,
> > > > > > > > > Jason Liao
> > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
8:03 a.m.
New subject: [Engine-devel] Please help us to review our database schema design with NUMA feature on ovirt
----- Original Message -----
From: "Gilad Chaplik" <gchaplik(a)redhat.com>
To: "Eli Mesika" <emesika(a)redhat.com>
Cc: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <xiao-lei.shi(a)hp.com>,
"Roy Golan" <rgolan(a)redhat.com>, "Omer Frenkel"
<ofrenkel(a)redhat.com>, "Chegu Vinod" <chegu_vinod(a)hp.com>,
"Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
<chuan.liao(a)hp.com>, "Doron Fediuck" <dfediuck(a)redhat.com>,
"Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
<shangchun.liang(a)hp.com>, "Yaniv Dary" <ydary(a)redhat.com>,
engine-devel(a)ovirt.org
Sent: Thursday, April 3, 2014 1:46:32 PM
Subject: Re: Please help us to review our database schema design with NUMA feature on
ovirt
----- Original Message -----
> From: "Eli Mesika" <emesika(a)redhat.com>
> To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <xiao-lei.shi(a)hp.com>
> Cc: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Roy Golan"
<rgolan(a)redhat.com>,
> "Omer Frenkel" <ofrenkel(a)redhat.com>,
> "Chegu Vinod" <chegu_vinod(a)hp.com>, "Chuan Liao (Jason Liao,
> HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>, "Doron
> Fediuck" <dfediuck(a)redhat.com>, "Shang-Chun Liang (David Liang,
> HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>,
> "Yaniv Dary" <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> Sent: Thursday, April 3, 2014 10:54:54 AM
> Subject: Re: Please help us to review our database schema design with NUMA
> feature on ovirt
>
>
>
> ----- Original Message -----
> > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> > To: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Eli
Mesika"
> > <emesika(a)redhat.com>
> > Cc: "Roy Golan" <rgolan(a)redhat.com>, "Omer Frenkel"
> > <ofrenkel(a)redhat.com>,
> > "Chegu Vinod" <chegu_vinod(a)hp.com>, "Chuan
> > Liao (Jason Liao, HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>,
"Doron
> > Fediuck" <dfediuck(a)redhat.com>, "Shang-Chun
> > Liang (David Liang, HPservers-Core-OE-PSC)"
<shangchun.liang(a)hp.com>,
> > "Yaniv Dary" <ydary(a)redhat.com>,
> > engine-devel(a)ovirt.org
> > Sent: Thursday, April 3, 2014 7:25:11 AM
> > Subject: RE: Please help us to review our database schema design with
> > NUMA
> > feature on ovirt
> >
> > Hi all,
> > Please see my comments in line.
> >
> > Thanks & Best Regards
> > Shi, Xiao-Lei (Bruce)
> >
> > Hewlett-Packard Co., Ltd.
> > HP Servers Core Platform Software China
> > Telephone +86 23 65683093
> > Mobile +86 18696583447
> > Email xiao-lei.shi(a)hp.com
> >
> > -----Original Message-----
> > From: Gilad Chaplik [mailto:gchaplik@redhat.com]
> > Sent: Thursday, April 03, 2014 9:05 AM
> > To: Eli Mesika
> > Cc: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Roy Golan; Omer Frenkel;
> > Vinod,
> > Chegu; Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck;
> > Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
> > engine-devel(a)ovirt.org
> > Subject: Re: Please help us to review our database schema design with
> > NUMA
> > feature on ovirt
> >
> > Hi all,
> > Sorry for joining-in late.
> >
> > My comments (according to the db diagram section in
> >
https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcmbGWAcyQo_ISTY8ykD...):
> > 1) Join vm_numa_node and vds_numa_node to a single table (almost
> > identical),
> > one of the FKs can be null.
> > [Bruce] I prefer two tables. Actually host level NUMA node and vm level
> > NUMA
> > node are different objects. In my understanding, vm level NUMA node is
> > just
> > a simulation of host level NUMA node, and host level NUMA node has more
> > features that not in vm NUMA (like several levels of host NUMA topology
> > mentioned by Vinod). We need to consider the extensions of host NUMA in
> > the
> > future.
Let's open the discussion and consider them right now. vNode and Node are the
same.
Vinod?
>
> I agree with Bruce, we have no problem with more tables and constrains
> should
> work as expected and remove entries when a Host or VM is removed.
> I do not like tables that have 2 UUIDs when one of them is null , this is
> against simple DB normalization
>
We are going to maintain and develop this feature. there is a huge overhead
in 6 table design in compare to 4.
Counting how many tables you should manage is out of context.
The only thing I can care of is database design
From DB design perspective if you have a main table A with PK PK-A if
you have any other table X that includes PK-A as a column Cx , then there should be a
foreign key constraint that handles removals from A and clean corresponding X table
records accordingly. This you can not do when you have 2 UUIDs as you suggested (not to
mention that this is considered as bad DB design with no doubt)
Add to that the fact
that when managing both UUIDs in one table, you are supposed to get deadlocks from
scenarios that wouldn't cause that if each entity is managed in its own table.
I don't see any point to open this to discussion, we had worked hard to separate
tables that used this bad method in the past and caused us a bunch of unexpected
problems.
Please develop your DB changes according to normal well accepted guidelines I will not ack
a change that violates simple DB design rules.
Thanks
> >
> > 2) No templates reference in the design, need to check it out (it might
> > be
> > inherently designed already :-) ); vNode can be linked to a template.
> > [Bruce] IMO, we can consider template as a special vm, our current design
> > supports to create vNodes in a template just like what it does in a vm.
>
> We also store today templates in the VM* tables as special entities defined
> by the entity_type column
+1, just need to see that this is taken care of.
>
> >
> > 3) The reason I want host's NUMA data to be in static is because it
> > updates
> > only once (on boot). "engineerically" speaking, dynamic table has a
lot
> > of
> > traffic and that's not the case for NUMA info. Its feels to me like 'a
> > hybrid' of static and dynamic, 3 suggestions comes to mind:
> > - leave it in dynamic (maybe in a separate process).
> > - have a separate flow that updates static.
> > - come up with a third 'vds_on_boot' table (my favorite ;-P ).
> > I will get back to you on that.
> > [Bruce] From the onTimer codes in vdsManager (IMO it's the scheduled vds
> > refresh action), when vds is in normal running status (up status), only
> > statistics data will be refreshed, so I think maybe dynamic table doesn't
> > have so much traffic, and the varied data (I mean the data varied through
> > a
> > power reload, like cpu topology, numa topology, ...etc) can be refreshed
> > meanwhile.
> >
I beg to differ, dynamic table contains a lot of dynamic data:
host status, used memory and pending resources (maybe more).
still need to think about it, and get back to you.
> > 4) vm_vds_numa_node_map is connected to vds_numa_node_statistics, why to
> > split the tables (vds_numa_node & vds_numa_node_statistics), going back
> > to
> > comment #1, don't we want vNode stats as well, it can be nice to show it
> > :-)
> > (have a vNUMA overview of the VM using guest-agent or sth, in a future
> > phase).
> > [Bruce] Split the tables is referring to vds_interface
> > (vds_interface_statistics) and vm_interface (vm_interface_statistics),
> > the
> > statistics table will be refreshed with a high frequency.
> > I will update the design to add the vNuma statistics for the future
> > phase,
> > and according to my feedback in comment #1, vNuma statistics will also in
> > an
> > independent table since I think there will be more statistics fields for
> > host NUMA than for vNuma.
>
> Agree with Bruce
I disagree with both:
a) don't compare interface to NUMA; interface is a key element in the system.
b) if you care about high frequency, you can separate the update flows to the
same table.
c) see my comment about 1, overhead.
d) vNuma = Numa, as I said we can open it now for discussion.
>
> >
> > 5) IMO vds_cpu_statistics shouldn't include any reference to NUMA, I gave
> > that comment in the BE patch as well (remove vds_numa_node_id FK in
> > vds_cpu_statistics), for that you should extract cpu_list to a connection
> > table (anyway I don't like lists as a text/strings/etc.)
> > [Bruce] Yes, I agree with you to remove the reference between
> > vds_cpu_statistics and NUMA. Actually cpu_list is enough for current
> > requirements. I think the connection table is needed when we consider to
> > collect more cpu related information and do more cpu related actions in
> > the
> > future.
fine, can be done in a later phase. Please document with a bug/RFE
enhancement and mark infra in whiteboard.
> >
> > 6) vm_numatune_nodeset can be removed - the vNode should hold it's
> > pinning
> > info; I think that vNode (node according to comment #1) should be
> > connected
> > to a connection table that points to vdsNode (also Node table) itself
> > (kinda
> > complicated but does the trick - nested link).
> > [Bruce] Yes, I will remove vm_numatune_nodeset, but according to my
> > feedback
> > in comment #1, vm_vds_numa_node_map table will be retained to hold the
> > references between host nodes and vNode, since they are "m:n"
relations.
repeating my later comment:
correction: no need for another connection table, use vm_vds_numa_node_map
with a flag (is_pinned)
> >
> > 7) Please add delete-cascade info all over, i.e. what happens when we
> > remove
> > a host/vm/node.
> > [Bruce] Yes, I will update the design.
:-) thanks!
> >
> > 8) Is it possible to put a db constraint that mapping between vNode and
> > Node
> > will be deleted once the VM isn't UP?
> > [Bruce] I have a question here. IMO, the mapping between vNode and Node
> > is
> > a
> > user configuration, why it is related with the vm status? If the mapping
> > is
> > deleted, that means the user configuration is deleted. I don't think
it's
> > reasonable.
see comment #6 (including the correction). there is actual real-life NUMA
mapping retrieved by the host, and there is pinning info.
when a VM is down, the actual real-life mapping can be removed.
> >
> > Thanks,
> > Gilad.
> >
> > ----- Original Message -----
> > > From: "Eli Mesika" <emesika(a)redhat.com>
> > > To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> > > Cc: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Roy
Golan"
> > > <rgolan(a)redhat.com>, "Omer Frenkel"
<ofrenkel(a)redhat.com>, "Chegu
> > > Vinod" <chegu_vinod(a)hp.com>, "Chuan Liao (Jason Liao,
> > > HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>, "Doron
Fediuck"
> > > <dfediuck(a)redhat.com>, "Shang-Chun Liang (David Liang,
> > > HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>, "Yaniv
Dary"
> > > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > > Sent: Tuesday, April 1, 2014 10:10:37 AM
> > > Subject: Re: Please help us to review our database schema design with
> > > NUMA feature on ovirt
> > >
> > >
> > >
> > > ----- Original Message -----
> > > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > > <xiao-lei.shi(a)hp.com>
> > > > To: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Roy
Golan"
> > > > <rgolan(a)redhat.com>, "Omer Frenkel"
<ofrenkel(a)redhat.com>, "Eli
> > > > Mesika" <emesika(a)redhat.com>, "Chegu Vinod"
<chegu_vinod(a)hp.com>
> > > > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > > > <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>,
> > > > "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
> > > > <shangchun.liang(a)hp.com>, "Yaniv Dary"
<ydary(a)redhat.com>,
> > > > engine-devel(a)ovirt.org
> > > > Sent: Tuesday, April 1, 2014 5:13:34 AM
> > > > Subject: RE: Please help us to review our database schema design
> > > > with NUMA feature on ovirt
> > > >
> > > > Assemble the related discussions in this mail session.
> > > >
> > > > Hi Vinod,
> > > > On 3/31/2014 2:38 AM, Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
wrote:
> > > > > We put host level NUMA fields in vds_dynamic because these
> > > > > information are from host itself, and NUMA topology may be
changed
> > > > > if the host's hardware make a change.
> > > > Can you please elaborate ? Are you thinking about resource (cpu
> > > > and/or
> > > > memory) hot plug on the host ?
> > > > [Bruce] It's not about resource hot plug. In ovirt engine, there
is
> > > > a scheduled task which will refresh hosts' and vms'
information
> > > > periodically.
> > > > Only the dynamic and statistics data will be updated during the
> > > > refresh. So I think the resource information, such as cpu and/or
> > > > memory, should be in dynamic and statistics. And in my
> > > > understanding, the information in dynamic class is the changeable
> > > > information but with a low varying frequency, like cpu topology,
> > > > libvirt/kernel versions, etc. The information in statistics class is
> > > > the information with a high varying frequency, like the usage of
> > > > cpu/memory, etc. In my opinion, it's reasonable to put host
level
> > > > NUMA information in vds_dynamic and host level NUMA statistics
> > > > information in vds_statistics.
> > > >
> > > > Hi Gilad/Roy/Omer,
> > > > I don't know if my understanding is correct. But according to
this
> > > > guess, I think it's also reasonable to put vm cpuPin information
in
> > > > vm_static.
> > > > Because cpuPin is user configured information, it will not vary
> > > > automatically. So we don’t need to refresh this information
> > > > periodically.
> > > > Please correct me if there are any mistakes.
> > > >
> > > > Hi Eli,
> > > > Sorry for the nag. If my understanding above is correct, I think we
> > > > should still put host level NUMA fields in
> > > > vds_dynamic/vds_statistics and vm level NUMA fields in vm_static.
> > > > Since vm level NUMA fields are configured by user and they will not
> > > > vary
> > > > automatically.
> > >
> > > Sorry, I had understood from Gilad that the NUMA fields in the host
> > > level are relatively static and the NUMA fields on the VM level are
> > > dynamic.
> > > I have no problem of having hybrid static/dynamic fields for Host/VM
> > > as long as it has a good reason and fully documented :-)
> > >
> > >
> > > >
> > > >
> > > > Thanks & Best Regards
> > > > Shi, Xiao-Lei (Bruce)
> > > >
> > > > Hewlett-Packard Co., Ltd.
> > > > HP Servers Core Platform Software China Telephone +86 23 65683093
> > > > Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > > >
> > > >
> > > > -----Original Message-----
> > > > From: Gilad Chaplik [mailto:gchaplik@redhat.com]
> > > > Sent: Monday, March 31, 2014 9:31 PM
> > > > To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Roy Golan; Omer
> > > > Frenkel
> > > > Cc: Eli Mesika; Roy Golan; Liao, Chuan (Jason Liao,
> > > > HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang,
> > > > Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
> > > > engine-devel(a)ovirt.org
> > > > Subject: Re: Please help us to review our database schema design
> > > > with NUMA feature on ovirt
> > > >
> > > > adding Roy & Omer.
> > > >
> > > > why CPU topology is in dynamic?
> > > >
> > > > Thanks,
> > > > Gilad.
> > > >
> > > > ----- Original Message -----
> > > > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > > > <xiao-lei.shi(a)hp.com>
> > > > > To: "Eli Mesika" <emesika(a)redhat.com>
> > > > > Cc: "Gilad Chaplik" <gchaplik(a)redhat.com>,
"Roy Golan"
> > > > > <rgolan(a)redhat.com>, "Chuan Liao (Jason Liao,
> > > > > HPservers-Core-OE-PSC)"
> > > > > <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>, "Chegu
> > > > > Vinod"
> > > > > <chegu_vinod(a)hp.com>, "Shang-Chun Liang (David
Liang,
> > > > > HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>,
"Yaniv Dary"
> > > > > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > > > > Sent: Monday, March 31, 2014 3:20:33 PM
> > > > > Subject: RE: Please help us to review our database schema
design
> > > > > with NUMA feature on ovirt
> > > > >
> > > > > Thanks Eli.
> > > > > I will move the vm level NUMA fields to vm_dynamic, and the
> > > > > related database schema will be updated accordingly.
> > > > >
> > > > > Thanks & Best Regards
> > > > > Shi, Xiao-Lei (Bruce)
> > > > >
> > > > > Hewlett-Packard Co., Ltd.
> > > > > HP Servers Core Platform Software China Telephone +86 23
65683093
> > > > > Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > > > >
> > > > > -----Original Message-----
> > > > > From: Eli Mesika [mailto:emesika@redhat.com]
> > > > > Sent: Monday, March 31, 2014 5:49 PM
> > > > > To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > > > Cc: Gilad Chaplik; Roy Golan; Liao, Chuan (Jason Liao,
> > > > > HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang,
> > > > > Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
> > > > > engine-devel(a)ovirt.org
> > > > > Subject: Re: Please help us to review our database schema
design
> > > > > with NUMA feature on ovirt
> > > > >
> > > > >
> > > > >
> > > > > ----- Original Message -----
> > > > > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > > > > <xiao-lei.shi(a)hp.com>
> > > > > > To: "Gilad Chaplik" <gchaplik(a)redhat.com>,
"Eli Mesika"
> > > > > > <emesika(a)redhat.com>, "Roy Golan"
<rgolan(a)redhat.com>
> > > > > > Cc: "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)"
> > > > > > <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>,
> > > > > > "Chegu Vinod"
> > > > > > <chegu_vinod(a)hp.com>, "Shang-Chun Liang (David
Liang,
> > > > > > HPservers-Core-OE-PSC)"
> > > > > > <shangchun.liang(a)hp.com>, "Yaniv Dary"
<ydary(a)redhat.com>,
> > > > > > engine-devel(a)ovirt.org
> > > > > > Sent: Monday, March 31, 2014 12:38:04 PM
> > > > > > Subject: RE: Please help us to review our database schema
design
> > > > > > with NUMA feature on ovirt
> > > > > >
> > > > > > We put host level NUMA fields in vds_dynamic because these
> > > > > > information are from host itself, and NUMA topology may be
> > > > > > changed if the host's hardware make a change. NUMA
information
> > > > > > are similar to the host's cpu topology information
like
> > > > > > cpu_cores and cpu_sockets which are in vds_dynamic, we
refer to
> > > > > > this.
> > > > > > VM level NUMA fields are configured by user, and actually
we
> > > > > > originally think they should be in vm_dynamic. But we found
that
> > > > > > the field of another feature cpuPin which is similar as
NUMA
> > > > > > feature is in vm_static, so we put vm NUMA fields in
vm_static.
> > > > > > Do you think we need to put VM level NUMA fields in
vm_dynamic?
> > > > >
> > > > > I think that in this case we should fix cpuPin to be in
vm_dynamic
> > > > > and put after that the other NUMA fields in vm_dynamic as well
> > > > >
> > > > > >
> > > > > > Thanks & Best Regards
> > > > > > Shi, Xiao-Lei (Bruce)
> > > > > >
> > > > > > Hewlett-Packard Co., Ltd.
> > > > > > HP Servers Core Platform Software China Telephone +86 23
> > > > > > 65683093 Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com
> > > > > >
> > > > > >
> > > > > > -----Original Message-----
> > > > > > From: Gilad Chaplik [mailto:gchaplik@redhat.com]
> > > > > > Sent: Monday, March 31, 2014 5:22 PM
> > > > > > To: Eli Mesika; Roy Golan
> > > > > > Cc: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Liao, Chuan
(Jason
> > > > > > Liao, HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu;
> > > > > > Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC);
Yaniv
> > > > > > Dary; engine-devel(a)ovirt.org
> > > > > > Subject: Re: Please help us to review our database schema
design
> > > > > > with NUMA feature on ovirt
> > > > > >
> > > > > > +1
> > > > > >
> > > > > > IMO: vds data should reside in static VM need to think
about it.
> > > > > >
> > > > > > Roy?
> > > > > >
> > > > > > Thanks,
> > > > > > Gilad.
> > > > > >
> > > > > >
> > > > > > ----- Original Message -----
> > > > > > > From: "Eli Mesika"
<emesika(a)redhat.com>
> > > > > > > To: "Xiao-Lei Shi (Bruce, HP
Servers-PSC-CQ)"
> > > > > > > <xiao-lei.shi(a)hp.com>
> > > > > > > Cc: "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)"
> > > > > > > <chuan.liao(a)hp.com>, "Doron Fediuck"
<dfediuck(a)redhat.com>,
> > > > > > > "Gilad Chaplik" <gchaplik(a)redhat.com>,
"Chegu Vinod"
> > > > > > > <chegu_vinod(a)hp.com>,
> > > > > > > "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)"
> > > > > > > <shangchun.liang(a)hp.com>, "Yaniv
Dary"
> > > > > > > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > > > > > > Sent: Monday, March 31, 2014 12:12:50 PM
> > > > > > > Subject: Re: Please help us to review our database
schema
> > > > > > > design with NUMA feature on ovirt
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > ----- Original Message -----
> > > > > > > > From: "Xiao-Lei Shi (Bruce, HP
Servers-PSC-CQ)"
> > > > > > > > <xiao-lei.shi(a)hp.com>
> > > > > > > > To: "Eli Mesika"
<emesika(a)redhat.com>
> > > > > > > > Cc: "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)"
> > > > > > > > <chuan.liao(a)hp.com>,
> > > > > > > > "Doron Fediuck"
<dfediuck(a)redhat.com>, "Gilad Chaplik"
> > > > > > > > <gchaplik(a)redhat.com>, "Chegu
Vinod"
> > > > > > > > <chegu_vinod(a)hp.com>,
> > > > > > > > "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)"
> > > > > > > > <shangchun.liang(a)hp.com>, "Yaniv
Dary"
> > > > > > > > <ydary(a)redhat.com>, engine-devel(a)ovirt.org
> > > > > > > > Sent: Monday, March 31, 2014 8:56:20 AM
> > > > > > > > Subject: RE: Please help us to review our
database schema
> > > > > > > > design with NUMA feature on ovirt
> > > > > > > >
> > > > > > > > Include the devel group.
> > > > > > > > Thanks Eli for the quick responses for our first
design and
> > > > > > > > sorry for the nag.
> > > > > > > > We appreciate any of the comments for our
database design
> > > > > > > > and will follow the design to do the
implementation if no
> > > > > > > > more comments.
> > > > > > > >
> > > > > > > >
http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
> > > > > > >
> > > > > > > Seems OK for me except an unanswered question I had
asked in
> > > > > > > my first review
> > > > > > > :
> > > > > > >
> > > > > > > Why in the Host level NUMA fields are added to
vds_dynamic
> > > > > > > while in the VM level it is added to vm_static ???
> > > > > > > I would expect it to be in both on static or dynamic ,
can you
> > > > > > > please explain ? Thanks
> > > > > > >
> > > > > > > >
> > > > > > > > Thanks & Best Regards
> > > > > > > > Shi, Xiao-Lei (Bruce)
> > > > > > > >
> > > > > > > > Hewlett-Packard Co., Ltd.
> > > > > > > > HP Servers Core Platform Software China Telephone
+86 23
> > > > > > > > 65683093 Mobile +86 18696583447 Email
xiao-lei.shi(a)hp.com
> > > > > > > >
> > > > > > > > -----Original Message-----
> > > > > > > > From: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > > > > > > Sent: Friday, March 28, 2014 1:30 PM
> > > > > > > > To: 'Eli Mesika'
> > > > > > > > Cc: Liao, Chuan (Jason Liao,
HPservers-Core-OE-PSC); Doron
> > > > > > > > Fediuck; Gilad Chaplik; Vinod, Chegu; Liang,
Shang-Chun
> > > > > > > > (David Liang, HPservers-Core-OE-PSC); Yaniv Dary
> > > > > > > > Subject: RE: Please help us to review our
database schema
> > > > > > > > design with NUMA feature on ovirt
> > > > > > > >
> > > > > > > > Hi Eli,
> > > > > > > >
> > > > > > > > After the UX design meeting, we did some
modification for
> > > > > > > > the database schema, and merged some update
according to
> > > > > > > > your last review comments.
> > > > > > > > Now the document has been posted on ovirt
wikipage, could
> > > > > > > > you help to review the database design again:
> > > > > > > >
http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
> > > > > > > >
> > > > > > > >
> > > > > > > > Thanks & Best Regards
> > > > > > > > Shi, Xiao-Lei (Bruce)
> > > > > > > >
> > > > > > > > Hewlett-Packard Co., Ltd.
> > > > > > > > HP Servers Core Platform Software China Telephone
+86 23
> > > > > > > > 65683093 Mobile
> > > > > > > > +86
> > > > > > > > 18696583447 Email xiao-lei.shi(a)hp.com
> > > > > > > >
> > > > > > > >
> > > > > > > > -----Original Message-----
> > > > > > > > From: Eli Mesika [mailto:emesika@redhat.com]
> > > > > > > > Sent: Monday, March 24, 2014 6:24 PM
> > > > > > > > To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > > > > > > Cc: Liao, Chuan (Jason Liao,
HPservers-Core-OE-PSC); Doron
> > > > > > > > Fediuck; Gilad Chaplik; Vinod, Chegu; Liang,
Shang-Chun
> > > > > > > > (David Liang, HPservers-Core-OE-PSC); Yaniv Dary
> > > > > > > > Subject: Re: Please help us to review our
database schema
> > > > > > > > design with NUMA feature on ovirt
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > ----- Original Message -----
> > > > > > > > > From: "Xiao-Lei Shi (Bruce, HP
Servers-PSC-CQ)"
> > > > > > > > > <xiao-lei.shi(a)hp.com>
> > > > > > > > > To: "Eli Mesika"
<emesika(a)redhat.com>, "Chuan Liao (Jason
> > > > > > > > > Liao, HPservers-Core-OE-PSC)"
<chuan.liao(a)hp.com>
> > > > > > > > > Cc: "Doron Fediuck"
<dfediuck(a)redhat.com>, "Gilad Chaplik"
> > > > > > > > > <gchaplik(a)redhat.com>, "Chegu
Vinod" <chegu_vinod(a)hp.com>,
> > > > > > > > > "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)"
> > > > > > > > > <shangchun.liang(a)hp.com>
> > > > > > > > > Sent: Monday, March 24, 2014 11:23:39 AM
> > > > > > > > > Subject: RE: Please help us to review our
database schema
> > > > > > > > > design with NUMA feature on ovirt
> > > > > > > > >
> > > > > > > > > Hi Eli,
> > > > > > > > >
> > > > > > > > > Thanks for your comments.
> > > > > > > > > I have updated the document according to
your comments
> > > > > > > > > except the below
> > > > > > > > > one:
> > > > > > > > > Missing from here are 2 issues:
> > > > > > > > >
> > > > > > > > > 1) Impact on the search engine, which new
columns are
> > > > > > > > > search-able and which changes are planned in
the search
> > > > > > > > > engine code to enable that
> > > > > > > > >
> > > > > > > > > 2) Impact on engine-reports, are those
changed planned to
> > > > > > > > > be exposed to the engine data warehouse and
required
> > > > > > > > > new/modified reports?
> > > > > > > > >
> > > > > > > > > Could you tell us more detailed information
about the
> > > > > > > > > modules you mentioned above? I mean
"search engine" and
> > > > > > > > > "engine-reports". I think we
missed these two parts in our
> > > > > > > > > previous investigation.
> > > > > > > > > I just find
org.ovirt.engine.core.bll.SearchQuery, is that
> > > > > > > > > the right object for search engine?
> > > > > > > >
> > > > > > > > Yes, actually when you are opening the admin UI,
there are
> > > > > > > > TABs for each entity , i.e. Data Center, Cluster,
Host etc.
> > > > > > > > In each, you can see a text-box in which you can
search for
> > > > > > > > by writing a search expression My question is
> > > > > > > > 1) What is the impact of your work on the
search on the
> > > > > > > > Fost
> > > > > > > > and
> > > > > > > > VM
> > > > > > > > TABs
> > > > > > > > a) Are there any fields that are supported
now in the
> > > > > > > > search
> > > > > > > > expression
> > > > > > > > and should pop-up when you write the
expression by the
> > > > > > > > auto-completion
> > > > > > > > mechanism ?
> > > > > > > > b) Are there any added columns displayed in
the result
> > > > > > > > of
> > > > > > > > such
> > > > > > > > a
> > > > > > > > search
> > > > > > > > in the grid ?
> > > > > > > >
> > > > > > > > > How about the engine-reports, could you give
us some
> > > > > > > > > hints, like the code location and any more
detailed
> > > > > > > > > information that we can start more
investigation?
> > > > > > > >
> > > > > > > > CCing Yaniv D who is in charge of the reports/dwh
module
> > > > > > > > Yaniv, any planned work for adding Numa features
to Host/VM
> > > > > > > > in the reports side ?
> > > > > > > >
> > > > > > > > Thanks
> > > > > > > >
> > > > > > > > >
> > > > > > > > > Thanks & Best Regards
> > > > > > > > > Shi, Xiao-Lei (Bruce)
> > > > > > > > >
> > > > > > > > > Hewlett-Packard Co., Ltd.
> > > > > > > > > HP Servers Core Platform Software China
Telephone +86 23
> > > > > > > > > 65683093 Mobile +86 18696583447 Email
xiao-lei.shi(a)hp.com
> > > > > > > > >
> > > > > > > > > -----Original Message-----
> > > > > > > > > From: Eli Mesika
[mailto:emesika@redhat.com]
> > > > > > > > > Sent: Sunday, March 23, 2014 4:44 PM
> > > > > > > > > To: Liao, Chuan (Jason Liao,
HPservers-Core-OE-PSC)
> > > > > > > > > Cc: Doron Fediuck; Gilad Chaplik; Vinod,
Chegu; Liang,
> > > > > > > > > Shang-Chun (David Liang,
HPservers-Core-OE-PSC); Shi,
> > > > > > > > > Xiao-Lei (Bruce, HP
> > > > > > > > > Servers-PSC-CQ)
> > > > > > > > > Subject: Re: Please help us to review our
database schema
> > > > > > > > > design with NUMA feature on ovirt
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > ----- Original Message -----
> > > > > > > > > > From: "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)"
> > > > > > > > > > <chuan.liao(a)hp.com>
> > > > > > > > > > To: emesika(a)redhat.com
> > > > > > > > > > Cc: "Doron Fediuck"
<dfediuck(a)redhat.com>, "Gilad
> > > > > > > > > > Chaplik"
> > > > > > > > > > <gchaplik(a)redhat.com>,
"Chegu Vinod"
> > > > > > > > > > <chegu_vinod(a)hp.com>,
"Shang-Chun Liang (David Liang,
> > > > > > > > > > HPservers-Core-OE-PSC)"
> > > > > > > > > > <shangchun.liang(a)hp.com>,
"Xiao-Lei Shi (Bruce, HP
> > > > > > > > > > Servers-PSC-CQ)"
> > > > > > > > > > <xiao-lei.shi(a)hp.com>
> > > > > > > > > > Sent: Friday, March 21, 2014 10:42:33
AM
> > > > > > > > > > Subject: Please help us to review our
database schema
> > > > > > > > > > design with NUMA feature on ovirt
> > > > > > > > > >
> > > > > > > > > > Hi Eli,
> > > > > > > > > >
> > > > > > > > > > Please help us to review our database
schema design with
> > > > > > > > > > NUMA feature on ovirt
> > > > > > > > > >
https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcm
> > > > > > > > > > bGWA
> > > > > > > > > > cyQo_IST
> > > > > > > > > > Y8
> > > > > > > > > > ykDr0I6VY/edit?usp=sharing
> > > > > > > > > >
> > > > > > > > > > Feel free to take comments on document
at anywhere
> > > > > > > > >
> > > > > > > > > Done, had commented on the document.
> > > > > > > > > Eli
> > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > Especially, 5.4 The used interface
between engine core
> > > > > > > > > > and
> > > > > > > > > > database(schema)
> > > > > > > > > >
> > > > > > > > > > Your approve and your comments with
this section will be
> > > > > > > > > > much more appreciate for us.
> > > > > > > > > >
> > > > > > > > > > Best Regards,
> > > > > > > > > > Jason Liao
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
3674
days inactive
3677
days old
16 comments
4 participants
participants (4)
-
Chegu Vinod -
Eli Mesika -
Gilad Chaplik -
Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)