From awels at redhat.com Fri Sep 25 13:29:28 2015
Content-Type: multipart/mixed; boundary="===============5820134152190067571=="
MIME-Version: 1.0
From: awels at redhat.com
To: engine-commits at ovirt.org
Subject: Change in ovirt-engine[master]: webadmin,
 userportal: Fix IE image size quirk
Date: Fri, 25 Sep 2015 13:29:24 -0400
Message-ID: <201509251729.t8PHTOnL016199@gerrit.ovirt.org>
In-Reply-To: gerrit.1442603667143.Ia17eb684cb08c0cb2cd610e38974bc9992e48285@gerrit.ovirt.org

--===============5820134152190067571==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

Alexander Wels has submitted this change and it was merged.

Change subject: webadmin,userportal: Fix IE image size quirk
......................................................................


webadmin,userportal: Fix IE image size quirk

IE automatically adds "width" and "height" attributes, with
values taken from "src" image data, when an <img> element is
created via Image constructor function. For example:

  var img =3D new Image();
  img.src =3D "foo.png";
  // adds "width" and "height" automatically
  document.body.appendChild(img);

This causes render issues for images that use "src" attribute
for initial placeholder image and CSS styling for the actual
image. For example:

  <style>
    .fooImage {
      background: url("foo.png");
      width: 400px;
      height: 200px;
    }
  </style>

  <img src=3D"clear.cache.gif" class=3D"fooImage">

In IE, above <img> element would have "width" and "height"
attributes, with values from "clear.cache.gif" placeholder
image, added automatically:

  <img src=3D"clear.cache.gif"
       width=3D"1" height=3D"1" class=3D"fooStyle">

To fix this quirk, "width" and "height" attributes of such
images are set to value "auto":

  <img src=3D"clear.cache.gif"
       width=3D"auto" height=3D"auto" class=3D"fooStyle">

Change-Id: Ia17eb684cb08c0cb2cd610e38974bc9992e48285
Bug-Url: https://bugzilla.redhat.com/1255428
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/co=
mmon/gin/BaseSystemModule.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/co=
mmon/system/BrowserHacks.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/co=
mmon/uicommon/ClientAgentType.java
3 files changed, 85 insertions(+), 2 deletions(-)

Approvals:
  Alexander Wels: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests
  Greg Sheremeta: Looks good to me, approved



-- =

To view, visit https://gerrit.ovirt.org/46377
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia17eb684cb08c0cb2cd610e38974bc9992e48285
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org

--===============5820134152190067571==--