From jira at ovirt-jira.atlassian.net Wed Feb 14 07:12:47 2018 Content-Type: multipart/mixed; boundary="===============5501694107587925853==" MIME-Version: 1.0 From: Barak Korren (oVirt JIRA) To: infra at ovirt.org Subject: [JIRA] (OVIRT-1895) CI votes not forwarded on commit message change Date: Wed, 14 Feb 2018 07:12:45 +0000 Message-ID: In-Reply-To: JIRA.33587.1518508952000@Atlassian.JIRA --===============5501694107587925853== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable This is a multi-part message in MIME format... ------------=3D_1518592365-27516-116 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 7bit [ https://ovirt-jira.atlassian.net/browse/OVIRT-1895?page=3Dcom.atlass= ian.jira.plugin.system.issuetabpanels:all-tabpanel ] Barak Korren updated OVIRT-1895: -------------------------------- Component/s: Gerrit/git Epic Link: OVIRT-400 Issue Type: Bug (was: By-EMAIL) > CI votes not forwarded on commit message change > ----------------------------------------------- > > Key: OVIRT-1895 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1895 > Project: oVirt - virtualization made easy > Issue Type: Bug > Components: Gerrit/git > Reporter: Yedidyah Bar David > Assignee: infra > > Hi all, > If a change goes through this flow: > 1. Push an update N > 2. CI triggers check-patch for N > 3. Push another update N+1 that changes only commit message > 4. CI marks +1 N > Then we have logic to not trigger CI for N+1 (with the assumption that > a change to commit message should not affect the result), but also do > not mark +1 N+1, leaving the patch unmarked. > We should either forward the +1, when giving it, to all consecutive > future patchsets that only changed the commit message, or give up on > the optimization and always trigger CI. > As an example, see: > https://gerrit.ovirt.org/87515 > Best regards, > -- = > Didi -- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100079) ------------=3D_1518592365-27516-116 Content-Type: text/html; charset=3D"UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1895?page=3Dcom.atlass=
ian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Barak Korren updated OVIRT-1895:

Component/s: Gerrit/git
  Epic Link: OVIRT-400
 Issue Type: Bug  (was: By-EMAIL)

CI votes not forwarded on commit message change
     Key: OVIRT-1895
     URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1895
 Project: oVirt - virtualization made easy
         Issue Type: Bug
         Components: Gerrit/git
Reporter: Yedidyah Bar David
Assignee: infra
Hi all, If a change goes through this flow:

Push an update N

CI triggers check-patch for N

Push another update N+1 that changes only commit message

CI marks +1 N

Then we have logic to not trigger CI for N+1 (with the assumption that a= change to commit message should not affect the result), but also do not ma= rk +1 N+1, leaving the patch unmarked. We should either forward the +1, whe= n giving it, to all consecutive future patchsets that only changed the comm= it message, or give up on the optimization and always trigger CI. As an exa= mple, see: https://gerrit.ovirt.= org/87515 Best regards, — Didi

— This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#1000= 79)

------------=3D_1518592365-27516-116-- --===============5501694107587925853== Content-Type: multipart/alternative MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="attachment.bin" VGhpcyBpcyBhIG11bHRpLXBhcnQgbWVzc2FnZSBpbiBNSU1FIGZvcm1hdC4uLgoKLS0tLS0tLS0t LS0tPV8xNTE4NTkyMzY1LTI3NTE2LTExNgpDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJz ZXQ9VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogN2JpdAoKCiAgICAgWyBodHRwczov L292aXJ0LWppcmEuYXRsYXNzaWFuLm5ldC9icm93c2UvT1ZJUlQtMTg5NT9wYWdlPWNvbS5hdGxh c3NpYW4uamlyYS5wbHVnaW4uc3lzdGVtLmlzc3VldGFicGFuZWxzOmFsbC10YWJwYW5lbCBdCgpC YXJhayBLb3JyZW4gdXBkYXRlZCBPVklSVC0xODk1OgotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLQogICAgQ29tcG9uZW50L3M6IEdlcnJpdC9naXQKICAgICAgRXBpYyBMaW5rOiBPVklS VC00MDAKICAgICBJc3N1ZSBUeXBlOiBCdWcgICh3YXM6IEJ5LUVNQUlMKQoKPiBDSSB2b3RlcyBu b3QgZm9yd2FyZGVkIG9uIGNvbW1pdCBtZXNzYWdlIGNoYW5nZQo+IC0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4KPiAgICAgICAgICAgICAgICAgS2V5OiBP VklSVC0xODk1Cj4gICAgICAgICAgICAgICAgIFVSTDogaHR0cHM6Ly9vdmlydC1qaXJhLmF0bGFz c2lhbi5uZXQvYnJvd3NlL09WSVJULTE4OTUKPiAgICAgICAgICAgICBQcm9qZWN0OiBvVmlydCAt IHZpcnR1YWxpemF0aW9uIG1hZGUgZWFzeQo+ICAgICAgICAgIElzc3VlIFR5cGU6IEJ1Zwo+ICAg ICAgICAgIENvbXBvbmVudHM6IEdlcnJpdC9naXQKPiAgICAgICAgICAgIFJlcG9ydGVyOiBZZWRp ZHlhaCBCYXIgRGF2aWQKPiAgICAgICAgICAgIEFzc2lnbmVlOiBpbmZyYQo+Cj4gSGkgYWxsLAo+ IElmIGEgY2hhbmdlIGdvZXMgdGhyb3VnaCB0aGlzIGZsb3c6Cj4gMS4gUHVzaCBhbiB1cGRhdGUg Tgo+IDIuIENJIHRyaWdnZXJzIGNoZWNrLXBhdGNoIGZvciBOCj4gMy4gUHVzaCBhbm90aGVyIHVw ZGF0ZSBOKzEgdGhhdCBjaGFuZ2VzIG9ubHkgY29tbWl0IG1lc3NhZ2UKPiA0LiBDSSBtYXJrcyAr MSBOCj4gVGhlbiB3ZSBoYXZlIGxvZ2ljIHRvIG5vdCB0cmlnZ2VyIENJIGZvciBOKzEgKHdpdGgg dGhlIGFzc3VtcHRpb24gdGhhdAo+IGEgY2hhbmdlIHRvIGNvbW1pdCBtZXNzYWdlIHNob3VsZCBu b3QgYWZmZWN0IHRoZSByZXN1bHQpLCBidXQgYWxzbyBkbwo+IG5vdCBtYXJrICsxIE4rMSwgbGVh dmluZyB0aGUgcGF0Y2ggdW5tYXJrZWQuCj4gV2Ugc2hvdWxkIGVpdGhlciBmb3J3YXJkIHRoZSAr MSwgd2hlbiBnaXZpbmcgaXQsIHRvIGFsbCBjb25zZWN1dGl2ZQo+IGZ1dHVyZSBwYXRjaHNldHMg dGhhdCBvbmx5IGNoYW5nZWQgdGhlIGNvbW1pdCBtZXNzYWdlLCBvciBnaXZlIHVwIG9uCj4gdGhl IG9wdGltaXphdGlvbiBhbmQgYWx3YXlzIHRyaWdnZXIgQ0kuCj4gQXMgYW4gZXhhbXBsZSwgc2Vl Ogo+IGh0dHBzOi8vZ2Vycml0Lm92aXJ0Lm9yZy84NzUxNQo+IEJlc3QgcmVnYXJkcywKPiAtLSAK PiBEaWRpCgoKCi0tClRoaXMgbWVzc2FnZSB3YXMgc2VudCBieSBBdGxhc3NpYW4gSmlyYQoodjEw MDEuMC4wLVNOQVBTSE9UIzEwMDA3OSkKCi0tLS0tLS0tLS0tLT1fMTUxODU5MjM2NS0yNzUxNi0x MTYKQ29udGVudC1UeXBlOiB0ZXh0L2h0bWw7IGNoYXJzZXQ9IlVURi04IgpDb250ZW50LURpc3Bv c2l0aW9uOiBpbmxpbmUKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogN2JpdAoKPGh0bWw+PGJv ZHk+CjxwcmU+WyBodHRwczovL292aXJ0LWppcmEuYXRsYXNzaWFuLm5ldC9icm93c2UvT1ZJUlQt MTg5NT9wYWdlPWNvbS5hdGxhc3NpYW4uamlyYS5wbHVnaW4uc3lzdGVtLmlzc3VldGFicGFuZWxz OmFsbC10YWJwYW5lbCBdPC9wcmU+CjxoMz5CYXJhayBLb3JyZW4gdXBkYXRlZCBPVklSVC0xODk1 OjwvaDM+CjxwcmU+Q29tcG9uZW50L3M6IEdlcnJpdC9naXQKICBFcGljIExpbms6IE9WSVJULTQw MAogSXNzdWUgVHlwZTogQnVnICAod2FzOiBCeS1FTUFJTCk8L3ByZT4KPGJsb2NrcXVvdGU+PGgz PkNJIHZvdGVzIG5vdCBmb3J3YXJkZWQgb24gY29tbWl0IG1lc3NhZ2UgY2hhbmdlPC9oMz4KPHBy ZT4gICAgIEtleTogT1ZJUlQtMTg5NQogICAgIFVSTDogaHR0cHM6Ly9vdmlydC1qaXJhLmF0bGFz c2lhbi5uZXQvYnJvd3NlL09WSVJULTE4OTUKIFByb2plY3Q6IG9WaXJ0IC0gdmlydHVhbGl6YXRp b24gbWFkZSBlYXN5CiAgICAgICAgIElzc3VlIFR5cGU6IEJ1ZwogICAgICAgICBDb21wb25lbnRz OiBHZXJyaXQvZ2l0ClJlcG9ydGVyOiBZZWRpZHlhaCBCYXIgRGF2aWQKQXNzaWduZWU6IGluZnJh PC9wcmU+CjxwPkhpIGFsbCwgSWYgYSBjaGFuZ2UgZ29lcyB0aHJvdWdoIHRoaXMgZmxvdzo8L3A+ CjxvbD48bGk+PHA+UHVzaCBhbiB1cGRhdGUgTjwvcD48L2xpPgo8bGk+PHA+Q0kgdHJpZ2dlcnMg Y2hlY2stcGF0Y2ggZm9yIE48L3A+PC9saT4KPGxpPjxwPlB1c2ggYW5vdGhlciB1cGRhdGUgTisx IHRoYXQgY2hhbmdlcyBvbmx5IGNvbW1pdCBtZXNzYWdlPC9wPjwvbGk+CjxsaT48cD5DSSBtYXJr cyArMSBOPC9wPjwvbGk+PC9vbD4KPHA+VGhlbiB3ZSBoYXZlIGxvZ2ljIHRvIG5vdCB0cmlnZ2Vy IENJIGZvciBOKzEgKHdpdGggdGhlIGFzc3VtcHRpb24gdGhhdCBhIGNoYW5nZSB0byBjb21taXQg bWVzc2FnZSBzaG91bGQgbm90IGFmZmVjdCB0aGUgcmVzdWx0KSwgYnV0IGFsc28gZG8gbm90IG1h cmsgKzEgTisxLCBsZWF2aW5nIHRoZSBwYXRjaCB1bm1hcmtlZC4gV2Ugc2hvdWxkIGVpdGhlciBm b3J3YXJkIHRoZSArMSwgd2hlbiBnaXZpbmcgaXQsIHRvIGFsbCBjb25zZWN1dGl2ZSBmdXR1cmUg cGF0Y2hzZXRzIHRoYXQgb25seSBjaGFuZ2VkIHRoZSBjb21taXQgbWVzc2FnZSwgb3IgZ2l2ZSB1 cCBvbiB0aGUgb3B0aW1pemF0aW9uIGFuZCBhbHdheXMgdHJpZ2dlciBDSS4gQXMgYW4gZXhhbXBs ZSwgc2VlOiA8YSBocmVmPSJodHRwczovL2dlcnJpdC5vdmlydC5vcmcvODc1MTUiPmh0dHBzOi8v Z2Vycml0Lm92aXJ0Lm9yZy84NzUxNTwvYT4gQmVzdCByZWdhcmRzLCAmbWRhc2g7IERpZGk8L3A+ PC9ibG9ja3F1b3RlPgo8cD4mbWRhc2g7IFRoaXMgbWVzc2FnZSB3YXMgc2VudCBieSBBdGxhc3Np YW4gSmlyYSAodjEwMDEuMC4wLVNOQVBTSE9UIzEwMDA3OSk8L3A+Cgo8aW1nIHNyYz0iaHR0cHM6 Ly91NDA0MzQwMi5jdC5zZW5kZ3JpZC5uZXQvd2Yvb3Blbj91cG49aTVUTVdHVjk5YW1KYk54SnBT cDItMkJKMzNCU00zdHVpVWZSVGs2NEstMkJPakdwRi0yQnVNem9KUlJCMWlmelpJRXJ0SXhUY2NM eTUyMXp6N094WlZpQjVtbnBiYndZSkZ6NmZsZ2V2WE96VUpWSC0yRnFCcXZjcXFxS0lwM3A0T2N5 REZPc1J3dmFMazFyN1g4SnBMRWJiWXRRLTJGOHNlLTJGQW9HM05xTXk2TUVGOTYwZk00V0NmQXJJ UGlwREF4VjNJOVF0RHh3SVprZU5XRDl5QXBQc2RKcmEzVjROVDdoSU9vVGlmNDZoTjlBMk5hLTJC SXNlSG5nU1NPenJTUG84N1hzNWRsVE9wblIyZXlVTTNVMGJRR2pxWDdkYXBHLTJGWHFqVjBiaWV3 TWM5QjV2Z1llZTE0YlpUZDBWU20wZGR6dDRPQUZCMVZldXI4dXcyazVaOEF0SERMUThyOGZCREZh V2w5NThqODJVYWM5S3c3LTJGYXhDWGs0WVJvWDB6eS0yQnVJaHRJZUZxVzRmbVVJTVZySVNmVFo1 Z0pUY0ZlQ2ROdDl2NGs4cWotMkIxaUtJNGxjdTBGVFJKaERQSzdLanBVamhFNk5meEtoTUIiIGFs dD0iIiB3aWR0aD0iMSIgaGVpZ2h0PSIxIiBib3JkZXI9IjAiIHN0eWxlPSJoZWlnaHQ6MXB4ICFp bXBvcnRhbnQ7d2lkdGg6MXB4ICFpbXBvcnRhbnQ7Ym9yZGVyLXdpZHRoOjAgIWltcG9ydGFudDtt YXJnaW4tdG9wOjAgIWltcG9ydGFudDttYXJnaW4tYm90dG9tOjAgIWltcG9ydGFudDttYXJnaW4t cmlnaHQ6MCAhaW1wb3J0YW50O21hcmdpbi1sZWZ0OjAgIWltcG9ydGFudDtwYWRkaW5nLXRvcDow ICFpbXBvcnRhbnQ7cGFkZGluZy1ib3R0b206MCAhaW1wb3J0YW50O3BhZGRpbmctcmlnaHQ6MCAh aW1wb3J0YW50O3BhZGRpbmctbGVmdDowICFpbXBvcnRhbnQ7Ii8+CjwvYm9keT48L2h0bWw+Cgot LS0tLS0tLS0tLS09XzE1MTg1OTIzNjUtMjc1MTYtMTE2LS0K --===============5501694107587925853==--