From jira at ovirt-jira.atlassian.net Wed Jan 17 12:58:43 2018 Content-Type: multipart/mixed; boundary="===============2673347766492475807==" MIME-Version: 1.0 From: Ryan Barry (oVirt JIRA) To: infra at ovirt.org Subject: [JIRA] (OVIRT-1849) enable all gerrit hooks for cockpit-ovirt project Date: Wed, 17 Jan 2018 12:58:41 +0000 Message-ID: In-Reply-To: JIRA.33397.1516189937000@Atlassian.JIRA --===============2673347766492475807== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable This is a multi-part message in MIME format... ------------=3D_1516193921-24843-123 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 7bit [ https://ovirt-jira.atlassian.net/browse/OVIRT-1849?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D35= 677#comment-35677 ] = Ryan Barry commented on OVIRT-1849: ----------------------------------- I don't see a good reason not to enable all of them. At a minimum, set_modified would be great > enable all gerrit hooks for cockpit-ovirt project > ------------------------------------------------- > > Key: OVIRT-1849 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1849 > Project: oVirt - virtualization made easy > Issue Type: Task > Reporter: eyal edri > Assignee: infra > > It looks like the cockpit-ovirt project doesn't have all hooks enabled, c= urrent these are the hooks its using: > /home/gerrit2/review_site/hooks/custom_hooks/update_tracker > /home/gerrit2/review_site/hooks/custom_hooks/comment-added.propagate_revi= ew_values > If we want that the hooks will also update bz status and do other verific= ation like backporing, we need to add more hooks. > [~sbonazzo(a)redhat.com] [~msivak(a)redhat.com] please comment which hook= s you'd like to enable or all of them. > Info on the hooks can be found here :http://ovirt-infra-docs.readthedocs.= io/en/latest/General/Creating_Gerrit_Projects/index.html#enabling-custom-ge= rrit-hooks > [~amarchuk] fyi -- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100076) ------------=3D_1516193921-24843-123 Content-Type: text/html; charset=3D"UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit 
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1849?page=3Dcom.atlass=
ian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D35677#comment-35677 ]

Ryan Barry commented on OVIRT-1849:

I don't see a good reason not to enable all of them.

At a minimum, set_modified would be great

enable all gerrit hooks for cockpit-ovirt project

     Key: OVIRT-1849
     URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1849
 Project: oVirt - virtualization made easy
         Issue Type: Task
Reporter: eyal edri
Assignee: infra

It looks like the cockpit-ovirt project doesn't have all hooks enabled, = current these are the hooks its using: /home/gerrit2/review_site/hooks/cust= om_hooks/update_tracker /home/gerrit2/review_site/hooks/custom_hooks/commen= t-added.propagate_review_values If we want that the hooks will also update = bz status and do other verification like backporing, we need to add more ho= oks. [~sbonazzo(a)redhat.com] [~msivak(a)redhat.com] please comment which h= ooks you'd like to enable or all of them. Info on the hooks can be found he= re :http://ovirt= -infra-docs.readthedocs.io/en/latest/General/Creating_Gerrit_Projects/index= .html#enabling-custom-gerrit-hooks [~amarchuk] fyi

— This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#1000= 76)

3D"" ------------=3D_1516193921-24843-123-- --===============2673347766492475807== Content-Type: multipart/alternative MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="attachment.bin" VGhpcyBpcyBhIG11bHRpLXBhcnQgbWVzc2FnZSBpbiBNSU1FIGZvcm1hdC4uLgoKLS0tLS0tLS0t LS0tPV8xNTE2MTkzOTIxLTI0ODQzLTEyMwpDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJz ZXQ9VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogN2JpdAoKCiAgICBbIGh0dHBzOi8v b3ZpcnQtamlyYS5hdGxhc3NpYW4ubmV0L2Jyb3dzZS9PVklSVC0xODQ5P3BhZ2U9Y29tLmF0bGFz c2lhbi5qaXJhLnBsdWdpbi5zeXN0ZW0uaXNzdWV0YWJwYW5lbHM6Y29tbWVudC10YWJwYW5lbCZm b2N1c2VkQ29tbWVudElkPTM1Njc3I2NvbW1lbnQtMzU2NzcgXSAKClJ5YW4gQmFycnkgY29tbWVu dGVkIG9uIE9WSVJULTE4NDk6Ci0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCgpJ IGRvbid0IHNlZSBhIGdvb2QgcmVhc29uIG5vdCB0byBlbmFibGUgYWxsIG9mIHRoZW0uCgpBdCBh IG1pbmltdW0sIHNldF9tb2RpZmllZCB3b3VsZCBiZSBncmVhdAoKPiBlbmFibGUgYWxsIGdlcnJp dCBob29rcyBmb3IgY29ja3BpdC1vdmlydCBwcm9qZWN0Cj4gLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+Cj4gICAgICAgICAgICAgICAgIEtleTogT1ZJ UlQtMTg0OQo+ICAgICAgICAgICAgICAgICBVUkw6IGh0dHBzOi8vb3ZpcnQtamlyYS5hdGxhc3Np YW4ubmV0L2Jyb3dzZS9PVklSVC0xODQ5Cj4gICAgICAgICAgICAgUHJvamVjdDogb1ZpcnQgLSB2 aXJ0dWFsaXphdGlvbiBtYWRlIGVhc3kKPiAgICAgICAgICBJc3N1ZSBUeXBlOiBUYXNrCj4gICAg ICAgICAgICBSZXBvcnRlcjogZXlhbCBlZHJpCj4gICAgICAgICAgICBBc3NpZ25lZTogaW5mcmEK Pgo+IEl0IGxvb2tzIGxpa2UgdGhlIGNvY2twaXQtb3ZpcnQgcHJvamVjdCBkb2Vzbid0IGhhdmUg YWxsIGhvb2tzIGVuYWJsZWQsIGN1cnJlbnQgdGhlc2UgYXJlIHRoZSBob29rcyBpdHMgdXNpbmc6 Cj4gL2hvbWUvZ2Vycml0Mi9yZXZpZXdfc2l0ZS9ob29rcy9jdXN0b21faG9va3MvdXBkYXRlX3Ry YWNrZXIKPiAvaG9tZS9nZXJyaXQyL3Jldmlld19zaXRlL2hvb2tzL2N1c3RvbV9ob29rcy9jb21t ZW50LWFkZGVkLnByb3BhZ2F0ZV9yZXZpZXdfdmFsdWVzCj4gSWYgd2Ugd2FudCB0aGF0IHRoZSBo b29rcyB3aWxsIGFsc28gdXBkYXRlIGJ6IHN0YXR1cyBhbmQgZG8gb3RoZXIgdmVyaWZpY2F0aW9u IGxpa2UgYmFja3BvcmluZywgd2UgbmVlZCB0byBhZGQgbW9yZSBob29rcy4KPiBbfnNib25henpv QHJlZGhhdC5jb21dIFt+bXNpdmFrQHJlZGhhdC5jb21dIHBsZWFzZSBjb21tZW50IHdoaWNoIGhv b2tzIHlvdSdkIGxpa2UgdG8gZW5hYmxlIG9yIGFsbCBvZiB0aGVtLgo+IEluZm8gb24gdGhlIGhv b2tzIGNhbiBiZSBmb3VuZCBoZXJlIDpodHRwOi8vb3ZpcnQtaW5mcmEtZG9jcy5yZWFkdGhlZG9j cy5pby9lbi9sYXRlc3QvR2VuZXJhbC9DcmVhdGluZ19HZXJyaXRfUHJvamVjdHMvaW5kZXguaHRt bCNlbmFibGluZy1jdXN0b20tZ2Vycml0LWhvb2tzCj4gW35hbWFyY2h1a10gZnlpCgoKCi0tClRo aXMgbWVzc2FnZSB3YXMgc2VudCBieSBBdGxhc3NpYW4gSmlyYQoodjEwMDEuMC4wLVNOQVBTSE9U IzEwMDA3NikKCi0tLS0tLS0tLS0tLT1fMTUxNjE5MzkyMS0yNDg0My0xMjMKQ29udGVudC1UeXBl OiB0ZXh0L2h0bWw7IGNoYXJzZXQ9IlVURi04IgpDb250ZW50LURpc3Bvc2l0aW9uOiBpbmxpbmUK Q29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogN2JpdAoKPGh0bWw+PGJvZHk+CjxwcmU+WyBodHRw czovL292aXJ0LWppcmEuYXRsYXNzaWFuLm5ldC9icm93c2UvT1ZJUlQtMTg0OT9wYWdlPWNvbS5h dGxhc3NpYW4uamlyYS5wbHVnaW4uc3lzdGVtLmlzc3VldGFicGFuZWxzOmNvbW1lbnQtdGFicGFu ZWwmYW1wO2ZvY3VzZWRDb21tZW50SWQ9MzU2NzcjY29tbWVudC0zNTY3NyBdPC9wcmU+CjxoMz5S eWFuIEJhcnJ5IGNvbW1lbnRlZCBvbiBPVklSVC0xODQ5OjwvaDM+CjxwPkkgZG9uJ3Qgc2VlIGEg Z29vZCByZWFzb24gbm90IHRvIGVuYWJsZSBhbGwgb2YgdGhlbS48L3A+CjxwPkF0IGEgbWluaW11 bSwgc2V0X21vZGlmaWVkIHdvdWxkIGJlIGdyZWF0PC9wPgo8YmxvY2txdW90ZT48aDM+ZW5hYmxl IGFsbCBnZXJyaXQgaG9va3MgZm9yIGNvY2twaXQtb3ZpcnQgcHJvamVjdDwvaDM+CjxwcmU+ICAg ICBLZXk6IE9WSVJULTE4NDkKICAgICBVUkw6IGh0dHBzOi8vb3ZpcnQtamlyYS5hdGxhc3NpYW4u bmV0L2Jyb3dzZS9PVklSVC0xODQ5CiBQcm9qZWN0OiBvVmlydCAtIHZpcnR1YWxpemF0aW9uIG1h ZGUgZWFzeQogICAgICAgICBJc3N1ZSBUeXBlOiBUYXNrClJlcG9ydGVyOiBleWFsIGVkcmkKQXNz aWduZWU6IGluZnJhPC9wcmU+CjxwPkl0IGxvb2tzIGxpa2UgdGhlIGNvY2twaXQtb3ZpcnQgcHJv amVjdCBkb2Vzbid0IGhhdmUgYWxsIGhvb2tzIGVuYWJsZWQsIGN1cnJlbnQgdGhlc2UgYXJlIHRo ZSBob29rcyBpdHMgdXNpbmc6IC9ob21lL2dlcnJpdDIvcmV2aWV3X3NpdGUvaG9va3MvY3VzdG9t X2hvb2tzL3VwZGF0ZV90cmFja2VyIC9ob21lL2dlcnJpdDIvcmV2aWV3X3NpdGUvaG9va3MvY3Vz dG9tX2hvb2tzL2NvbW1lbnQtYWRkZWQucHJvcGFnYXRlX3Jldmlld192YWx1ZXMgSWYgd2Ugd2Fu dCB0aGF0IHRoZSBob29rcyB3aWxsIGFsc28gdXBkYXRlIGJ6IHN0YXR1cyBhbmQgZG8gb3RoZXIg dmVyaWZpY2F0aW9uIGxpa2UgYmFja3BvcmluZywgd2UgbmVlZCB0byBhZGQgbW9yZSBob29rcy4g W35zYm9uYXp6b0ByZWRoYXQuY29tXSBbfm1zaXZha0ByZWRoYXQuY29tXSBwbGVhc2UgY29tbWVu dCB3aGljaCBob29rcyB5b3UnZCBsaWtlIHRvIGVuYWJsZSBvciBhbGwgb2YgdGhlbS4gSW5mbyBv biB0aGUgaG9va3MgY2FuIGJlIGZvdW5kIGhlcmUgOjxhIGhyZWY9Imh0dHA6Ly9vdmlydC1pbmZy YS1kb2NzLnJlYWR0aGVkb2NzLmlvL2VuL2xhdGVzdC9HZW5lcmFsL0NyZWF0aW5nX0dlcnJpdF9Q cm9qZWN0cy9pbmRleC5odG1sI2VuYWJsaW5nLWN1c3RvbS1nZXJyaXQtaG9va3MiPmh0dHA6Ly9v dmlydC1pbmZyYS1kb2NzLnJlYWR0aGVkb2NzLmlvL2VuL2xhdGVzdC9HZW5lcmFsL0NyZWF0aW5n X0dlcnJpdF9Qcm9qZWN0cy9pbmRleC5odG1sI2VuYWJsaW5nLWN1c3RvbS1nZXJyaXQtaG9va3M8 L2E+IFt+YW1hcmNodWtdIGZ5aTwvcD48L2Jsb2NrcXVvdGU+CjxwPiZtZGFzaDsgVGhpcyBtZXNz YWdlIHdhcyBzZW50IGJ5IEF0bGFzc2lhbiBKaXJhICh2MTAwMS4wLjAtU05BUFNIT1QjMTAwMDc2 KTwvcD4KCjxpbWcgc3JjPSJodHRwczovL3U0MDQzNDAyLmN0LnNlbmRncmlkLm5ldC93Zi9vcGVu P3Vwbj1pNVRNV0dWOTlhbUpiTnhKcFNwMi0yQkozM0JTTTN0dWlVZlJUazY0Sy0yQk9qRUo1WE5W S2ZwOGY0OWhlblBwRzk2VjE1MmJOdGFVV0tYWS0yQmU0dUNVZ2J3eW4tMkJSbmhYTjRjSy0yQnQw UVJQSnUzZWpRT2M2WGdobHZ0dXhIQlVQRHBZSkNDV0F1Z09VTVJRZFJ2MVNDVUQ3a0lYY2JCZWVq OXBnRzBNTWxaQ2pvRkVqaUJyY1J0UVk2Smx5aVNMbTJwT2FOVTY0NFdYdi0yQjRNM1JyRXoxRmdP VzZ2WnM0NlE2bWFFQWQ0YU04aEtESHotMkJ6TVpzLTJGR1Joa01ZWGtJbjJXME1ZWjdRTXhaVUI0 WUtMRkpXdDJBTHhtdXMtMkZ4NU1CMUZVYUVUeGNwTUtkQ3VSdU9uVWVmbnpuRlJzbXlrdTJwMDl1 LTJGWjNHaE11TlA0S2xZOTdySmVJVXNzOXM4RHY0STMwcU9JeWstMkY2clFNQkdkckFyWlpramJn eVVhcXRrWjhFUm9XUTk0WEVOaTJWUzNtRVplRENobkJFWjFBb0c2eDNneGJZUml2Ti0yRkxFZk5q cGF1Z1ZJQy0yRlFJRC0yQlJ0Zkd3cTlKSiIgYWx0PSIiIHdpZHRoPSIxIiBoZWlnaHQ9IjEiIGJv cmRlcj0iMCIgc3R5bGU9ImhlaWdodDoxcHggIWltcG9ydGFudDt3aWR0aDoxcHggIWltcG9ydGFu dDtib3JkZXItd2lkdGg6MCAhaW1wb3J0YW50O21hcmdpbi10b3A6MCAhaW1wb3J0YW50O21hcmdp bi1ib3R0b206MCAhaW1wb3J0YW50O21hcmdpbi1yaWdodDowICFpbXBvcnRhbnQ7bWFyZ2luLWxl ZnQ6MCAhaW1wb3J0YW50O3BhZGRpbmctdG9wOjAgIWltcG9ydGFudDtwYWRkaW5nLWJvdHRvbTow ICFpbXBvcnRhbnQ7cGFkZGluZy1yaWdodDowICFpbXBvcnRhbnQ7cGFkZGluZy1sZWZ0OjAgIWlt cG9ydGFudDsiLz4KPC9ib2R5PjwvaHRtbD4KCi0tLS0tLS0tLS0tLT1fMTUxNjE5MzkyMS0yNDg0 My0xMjMtLQo= --===============2673347766492475807==--