From jira at ovirt-jira.atlassian.net Tue Feb 13 10:16:20 2018 Content-Type: multipart/mixed; boundary="===============7908912055113950957==" MIME-Version: 1.0 From: Daniel Belenky (oVirt JIRA) To: infra at ovirt.org Subject: [JIRA] (OVIRT-1895) CI votes not forwarded on commit message change Date: Tue, 13 Feb 2018 10:16:15 +0000 Message-ID: In-Reply-To: JIRA.33587.1518508952000@Atlassian.JIRA --===============7908912055113950957== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable This is a multi-part message in MIME format... ------------=3D_1518516975-15615-100 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 7bit [ https://ovirt-jira.atlassian.net/browse/OVIRT-1895?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D35= 821#comment-35821 ] = Daniel Belenky commented on OVIRT-1895: --------------------------------------- It's a known bug that's coming from the Gerrit Trigger Plugin, the current= solution is not to push commit message changes if you have CI tests runnin= g. > CI votes not forwarded on commit message change > ----------------------------------------------- > > Key: OVIRT-1895 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1895 > Project: oVirt - virtualization made easy > Issue Type: By-EMAIL > Reporter: Yedidyah Bar David > Assignee: infra > > Hi all, > If a change goes through this flow: > 1. Push an update N > 2. CI triggers check-patch for N > 3. Push another update N+1 that changes only commit message > 4. CI marks +1 N > Then we have logic to not trigger CI for N+1 (with the assumption that > a change to commit message should not affect the result), but also do > not mark +1 N+1, leaving the patch unmarked. > We should either forward the +1, when giving it, to all consecutive > future patchsets that only changed the commit message, or give up on > the optimization and always trigger CI. > As an example, see: > https://gerrit.ovirt.org/87515 > Best regards, > -- = > Didi -- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100079) ------------=3D_1518516975-15615-100 Content-Type: text/html; charset=3D"UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1895?page=3Dcom.atlass=
ian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D35821#comment-35821 ]

Daniel Belenky commented on OVIRT-1895:

It's a known bug that's coming from the Gerrit Trigger Plugin, the curr= ent solution is not to push commit message changes if you have CI tests run= ning.

CI votes not forwarded on commit message change
     Key: OVIRT-1895
     URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1895
 Project: oVirt - virtualization made easy
         Issue Type: By-EMAIL
Reporter: Yedidyah Bar David
Assignee: infra
Hi all, If a change goes through this flow:

Push an update N

CI triggers check-patch for N

Push another update N+1 that changes only commit message

CI marks +1 N

Then we have logic to not trigger CI for N+1 (with the assumption that a= change to commit message should not affect the result), but also do not ma= rk +1 N+1, leaving the patch unmarked. We should either forward the +1, whe= n giving it, to all consecutive future patchsets that only changed the comm= it message, or give up on the optimization and always trigger CI. As an exa= mple, see: https://gerrit.ovirt.= org/87515 Best regards, — Didi

— This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#1000= 79)

------------=3D_1518516975-15615-100-- --===============7908912055113950957== Content-Type: multipart/alternative MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="attachment.bin" VGhpcyBpcyBhIG11bHRpLXBhcnQgbWVzc2FnZSBpbiBNSU1FIGZvcm1hdC4uLgoKLS0tLS0tLS0t LS0tPV8xNTE4NTE2OTc1LTE1NjE1LTEwMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJz ZXQ9VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogN2JpdAoKCiAgICBbIGh0dHBzOi8v b3ZpcnQtamlyYS5hdGxhc3NpYW4ubmV0L2Jyb3dzZS9PVklSVC0xODk1P3BhZ2U9Y29tLmF0bGFz c2lhbi5qaXJhLnBsdWdpbi5zeXN0ZW0uaXNzdWV0YWJwYW5lbHM6Y29tbWVudC10YWJwYW5lbCZm b2N1c2VkQ29tbWVudElkPTM1ODIxI2NvbW1lbnQtMzU4MjEgXSAKCkRhbmllbCBCZWxlbmt5IGNv bW1lbnRlZCBvbiBPVklSVC0xODk1OgotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KCkl0J3MgYSBrbm93biBidWcgdGhhdCdzIGNvbWluZyBmcm9tIHRoZSBHZXJyaXQgVHJp Z2dlciBQbHVnaW4sICB0aGUgY3VycmVudCBzb2x1dGlvbiBpcyBub3QgdG8gcHVzaCBjb21taXQg bWVzc2FnZSBjaGFuZ2VzIGlmIHlvdSBoYXZlIENJIHRlc3RzIHJ1bm5pbmcuCgo+IENJIHZvdGVz IG5vdCBmb3J3YXJkZWQgb24gY29tbWl0IG1lc3NhZ2UgY2hhbmdlCj4gLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPgo+ICAgICAgICAgICAgICAgICBLZXk6 IE9WSVJULTE4OTUKPiAgICAgICAgICAgICAgICAgVVJMOiBodHRwczovL292aXJ0LWppcmEuYXRs YXNzaWFuLm5ldC9icm93c2UvT1ZJUlQtMTg5NQo+ICAgICAgICAgICAgIFByb2plY3Q6IG9WaXJ0 IC0gdmlydHVhbGl6YXRpb24gbWFkZSBlYXN5Cj4gICAgICAgICAgSXNzdWUgVHlwZTogQnktRU1B SUwKPiAgICAgICAgICAgIFJlcG9ydGVyOiBZZWRpZHlhaCBCYXIgRGF2aWQKPiAgICAgICAgICAg IEFzc2lnbmVlOiBpbmZyYQo+Cj4gSGkgYWxsLAo+IElmIGEgY2hhbmdlIGdvZXMgdGhyb3VnaCB0 aGlzIGZsb3c6Cj4gMS4gUHVzaCBhbiB1cGRhdGUgTgo+IDIuIENJIHRyaWdnZXJzIGNoZWNrLXBh dGNoIGZvciBOCj4gMy4gUHVzaCBhbm90aGVyIHVwZGF0ZSBOKzEgdGhhdCBjaGFuZ2VzIG9ubHkg Y29tbWl0IG1lc3NhZ2UKPiA0LiBDSSBtYXJrcyArMSBOCj4gVGhlbiB3ZSBoYXZlIGxvZ2ljIHRv IG5vdCB0cmlnZ2VyIENJIGZvciBOKzEgKHdpdGggdGhlIGFzc3VtcHRpb24gdGhhdAo+IGEgY2hh bmdlIHRvIGNvbW1pdCBtZXNzYWdlIHNob3VsZCBub3QgYWZmZWN0IHRoZSByZXN1bHQpLCBidXQg YWxzbyBkbwo+IG5vdCBtYXJrICsxIE4rMSwgbGVhdmluZyB0aGUgcGF0Y2ggdW5tYXJrZWQuCj4g V2Ugc2hvdWxkIGVpdGhlciBmb3J3YXJkIHRoZSArMSwgd2hlbiBnaXZpbmcgaXQsIHRvIGFsbCBj b25zZWN1dGl2ZQo+IGZ1dHVyZSBwYXRjaHNldHMgdGhhdCBvbmx5IGNoYW5nZWQgdGhlIGNvbW1p dCBtZXNzYWdlLCBvciBnaXZlIHVwIG9uCj4gdGhlIG9wdGltaXphdGlvbiBhbmQgYWx3YXlzIHRy aWdnZXIgQ0kuCj4gQXMgYW4gZXhhbXBsZSwgc2VlOgo+IGh0dHBzOi8vZ2Vycml0Lm92aXJ0Lm9y Zy84NzUxNQo+IEJlc3QgcmVnYXJkcywKPiAtLSAKPiBEaWRpCgoKCi0tClRoaXMgbWVzc2FnZSB3 YXMgc2VudCBieSBBdGxhc3NpYW4gSmlyYQoodjEwMDEuMC4wLVNOQVBTSE9UIzEwMDA3OSkKCi0t LS0tLS0tLS0tLT1fMTUxODUxNjk3NS0xNTYxNS0xMDAKQ29udGVudC1UeXBlOiB0ZXh0L2h0bWw7 IGNoYXJzZXQ9IlVURi04IgpDb250ZW50LURpc3Bvc2l0aW9uOiBpbmxpbmUKQ29udGVudC1UcmFu c2Zlci1FbmNvZGluZzogN2JpdAoKPGh0bWw+PGJvZHk+CjxwcmU+WyBodHRwczovL292aXJ0LWpp cmEuYXRsYXNzaWFuLm5ldC9icm93c2UvT1ZJUlQtMTg5NT9wYWdlPWNvbS5hdGxhc3NpYW4uamly YS5wbHVnaW4uc3lzdGVtLmlzc3VldGFicGFuZWxzOmNvbW1lbnQtdGFicGFuZWwmYW1wO2ZvY3Vz ZWRDb21tZW50SWQ9MzU4MjEjY29tbWVudC0zNTgyMSBdPC9wcmU+CjxoMz5EYW5pZWwgQmVsZW5r eSBjb21tZW50ZWQgb24gT1ZJUlQtMTg5NTo8L2gzPgo8cD5JdCdzIGEga25vd24gYnVnIHRoYXQn cyBjb21pbmcgZnJvbSB0aGUgR2Vycml0IFRyaWdnZXIgUGx1Z2luLCAgdGhlIGN1cnJlbnQgc29s dXRpb24gaXMgbm90IHRvIHB1c2ggY29tbWl0IG1lc3NhZ2UgY2hhbmdlcyBpZiB5b3UgaGF2ZSBD SSB0ZXN0cyBydW5uaW5nLjwvcD4KPGJsb2NrcXVvdGU+PGgzPkNJIHZvdGVzIG5vdCBmb3J3YXJk ZWQgb24gY29tbWl0IG1lc3NhZ2UgY2hhbmdlPC9oMz4KPHByZT4gICAgIEtleTogT1ZJUlQtMTg5 NQogICAgIFVSTDogaHR0cHM6Ly9vdmlydC1qaXJhLmF0bGFzc2lhbi5uZXQvYnJvd3NlL09WSVJU LTE4OTUKIFByb2plY3Q6IG9WaXJ0IC0gdmlydHVhbGl6YXRpb24gbWFkZSBlYXN5CiAgICAgICAg IElzc3VlIFR5cGU6IEJ5LUVNQUlMClJlcG9ydGVyOiBZZWRpZHlhaCBCYXIgRGF2aWQKQXNzaWdu ZWU6IGluZnJhPC9wcmU+CjxwPkhpIGFsbCwgSWYgYSBjaGFuZ2UgZ29lcyB0aHJvdWdoIHRoaXMg Zmxvdzo8L3A+CjxvbD48bGk+PHA+UHVzaCBhbiB1cGRhdGUgTjwvcD48L2xpPgo8bGk+PHA+Q0kg dHJpZ2dlcnMgY2hlY2stcGF0Y2ggZm9yIE48L3A+PC9saT4KPGxpPjxwPlB1c2ggYW5vdGhlciB1 cGRhdGUgTisxIHRoYXQgY2hhbmdlcyBvbmx5IGNvbW1pdCBtZXNzYWdlPC9wPjwvbGk+CjxsaT48 cD5DSSBtYXJrcyArMSBOPC9wPjwvbGk+PC9vbD4KPHA+VGhlbiB3ZSBoYXZlIGxvZ2ljIHRvIG5v dCB0cmlnZ2VyIENJIGZvciBOKzEgKHdpdGggdGhlIGFzc3VtcHRpb24gdGhhdCBhIGNoYW5nZSB0 byBjb21taXQgbWVzc2FnZSBzaG91bGQgbm90IGFmZmVjdCB0aGUgcmVzdWx0KSwgYnV0IGFsc28g ZG8gbm90IG1hcmsgKzEgTisxLCBsZWF2aW5nIHRoZSBwYXRjaCB1bm1hcmtlZC4gV2Ugc2hvdWxk IGVpdGhlciBmb3J3YXJkIHRoZSArMSwgd2hlbiBnaXZpbmcgaXQsIHRvIGFsbCBjb25zZWN1dGl2 ZSBmdXR1cmUgcGF0Y2hzZXRzIHRoYXQgb25seSBjaGFuZ2VkIHRoZSBjb21taXQgbWVzc2FnZSwg b3IgZ2l2ZSB1cCBvbiB0aGUgb3B0aW1pemF0aW9uIGFuZCBhbHdheXMgdHJpZ2dlciBDSS4gQXMg YW4gZXhhbXBsZSwgc2VlOiA8YSBocmVmPSJodHRwczovL2dlcnJpdC5vdmlydC5vcmcvODc1MTUi Pmh0dHBzOi8vZ2Vycml0Lm92aXJ0Lm9yZy84NzUxNTwvYT4gQmVzdCByZWdhcmRzLCAmbWRhc2g7 IERpZGk8L3A+PC9ibG9ja3F1b3RlPgo8cD4mbWRhc2g7IFRoaXMgbWVzc2FnZSB3YXMgc2VudCBi eSBBdGxhc3NpYW4gSmlyYSAodjEwMDEuMC4wLVNOQVBTSE9UIzEwMDA3OSk8L3A+Cgo8aW1nIHNy Yz0iaHR0cHM6Ly91NDA0MzQwMi5jdC5zZW5kZ3JpZC5uZXQvd2Yvb3Blbj91cG49aTVUTVdHVjk5 YW1KYk54SnBTcDItMkJKMzNCU00zdHVpVWZSVGs2NEstMkJPakg2T2ZId0hGMDdLYldnS2lWNmdt M21CMUlJMThCU0J0WFBSRWowV2tqZnFBZ1hXbnNodk5taTNnN2hmN2t2N0ZxQmtpMlJaemdGYnFS bks5Z29xcUprY0Fpelc3bm9pN0VweUM3Q3lxNG01TGNGWTdnRjFkZlBBNzFjdERKdjFpdFA1NUo0 VGFJUTBPVk9GUEtMbEVrRHF2UjV6dS0yQk9pVXZNbXpFSkliTVFFZGQ1VElYZDBFVUlyWnpwV2sw QWNidGE1aXktMkJXZWNPRC0yRk1ZQ3JPdE5KZWxNVTh2UHBpanVHRXR2b2lIeFh2NkNlLTJCY2hi a0tnWENBeFgzQ0JMbjFYcUpzSjl0ak83SWZkcnp5LTJCSExvMUtTRGowRE5zd1kzNlF2UmQ5Uy0y RjBZLTJGSkhXc3l3cElSZFk3SmR5SUNYMG9BTUVlanpGQU9mLTJGa2FrU1ZyQVNnT2dEdWhmT2cw dHNwVnBwTGE1eUZxbnJmdHBxVllUZjNmYVoyMkgxSlBpNkVXVmpmUDJISWstMkJMSzYxQm1QTDJS MUVMMUoiIGFsdD0iIiB3aWR0aD0iMSIgaGVpZ2h0PSIxIiBib3JkZXI9IjAiIHN0eWxlPSJoZWln aHQ6MXB4ICFpbXBvcnRhbnQ7d2lkdGg6MXB4ICFpbXBvcnRhbnQ7Ym9yZGVyLXdpZHRoOjAgIWlt cG9ydGFudDttYXJnaW4tdG9wOjAgIWltcG9ydGFudDttYXJnaW4tYm90dG9tOjAgIWltcG9ydGFu dDttYXJnaW4tcmlnaHQ6MCAhaW1wb3J0YW50O21hcmdpbi1sZWZ0OjAgIWltcG9ydGFudDtwYWRk aW5nLXRvcDowICFpbXBvcnRhbnQ7cGFkZGluZy1ib3R0b206MCAhaW1wb3J0YW50O3BhZGRpbmct cmlnaHQ6MCAhaW1wb3J0YW50O3BhZGRpbmctbGVmdDowICFpbXBvcnRhbnQ7Ii8+CjwvYm9keT48 L2h0bWw+CgotLS0tLS0tLS0tLS09XzE1MTg1MTY5NzUtMTU2MTUtMTAwLS0K --===============7908912055113950957==--