From jira at ovirt-jira.atlassian.net Wed Feb 14 07:12:56 2018 Content-Type: multipart/mixed; boundary="===============6880814288057024700==" MIME-Version: 1.0 From: Barak Korren (oVirt JIRA) To: infra at ovirt.org Subject: [JIRA] (OVIRT-1895) CI votes not forwarded on commit message change Date: Wed, 14 Feb 2018 07:12:53 +0000 Message-ID: In-Reply-To: JIRA.33587.1518508952000@Atlassian.JIRA --===============6880814288057024700== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable This is a multi-part message in MIME format... ------------=3D_1518592373-16157-109 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 7bit [ https://ovirt-jira.atlassian.net/browse/OVIRT-1895?page=3Dcom.atlass= ian.jira.plugin.system.issuetabpanels:all-tabpanel ] Barak Korren updated OVIRT-1895: -------------------------------- Resolution: Duplicate Status: Done (was: To Do) > CI votes not forwarded on commit message change > ----------------------------------------------- > > Key: OVIRT-1895 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1895 > Project: oVirt - virtualization made easy > Issue Type: Bug > Components: Gerrit/git > Reporter: Yedidyah Bar David > Assignee: infra > > Hi all, > If a change goes through this flow: > 1. Push an update N > 2. CI triggers check-patch for N > 3. Push another update N+1 that changes only commit message > 4. CI marks +1 N > Then we have logic to not trigger CI for N+1 (with the assumption that > a change to commit message should not affect the result), but also do > not mark +1 N+1, leaving the patch unmarked. > We should either forward the +1, when giving it, to all consecutive > future patchsets that only changed the commit message, or give up on > the optimization and always trigger CI. > As an example, see: > https://gerrit.ovirt.org/87515 > Best regards, > -- = > Didi -- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100079) ------------=3D_1518592373-16157-109 Content-Type: text/html; charset=3D"UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1895?page=3Dcom.atlass=
ian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Barak Korren updated OVIRT-1895:

Resolution: Duplicate
    Status: Done  (was: To Do)

CI votes not forwarded on commit message change
     Key: OVIRT-1895
     URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1895
 Project: oVirt - virtualization made easy
         Issue Type: Bug
         Components: Gerrit/git
Reporter: Yedidyah Bar David
Assignee: infra
Hi all, If a change goes through this flow:

Push an update N

CI triggers check-patch for N

Push another update N+1 that changes only commit message

CI marks +1 N

Then we have logic to not trigger CI for N+1 (with the assumption that a= change to commit message should not affect the result), but also do not ma= rk +1 N+1, leaving the patch unmarked. We should either forward the +1, whe= n giving it, to all consecutive future patchsets that only changed the comm= it message, or give up on the optimization and always trigger CI. As an exa= mple, see: https://gerrit.ovirt.= org/87515 Best regards, — Didi

— This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#1000= 79)

------------=3D_1518592373-16157-109-- --===============6880814288057024700== Content-Type: multipart/alternative MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="attachment.bin" VGhpcyBpcyBhIG11bHRpLXBhcnQgbWVzc2FnZSBpbiBNSU1FIGZvcm1hdC4uLgoKLS0tLS0tLS0t LS0tPV8xNTE4NTkyMzczLTE2MTU3LTEwOQpDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJz ZXQ9VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogN2JpdAoKCiAgICAgWyBodHRwczov L292aXJ0LWppcmEuYXRsYXNzaWFuLm5ldC9icm93c2UvT1ZJUlQtMTg5NT9wYWdlPWNvbS5hdGxh c3NpYW4uamlyYS5wbHVnaW4uc3lzdGVtLmlzc3VldGFicGFuZWxzOmFsbC10YWJwYW5lbCBdCgpC YXJhayBLb3JyZW4gdXBkYXRlZCBPVklSVC0xODk1OgotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLQogICAgUmVzb2x1dGlvbjogRHVwbGljYXRlCiAgICAgICAgU3RhdHVzOiBEb25lICAo d2FzOiBUbyBEbykKCj4gQ0kgdm90ZXMgbm90IGZvcndhcmRlZCBvbiBjb21taXQgbWVzc2FnZSBj aGFuZ2UKPiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ Cj4gICAgICAgICAgICAgICAgIEtleTogT1ZJUlQtMTg5NQo+ICAgICAgICAgICAgICAgICBVUkw6 IGh0dHBzOi8vb3ZpcnQtamlyYS5hdGxhc3NpYW4ubmV0L2Jyb3dzZS9PVklSVC0xODk1Cj4gICAg ICAgICAgICAgUHJvamVjdDogb1ZpcnQgLSB2aXJ0dWFsaXphdGlvbiBtYWRlIGVhc3kKPiAgICAg ICAgICBJc3N1ZSBUeXBlOiBCdWcKPiAgICAgICAgICBDb21wb25lbnRzOiBHZXJyaXQvZ2l0Cj4g ICAgICAgICAgICBSZXBvcnRlcjogWWVkaWR5YWggQmFyIERhdmlkCj4gICAgICAgICAgICBBc3Np Z25lZTogaW5mcmEKPgo+IEhpIGFsbCwKPiBJZiBhIGNoYW5nZSBnb2VzIHRocm91Z2ggdGhpcyBm bG93Ogo+IDEuIFB1c2ggYW4gdXBkYXRlIE4KPiAyLiBDSSB0cmlnZ2VycyBjaGVjay1wYXRjaCBm b3IgTgo+IDMuIFB1c2ggYW5vdGhlciB1cGRhdGUgTisxIHRoYXQgY2hhbmdlcyBvbmx5IGNvbW1p dCBtZXNzYWdlCj4gNC4gQ0kgbWFya3MgKzEgTgo+IFRoZW4gd2UgaGF2ZSBsb2dpYyB0byBub3Qg dHJpZ2dlciBDSSBmb3IgTisxICh3aXRoIHRoZSBhc3N1bXB0aW9uIHRoYXQKPiBhIGNoYW5nZSB0 byBjb21taXQgbWVzc2FnZSBzaG91bGQgbm90IGFmZmVjdCB0aGUgcmVzdWx0KSwgYnV0IGFsc28g ZG8KPiBub3QgbWFyayArMSBOKzEsIGxlYXZpbmcgdGhlIHBhdGNoIHVubWFya2VkLgo+IFdlIHNo b3VsZCBlaXRoZXIgZm9yd2FyZCB0aGUgKzEsIHdoZW4gZ2l2aW5nIGl0LCB0byBhbGwgY29uc2Vj dXRpdmUKPiBmdXR1cmUgcGF0Y2hzZXRzIHRoYXQgb25seSBjaGFuZ2VkIHRoZSBjb21taXQgbWVz c2FnZSwgb3IgZ2l2ZSB1cCBvbgo+IHRoZSBvcHRpbWl6YXRpb24gYW5kIGFsd2F5cyB0cmlnZ2Vy IENJLgo+IEFzIGFuIGV4YW1wbGUsIHNlZToKPiBodHRwczovL2dlcnJpdC5vdmlydC5vcmcvODc1 MTUKPiBCZXN0IHJlZ2FyZHMsCj4gLS0gCj4gRGlkaQoKCgotLQpUaGlzIG1lc3NhZ2Ugd2FzIHNl bnQgYnkgQXRsYXNzaWFuIEppcmEKKHYxMDAxLjAuMC1TTkFQU0hPVCMxMDAwNzkpCgotLS0tLS0t LS0tLS09XzE1MTg1OTIzNzMtMTYxNTctMTA5CkNvbnRlbnQtVHlwZTogdGV4dC9odG1sOyBjaGFy c2V0PSJVVEYtOCIKQ29udGVudC1EaXNwb3NpdGlvbjogaW5saW5lCkNvbnRlbnQtVHJhbnNmZXIt RW5jb2Rpbmc6IDdiaXQKCjxodG1sPjxib2R5Pgo8cHJlPlsgaHR0cHM6Ly9vdmlydC1qaXJhLmF0 bGFzc2lhbi5uZXQvYnJvd3NlL09WSVJULTE4OTU/cGFnZT1jb20uYXRsYXNzaWFuLmppcmEucGx1 Z2luLnN5c3RlbS5pc3N1ZXRhYnBhbmVsczphbGwtdGFicGFuZWwgXTwvcHJlPgo8aDM+QmFyYWsg S29ycmVuIHVwZGF0ZWQgT1ZJUlQtMTg5NTo8L2gzPgo8cHJlPlJlc29sdXRpb246IER1cGxpY2F0 ZQogICAgU3RhdHVzOiBEb25lICAod2FzOiBUbyBEbyk8L3ByZT4KPGJsb2NrcXVvdGU+PGgzPkNJ IHZvdGVzIG5vdCBmb3J3YXJkZWQgb24gY29tbWl0IG1lc3NhZ2UgY2hhbmdlPC9oMz4KPHByZT4g ICAgIEtleTogT1ZJUlQtMTg5NQogICAgIFVSTDogaHR0cHM6Ly9vdmlydC1qaXJhLmF0bGFzc2lh bi5uZXQvYnJvd3NlL09WSVJULTE4OTUKIFByb2plY3Q6IG9WaXJ0IC0gdmlydHVhbGl6YXRpb24g bWFkZSBlYXN5CiAgICAgICAgIElzc3VlIFR5cGU6IEJ1ZwogICAgICAgICBDb21wb25lbnRzOiBH ZXJyaXQvZ2l0ClJlcG9ydGVyOiBZZWRpZHlhaCBCYXIgRGF2aWQKQXNzaWduZWU6IGluZnJhPC9w cmU+CjxwPkhpIGFsbCwgSWYgYSBjaGFuZ2UgZ29lcyB0aHJvdWdoIHRoaXMgZmxvdzo8L3A+Cjxv bD48bGk+PHA+UHVzaCBhbiB1cGRhdGUgTjwvcD48L2xpPgo8bGk+PHA+Q0kgdHJpZ2dlcnMgY2hl Y2stcGF0Y2ggZm9yIE48L3A+PC9saT4KPGxpPjxwPlB1c2ggYW5vdGhlciB1cGRhdGUgTisxIHRo YXQgY2hhbmdlcyBvbmx5IGNvbW1pdCBtZXNzYWdlPC9wPjwvbGk+CjxsaT48cD5DSSBtYXJrcyAr MSBOPC9wPjwvbGk+PC9vbD4KPHA+VGhlbiB3ZSBoYXZlIGxvZ2ljIHRvIG5vdCB0cmlnZ2VyIENJ IGZvciBOKzEgKHdpdGggdGhlIGFzc3VtcHRpb24gdGhhdCBhIGNoYW5nZSB0byBjb21taXQgbWVz c2FnZSBzaG91bGQgbm90IGFmZmVjdCB0aGUgcmVzdWx0KSwgYnV0IGFsc28gZG8gbm90IG1hcmsg KzEgTisxLCBsZWF2aW5nIHRoZSBwYXRjaCB1bm1hcmtlZC4gV2Ugc2hvdWxkIGVpdGhlciBmb3J3 YXJkIHRoZSArMSwgd2hlbiBnaXZpbmcgaXQsIHRvIGFsbCBjb25zZWN1dGl2ZSBmdXR1cmUgcGF0 Y2hzZXRzIHRoYXQgb25seSBjaGFuZ2VkIHRoZSBjb21taXQgbWVzc2FnZSwgb3IgZ2l2ZSB1cCBv biB0aGUgb3B0aW1pemF0aW9uIGFuZCBhbHdheXMgdHJpZ2dlciBDSS4gQXMgYW4gZXhhbXBsZSwg c2VlOiA8YSBocmVmPSJodHRwczovL2dlcnJpdC5vdmlydC5vcmcvODc1MTUiPmh0dHBzOi8vZ2Vy cml0Lm92aXJ0Lm9yZy84NzUxNTwvYT4gQmVzdCByZWdhcmRzLCAmbWRhc2g7IERpZGk8L3A+PC9i bG9ja3F1b3RlPgo8cD4mbWRhc2g7IFRoaXMgbWVzc2FnZSB3YXMgc2VudCBieSBBdGxhc3NpYW4g SmlyYSAodjEwMDEuMC4wLVNOQVBTSE9UIzEwMDA3OSk8L3A+Cgo8aW1nIHNyYz0iaHR0cHM6Ly91 NDA0MzQwMi5jdC5zZW5kZ3JpZC5uZXQvd2Yvb3Blbj91cG49aTVUTVdHVjk5YW1KYk54SnBTcDIt MkJKMzNCU00zdHVpVWZSVGs2NEstMkJPakdwRi0yQnVNem9KUlJCMWlmelpJRXJ0SXhUY2NMeTUy MXp6N094WlZpQjVtbnBiYndZSkZ6NmZsZ2V2WE96VUpWSC0yRnFCcXZjcXFxS0lwM3A0T2N5REZP c1J3dmFMazFyN1g4SnBMRWJiWXRRLTJGOHNlLTJGQW9HM05xTXk2TUVGOTYwZk00V0NmQXJJUGlw REF4VjNJOVF0RHh3SVprZU5XRDl5QXBQc2RKcmEzVjROVDdoSU9vVGlmNDZoTjlBMk5hLTJCSXNl SG5nU1NPenJTUG84N1hzNWRsVE9wcEU4eWpIM0lvWUNRd2wxWkh6aFA5NWwyUVZvamNQTTRVMFVt Z0RNdHhka3lONDdRWkRKVEwtMkZSLTJGeDJ1cHVmN3o4a2FBMk8tMkJ3T3hhQ3I3MVdvanNualRD bTVTRTdjUHdESTUtMkJtOGtoWG9HNnBKckl5cjd2QUxyekJXaGtVVkZuSGhNdTgtMkZqdXYtMkIz bjJVR1pMenNyaURmV2oybnhaNVd0eEo4WUFOSkpmNVFCZ1ZJRU91QVJsaUZZSXlNaVZFQmlZIiBh bHQ9IiIgd2lkdGg9IjEiIGhlaWdodD0iMSIgYm9yZGVyPSIwIiBzdHlsZT0iaGVpZ2h0OjFweCAh aW1wb3J0YW50O3dpZHRoOjFweCAhaW1wb3J0YW50O2JvcmRlci13aWR0aDowICFpbXBvcnRhbnQ7 bWFyZ2luLXRvcDowICFpbXBvcnRhbnQ7bWFyZ2luLWJvdHRvbTowICFpbXBvcnRhbnQ7bWFyZ2lu LXJpZ2h0OjAgIWltcG9ydGFudDttYXJnaW4tbGVmdDowICFpbXBvcnRhbnQ7cGFkZGluZy10b3A6 MCAhaW1wb3J0YW50O3BhZGRpbmctYm90dG9tOjAgIWltcG9ydGFudDtwYWRkaW5nLXJpZ2h0OjAg IWltcG9ydGFudDtwYWRkaW5nLWxlZnQ6MCAhaW1wb3J0YW50OyIvPgo8L2JvZHk+PC9odG1sPgoK LS0tLS0tLS0tLS0tPV8xNTE4NTkyMzczLTE2MTU3LTEwOS0tCg== --===============6880814288057024700==--