From jira at ovirt-jira.atlassian.net Mon Jan 1 15:04:21 2018 Content-Type: multipart/mixed; boundary="===============8104608170561873303==" MIME-Version: 1.0 From: Barak Korren (oVirt JIRA) To: infra at ovirt.org Subject: [JIRA] (OVIRT-1821) jenkins 'check-patch.sh' does not always generate differences.html in downstream repos Date: Mon, 01 Jan 2018 15:04:19 +0000 Message-ID: In-Reply-To: JIRA.33368.1514819058000@Atlassian.JIRA --===============8104608170561873303== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable This is a multi-part message in MIME format... ------------=3D_1514819059-25030-101 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 7bit Barak Korren created OVIRT-1821: ----------------------------------- Summary: jenkins 'check-patch.sh' does not always generate dif= ferences.html in downstream repos Key: OVIRT-1821 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1821 Project: oVirt - virtualization made easy Issue Type: Bug Reporter: Barak Korren Assignee: infra The 'check-patch.sh' script in the 'jenkins' repo knows how to generate a '= differences.html' file when job YAML changes. The 'jenkins' repo is designed to be used as an upstream source repo for ot= her repos, and it is designed that 'check-patch.sh' will be usable on those= DS repos. When YAML changes from the 'jenkins' repo make it into the DS repos via a = patch to the 'upstream-sources.yaml' file in the DS repo, and 'check-patch.= sh' runs on that repo, 'differences.html' is not being generated, because t= he change to 'upstream-sources.yaml' does not look like a job YAML change. We need to change 'check-patch.sh' so that when running in a DS repo, it k= nows how to look and diagnose changes coming from the upstream repo. -- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100075) ------------=3D_1514819059-25030-101 Content-Type: text/html; charset=3D"UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit

Barak Korren created OVIRT-1821:

   Summary: jenkins 'check-patch.sh' does not always generate differen=
ces.html in downstream repos
       Key: OVIRT-1821
       URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1821
   Project: oVirt - virtualization made easy
Issue Type: Bug
  Reporter: Barak Korren
  Assignee: infra

The ‘check-patch.sh’ script in the ‘jenkins’ rep= o knows how to generate a ‘differences.html’ file when job YAML= changes.

The ‘jenkins’ repo is designed to be used as an upstream sou= rce repo for other repos, and it is designed that ‘check-patch.sh&rsq= uo; will be usable on those DS repos.

When YAML changes from the ‘jenkins’ repo make it into the = DS repos via a patch to the ‘upstream-sources.yaml’ file in the= DS repo, and ‘check-patch.sh’ runs on that repo, ‘differ= ences.html’ is not being generated, because the change to ‘upst= ream-sources.yaml’ does not look like a job YAML change.

We need to change ‘check-patch.sh’ so that when running in = a DS repo, it knows how to look and diagnose changes coming from the upstre= am repo.

— This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#1000= 75)

3D"" ------------=3D_1514819059-25030-101-- --===============8104608170561873303== Content-Type: multipart/alternative MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="attachment.bin" VGhpcyBpcyBhIG11bHRpLXBhcnQgbWVzc2FnZSBpbiBNSU1FIGZvcm1hdC4uLgoKLS0tLS0tLS0t LS0tPV8xNTE0ODE5MDU5LTI1MDMwLTEwMQpDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJz ZXQ9VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogN2JpdAoKQmFyYWsgS29ycmVuIGNy ZWF0ZWQgT1ZJUlQtMTgyMToKLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KCiAg ICAgICAgICAgICBTdW1tYXJ5OiBqZW5raW5zICdjaGVjay1wYXRjaC5zaCcgZG9lcyBub3QgYWx3 YXlzIGdlbmVyYXRlIGRpZmZlcmVuY2VzLmh0bWwgaW4gZG93bnN0cmVhbSByZXBvcwogICAgICAg ICAgICAgICAgIEtleTogT1ZJUlQtMTgyMQogICAgICAgICAgICAgICAgIFVSTDogaHR0cHM6Ly9v dmlydC1qaXJhLmF0bGFzc2lhbi5uZXQvYnJvd3NlL09WSVJULTE4MjEKICAgICAgICAgICAgIFBy b2plY3Q6IG9WaXJ0IC0gdmlydHVhbGl6YXRpb24gbWFkZSBlYXN5CiAgICAgICAgICBJc3N1ZSBU eXBlOiBCdWcKICAgICAgICAgICAgUmVwb3J0ZXI6IEJhcmFrIEtvcnJlbgogICAgICAgICAgICBB c3NpZ25lZTogaW5mcmEKCgpUaGUgJ2NoZWNrLXBhdGNoLnNoJyBzY3JpcHQgaW4gdGhlICdqZW5r aW5zJyByZXBvIGtub3dzIGhvdyB0byBnZW5lcmF0ZSBhICdkaWZmZXJlbmNlcy5odG1sJyBmaWxl IHdoZW4gam9iIFlBTUwgY2hhbmdlcy4KClRoZSAnamVua2lucycgcmVwbyBpcyBkZXNpZ25lZCB0 byBiZSB1c2VkIGFzIGFuIHVwc3RyZWFtIHNvdXJjZSByZXBvIGZvciBvdGhlciByZXBvcywgYW5k IGl0IGlzIGRlc2lnbmVkIHRoYXQgJ2NoZWNrLXBhdGNoLnNoJyB3aWxsIGJlIHVzYWJsZSBvbiB0 aG9zZSBEUyByZXBvcy4KCldoZW4gWUFNTCBjaGFuZ2VzIGZyb20gdGhlICdqZW5raW5zJyByZXBv ICBtYWtlIGl0IGludG8gdGhlIERTIHJlcG9zIHZpYSBhIHBhdGNoIHRvIHRoZSAndXBzdHJlYW0t c291cmNlcy55YW1sJyBmaWxlIGluIHRoZSBEUyByZXBvLCBhbmQgJ2NoZWNrLXBhdGNoLnNoJyBy dW5zIG9uIHRoYXQgcmVwbywgJ2RpZmZlcmVuY2VzLmh0bWwnIGlzIG5vdCBiZWluZyBnZW5lcmF0 ZWQsIGJlY2F1c2UgdGhlIGNoYW5nZSB0byAndXBzdHJlYW0tc291cmNlcy55YW1sJyBkb2VzIG5v dCBsb29rIGxpa2UgYSBqb2IgWUFNTCBjaGFuZ2UuCgpXZSBuZWVkIHRvICBjaGFuZ2UgJ2NoZWNr LXBhdGNoLnNoJyBzbyB0aGF0IHdoZW4gcnVubmluZyBpbiBhIERTIHJlcG8sIGl0IGtub3dzIGhv dyB0byBsb29rIGFuZCBkaWFnbm9zZSBjaGFuZ2VzIGNvbWluZyBmcm9tIHRoZSB1cHN0cmVhbSBy ZXBvLgoKCgotLQpUaGlzIG1lc3NhZ2Ugd2FzIHNlbnQgYnkgQXRsYXNzaWFuIEppcmEKKHYxMDAx LjAuMC1TTkFQU0hPVCMxMDAwNzUpCgotLS0tLS0tLS0tLS09XzE1MTQ4MTkwNTktMjUwMzAtMTAx CkNvbnRlbnQtVHlwZTogdGV4dC9odG1sOyBjaGFyc2V0PSJVVEYtOCIKQ29udGVudC1EaXNwb3Np dGlvbjogaW5saW5lCkNvbnRlbnQtVHJhbnNmZXItRW5jb2Rpbmc6IDdiaXQKCjxodG1sPjxib2R5 Pgo8aDM+QmFyYWsgS29ycmVuIGNyZWF0ZWQgT1ZJUlQtMTgyMTo8L2gzPgo8cHJlPiAgIFN1bW1h cnk6IGplbmtpbnMgJ2NoZWNrLXBhdGNoLnNoJyBkb2VzIG5vdCBhbHdheXMgZ2VuZXJhdGUgZGlm ZmVyZW5jZXMuaHRtbCBpbiBkb3duc3RyZWFtIHJlcG9zCiAgICAgICBLZXk6IE9WSVJULTE4MjEK ICAgICAgIFVSTDogaHR0cHM6Ly9vdmlydC1qaXJhLmF0bGFzc2lhbi5uZXQvYnJvd3NlL09WSVJU LTE4MjEKICAgUHJvamVjdDogb1ZpcnQgLSB2aXJ0dWFsaXphdGlvbiBtYWRlIGVhc3kKSXNzdWUg VHlwZTogQnVnCiAgUmVwb3J0ZXI6IEJhcmFrIEtvcnJlbgogIEFzc2lnbmVlOiBpbmZyYTwvcHJl Pgo8cD5UaGUgJmxzcXVvO2NoZWNrLXBhdGNoLnNoJnJzcXVvOyBzY3JpcHQgaW4gdGhlICZsc3F1 bztqZW5raW5zJnJzcXVvOyByZXBvIGtub3dzIGhvdyB0byBnZW5lcmF0ZSBhICZsc3F1bztkaWZm ZXJlbmNlcy5odG1sJnJzcXVvOyBmaWxlIHdoZW4gam9iIFlBTUwgY2hhbmdlcy48L3A+CjxwPlRo ZSAmbHNxdW87amVua2lucyZyc3F1bzsgcmVwbyBpcyBkZXNpZ25lZCB0byBiZSB1c2VkIGFzIGFu IHVwc3RyZWFtIHNvdXJjZSByZXBvIGZvciBvdGhlciByZXBvcywgYW5kIGl0IGlzIGRlc2lnbmVk IHRoYXQgJmxzcXVvO2NoZWNrLXBhdGNoLnNoJnJzcXVvOyB3aWxsIGJlIHVzYWJsZSBvbiB0aG9z ZSBEUyByZXBvcy48L3A+CjxwPldoZW4gWUFNTCBjaGFuZ2VzIGZyb20gdGhlICZsc3F1bztqZW5r aW5zJnJzcXVvOyByZXBvICBtYWtlIGl0IGludG8gdGhlIERTIHJlcG9zIHZpYSBhIHBhdGNoIHRv IHRoZSAmbHNxdW87dXBzdHJlYW0tc291cmNlcy55YW1sJnJzcXVvOyBmaWxlIGluIHRoZSBEUyBy ZXBvLCBhbmQgJmxzcXVvO2NoZWNrLXBhdGNoLnNoJnJzcXVvOyBydW5zIG9uIHRoYXQgcmVwbywg JmxzcXVvO2RpZmZlcmVuY2VzLmh0bWwmcnNxdW87IGlzIG5vdCBiZWluZyBnZW5lcmF0ZWQsIGJl Y2F1c2UgdGhlIGNoYW5nZSB0byAmbHNxdW87dXBzdHJlYW0tc291cmNlcy55YW1sJnJzcXVvOyBk b2VzIG5vdCBsb29rIGxpa2UgYSBqb2IgWUFNTCBjaGFuZ2UuPC9wPgo8cD5XZSBuZWVkIHRvICBj aGFuZ2UgJmxzcXVvO2NoZWNrLXBhdGNoLnNoJnJzcXVvOyBzbyB0aGF0IHdoZW4gcnVubmluZyBp biBhIERTIHJlcG8sIGl0IGtub3dzIGhvdyB0byBsb29rIGFuZCBkaWFnbm9zZSBjaGFuZ2VzIGNv bWluZyBmcm9tIHRoZSB1cHN0cmVhbSByZXBvLjwvcD4KPHA+Jm1kYXNoOyBUaGlzIG1lc3NhZ2Ug d2FzIHNlbnQgYnkgQXRsYXNzaWFuIEppcmEgKHYxMDAxLjAuMC1TTkFQU0hPVCMxMDAwNzUpPC9w PgoKPGltZyBzcmM9Imh0dHBzOi8vdTQwNDM0MDIuY3Quc2VuZGdyaWQubmV0L3dmL29wZW4/dXBu PWk1VE1XR1Y5OWFtSmJOeEpwU3AyLTJCSjMzQlNNM3R1aVVmUlRrNjRLLTJCT2pHcEYtMkJ1TXpv SlJSQjFpZnpaSUVydEl4VGNjTHk1MjF6ejdPeFpWaUI1bW5wYmJ3WUpGejZmbGdldlhPelVKVkgt MkZxQnF2Y3FxcUtJcDNwNE9jeURGT3NSd3ZhTGsxcjdYOEpwTEViYll0US0yRjhzZS0yRkFvRzNO cU15Nk1FRjk2MGZNNFdDZkFySVBpcERBeFYzSTlRdER4d0laa2VOV0Q5eUFwUHNkSnJhM1Y0TlQ3 aElPb1RpZjQ2aE45QTJOYS0yQklzZUhuZ1NTT3pyU1BvODdYczVkbFRPcDRrVkUtMkZ6T3lmQWhz NnlKNkxJQ1VNQmEyZDBEaGtHLTJCQWtzeW04QUpyMFFmUFpjTmdNWklBbjZmQzA3R3JQaHo4VFVj eE1mSWRwcDR1enVDdmZubi0yQmdibnpqNUI5a2g2WkVSaXNQTFJ4R09VeDdWSG1oWUZtMWVicWs2 Nk80R3NDQlVnRlhRQXBSOVNGSS0yRnRmZzcwR2NQZ3djaHJheHlUclI5dE4xQ24tMkZic2F2NFNa SWVUeVdrTFF6WGFmQVI4TXQiIGFsdD0iIiB3aWR0aD0iMSIgaGVpZ2h0PSIxIiBib3JkZXI9IjAi IHN0eWxlPSJoZWlnaHQ6MXB4ICFpbXBvcnRhbnQ7d2lkdGg6MXB4ICFpbXBvcnRhbnQ7Ym9yZGVy LXdpZHRoOjAgIWltcG9ydGFudDttYXJnaW4tdG9wOjAgIWltcG9ydGFudDttYXJnaW4tYm90dG9t OjAgIWltcG9ydGFudDttYXJnaW4tcmlnaHQ6MCAhaW1wb3J0YW50O21hcmdpbi1sZWZ0OjAgIWlt cG9ydGFudDtwYWRkaW5nLXRvcDowICFpbXBvcnRhbnQ7cGFkZGluZy1ib3R0b206MCAhaW1wb3J0 YW50O3BhZGRpbmctcmlnaHQ6MCAhaW1wb3J0YW50O3BhZGRpbmctbGVmdDowICFpbXBvcnRhbnQ7 Ii8+CjwvYm9keT48L2h0bWw+CgotLS0tLS0tLS0tLS09XzE1MTQ4MTkwNTktMjUwMzAtMTAxLS0K --===============8104608170561873303==--