From jira at ovirt-jira.atlassian.net Wed Jan 10 08:49:24 2018 Content-Type: multipart/mixed; boundary="===============1273359119114074025==" MIME-Version: 1.0 From: Barak Korren (oVirt JIRA) To: infra at ovirt.org Subject: [JIRA] (OVIRT-1689) Improve error messages in STDCI environment variable handling Date: Wed, 10 Jan 2018 08:49:21 +0000 Message-ID: In-Reply-To: JIRA.33215.1507457201000@Atlassian.JIRA --===============1273359119114074025== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable This is a multi-part message in MIME format... ------------=3D_1515574161-11214-315 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 7bit [ https://ovirt-jira.atlassian.net/browse/OVIRT-1689?page=3Dcom.atlass= ian.jira.plugin.system.issuetabpanels:all-tabpanel ] Barak Korren updated OVIRT-1689: -------------------------------- Component/s: (was: oVirt CI) mock_runner > Improve error messages in STDCI environment variable handling > ------------------------------------------------------------- > > Key: OVIRT-1689 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1689 > Project: oVirt - virtualization made easy > Issue Type: Improvement > Components: mock_runner > Reporter: Daniel Belenky > Assignee: infra > > * All references to things like 'xdg-home' need to be replaced with speci= fications of actual paths, as users are not expected to know what XDG is. > * Accurate indication of what is missing from which file and what can be = done to fix it need to be given in all error messages. > * When variable/key names are given in error messages, they need to be qu= oted for clarity. > * Edge cases like for example an existing but empty secrets file and a mi= ssing 'secrets_data' key need to be handled better, with clear error messag= es > * Error message when a requested env var is missing needs to be improved= to tell the user what to do. Current message can be very confusing when tr= ying to use 'mock_runner.sh' for the 'jenkins' repo for example. -- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100075) ------------=3D_1515574161-11214-315 Content-Type: text/html; charset=3D"UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit 
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1689?page=3Dcom.atlass=
ian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Barak Korren updated OVIRT-1689:

    Component/s:     (was: oVirt CI)
mock_runner

Improve error messages in STDCI environment variable handli= ng

     Key: OVIRT-1689
     URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1689
 Project: oVirt - virtualization made easy
         Issue Type: Improvement
         Components: mock_runner
Reporter: Daniel Belenky
Assignee: infra

  • All references to things like ‘xdg-home’ need to be = replaced with specifications of actual paths, as users are not expected to = know what XDG is.

  • Accurate indication of what is missing from which file and what can = be done to fix it need to be given in all error messages.

  • When variable/key names are given in error messages, they need to be= quoted for clarity.

  • Edge cases like for example an existing but empty secrets file and a= missing ‘secrets_data’ key need to be handled better, with cle= ar error messages

  • Error message when a requested env var is missing needs to be improv= ed to tell the user what to do. Current message can be very confusing when = trying to use ‘mock_runner.sh’ for the ‘jenkins’ re= po for example.

— This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#1000= 75)

3D"" ------------=3D_1515574161-11214-315-- --===============1273359119114074025== Content-Type: multipart/alternative MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="attachment.bin" VGhpcyBpcyBhIG11bHRpLXBhcnQgbWVzc2FnZSBpbiBNSU1FIGZvcm1hdC4uLgoKLS0tLS0tLS0t LS0tPV8xNTE1NTc0MTYxLTExMjE0LTMxNQpDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJz ZXQ9VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogN2JpdAoKCiAgICAgWyBodHRwczov L292aXJ0LWppcmEuYXRsYXNzaWFuLm5ldC9icm93c2UvT1ZJUlQtMTY4OT9wYWdlPWNvbS5hdGxh c3NpYW4uamlyYS5wbHVnaW4uc3lzdGVtLmlzc3VldGFicGFuZWxzOmFsbC10YWJwYW5lbCBdCgpC YXJhayBLb3JyZW4gdXBkYXRlZCBPVklSVC0xNjg5OgotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLQogICAgQ29tcG9uZW50L3M6ICAgICAod2FzOiBvVmlydCBDSSkKICAgICAgICAgICAg ICAgICBtb2NrX3J1bm5lcgoKPiBJbXByb3ZlIGVycm9yIG1lc3NhZ2VzIGluIFNURENJIGVudmly b25tZW50IHZhcmlhYmxlIGhhbmRsaW5nCj4gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+Cj4gICAgICAgICAgICAgICAgIEtleTog T1ZJUlQtMTY4OQo+ICAgICAgICAgICAgICAgICBVUkw6IGh0dHBzOi8vb3ZpcnQtamlyYS5hdGxh c3NpYW4ubmV0L2Jyb3dzZS9PVklSVC0xNjg5Cj4gICAgICAgICAgICAgUHJvamVjdDogb1ZpcnQg LSB2aXJ0dWFsaXphdGlvbiBtYWRlIGVhc3kKPiAgICAgICAgICBJc3N1ZSBUeXBlOiBJbXByb3Zl bWVudAo+ICAgICAgICAgIENvbXBvbmVudHM6IG1vY2tfcnVubmVyCj4gICAgICAgICAgICBSZXBv cnRlcjogRGFuaWVsIEJlbGVua3kKPiAgICAgICAgICAgIEFzc2lnbmVlOiBpbmZyYQo+Cj4gKiBB bGwgcmVmZXJlbmNlcyB0byB0aGluZ3MgbGlrZSAneGRnLWhvbWUnIG5lZWQgdG8gYmUgcmVwbGFj ZWQgd2l0aCBzcGVjaWZpY2F0aW9ucyBvZiBhY3R1YWwgcGF0aHMsIGFzIHVzZXJzIGFyZSBub3Qg ZXhwZWN0ZWQgdG8ga25vdyB3aGF0IFhERyBpcy4KPiAqIEFjY3VyYXRlIGluZGljYXRpb24gb2Yg d2hhdCBpcyBtaXNzaW5nIGZyb20gd2hpY2ggZmlsZSBhbmQgd2hhdCBjYW4gYmUgZG9uZSB0byBm aXggaXQgbmVlZCB0byBiZSBnaXZlbiBpbiBhbGwgZXJyb3IgbWVzc2FnZXMuCj4gKiBXaGVuIHZh cmlhYmxlL2tleSBuYW1lcyBhcmUgZ2l2ZW4gaW4gZXJyb3IgbWVzc2FnZXMsIHRoZXkgbmVlZCB0 byBiZSBxdW90ZWQgZm9yIGNsYXJpdHkuCj4gKiBFZGdlIGNhc2VzIGxpa2UgZm9yIGV4YW1wbGUg YW4gZXhpc3RpbmcgYnV0IGVtcHR5IHNlY3JldHMgZmlsZSBhbmQgYSBtaXNzaW5nICdzZWNyZXRz X2RhdGEnIGtleSBuZWVkIHRvIGJlIGhhbmRsZWQgYmV0dGVyLCB3aXRoIGNsZWFyIGVycm9yIG1l c3NhZ2VzCj4gKiAgRXJyb3IgbWVzc2FnZSB3aGVuIGEgcmVxdWVzdGVkIGVudiB2YXIgaXMgbWlz c2luZyBuZWVkcyB0byBiZSBpbXByb3ZlZCB0byB0ZWxsIHRoZSB1c2VyIHdoYXQgdG8gZG8uIEN1 cnJlbnQgbWVzc2FnZSBjYW4gYmUgdmVyeSBjb25mdXNpbmcgd2hlbiB0cnlpbmcgdG8gdXNlICdt b2NrX3J1bm5lci5zaCcgZm9yIHRoZSAnamVua2lucycgcmVwbyBmb3IgZXhhbXBsZS4KCgoKLS0K VGhpcyBtZXNzYWdlIHdhcyBzZW50IGJ5IEF0bGFzc2lhbiBKaXJhCih2MTAwMS4wLjAtU05BUFNI T1QjMTAwMDc1KQoKLS0tLS0tLS0tLS0tPV8xNTE1NTc0MTYxLTExMjE0LTMxNQpDb250ZW50LVR5 cGU6IHRleHQvaHRtbDsgY2hhcnNldD0iVVRGLTgiCkNvbnRlbnQtRGlzcG9zaXRpb246IGlubGlu ZQpDb250ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA3Yml0Cgo8aHRtbD48Ym9keT4KPHByZT5bIGh0 dHBzOi8vb3ZpcnQtamlyYS5hdGxhc3NpYW4ubmV0L2Jyb3dzZS9PVklSVC0xNjg5P3BhZ2U9Y29t LmF0bGFzc2lhbi5qaXJhLnBsdWdpbi5zeXN0ZW0uaXNzdWV0YWJwYW5lbHM6YWxsLXRhYnBhbmVs IF08L3ByZT4KPGgzPkJhcmFrIEtvcnJlbiB1cGRhdGVkIE9WSVJULTE2ODk6PC9oMz4KPHByZT4g ICAgQ29tcG9uZW50L3M6ICAgICAod2FzOiBvVmlydCBDSSkKbW9ja19ydW5uZXI8L3ByZT4KPGJs b2NrcXVvdGU+PGgzPkltcHJvdmUgZXJyb3IgbWVzc2FnZXMgaW4gU1REQ0kgZW52aXJvbm1lbnQg dmFyaWFibGUgaGFuZGxpbmc8L2gzPgo8cHJlPiAgICAgS2V5OiBPVklSVC0xNjg5CiAgICAgVVJM OiBodHRwczovL292aXJ0LWppcmEuYXRsYXNzaWFuLm5ldC9icm93c2UvT1ZJUlQtMTY4OQogUHJv amVjdDogb1ZpcnQgLSB2aXJ0dWFsaXphdGlvbiBtYWRlIGVhc3kKICAgICAgICAgSXNzdWUgVHlw ZTogSW1wcm92ZW1lbnQKICAgICAgICAgQ29tcG9uZW50czogbW9ja19ydW5uZXIKUmVwb3J0ZXI6 IERhbmllbCBCZWxlbmt5CkFzc2lnbmVlOiBpbmZyYTwvcHJlPgo8dWw+PGxpPjxwPkFsbCByZWZl cmVuY2VzIHRvIHRoaW5ncyBsaWtlICZsc3F1bzt4ZGctaG9tZSZyc3F1bzsgbmVlZCB0byBiZSBy ZXBsYWNlZCB3aXRoIHNwZWNpZmljYXRpb25zIG9mIGFjdHVhbCBwYXRocywgYXMgdXNlcnMgYXJl IG5vdCBleHBlY3RlZCB0byBrbm93IHdoYXQgWERHIGlzLjwvcD48L2xpPgo8bGk+PHA+QWNjdXJh dGUgaW5kaWNhdGlvbiBvZiB3aGF0IGlzIG1pc3NpbmcgZnJvbSB3aGljaCBmaWxlIGFuZCB3aGF0 IGNhbiBiZSBkb25lIHRvIGZpeCBpdCBuZWVkIHRvIGJlIGdpdmVuIGluIGFsbCBlcnJvciBtZXNz YWdlcy48L3A+PC9saT4KPGxpPjxwPldoZW4gdmFyaWFibGUva2V5IG5hbWVzIGFyZSBnaXZlbiBp biBlcnJvciBtZXNzYWdlcywgdGhleSBuZWVkIHRvIGJlIHF1b3RlZCBmb3IgY2xhcml0eS48L3A+ PC9saT4KPGxpPjxwPkVkZ2UgY2FzZXMgbGlrZSBmb3IgZXhhbXBsZSBhbiBleGlzdGluZyBidXQg ZW1wdHkgc2VjcmV0cyBmaWxlIGFuZCBhIG1pc3NpbmcgJmxzcXVvO3NlY3JldHNfZGF0YSZyc3F1 bzsga2V5IG5lZWQgdG8gYmUgaGFuZGxlZCBiZXR0ZXIsIHdpdGggY2xlYXIgZXJyb3IgbWVzc2Fn ZXM8L3A+PC9saT4KPGxpPjxwPkVycm9yIG1lc3NhZ2Ugd2hlbiBhIHJlcXVlc3RlZCBlbnYgdmFy IGlzIG1pc3NpbmcgbmVlZHMgdG8gYmUgaW1wcm92ZWQgdG8gdGVsbCB0aGUgdXNlciB3aGF0IHRv IGRvLiBDdXJyZW50IG1lc3NhZ2UgY2FuIGJlIHZlcnkgY29uZnVzaW5nIHdoZW4gdHJ5aW5nIHRv IHVzZSAmbHNxdW87bW9ja19ydW5uZXIuc2gmcnNxdW87IGZvciB0aGUgJmxzcXVvO2plbmtpbnMm cnNxdW87IHJlcG8gZm9yIGV4YW1wbGUuPC9wPjwvbGk+PC91bD48L2Jsb2NrcXVvdGU+CjxwPiZt ZGFzaDsgVGhpcyBtZXNzYWdlIHdhcyBzZW50IGJ5IEF0bGFzc2lhbiBKaXJhICh2MTAwMS4wLjAt U05BUFNIT1QjMTAwMDc1KTwvcD4KCjxpbWcgc3JjPSJodHRwczovL3U0MDQzNDAyLmN0LnNlbmRn cmlkLm5ldC93Zi9vcGVuP3Vwbj1pNVRNV0dWOTlhbUpiTnhKcFNwMi0yQkozM0JTTTN0dWlVZlJU azY0Sy0yQk9qR3BGLTJCdU16b0pSUkIxaWZ6WklFcnRJeFRjY0x5NTIxeno3T3haVmlCNW1ucGJi d1lKRno2ZmxnZXZYT3pVSlZILTJGcUJxdmNxcXFLSXAzcDRPY3lERk9zUnd2YUxrMXI3WDhKcExF YmJZdFEtMkY4c2UtMkZBb0czTnFNeTZNRUY5NjBmTTRXQ2ZBcklQaXBEQXhWM0k5UXREeHdJWmtl TldEOXlBcFBzZEpyYTNWNE5UN2hJT29UaWY0NmhOOUEyTmEtMkJJc2VIbmdTU096clNQbzg3WHM1 ZGxUT3BuQUF1ZmRSNjJTMWU0WE44YU5LMUl6N1h0eFlnVVV6SXdScFo0S1lyaVR1eXIwYnJwUjd5 MVBSbHZTRDJ5OGFCQ3k4dkZtOUJDQjUzcnN5UnpLZWNoOVpHQlB1dzRZalNzdmJNV1pPLTJCSU9n YmNlLTJGS2hMRDhyLTJGSmdKcDZ5WVF6Y2tQWkduMy0yRjVoMWxpc20tMkJSWUJzc3IzWWN3WVNh NTJaeFpRRi0yRlI3ZjdTc2xDRC0yQkhnLTJCV2hENGlDTVNjakQzczJ3IiBhbHQ9IiIgd2lkdGg9 IjEiIGhlaWdodD0iMSIgYm9yZGVyPSIwIiBzdHlsZT0iaGVpZ2h0OjFweCAhaW1wb3J0YW50O3dp ZHRoOjFweCAhaW1wb3J0YW50O2JvcmRlci13aWR0aDowICFpbXBvcnRhbnQ7bWFyZ2luLXRvcDow ICFpbXBvcnRhbnQ7bWFyZ2luLWJvdHRvbTowICFpbXBvcnRhbnQ7bWFyZ2luLXJpZ2h0OjAgIWlt cG9ydGFudDttYXJnaW4tbGVmdDowICFpbXBvcnRhbnQ7cGFkZGluZy10b3A6MCAhaW1wb3J0YW50 O3BhZGRpbmctYm90dG9tOjAgIWltcG9ydGFudDtwYWRkaW5nLXJpZ2h0OjAgIWltcG9ydGFudDtw YWRkaW5nLWxlZnQ6MCAhaW1wb3J0YW50OyIvPgo8L2JvZHk+PC9odG1sPgoKLS0tLS0tLS0tLS0t PV8xNTE1NTc0MTYxLTExMjE0LTMxNS0tCg== --===============1273359119114074025==--