[ https://ovirt-jira.atlassian.net/browse/OVIRT-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=35287#comment-35287 ]

Barak Korren commented on OVIRT-1702:

{quote} I'm pretty sure in the past it was completely removed from the slave. {quote}

I'm pretty sure it was not, since code handling this has not been significantly changed since David first wrote it.

The workspace including the source checkout does get completely remove when a different job starts running on the node. But as long as its the same job, the workspace stays as-is.

{quote}

Is there any good reason for not cleaning the slave after job completion?

{quote}

Yes. Re-cloning the whole git repo every time we run something will significantly slow things down.

Also we do not clean the slave up after the execution, we clean it before the next one. This has the benefit of allowing us to debug failed runs and also prevent the next run from failing if the post-run code was not reached for some reason. But a side-affect of this is that the more cleanup steps we have the longer the latency our users experience between submitting patchs and having their check-patch code run, so we try to keep it to a minimum.

Jenkins STD-CI are running in dirty mock chroots

     Key: OVIRT-1702
     URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1702
 Project: oVirt - virtualization made easy
         Issue Type: By-EMAIL
Reporter: sbonazzo
Assignee: infra

Example: http://jenkins.ovirt.org/job/ovirt-wgt_master_check-patch-fc26-x86_64/11/console 09:44:06 + ./automation/build-artifacts.sh*09:44:06* + [[ -d exported-artifacts ]]*09:44:06* + mkdir -p exported-artifacts*09:44:06* + [[ -d tmp.repos/SOURCES ]]*09:44:06* + mkdir -p tmp.repos/SOURCES*09:44:06* + git clone git://anongit.freedesktop.org/spice/spice-nsis*09:44:06* fatal: destination path ‘spice-nsis’ already exists and is not an empty directory. jobs should run in clean chroots. — SANDRO BONAZZOLA ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D Red Hat EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted> <http://www.teraplan.it/redhat-osd-2017/>

— This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100070)