[ https://ovirt-jira.atlassian.net/browse/OVIRT-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=36620#comment-36620 ]

Barak Korren commented on OVIRT-1759:

{quote} I think 1 hour should suffice, but it depends on how loaded the CQ is, Barak Korren any thoughts? {quote}

There is no need to wait one hour and this has nothing to do with the delay between merging ‘vdsm-jsonrpc-java’ and ‘ovirt-engine’. The issue discussed in this ticket is triggered when reviewing a series of patches and merging all of then together by clicking the “submit with parents” button on a child patch in Gerrit. As long as patches are merged individually by clicking on the “merge” button for each one the issue shouldn't arise.

This issue should not be confused with the need to do dependency handling so that equivalent versions of engine and ‘vdsm-jsonrpc-java’ are tested together. That is tracked in OVIRT-1662.

Gerrit patches can reach CQ out-of-order

     Key: OVIRT-1759
     URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1759
 Project: oVirt - virtualization made easy
         Issue Type: Bug
         Components: Change Queue, Gerrit/git
Reporter: Barak Korren
Assignee: infra
Priority: High
  Labels: change-queue, gerrit

Is seems that despite the fact that all the jobs involved were designed to preserve proper patch ordering, there can be cases where patches trigger Jenkins jobs in the wrong order, which in turn end up putting the patches in the wrong order into the CQ. This in turn, causes the CQ to fail accurately detecting the patches that cause issues. Here is en example of such an occurance. The following patches were merged in the order specified below: # https://gerrit.ovirt.org/c/83917 # https://gerrit.ovirt.org/c/83918 # https://gerrit.ovirt.org/c/83919 # https://gerrit.ovirt.org/c/83920 The standard-enqueue runs putting them in the CQ however, seem to have run in a different order: # http://jenkins.ovirt.org/job/standard-enqueue/6712/ (83 917) # http://jenkins.ovirt.org/job/standard-enqueue/6713/ (83919) # http://jenkins.ovirt.org/job/standard-enqueue/6714/ (83920) # http://jenkins.ovirt.org/job/standard-enqueue/6715/ (83918) This resulted in CQ ‘add’ command running in the wrong order: # http://jenkins.ovirt.org/job/ovirt-master_change-queue/12200/ (add 83917) # http://jenkins.ovirt.org/job/ovirt-master_change-queue/12201/ (add 83919) # http://jenkins.ovirt.org/job/ovirt-master_change-queue/12202/ (add 83920) # http ://jenkins.ovirt.org/job/ovirt-master_change-queue/12203/ (add 83918) We need to come up with a way to make the system properly preserver order.

— This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100085)