On Sun, Sep 24, 2017 at 4:52 PM, Eyal Edri <eedri@redhat.com> wrote:

On Sun, Sep 24, 2017 at 4:48 PM, Eyal Edri <eedri@redhat.com> wrote:
Hi,

So I've found linkchecker[1], which is quite a powerful and useful tool for that, and run it on oVirt.org, the results are not good, unfortunately.
We have over 15K(!) of broken links to fix before we can even consider adding a constant CI job to check new commits. 

Snippet example from the huge report attached to this email [2]. ( btw there are other formats available to generate this report if we want )

resending with zipped report ( the file was 16MB, too big for the list ).

I've rerun the tool excluding .png images, since there are many of them and the broken links got down to 2373, to much more reasonable number 
to start working on.

Attached new report w/o images.
 
 

After we'll do an initial cleanup of the broken links ( similar to what we did on findbugs errors ), we can consider adding CI for it, 2 ideas I had in mind:


1. Running the tool on GitHub PR using Travis CI ( which ovirt-site is already connected to it ), the tool seems to be using it as well for testing itself
2. Adding ovirt-site as a std-ci project and using it to also properly deploy to the site in the end ( more complex and long term goal, which might require more work ).


TL;DR, let's schedule a doc-fix day first to address the sheer amount of broken links and then worry about adding CI.



[2] 

URL `develop/release-management/features/sla/hosted-engine-agent-offloading/#documentation'
Name`Documentation/External references'
Parent URLhttps://ovirt.org/develop/release-management/features/sla/hosted-engine-agent-offloading/, line 1870, col 131 (HTML) (CSS)
Real URLhttps://ovirt.org/develop/release-management/features/sla/hosted-engine-agent-offloading/develop/release-management/features/sla/hosted-engine-agent-offloading/#documentation
Size14.63KB
Check time3.496 seconds
ResultError: 404 Not Found


URL `/images/apple-touch-icon-precomposed.png'
Parent URLhttps://www.ovirt.org, line 22, col 1 (HTML) (CSS)
Real URLhttps://www.ovirt.org/images/apple-touch-icon-precomposed.png
Size14.63KB
Check time1.851 seconds
ResultError: 404 Not Found



--

Eyal edri


ASSOCIATE MANAGER

RHV DevOps

EMEA VIRTUALIZATION R&D


Red Hat EMEA

TRIED. TESTED. TRUSTED.
phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)



--

Eyal edri


ASSOCIATE MANAGER

RHV DevOps

EMEA VIRTUALIZATION R&D


Red Hat EMEA

TRIED. TESTED. TRUSTED.
phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)