On Mon, Aug 1, 2016 at 9:56 PM, Vojtech Szocs <vszocs@redhat.com> wrote:

----- Original Message -----
> From: "Juan Hernández" <jhernand@redhat.com>
> To: "Eyal Edri" <eedri@redhat.com>, "Vojtech Szocs" <vszocs@redhat.com>, "Anton Marchukov" <amarchuk@redhat.com>
> Cc: "infra" <infra@ovirt.org>
> Sent: Monday, August 1, 2016 9:30:23 PM
> Subject: Re: Errors / warnings in ovirt-engine-nodejs-modules build log
>
> On 08/01/2016 09:01 PM, Eyal Edri wrote:
> > Anton, can you sit with Vojtech tomorrow and see if you can help?
> >
> > Vojtech
> > Maybe we're hitting: http://rpm.org/ticket/862
> > https://bugzilla.redhat.com/show_bug.cgi?id=913099
> >
> > Anyway, what I meant was to try and run it on el7 slaves, not el7 mock,
> > to see if its a regression on mock running on fc24.
> > trying it here to see if it
> > works:
> > http://jenkins.ovirt.org/job/ovirt-engine-nodejs-modules_master_create-rpms-el7-x86_64_created/22/console
> >
>
> As this seems to be a RPM limitation, and one that isn't going to be
> fixed soon, I'd suggest to change the Node.js modules RPM so that it
> packages a single .tar file containing all the modules. It can then,
> during installation (in the %post) section extract the content to
> /var/lib/ovirt-engine-nodejs-modules, so users only have to change the
> directory they use. Actually, as Vojtech introduced a "setup-env.sh"
> script that does all the preparations, only this script needs to be
> changed. This patch reflects my suggestion:
>
>   Package tarball containing Node.js modules
>   https://gerrit.ovirt.org/61790

+1 this is great!

Proposed solution doesn't require any change in Dashboard code.

Seems like it was only a matter of time till we hit that ~100k
files limit when creating ovirt-engine-nodejs-modules RPM.

You may also consider spliitng the rpm in subpackages in a per-module fashion.

 

Juan++

>
> > On Mon, Aug 1, 2016 at 9:42 PM, Vojtech Szocs <vszocs@redhat.com
> > <mailto:vszocs@redhat.com>> wrote:
> >
> >
> >
> >     ----- Original Message -----
> >     > From: "Eyal Edri" <eedri@redhat.com <mailto:eedri@redhat.com>>
> >     > To: "Vojtech Szocs" <vszocs@redhat.com <mailto:vszocs@redhat.com>>
> >     > Cc: "infra" <infra@ovirt.org <mailto:infra@ovirt.org>>
> >     > Sent: Monday, August 1, 2016 8:25:50 PM
> >     > Subject: Re: Errors / warnings in ovirt-engine-nodejs-modules build
> >     > log
> >     >
> >     > Does it work on el7?
> >
> >     It fails on el7 as well:
> >
> >     http://jenkins.ovirt.org/job/ovirt-engine-nodejs-modules_master_create-rpms-el7-x86_64_created/21/console
> >
> >       error: Unable to create immutable header region.
> >
> >     >
> >     > On Mon, Aug 1, 2016 at 8:21 PM, Vojtech Szocs <vszocs@redhat.com
> >     <mailto:vszocs@redhat.com>> wrote:
> >     >
> >     > > Forwarding to infra, TL;DR we seem to have an issue with rpmbuild
> >     > > (see below) and I'm not sure how to fix that, is there anyone who
> >     > > faced such issue in past?
> >     > >
> >     > > Vojtech
> >     > >
> >     > >
> >     > > ----- Forwarded Message -----
> >     > > From: "Vojtech Szocs" <vszocs@redhat.com
> >     > > <mailto:vszocs@redhat.com>>
> >     > > To: "Sandro Bonazzola" <sbonazzo@redhat.com
> >     <mailto:sbonazzo@redhat.com>>
> >     > > Cc: "Oved Ourfali" <oourfali@redhat.com
> >     <mailto:oourfali@redhat.com>>, "Alexander Wels" <
> >     > > awels@redhat.com <mailto:awels@redhat.com>>, "Greg Sheremeta"
> >     <gshereme@redhat.com <mailto:gshereme@redhat.com>>, "Juan
> >     > > Hernández" <jhernand@redhat.com <mailto:jhernand@redhat.com>>,
> >     "Ryan Barry" <rbarry@redhat.com <mailto:rbarry@redhat.com>>
> >     > > Sent: Monday, August 1, 2016 6:49:08 PM
> >     > > Subject: Errors / warnings in ovirt-engine-nodejs-modules build log

> >     > >
> >     > > Hi Sandro,
> >     > >
> >     > > I've looked into the build log [1].
> >     > >
> >     > > Adding Juan & Ryan as well. Your feedback is highly appreciated.
> >     > >
> >     > > npm-specific issues (don't block the build):
> >     > >
> >     > >   npm WARN package.json dependencies@ No repository field.
> >     > >   npm WARN package.json dependencies@ No license field.
> >     > >   - these warnings are harmless
> >     > >   - TODO update modules' package.json
> >     > >
> >     > >   npm WARN deprecated ...
> >     > >   - some (possibly transitive) dependency in package.json relies
> >     > >     on a deprecated npm package
> >     > >   - TODO find out which dependencies are causing this
> >     > >
> >     > >   npm ERR! registry error parsing json
> >     > >   - this might indicate corrupt npm cache
> >     > >   - should be fixed by `npm cache clean`
> >     > >   - TODO update modules' build.sh
> >     > >
> >     > >   npm WARN optional dep failed, continuing ...
> >     > >   - these warnings are harmless
> >     > >   - some (possibly transitive) dependency in package.json relies
> >     > >     on an optional npm package that is platform-specific but it
> >     > >     is NOT available for current platform
> >     > >   - e.g. "fsevents" is MacOSX only
> >     > >   - this should be fixed by `npm install --no-optional`
> >     > >   - TODO update modules' build.sh
> >     > >
> >     > >   sh: bower: command not found
> >     > >   npm WARN optional dep failed, continuing bootstrap-treeview@1.2.0
> >     > >   - bootstrap-treeview does `bower install` in its `install` script
> >     > >   - this is BAD practice (bootstrap-treeview's fault)
> >     > >   - TODO latest commit on May 9, 2015 -- do we need this at all (?)
> >     > >
> >     > > CI-specific issues (which block the build):
> >     > >
> >     > >   Wrote:
> >     > >
> >     /tmp/ovirt-engine-nodejs-modules/ovirt-engine-nodejs-modules-0.0.10-1.fc24.src.rpm
> >     > >   error: Unable to create immutable header region.
> >     > >   - at this point, spec's %install phase has finished executing
> >     > >     and RPM was created
> >     > >   - it is rpmbuild related, see
> >     > >     https://bugzilla.redhat.com/show_bug.cgi?id=913099#c2
> >     > >
> >     > > For ^^ error, seems like too many files in RPM package will cause
> >     > > "artificial cap on header size" to be exceeded and rpmbuild fails.
> >     > >
> >     > > Juan, what do you think? I don't have any idea how to solve this.
> >     > >
> >     > > I don't understand the actual issue as we're creating single .tar
> >     > > file from `node_modules` directory during the RPM build..
> >     > >
> >     > > [1]
> >     > >
> >     http://jenkins.ovirt.org/job/ovirt-engine-nodejs-modules_master_create-rpms-fc24-x86_64_created/4/console
> >     > >
> >     > > Thanks,
> >     > > Vojtech

> >     > > _______________________________________________
> >     > > Infra mailing list
> >     > > Infra@ovirt.org <mailto:Infra@ovirt.org>
> >     > > http://lists.ovirt.org/mailman/listinfo/infra
> >     > >
> >     > >
> >     > >
> >     >
> >     >
> >     > --
> >     > Eyal Edri
> >     > Associate Manager
> >     > RHV DevOps
> >     > EMEA ENG Virtualization R&D
> >     > Red Hat Israel
> >     >
> >     > phone: +972-9-7692018 <tel:%2B972-9-7692018>
> >     > irc: eedri (on #tlv #rhev-dev #rhev-integ)
> >     >
> >
> >
> >
> >
> > --
> > Eyal Edri
> > Associate Manager
> > RHV DevOps
> > EMEA ENG Virtualization R&D
> > Red Hat Israel
> >
> > phone: +972-9-7692018
> > irc: eedri (on #tlv #rhev-dev #rhev-integ)
> >
> >
> > _______________________________________________
> > Infra mailing list
> > Infra@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
>
>
> --
> Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta
> 3ºD, 28016 Madrid, Spain
> Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
>
_______________________________________________
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

--

Sandro Bonazzola
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com

_______________________________________________
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra