On Sun, Jun 21, 2020 at 11:23 AM Galit Rosenthal <grosenth@redhat.com> wrote:
>
> Hi,
>
> This is the fix: https://gerrit.ovirt.org/#/c/109785/
>
> I've already saw the issue.

Thanks!

Can you please check why it was not caught on check-patch? Thanks.

>
> Galit
>
> On Sun, Jun 21, 2020 at 10:54 AM Yedidyah Bar David <didi@redhat.com> wrote:
>>
>> On Sun, Jun 21, 2020 at 6:18 AM <jenkins@jenkins.phx.ovirt.org> wrote:
>> >
>> > Project: https://jenkins.ovirt.org/job/ovirt-system-tests_he-basic-suite-4.3/
>> > Build: https://jenkins.ovirt.org/job/ovirt-system-tests_he-basic-suite-4.3/480/
>>
>> This, and other HE suites in recent days, failed with:
>>
>> Traceback (most recent call last):
>>   File "/usr/lib64/python2.7/unittest/case.py", line 369, in run
>>     testMethod()
>>   File "/usr/lib/python2.7/site-packages/nose/loader.py", line 418, in
>> loadTestsFromName
>>     addr.filename, addr.module)
>>   File "/usr/lib/python2.7/site-packages/nose/importer.py", line 47,
>> in importFromPath
>>     return self.importFromDir(dir_path, fqname)
>>   File "/usr/lib/python2.7/site-packages/nose/importer.py", line 94,
>> in importFromDir
>>     mod = load_module(part_fqname, fh, filename, desc)
>>   File "/home/jenkins/agent/workspace/ovirt-system-tests_he-basic-suite-4.3/ovirt-system-tests/he-basic-suite-4.3/test-scenarios/002_bootstrap.py",
>> line 35, in <module>
>>     import test_utils
>>   File "/home/jenkins/agent/workspace/ovirt-system-tests_he-basic-suite-4.3/ovirt-system-tests/he-basic-suite-4.3/test-scenarios/test_utils/__init__.py",
>> line 30, in <module>
>>     from ost_utils.memoized import memoized
>> ImportError: No module named ost_utils.memoized
>>
>> I assume that this is a result of:
>>
>> https://gerrit.ovirt.org/109337
>>
>> and of the fact that some suites (HE, not sure about others) are still
>> using nose.
>>
>> Marcin, can you please have a look? Thanks.
>>
>> Galit, can you please check why check-patch on above patch didn't
>> fail? If it's because we removed HE suites from check-patch, because
>> they were unstable, then IMO we should add them back. They are rather
>> stable now, and if they fail, we should fix them. Thanks.
>>
>> Best regards,
>> --
>> Didi
>>
>
>
> --
>
> GALIT ROSENTHAL
>
> SOFTWARE ENGINEER
>
> Red Hat
>
> galit@redhat.com    T: 972-9-7692230



--
Didi