Is there anything we can/should do to fix this or next runs should work?

On Tue, Oct 22, 2019 at 9:50 AM Barak Korren (oVirt JIRA) <jira@ovirt-jira.atlassian.net> wrote:

    [ https://ovirt-jira.atlassian.net/browse/OVIRT-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=39909#comment-39909 ]

Barak Korren commented on OVIRT-2814:
-------------------------------------

{code}
this looks like a concurrency issue, a lock should be used in order to
prevent two instances to use the same cache directory at the same time or
use separate cache directories for different repos.
{code}

As you can see in the path name - it is unique for the repo, and there is only one update job per repo that does not run concurrently. So the last sentence you wrote above holds.

This might be a cleanup issues, where some failure scenario leaves some lock files behind.

> reposync fails syncing repos on completely unrelated paths (concurrency issue?)
> -------------------------------------------------------------------------------
>
>                 Key: OVIRT-2814
>                 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-2814
>             Project: oVirt - virtualization made easy
>          Issue Type: By-EMAIL
>            Reporter: Sandro Bonazzola
>            Assignee: infra
>
> About job
> https://jenkins.ovirt.org/job/system-sync_mirrors-centos-kvm-common-el7-x86_64/2934/console
> As you can see below
> 05:35:07 ++ reposync --config=jenkins/data/mirrors-reposync.conf
> --repoid=centos-kvm-common-el7 --arch=x86_64
> --cachedir=/home/jenkins/mirrors_cache
> --download_path=/var/www/html/repos/yum/centos-kvm-common-el7/base
> --norepopath --newest-only --urls --quiet
> the sync is related to "/var/www/html/repos/yum/centos-kvm-common-el7/base"
> using as cache directory "/home/jenkins/mirrors_cache"
> but in "/home/jenkins/mirrors_cache" there's
> "/home/jenkins/mirrors_cache/fedora-base-fc29":
> 05:35:16 Traceback (most recent call last):
> 05:35:16   File "/usr/bin/reposync", line 373, in <module>
> 05:35:16     main()
> 05:35:16   File "/usr/bin/reposync", line 185, in main
> 05:35:16     my.doRepoSetup()
> 05:35:16   File "/usr/lib/python2.7/site-packages/yum/__init__.py", line
> 681, in doRepoSetup
> 05:35:16     return self._getRepos(thisrepo, True)
> 05:35:16   File "/usr/lib/python2.7/site-packages/yum/__init__.py", line
> 721, in _getRepos
> 05:35:16     self._repos.doSetup(thisrepo)
> 05:35:16   File "/usr/lib/python2.7/site-packages/yum/repos.py", line 157,
> in doSetup
> 05:35:16     self.retrieveAllMD()
> 05:35:16   File "/usr/lib/python2.7/site-packages/yum/repos.py", line 88,
> in retrieveAllMD
> 05:35:16     dl = repo._async and repo._commonLoadRepoXML(repo)
> 05:35:16   File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line
> 1468, in _commonLoadRepoXML
> 05:35:16     local  = self.cachedir + '/repomd.xml'
> 05:35:16   File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line
> 777, in <lambda>
> 05:35:16     cachedir = property(lambda self: self._dirGetAttr('cachedir'))
> 05:35:16   File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line
> 760, in _dirGetAttr
> 05:35:16     self.dirSetup()
> 05:35:16   File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line
> 738, in dirSetup
> 05:35:16     self._dirSetupMkdir_p(dir)
> 05:35:16   File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line
> 715, in _dirSetupMkdir_p
> 05:35:16     raise Errors.RepoError, msg
> 05:35:16 yum.Errors.RepoError: Error making cache directory:
> /home/jenkins/mirrors_cache/fedora-base-fc29 error was: [Errno 17] File
> exists: '/home/jenkins/mirrors_cache/fedora-base-fc29'
> this looks like a concurrency issue, a lock should be used in order to
> prevent two instances to use the same cache directory at the same time or
> use separate cache directories for different repos.
> --
> Sandro Bonazzola



--
This message was sent by Atlassian Jira
(v1001.0.0-SNAPSHOT#100113)
_______________________________________________
Infra mailing list -- infra@ovirt.org
To unsubscribe send an email to infra-leave@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/
List Archives: https://lists.ovirt.org/archives/list/infra@ovirt.org/message/WE5IYWTQQVIDGTUHUMAKRNLX7GT552RO/


--

Eyal edri

He / Him / His


MANAGER

CONTINUOUS PRODUCTIZATION

SYSTEM ENGINEERING

Red Hat

phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ #cp-devel)