[ https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=23824#comment-23824 ]

eyal edri [Administrator] commented on OVIRT-900:
-------------------------------------------------

So what you're saying is any 'registered user' should have 'forge author
identity' permission?
Isn't that a bit of a security issue?

On Sun, Dec 4, 2016 at 2:58 PM, ybronhei (oVirt JIRA) <




--
Eyal Edri
Associate Manager
RHV DevOps
EMEA ENG Virtualization R&D
Red Hat Israel

phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)


> Re: Rebase over other author's patch cannot be pushed to gerrit

> ---------------------------------------------------------------
>
>                 Key: OVIRT-900
>                 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900
>             Project: oVirt - virtualization made easy
>          Issue Type: By-EMAIL
>            Reporter: Barak Korren
>            Assignee: Shlomo Ben David
>
> Forwarding to infra-support.
> On 1 December 2016 at 18:03, Yaniv Bronheim <ybronhei@redhat.com> wrote:
> > Not sure since when it was changed, but I noticed that I can't push patches
> > if I'm not the author
> >
> > Counting objects: 50, done.
> > Delta compression using up to 4 threads.
> > Compressing objects: 100% (50/50), done.
> > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done.
> > Total 50 (delta 34), reused 0 (delta 0)
> > remote: Resolving deltas: 100% (34/34)
> > remote: Processing changes: refs: 1, done
> > remote:
> > remote: ERROR:  In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4
> > remote: ERROR:  author email address rnachimu@redhat.com
> > remote: ERROR:  does not match your user account.
> > remote: ERROR:
> > remote: ERROR:  The following addresses are currently registered:
> > remote: ERROR:    bronhaim@gmail.com
> > remote: ERROR:    ybronhei@redhat.com
> > remote: ERROR:
> > remote: ERROR:  To register an email address, please visit:
> > remote: ERROR:  https://gerrit.ovirt.org/#/settings/contact
> > remote:
> > remote:
> > To ssh://ybronhei@gerrit.ovirt.org:29418/vdsm
> >  ! [remote rejected] HEAD -> refs/for/master (invalid author)
> > error: failed to push some refs to
> > 'ssh://ybronhei@gerrit.ovirt.org:29418/vdsm'
> >
> > We must have permissions to do that, this is part of the rebasing part, and
> > I think its fine to fix patches on behalf of someone else.. but its not the
> > best practice for reviewing.
> > anyway, please undo this change, unless its something that related only to
> > my env.. let me know
> >
> > Thanks
> >
> > --
> > Yaniv Bronhaim.
> >
> > _______________________________________________
> > Infra mailing list
> > Infra@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> --
> Barak Korren
> bkorren@redhat.com
> RHCE, RHCi, RHV-DevOps Team
> https://ifireball.wordpress.com/



--

This message was sent by Atlassian JIRA

(v1000.610.2#100023)
_______________________________________________
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra