2018-05-09 12:55 GMT+02:00 Sandro Bonazzola <sbonazzo@redhat.com>:


2018-05-09 12:49 GMT+02:00 Piotr Kliczewski <piotr.kliczewski@gmail.com>:


On Wed, May 9, 2018 at 12:27 PM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:


2018-05-09 12:09 GMT+02:00 Piotr Kliczewski <piotr.kliczewski@gmail.com>:
Hi,

I would like to push a patch to update releng-tools repo with correct
version but I do not see 4.2.4 files yet. Should I create it?

We are not yet building 4.2.4 release candidates, but you can create the 4.2.4 rc1 conf file with the updated release.
Please push vdsm-jsonrpc-java update, wait until it shows up in ovirt-4.2-snapshot repo then push update on the spec file for ovirt-engine.
This should avoid issues in jenkins.

Ack, here is the engine patch [1]. Jenkins is fine with it.


I'm not fine with it, but I've been beaten on reviewing patches on packaging area which was supposed to require integration ack.
The build of vdsm-jsonrpc-java is not yet available on http://plain.resources.ovirt.org/pub/ovirt-master-snapshot/rpm/el7/noarch/
so if you build the rpm locally now and you try to install it, it will fail.

This also means current check-patch job is not adeguate.
 

 
 
 

Thanks,
Piotr



--

SANDRO BONAZZOLA

ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D

Red Hat EMEA

sbonazzo@redhat.com   





--

SANDRO BONAZZOLA

ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D

Red Hat EMEA

sbonazzo@redhat.com   




--

SANDRO BONAZZOLA

ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D

Red Hat EMEA

sbonazzo@redhat.com