I agree, this is one of the advantages of the standard CI [1].

You can update 'check-patch.sh' or 'check-merged' with the maven command you'd like to add via a commit to gerrit, and we can help with the review.

I think the best way will be to add it either as a new Make goal (like validations) and then add a line to the check-patch.sh to run the goal,

You can also add a new maven profile for animal sniffer so just running mvn test -Panimal will do the trick.

I think Juan sent already something for it..

[1] http://ovirt-infra-docs.readthedocs.org/en/latest/CI/Build_and_test_standards.html

On Mon, Mar 21, 2016 at 6:27 AM, Barak Korren <bkorren@redhat.com> wrote:

> TL;DR - we need this job re-enabled:
>
> What to run - "mvn animal-sniffer:check" on a directory that already has the
> built targets. If you're triggering it on sources that haven't been built
> yet, or on a directory you're not sure about the status, use "mvn clean
> install animal-sniffer:check -DskipTests" instead
> When to run - trigger per verified patch in gerrit (similar to findbugs) on
> a patch that touches one of the following directories:
>
> backend/manager/modules/compat
> backend/manager/modules/common
> backend/manager/modules/searchbackend
> backend/manager/modules/aaa
>

This can be easily added to check_patch.sh in the engine repo, you
don't need us (infra) to enable this at all.

--
Barak Korren
bkorren@redhat.com
RHEV-CI Team
_______________________________________________
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Eyal Edri
Associate Manager

RHEV DevOps
EMEA ENG Virtualization R&D
Red Hat Israel

phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)