On Tue, 11 Feb 2020 at 12:02, Marcin Sobczyk <msobczyk@redhat.com> wrote:

Hi,

agents used for CI runs for one of my patches [1] seem to be contaminated, i.e. our linters
run complains about files like [2]:

[2020-02-11T09:16:00.381Z] ./.local/share/virtualenv/seed-v1/3.7/image/SymlinkPipInstall/wheel-0.34.2-py2.py3-none-any/wheel/bdist_wheel.py:135:80: E501 line too long (84 > 79 characters)
[2020-02-11T09:16:00.381Z]             raise ValueError('Unsupported compression: {}'.format(self.compression))
[2020-02-11T09:16:00.381Z]                                                                                ^
[2020-02-11T09:16:00.381Z] ./.local/share/virtualenv/seed-v1/3.7/image/SymlinkPipInstall/wheel-0.34.2-py2.py3-none-any/wheel/bdist_wheel.py:145:80: E501 line too long (93 > 79 characters)
[2020-02-11T09:16:00.381Z]         if self.py_limited_api and not re.match(PY_LIMITED_API_PATTERN, self.py_limited_api):

tests are failing with [3]:

[2020-02-11T09:13:53.807Z] tox -e "tests,storage,lib,network,virt,gluster"
[2020-02-11T09:13:54.074Z] tests create: /home/jenkins/workspace/vdsm_standard-check-patch/vdsm/.tox/tests
[2020-02-11T09:13:54.336Z] ERROR: invocation failed (exit code 1), logfile: /home/jenkins/workspace/vdsm_standard-check-patch/vdsm/.tox/tests/log/tests-0.log
[2020-02-11T09:13:54.337Z] ================================== log start ===================================
[2020-02-11T09:13:54.337Z] ERROR:root:ImportError: cannot import name 'ensure_text'

The patch itself is minimal and the parent patch seemed to be fine [4].

I think the root cause for this is that inside mock $HOME == $PWD == where the repo is cloned.

Where we're seeing is that tox is trying to place the virtualenv it creates in $HOME/.local and then flake8 trying to scan everything under $PWD which happens to include the `.local` directory which ends up containing libraries that are not pep8 conforment....