On Mon, Feb 1, 2021 at 12:46 PM Marcin Sobczyk <msobczyk@redhat.com> wrote:


On 2/1/21 11:41 AM, Marcin Sobczyk wrote:
> Hi,
>
> On 1/31/21 4:22 PM, Yedidyah Bar David wrote:
>> On Sun, Jan 17, 2021 at 2:42 PM Yedidyah Bar David <didi@redhat.com
>> <mailto:didi@redhat.com>> wrote:
>>> Hi all,
>>>
>>> Ran [1] for verifying [2]. Passed [3] as CUSTOM_REPOS.
>>>
>>> lago.log [4] shows that it did add it to internal_repo, but it was not
>>> actually installed later. Perhaps something changed in local repos
>>> handling or something like that?
>> Now happened again, so I spent some more time looking. I tried this
>> locally (on buri03) and it did work - passing '-s URL' to run_suite.sh
>> did install/update packages from there. In CI it does not, e.g. [1].
>>
>> I think that the problem is around here, inside global_setup.sh:
>>
>> *11:04:29* + sudo -nl firewall-cmd
>>
>> *11:04:29* ++ sudo -n firewall-cmd --query-service=ovirtlago
>>
>> *11:04:30* + [[ ! -n yes ]]
>>
>> *11:04:30* + known_hosts
>>
>> Meaning, there were no sudo permissions to run firewall-cmd,
>> so it didn't add 8585, so later (in lago.log):
>>
>> + ADDR=192.168.200.1
>> + curl_res=0
>> + curl -f http://192.168.200.1:8585/default/el8/repodata/repomd.xml
>> <http://192.168.200.1:8585/default/el8/repodata/repomd.xml>
>>    % Total    % Received % Xferd  Average Speed   Time    Time     Time
>>   Current
>>                                   Dload  Upload   Total   Spent    Left
>>   Speed
>> \r  0     0    0     0    0     0      0      0 --:--:-- --:--:--
>> --:--:--     0curl: (7) Failed to connect to 192.168.200.1 port 8585:
>> Connection refused
>> + curl_res=7

Are you sure this failed because the proxy wasn't running, and not because
it was blocked? How did this work for me on buri03, then?
 
>>
>> Since this seems like an infra issue, moving to infra list.
>>
>> Can someone have a look there? Thanks!
> The topic of adding and using extra repos in OST is complicated...
BTW we have an RFE for this that Harel is working on:

https://issues.redhat.com/browse/RHV-40844

Thanks :-). Commented there.
 


> Since HE suite is half-migrated to pytest and still depends on lago OST
> plugin, we need
> to add some legacy compatibility layer to 'conftest.py' like the one
> that still exists
> in basic suite:
>
> https://github.com/oVirt/ovirt-system-tests/blob/ebab2fc2c1c10a36bd835f4a8cdb18bd71903cf8/basic-suite-master/test-scenarios/conftest.py#L31
>
> Please try using custom repos with this added ^^^.

I already verified manually and merged the patch I wanted to test (to ovirt-hosted-engine-ha).

I'll try to keep that in mind for the next time.

Best regards,
 
>
> Regards, Marcin
>
>> Best regards,
>>
>> [1]
>> https://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_manual/7726/
>> <https://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_manual/7726/>
>>
>>
>> On Sun, Jan 17, 2021 at 2:42 PM Yedidyah Bar David <didi@redhat.com
>> <mailto:didi@redhat.com>> wrote:
>>
>>      Hi all,
>>
>>      Ran [1] for verifying [2]. Passed [3] as CUSTOM_REPOS.
>>
>>      lago.log [4] shows that it did add it to internal_repo, but it was not
>>      actually installed later. Perhaps something changed in local repos
>>      handling or something like that?
>>
>>      Thanks and best regards,
>>
>>      [1]
>>      https://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_manual/7681/
>>      <https://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_manual/7681/>
>>
>>      [2] https://github.com/oVirt/ovirt-ansible-collection/pull/202
>>      <https://github.com/oVirt/ovirt-ansible-collection/pull/202>
>>
>>      [3]
>>      https://jenkins.ovirt.org/job/oVirt_ovirt-ansible-collection_standard-check-pr/468/artifact/check-patch.el8.x86_64/
>>      <https://jenkins.ovirt.org/job/oVirt_ovirt-ansible-collection_standard-check-pr/468/artifact/check-patch.el8.x86_64/>
>>
>>      [4]
>>      https://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_manual/7681/artifact/exported-artifacts/test_logs/he-basic-suite-master/post-012_local_maintenance_sdk_pytest.py/lago_logs/lago.log
>>      <https://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_manual/7681/artifact/exported-artifacts/test_logs/he-basic-suite-master/post-012_local_maintenance_sdk_pytest.py/lago_logs/lago.log>
>>      --
>>      Didi
>>
>>
>>
>> --
>> Didi



--
Didi