On Tue, Nov 17, 2015 at 10:47 AM, David Caro <dcaro@redhat.com> wrote:
> On 11/17 10:44, Yedidyah Bar David wrote:
>> See e.g. [1]. Patch was merged to master only (not to 3.6 branch), bug
>> was moved to modified. When I later pushed the patch to 3.6, it
>> correctly moved it back to POST. Not sure we should even automatically
>> move to modified if merged to 3.6, because there might be other
>> changes needed for that bug - it might be best to let the owner to
>> decide.
>
> The issue here is that there's no way for the hooks to know that you will be
> pushing more patches, so when it saw that there were no more open patches it
> moved the bug to MODIFIED. Is there any reason why you did not open the patches
> first?

There are two different issues here:

1. If merging to master branch, and bug is 3.6, bug should not be
moved to modified
at all.

2. If merging to 3.6 branch, and bug is 3.6, we might or might not
want to move to
modified. Not always people push all patches at once - sometimes they
prefer to have
some preparation patch merged (perhaps after a long review process, during which
the patch is changed quite a lot), then continue with more patches. This wasn't
current case, although I still think we might want to open it to discussion.

--
Didi
_______________________________________________
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra