Shall we kindly reply to the requester to submit via gerrit.ovirt.org?

בתאריך 27 באפר׳ 2016 14:53,‏ "Eyal Edri" <eedri@redhat.com> כתב:
Not the first time.
I think there was a task or thread on blocking this option if possible and adding a message on GitHub that requests will be accepted only via Gerrit.
OTOH, If we see there is a large group of developers contributing from GitHub, we might want to consider adding the GitHub gerrit plugin [1] which converts PR to ChangeSets.

[1] https://gerrit.googlesource.com/plugins/github/+/master/README.md

On Wed, Apr 27, 2016 at 2:49 PM, Barak Korren <bkorren@redhat.com> wrote:

This looks like a merged PR for ovirt-engine on github! wtf is going on?

‏---------- הודעה שהועברה ----------
מאת: "Hubtang" <notifications@github.com>
תאריך: 27 באפר׳ 2016 11:56
נושא: [oVirt/ovirt-engine] Eayunos 4.2 (#5)
אל: "oVirt/ovirt-engine" <ovirt-engine@noreply.github.com>
‏עותק:

Modify the welcome page & login page, and develop some widgets with an icon on the side of left via extends AbstractValidatedWidgetWithLabel.

You can view, comment on, or merge this pull request online at:

  https://github.com/oVirt/ovirt-engine/pull/5

Commit Summary

  • core: make OsRepository injectable using @Inject
  • core: hosted-engine: set the os type to linux on import
  • core: hosted-engine: missing config from engine-config
  • restapi: Fix update of virtio_scsi.enabled
  • core,webadmin: Not validating HostNetworkQos values
  • userportal: show fill in fields message
  • userportal: Fixed New Template dialog size
  • engine,userportal,webadmin: log uncaught UI exceptions
  • webadmin: auto-scroll SetupNetworks interfaces list during drag-and-drop
  • host-deploy: attemptConnection() should not throw exceptions
  • engine: both null and empty gateway should be considered as no gateway
  • packaging: rename: fixes for vmconsole proxy helper
  • core: Ignore expected exception during connection attempts
  • packaging: moving the ovirt extentions api dependencies to his own line
  • webadmin: Added fontend null checks
  • automation: add quick validation
  • core: Fix of merging of VmDynamics form DB and VDSM
  • automation: reducing GWT workers
  • jsonrpc: bump version
  • webadmin: Fix ClassCastException when importing VMs with pinned host
  • core: VmDevice null safe hashCode() method
  • engine: Do not assign creator as owner to VMs from pool
  • Add Attach Disk/Cpu profile permissions to all Import/Export capable roles
  • core: adding missing ctors
  • engine: Null ip configuration should be considered as NONE
  • webadmin: Add warning on live snapshot on VM without guest agent
  • core: missing constructor
  • frontend: Fix name uniqueness chack in ImportVmModel
  • frontend: Fix NPE in ImportVms Dialog
  • webadmin: Fix ClassCastException in SearchableListModel
  • core: Allow GetVmTemplatesByStoragePoolIdQuery in UserPortal
  • restapi: Populate vm.placement_policy.affinity
  • utils: Remove extra parameters in copyVmDevices
  • core: Prevent host device copy on pinned host mismatch
  • core: allow to balance migrate vm that run on specific host
  • build: post ovirt-engine-3.6.3 branching
  • core: fix remove disk snapshots for cinder
  • Use the proper whitelist for MigrateVmCommand.canDoAction
  • webadmin: Release keys removed from the console title
  • packaging: spec: Fix semanage requirement in fedora 23
  • packaging: setup: Do not require ovirt-log-collector
  • core: CreateSnapshot - add parameters ctor
  • webadmin: Uninitialized host fails to open hardware tab
  • webadmin: new pool dialog contained the sub version field
  • core: Reimplement PKIResources.Resource as class
  • Revert "core,webadmin: Not validating HostNetworkQos values"
  • webadmin: added warning when import windows without virtio
  • webadmin: change sizes of suggest boxes
  • webadmin: show the "latest" template only when the new VM is stateless
  • webadmin: use the cluster version rather than host one
  • webadmin: Consistent relation memory - guaranteed memory
  • core: Only allow continuous numa node indices
  • packaging: rename: Handle storage domains more nicely
  • core: cleanup cmd data when compensation deleted
  • webadmin: Warn for suspended VMs when cluster change
  • restapi: Fix RSDL for adding clusters
  • core: CreateAllSnapshotsFromVmCommand - use snapshot type from params
  • core: serialization/deserialization of SnapshotType
  • core: Do not acquire in left-most-available order
  • core: add code setting storage pool id in DetachNetworkFromVdsInterfaceCommand
  • core: Case-insensitive match of file name patterns
  • webadmin: Edit Fence Agent
  • core: Copy non template disks correctly
  • webadmin: Updated "Specific" label in Edit VM dialog
  • webadmin: Edit VM dialog -- capitalize "Host"
  • core: hosted engine: Avoid choosing the hosted engine sd as master
  • webadmin: Block restore memory on newer compatibility versions
  • scheduler: Add cpu pinning policy unit
  • webadmin: Fix migration policy update for running VM
  • core, frontend: Prevent console stealing from admin user
  • core: Set default boot order if absent in OVF
  • webadmin: Fix display if Online Logical CPU Cores list
  • core: new hook error code
  • webadmin: Fix display if Online Logical CPU Cores list
  • jsonrpc: version bump
  • packaging: fix ovirt-engine-setup-plugin-ovirt-engine dependencies
  • automation: add debug code for CI
  • webadmin: German messages overlapp with icons in Nic dialog
  • core: verify Live Merge image deletion on SPM
  • broker: Do not autogenerate numatune node pinnings
  • webadmin: Disk edit dialogs are all enbabled when they should not
  • webadmin: added help for Storage > ISO > DC > Attach
  • webadmin: Fixed column separator in new quota dialog
  • webadmin: Prevent NPE in StorageGeneralModel
  • core: Live Merge's check for merge completion is wrong
  • logging: remove debug message with no value
  • core: Use Callback for RunVmCommand.
  • core: Validate steps using CoCo on RunVmCommand
  • core: RunVmCommand using callbacks
  • core: Set parent command for child comamnd.
  • webadmin,userportal: Pass isAdmin flag to UI
  • core: adding CreateAllCinderSnapshotsCommand
  • core: Block adding host with XML-RPC protocol to 3.6 cluster
  • webadmin: Add a scroll panel to SetupNetworks networks list
  • scheduling: Initialize pending resource manager after all beans are injected
  • scheduling: Use the right memory value for pending memory checks
  • Fix the race between committed memory and pending memory updates
  • bll: Hosted Engine editing validator
  • core: custom parameters couldn't be updated and wasnt reported
  • restapi: custom parameters couldn't be updated and wasnt reported
  • core: Enable fencing of previous host which HE VM was running on
  • exttool: aaa: fix recursive loop print
  • backend: override default job property in ImportRepoImageCommand
  • userportal, webadmin: disable uncaught exception popup.
  • aaa: prevent of recursion loop in flat groups
  • webadmin: Add link to browser compatibility warning
  • engine: Fixing updating of HostNicVfsConfig table
  • engine: No validation for 'passthrough' profile DCs less than 3.6
  • packaging: engine-backup: Allow branding of help url
  • gluster: optionally stop gluster services
  • frontend: Only warn on timezone difference for Windows VMs
  • webadmin: Populate host protocol on 'edit host'
  • engine: Fix NPE in async task manager
  • webadmin: Make multiselect behaviour of list model consistent
  • frontend: Change VM Time Zone display string to 'Hardware Clock Time Offset'
  • packaging: setup: check if self-hosted-engine on el6
  • core: Remove condition for AsyncTaskType.notSupported.
  • core: Added Roles and groups for cpu profiling
  • core: fix windows vm name length validator
  • core: limit sysprep net-bios name to 15 chars
  • ui: Windows VM name validation is limited to 15 chars in sysprep
  • Revert "core: Remove condition for AsyncTaskType.notSupported."
  • jsonrpc: version update
  • core: sign websocket ticket did not work for VNC
  • webadmin: edit running VM is not possible
  • engine: Fix migration policy update for running VM
  • webadmin: Fix a bug in ISO domain attachment selection
  • build: post ovirt-engine-3.6.4 branching
  • webadmin: reorder quota list when creating disk or template
  • webadmin: Tag selection exception
  • refactor: Split syncDbRecords code
  • core: Wrap syncDbRecords code in a transaction
  • core: Move getImageInfo call outside of transaction boundary
  • core: Handle exception if calling VDSM fails
  • core: Remove index from curly braces
  • restapi: Fixed missing cloud_init mapping
  • engine: Leave cpuProfileId untouched after reading a snapshot
  • engine: ObjectIdentityChecker: Exclude transient fields from comparison
  • core: prevent duplicate virtio-serial device
  • core: prevent duplicate watchdog device on new vm
  • restapi: Don't fail with unexpected version numbers
  • userportal, webadmin: updated csh for VMs > Run Once
  • core: CommandBase - avoid setting end status prematurely
  • engine: Ignore change in creationDate for NEXT_RUN
  • Selectively enable VM field editing for hosted engine
  • core: Always persist changes to hosted-engine VM (avoid using NEXT_RUN)
  • webadmin: Do not fetch disk info together with VM templates
  • engine : No debug log entry for user executing an action or query
  • packaging: engine-backup: recreate dwh conf only if found
  • webadmin: Network Import dialog open/cancel fails
  • hostdev: Fix cleanup treatment in RefreshHostDevicesCommand
  • core: LiveMigrateDiskCommand - shared locks are unneeded
  • core: Provisioning of VMs created from Templates tab fix
  • webadmin: console not correctly loaded for edit template
  • userportal: ignore CpuProfileOperator for everyone
  • userportal,webadmin: fix external links
  • utils: Add missing javax.activation.api dependency
  • webadmin: Check box tooltip
  • core: Add support for suppressing audit log engine errors
  • core: Remove redundant shouldLogToAudit method
  • core: LiveMerge: Remove audit message when delete succeeds
  • core: Remove index from curly braces
  • core: Call end action once CopyTaskHandler is finished.
  • core: Avoid errors when applying NEXT_RUN snapshot
  • userportal, webadmin: fix vm status tooltip w/ alerts
  • userportal: added data-status attr for automation
  • HE: Fix next run need detection bug
  • HE: Set default priority and timezone when importing hosted engine VM
  • HE: Editing forbidden fields on HE VM should show better error
  • webadmin: Supported browser link color
  • webadmin: the HA flag was not shown in the edit instance type
  • engine: Allow Html5 as one of the default spice modes
  • engine-backup: allow backups to be done without ovirt-engine.
  • webadmin: Sessions in left tree was called 'Guest Information'
  • engine: Added VmActionByVmOriginTypeValidator for Allowed Cmds
  • webadmin: Avoid UpdateVmDiskCommand for hosted engine Edit VM
  • core: change template version of pool removed some vm devices
  • core: Fix of audit log message in UpdateVmCommand
  • core: prevent a race on add template version
  • core: graphics of template were not available in user portal
  • core: Console stealing fix
  • core: Fix of "virtual" memory hot (un)plug
  • packaging: Conflict on version below 3.5.6
  • restapi: schema: Allow to pass scheduling policy name for Update Cluster
  • build: post ovirt-engine-3.6.5 branch creation
  • kerbldap: Add deprecation message to engine-manage-domains
  • engine: Enabled editing HE in pre-upgrade script
  • v2v: Set disk's boot flag after conversion
  • packaging: setup: require correct otopi version
  • core: prevent a race on add template version - done right
  • webadmin: Fix name of notifier service
  • userportal: Fixed New Template dialog size
  • core: Support configurable mixed RHEL 6, 7 check
  • scheduler: Add in-cluster upgrade policy units
  • packaging: spec: Fix deps for ovirt-engine-tools-backup
  • core: Improve Host OS detection
  • core: Check if cluster upgrade can be started or stopped
  • core: Add InClusterUpgrade policy
  • core: Do not enforce affinity groups while in upgrade mode
  • core: Forbid suspending VMs while cluster is upgrading
  • core: Do not allow binding VMs to hosts during cluster upgrade
  • core: Treat specific different OS types as equal
  • core: Generate human readable error messages for cluster upgrade
  • scheduler: Give newest host OS versions the best weight on VM startup
  • core: adding support for ilo_ssh fence agent
  • construct jsonrpc with identifier name.
  • packaging: spec: remove %license call
  • HE: Make the unmanaged hosted engine error a bit more generic
  • HE: Enable hosted engine vNIC editing
  • restapi: Tolerate invalid fencing options
  • webadmin: Added CPU Profiles Roles to the RoleTree
  • packaging: Allow different java home per component
  • scheduler: Store correct OS version in map
  • core: Added permissions to Power User
  • engine: Limited use of CPU Profiles by user
  • core: do not ping too often
  • setup: fixing setup when engine option is not enabled
  • core: Disabled ability to make VM HA on hosted engine
  • core: reducing race - avoid syncing the storage domain status when its in process
  • userportal, webadmin: use a custom patched bootstrap.js
  • webadmin: Name validation invalidates the General tab
  • webadmin: fix memory leak in alerts / events footer
  • restapi: BackendTemplateDiskResource.copy() - pass the disk id
  • HE: fixed the vm nic changing it's status to unplugged.
  • core: Added cpu profiles permissions propagation
  • core: fix import from configuration as clone
  • webadmin: Warning for unsupported memory restore (Custom Snapshot Preview)
  • Ignore memory and CPU hotplug errors for hosted engine VM
  • core: Refactor - created helper class for IoTune
  • core: Dao functions take lists of ids
  • core: Enable live QoS change for cpu and IO
  • userportal: use the default host that was set in template in a vm
  • hyperv: default on again for windows >= 2008/2012
  • core: cleanup old event notification history
  • core: Removes empty line from upgrade script
  • webadmin: Fix event handling after CPU Count change of running VM
  • engine: Remove hotplugged memory & CPUs from changed fields list
  • core: Don't overwrite local domain's format
  • vdsbroker: wait for reconnection
  • webadmin: Fix NPE in Edit VM dialog
  • restapi: Add links to SSH public keys
  • packaging: engine-backup: Backup ovirt-vmconsole conf and pki
  • userportal: use the default host that was set in vm in template
  • core: open Cockpit port in firewall
  • packaging: setup: versionlock tools-backup
  • core: Add cinder call back for AddVmFromSnapshot.
  • core: Added permissions on AddProfileBase
  • core: Refactored ProfileParametersBase constructor
  • webadmin: Fixed remove storage qos error popup
  • core: Make disk list of VM editable on HE update

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub


_______________________________________________
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra




--
Eyal Edri
Associate Manager
RHEV DevOps
EMEA ENG Virtualization R&D
Red Hat Israel

phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)