If you disabled other people from watching it if they are not reviewers then it's fine to leave it like that then

On Tue, Dec 20, 2016 at 6:21 PM, Shlomo Ben David <sbendavi@redhat.com> wrote:

About the last thing...

When people push drafts only they can view them, unless they add someone as reviewers before publishing it as a regular patch.

That's why I think it is useless permission, but if you still want i can add it.

Best Regards,

Shlomi Ben-David | Software Engineer | Red Hat ISRAEL

RHCSA | RHCE  

IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1

On Tue, Dec 20, 2016 at 6:10 PM, Tal Nisan <tnisan@redhat.com> wrote:

None, just +2, especially not remove other reviewers as sometimes people remove the gerrit-hooks without asking.

If you can block people from pushing drafts to the stable branches it will also be great

On Tue, Dec 20, 2016 at 5:52 PM, Shlomo Ben David <sbendavi@redhat.com> wrote:

Hi Tal/Eyal,

I added CR (-/+)2 permission for the ovirt-engine-master-maintainers group on the stable-branches.

Best Regards,

Shlomi Ben-David | Software Engineer | Red Hat ISRAEL

RHCSA | RHCE  

IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1

On Tue, Dec 20, 2016 at 5:12 PM, Eyal Edri <eedri@redhat.com> wrote:

I wasn't aware we were allowing +2 permissions without merge rights on stable branch,

If this should be supported then we need to update the permissions, so all master branch maintainers need +2 (w/o merge) to stable branches?

On Tue, Dec 20, 2016 at 4:58 PM, Tal Nisan <tnisan@redhat.com> wrote:

Master

On Tue, Dec 20, 2016 at 4:53 PM, Eyal Edri <eedri@redhat.com> wrote:

stable branch maintainers or master branch maintainers? 

On Dec 20, 2016 4:40 PM, "Tal Nisan" <tnisan@redhat.com> wrote:

Heard it from a couple of guys, yesterday it appeared to be working fine, today it's not

_______________________________________________
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

--

Eyal Edri
Associate Manager

RHV DevOps
EMEA ENG Virtualization R&D
Red Hat Israel

phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)