DafnaThanks,Can you try to run the fix using mock locally?I am adding Barak and Daniel because we may need to look at the manual job to see why it would pass there and not in CQ.Hi Ravi,I trust CQ more then the manual job :)On Wed, Sep 12, 2018 at 2:41 PM, Ravi Shankar Nori <rnori@redhat.com> wrote:On Wed, Sep 12, 2018 at 9:14 AM, Dafna Ron <dron@redhat.com> wrote:Hi Ravi,I looked at the parameters of the manual job and the job ran is in 4.2 while the failure is in master branch.On Wed, Sep 12, 2018 at 2:07 PM, Ravi Shankar Nori <rnori@redhat.com> wrote:Hi Dafna,I ran OST upgrade from release on my patch [1] and it seems to pass OST [2]What am I missing?ThanksRaviOn Wed, Sep 12, 2018 at 7:02 AM, Dafna Ron <dron@redhat.com> wrote:Hi Ravi,it seems your patch is failing CQ with the same issue:
https://jenkins.ovirt.org/job/ovirt-master_change-queue-test er/10230/ can you please take a look?Thanks,DafnaOn Wed, Sep 12, 2018 at 8:08 AM, Dafna Ron <dron@redhat.com> wrote:Thank you Ravi.On Tue, Sep 11, 2018 at 4:22 PM, Ravi Shankar Nori <rnori@redhat.com> wrote:Hi Dafna,Posted a patch to fix the issue [1]. [2] successful OST execution.ThanksRaviOn Tue, Sep 11, 2018 at 4:44 AM, Dafna Ron <dron@redhat.com> wrote:The patch reported as cause is:Hi,we have failures on both upgrade and basic suites for master.
https://gerrit.ovirt.org/#/c/93345/10 - engine : Add finer grained monitoring thresholds for memory consumption on HypervisorsRavi, can you please check this issue?You can see the logs here:
https://jenkins.ovirt.org/job/ovirt-master_change-queue-test er/10187/artifact/basic-suite. el7.x86_64/test_logs/basic-sui te-master/ Here is the error:
2018-09-11 02:08:44,511-04 WARNÂ [org.ovirt.engine.core.bll.AddClusterCommand] (default task-2) [1362d97c-9d55-40d2-9b03-ebe93 ae2fe67] Validation of action 'AddCluster' failed for user admin@internal-authz. Reasons: VAR__TYPE__CLUSTER,VAR
__ACTION__CREATE,must be greater than or equal to 1,$groups [Ljava.lang.Class;@29a040fc,$message {javax.validation.constraints. Min.message},$payload [Ljava.lang.Class;@64094510,$v alue 1,ACTION_TYPE_FAILED_ATTRIBUTE _PATH,$path cluster.logM
axMemoryUsedThreshold,$validatedValue 0
2018-09-11 02:08:44,511-04 DEBUG [org.ovirt.engine.core.common.di.interceptor.DebugLoggingInt erceptor] (default task-2) [1362d97c-9d55-40d2-9b03-ebe93 ae2fe67] method: runAction, params: [AddCluster, ManagementNetworkOnClusterOper ationPara
meters:{commandId='e5eb6cf6-4e3d-4f50-be6a-9fe18bfc4d97', user='null', commandType='Unknown'}], timeElapsed: 56ms
2018-09-11 02:08:44,516-04 ERROR [org.ovirt.engine.api.restapi.resource.AbstractBackendResour ce] (default task-2) [] Operation Failed: [must be greater than or equal to 1, Attribute: cluster.logMaxMemoryUsedThresh old]
2018-09-11 02:08:44,533-04 DEBUG [org.ovirt.engine.core.aaa.filters.SsoRestApiAuthFilter] (default task-2) [] Entered SsoRestApiAuthFilter Thanks,Dafna