From alinefm at linux.vnet.ibm.com Tue Jun 17 16:11:03 2014 Content-Type: multipart/mixed; boundary="===============3143383252661386471==" MIME-Version: 1.0 From: Aline Manera To: kimchi-devel at ovirt.org Subject: Re: [Kimchi-devel] [PATCHv3 3/3] Add doc and test case for dedicate iso pool Date: Tue, 17 Jun 2014 17:10:56 -0300 Message-ID: <53A0A0D0.30605@linux.vnet.ibm.com> In-Reply-To: 53A09EBA.5090705@linux.vnet.ibm.com --===============3143383252661386471== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 06/17/2014 05:02 PM, Aline Manera wrote: > On 06/16/2014 05:29 AM, lvroyce(a)linux.vnet.ibm.com wrote: >> From: Royce Lv >> >> Add doc for user to upload the iso to a dedicate pool, >> add testcase to validate correctness. >> >> Signed-off-by: Royce Lv >> --- >> docs/README.md | 5 +++++ >> tests/test_model.py | 3 +++ >> ui/pages/help/en_US/storage.dita | 3 ++- >> ui/pages/help/en_US/templates.dita | 3 ++- >> ui/pages/help/pt_BR/storage.dita | 3 ++- >> ui/pages/help/pt_BR/templates.dita | 3 ++- >> ui/pages/help/zh_CN/storage.dita | 3 ++- >> ui/pages/help/zh_CN/templates.dita | 3 ++- >> 8 files changed, 20 insertions(+), 6 deletions(-) >> >> diff --git a/docs/README.md b/docs/README.md >> index c658637..2591f7c 100644 >> --- a/docs/README.md >> +++ b/docs/README.md >> @@ -143,6 +143,11 @@ The template screen looks like: >> From this view, you can change the parameters of a template or = >> create a >> new template using the "+" button in the upper right corner. >> >> +To create a template, you need an ISO on your host or using remote one. >> +If you are willing to use your own ISO, >> +please copy it to out of box storage pool (default path is: >> +/var/lib/libvirt/isos). >> + >> Known Issues >> ------------ >> >> diff --git a/tests/test_model.py b/tests/test_model.py >> index 142e4fc..ea38f59 100644 >> --- a/tests/test_model.py >> +++ b/tests/test_model.py >> @@ -416,6 +416,9 @@ class ModelTests(unittest.TestCase): >> self.assertIn('default', pools) >> poolinfo =3D inst.storagepool_lookup('default') >> self.assertEquals('active', poolinfo['state']) >> + self.assertIn('ISO', pools) >> + poolinfo =3D inst.storagepool_lookup('ISO') >> + self.assertEquals('active', poolinfo['state']) >> self.assertEquals((num - 1), len(pools)) >> >> @unittest.skipUnless(utils.running_as_root(), 'Must be run as = >> root') >> diff --git a/ui/pages/help/en_US/storage.dita = >> b/ui/pages/help/en_US/storage.dita >> index 12ce15c..7ab74a9 100644 >> --- a/ui/pages/help/en_US/storage.dita >> +++ b/ui/pages/help/en_US/storage.dita >> @@ -10,7 +10,8 @@ https://w3.opensource.ibm.com/projects/dita-cshelp/--> >> >> Storage >> The Storage page lists the available >> -storage pools, including the default storage pool. >> +storage pools, including the out of box 'default' and 'ISO' storage = >> pool. >> +If you want to use your own ISO, please scp it to 'ISO' storage pool = >> path. > > As 'scp' is command, I'd suggest to don't use it on help pages. > We can replace it to "add" I will do that before applying > >> >>

For each storage pool, the following information is displayed:

>> >> diff --git a/ui/pages/help/en_US/templates.dita = >> b/ui/pages/help/en_US/templates.dita >> index aee0726..f5f5a43 100644 >> --- a/ui/pages/help/en_US/templates.dita >> +++ b/ui/pages/help/en_US/templates.dita >> @@ -74,7 +74,8 @@ you edit a field, click = >> Save.

>> >> >> Add template >> -Add a template from source media. >> +Add a template from source media. >> +You can scp your own ISO image to 'ISO' storage pool for following = >> discovery. >> >>

Select the location of the source media from the following = >> options:

>> >> diff --git a/ui/pages/help/pt_BR/storage.dita = >> b/ui/pages/help/pt_BR/storage.dita >> index 12ce15c..7ab74a9 100644 >> --- a/ui/pages/help/pt_BR/storage.dita >> +++ b/ui/pages/help/pt_BR/storage.dita >> @@ -10,7 +10,8 @@ https://w3.opensource.ibm.com/projects/dita-cshelp/--> >> >> Storage >> The Storage page lists the available >> -storage pools, including the default storage pool. >> +storage pools, including the out of box 'default' and 'ISO' storage = >> pool. >> +If you want to use your own ISO, please scp it to 'ISO' storage pool = >> path. >> >>

For each storage pool, the following information is displayed:

>> >> diff --git a/ui/pages/help/pt_BR/templates.dita = >> b/ui/pages/help/pt_BR/templates.dita >> index aee0726..f5f5a43 100644 >> --- a/ui/pages/help/pt_BR/templates.dita >> +++ b/ui/pages/help/pt_BR/templates.dita >> @@ -74,7 +74,8 @@ you edit a field, click = >> Save.

>> >> >> Add template >> -Add a template from source media. >> +Add a template from source media. >> +You can scp your own ISO image to 'ISO' storage pool for following = >> discovery. >> >>

Select the location of the source media from the following = >> options:

>> >> diff --git a/ui/pages/help/zh_CN/storage.dita = >> b/ui/pages/help/zh_CN/storage.dita >> index 12ce15c..7ab74a9 100644 >> --- a/ui/pages/help/zh_CN/storage.dita >> +++ b/ui/pages/help/zh_CN/storage.dita >> @@ -10,7 +10,8 @@ https://w3.opensource.ibm.com/projects/dita-cshelp/--> >> >> Storage >> The Storage page lists the available >> -storage pools, including the default storage pool. >> +storage pools, including the out of box 'default' and 'ISO' storage = >> pool. >> +If you want to use your own ISO, please scp it to 'ISO' storage pool = >> path. >> >>

For each storage pool, the following information is displayed:

>> >> diff --git a/ui/pages/help/zh_CN/templates.dita = >> b/ui/pages/help/zh_CN/templates.dita >> index aee0726..f5f5a43 100644 >> --- a/ui/pages/help/zh_CN/templates.dita >> +++ b/ui/pages/help/zh_CN/templates.dita >> @@ -74,7 +74,8 @@ you edit a field, click = >> Save.

>> >> >> Add template >> -Add a template from source media. >> +Add a template from source media. >> +You can scp your own ISO image to 'ISO' storage pool for following = >> discovery. >> >>

Select the location of the source media from the following = >> options:

>> > > _______________________________________________ > Kimchi-devel mailing list > Kimchi-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/kimchi-devel > --===============3143383252661386471==--