From alinefm at linux.vnet.ibm.com Fri Jul 3 08:40:09 2015
Content-Type: multipart/mixed; boundary="===============9086467722045505395=="
MIME-Version: 1.0
From: Aline Manera
To: kimchi-devel at ovirt.org
Subject: Re: [Kimchi-devel] [PATCH 2/2] Review changes for Kimchi
Date: Fri, 03 Jul 2015 09:39:56 -0300
Message-ID: <5596829C.5080904@linux.vnet.ibm.com>
In-Reply-To: 1435704502-8836-1-git-send-email-kersten@us.ibm.com
--===============9086467722045505395==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
On 30/06/2015 19:48, Kersten wrote:
> Made changes to 3 files per comments from Aline.
>
> Signed-off-by: Kersten
> ---
> ui/pages/help/en_US/guests.dita | 30 +++++++++++++++---------------
> ui/pages/help/en_US/storage.dita | 8 ++++----
> ui/pages/help/en_US/templates.dita | 15 +++++++++------
> 3 files changed, 28 insertions(+), 25 deletions(-)
>
> diff --git a/ui/pages/help/en_US/guests.dita b/ui/pages/help/en_US/guests=
.dita
> index 7d0d453..45cf7da 100644
> --- a/ui/pages/help/en_US/guests.dita
> +++ b/ui/pages/help/en_US/guests.dita
> @@ -10,14 +10,14 @@ https://w3.opensource.ibm.com/projects/dita-cshelp/-->
>
> Guests
> The Guests page lists the defined
> -guests or virtual machines.
> +guests for your server.
>
> For each guest, the following information is displayed:
> - Name
> -- Name of the virtual machine.
> +- Name of the guest.
>
> - CPU
> -- Percentage of processor utilization in the virtual machine.
> +- Percentage of processor utilization in the guest.
>
> - Disk I/O
> - Disk input/output transmission rate in KB per seconds.
> @@ -53,16 +53,16 @@ existing guest. Guests can be edited only while stopp=
ed.
> - Select Power Off to force an immediate
> shut down of the guest.
> - Select Delete to delete the guest.
> -To create a guest, or virtual machine, click the plus
> -(+) icon on the page.
> +To create a guest, click the plus (+) icon
> +on the page.
>
>
> -Create a guest (virtual machine)
> +Create a guest
> Create a guest by using an existing template.
>
>
> -- Type the name to be used to identify the virtual machine.
> -- Select a template.
> +- Type the name to be used to identify the guest.
> +- Select a template.
> - If templates exist, select from displayed templates.
> - If no templates exist, click Create a template to
> create a template.
> @@ -73,9 +73,9 @@ create a template.
>
>
> Edit guest
> -Edit the properties of an existing virtual machine. Some
> -properties can be edited only while guest is stopped. Others will
> -take effect in next boot.
> +Edit the properties of an existing guest. Some properties
> +can be edited only while guest is stopped. Others will take effect
> +in next boot.
>
>
> - General
> @@ -124,11 +124,11 @@ guest.
> iSCSI volumes or if the target pool does not have enough space, the
> clone will be created on a default storage pool.
>
> -A guest appears in your list with the label "cloning..." When the
> -process is complete, the cloned guest is available to use.
-Caret 54?>
> +A guest appears in your list with the label Cloning... When
> +the process is complete, the cloned guest is available to use.
+Caret 45?>
>
>
>
>
> -
> +
> diff --git a/ui/pages/help/en_US/storage.dita b/ui/pages/help/en_US/stora=
ge.dita
> index e6f995d..53d1404 100644
> --- a/ui/pages/help/en_US/storage.dita
> +++ b/ui/pages/help/en_US/storage.dita
> @@ -94,16 +94,16 @@ pool is created, it will be created for you.
>
>
> Add volume
> -Adds volume to a storage pool.
> +Adds volume to a storage pool.
>
>
> - Fetch from remote URL
> -- Specifies a location to upload the volume from. For example: https://my-server/fedora22.img.
> +- Specifies a location to download the volume from. For example: https://my-server/fedora22.img.
>
> - Upload a file
> - Specifies a location on your local system.
> -
> +
>
>
>
> -
> +
> diff --git a/ui/pages/help/en_US/templates.dita b/ui/pages/help/en_US/tem=
plates.dita
> index 1c03016..ad3747c 100644
> --- a/ui/pages/help/en_US/templates.dita
> +++ b/ui/pages/help/en_US/templates.dita
> @@ -55,7 +55,7 @@ You can select multiple networks.
> In the CPU Number field, specify the number
> of processors that are defined for the template.
> Select to Manually set CPU topology for each guest.
> -
> +
>
>
>
> @@ -69,16 +69,19 @@ ISO image to 'ISO' storage pool for following discove=
ry.
> Select to scan storage pools for installation ISO images available
> on the system.
>
> +Local Image File
> +Select to specify a path to the local image file.
> +
> Remote ISO image
> Select to specify a remote location for an installation ISO image.<=
/dd>
>
>
>
>
> -Add template - local ISO image
> -Add a template from a local ISO image.
> +Add template - ISO image
> +Add a template from a ISO image.
>
> -The ISO images available on the system are displayed.
> +The ISO images available on the system ore remotely are displayed.
Just a typo here 'ore' but I can fix is before applying.
>
> - OS
> - Name of the operating system or distribution.
> @@ -105,7 +108,7 @@ specify a path to the ISO image.
> ISO images.
>
>
> -
> +
>
>
> -
> +
--===============9086467722045505395==--