From alinefm at linux.vnet.ibm.com Mon Jan 20 20:00:14 2014 Content-Type: multipart/mixed; boundary="===============3686422702651292705==" MIME-Version: 1.0 From: Aline Manera To: kimchi-devel at ovirt.org Subject: Re: [Kimchi-devel] [PATCH 3/5] Issue #310: Query correct name to validate logical devices Date: Mon, 20 Jan 2014 23:00:09 -0200 Message-ID: <52DDC699.4090105@linux.vnet.ibm.com> In-Reply-To: 1390255778-29000-3-git-send-email-vianac@linux.vnet.ibm.com --===============3686422702651292705== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Reviewed-by: Aline Manera On 01/20/2014 08:09 PM, Cr=C3=ADstian Viana wrote: > The dialog to create a new logical storage pool must validate the user > input by checking if they selected at least one of the available > devices. However, the code is looking for checkboxes with a non-existing > element name and it is always reporting that the user did not select any = of > them - even when they do. Therefore, it is impossible to create a > logical storage pool. > > Change the HTML element name of the devices' checkboxes on the storage po= ol > page to match the validation algorithm. Instead of "source.devices", use > the name "devices" on those elements. > > Signed-off-by: Cr=C3=ADstian Viana > --- > ui/pages/storagepool-add.html.tmpl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ui/pages/storagepool-add.html.tmpl b/ui/pages/storagepool-ad= d.html.tmpl > index e8dac43..03c063d 100644 > --- a/ui/pages/storagepool-add.html.tmpl > +++ b/ui/pages/storagepool-add.html.tmpl > @@ -143,7 +143,7 @@ > > --===============3686422702651292705==--