From alinefm at linux.vnet.ibm.com Tue Apr 22 13:51:59 2014
Content-Type: multipart/mixed; boundary="===============0451426208263736152=="
MIME-Version: 1.0
From: Aline Manera <alinefm at linux.vnet.ibm.com>
To: kimchi-devel at ovirt.org
Subject: Re: [Kimchi-devel] [PATCHv2 3/3] Display all disk types in storage
 edit view
Date: Tue, 22 Apr 2014 14:51:52 -0300
Message-ID: <5356AC38.6070308@linux.vnet.ibm.com>
In-Reply-To: 1398157542-3538-4-git-send-email-lvroyce@linux.vnet.ibm.com

--===============0451426208263736152==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


Reviewed-by: Aline Manera <alinefm(a)linux.vnet.ibm.com>

On 04/22/2014 06:05 AM, lvroyce(a)linux.vnet.ibm.com wrote:
> From: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
>
> Instead of just displaying cdrom type in storage edit view,
> Add disk type to storage display view to make sure
> we get the right view after attach and detach new disk.
>
> Signed-off-by: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
> ---
>   ui/js/src/kimchi.guest_edit_main.js |  5 ++---
>   ui/pages/guest-edit.html.tmpl       | 17 ++++++++++++++++-
>   2 files changed, 18 insertions(+), 4 deletions(-)
>
> diff --git a/ui/js/src/kimchi.guest_edit_main.js b/ui/js/src/kimchi.guest=
_edit_main.js
> index 9375c51..eec1214 100644
> --- a/ui/js/src/kimchi.guest_edit_main.js
> +++ b/ui/js/src/kimchi.guest_edit_main.js
> @@ -34,15 +34,14 @@ kimchi.guest_edit_main =3D function() {
>
>       var refreshCDROMs =3D function() {
>           kimchi.listVMStorages({
> -            vm: kimchi.selectedGuest,
> -            storageType: 'cdrom'
> +            vm: kimchi.selectedGuest
>           }, function(storages) {
> -            var rowHTML =3D $('#cdrom-row-tmpl').html();
>               var container =3D $('#guest-edit-cdrom-row-container');
>               $(container).empty();
>
>               $.each(storages, function(index, storage) {
>                   storage['vm'] =3D kimchi.selectedGuest;
> +                rowHTML =3D $('#' + storage['type'] + '-row-tmpl').html(=
);
>                   var templated =3D kimchi.template(rowHTML, storage);
>                   container.append(templated);
>               });
> diff --git a/ui/pages/guest-edit.html.tmpl b/ui/pages/guest-edit.html.tmpl
> index 804fc39..0405d6f 100644
> --- a/ui/pages/guest-edit.html.tmpl
> +++ b/ui/pages/guest-edit.html.tmpl
> @@ -133,7 +133,22 @@
>           </div>
>       </div>
>   </script>
> -
> +<script id=3D"disk-row-tmpl" type=3D"text/html">
> +    <div>
> +        <div class=3D"guest-edit-wrapper-label">
> +            <label for=3D"disk-{dev}">{dev}</label>
> +        </div>
> +        <div class=3D"guest-edit-wrapper-controls">
> +            <input id=3D"disk-{dev}" name=3D"disk" type=3D"text"
> +                data-vm=3D"{vm}" data-dev=3D"{dev}"
> +                value=3D"{path}" readonly=3D"readonly" />
> +            <button class=3D"guest-edit-cdrom-button detach"
> +                data-vm=3D"{vm}" data-dev=3D"{dev}"
> +                title=3D"$_("Detach")">
> +            </button>
> +        </div>
> +    </div>
> +</script>
>   <script type=3D"text/javascript">
>       kimchi.guest_edit_main();
>   </script>


--===============0451426208263736152==--