Thanks, Atreyee!
Seems you forgot to include the Kimchi ML. I am doing it now so
everyone can be aware about that.
Please, send the patch itself direct to the ML. It is easy to apply
the changes and test.
Regards,
Aline Manera
On 15/10/2015 09:27, Atreye
Mukhopadhyay wrote:
Hi Samuel,
I have fixed the issue you mentioned during the hangout meeting
session regarding the incorrect action name for enabled
repositories in repository list.
I worked on the latest code available in your branch https://github.com/samhenri/kimchi.git
. I have made changes in "onRowSelected" method in
kimchi.host.js. Changes are highlighted below.
Enable/disable button of each row was having same 'id' . Incorrect
action was displayed for the enabled repositories other than first
record as $('#repositories-grid-enable-button') was always
returning button from first action dropdown menu.
onRowSelected: function(row) {
var repository = repositoriesGrid.getSelected();
if (!repository) {
return;
}
var selectedRow = $('tr',
repositoriesGrid.bodyContainer);
$('#repositories-grid-remove-button',selectedRow).prop('disabled',
false);
$('#repositories-grid-edit-button',selectedRow).prop('disabled',
false);
var enabled = repository['enabled'];
$('#repositories-grid-enable-button',selectedRow)
.html('<i class="fa
fa-play-circle-o"></i>'+i18n[enabled ?
'KCHREPO6017M' : 'KCHREPO6016M'])
.prop('disabled', false);
},
Screenshots are attached herewith.
Please ignore the mail if you have resolved the issue already .
Thanks & Regards,
Atreyee