On 8/12/2014 2:41 AM, Crístian Viana wrote:
On 11-08-2014 11:22, shaohef@linux.vnet.ibm.com wrote:
From: ShaoHe Feng <shaohef@linux.vnet.ibm.com>

We don not need a special "save" button for permission form.

All form in guest edit tab can share the same "save" button.

also, we will add a password form, it will also share this button.

Signed-off-by: ShaoHe Feng <shaohef@linux.vnet.ibm.com>
Signed-off-by: Simon Jin <simonjin@linux.vnet.ibm.com>
Why are we using a save button for each tab in that dialog? That's definitely not a common user experience. One would expect that a "Save" button in that dialog would apply all changes done in the dialog, not on that tab alone. What if the user wants to change the VM name and permission (and the password, after the next patch)? They will need to open the "Edit Guest" dialog, changing the value they want to change, and then saving that value alone. Three times. That's not a good flow.

IMO, we should have only one "Save" button which, when clicked, applies all the changes done in that dialog. Not a button which does different things depending on which tab the user is on.

1. Right now, there are already many options when editing VM, and I believe there will be more and more.
    Each time user edit VM, they will only edit one or two options(a small portion of all), save all the options back is inefficient and go against user's intension.
2. The design need to be changed to save what user has changed and allow user to change at a fine granularity, I noticed that virt-manager did a good job here.
    In virt-manager, user can update anything in a quite fine granularity and the 'apply' button feels quite make sense to indicate that it just update what user is changing.

    



_______________________________________________
Kimchi-devel mailing list
Kimchi-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel