Exactly. If you inspect the current code for username and password, they both have the placeholder attribute (html5) and
hidden labels. Please note that elements with CSS property “display: none” are always ignored by screen reader software. The bootstrap class “sr-only” hides the content in the negative space of the element keeping the element display property unchanged.
Samuel
From: kimchi-devel-bounces@ovirt.org
[mailto:kimchi-devel-bounces@ovirt.org] On Behalf Of Daniel Henrique Barboza
Sent: terça-feira, 10 de maio de 2016 11:12
To: kimchi-devel@ovirt.org
Subject: Re: [Kimchi-devel] [Wok][PATCH v2 0/7] Multi-Culture Support
On 05/09/2016 04:44 PM, Samuel Henrique De Oliveira Guimaraes wrote:
Hi,
I don’t think the new login.html is good for accessibility with screen reader software. I don’t have the tools to test it, but the form fields were added to a <dl> element (Definition list) when just the <form>, <label> and <input> elements should be enough for accessibility, usability and styling.
From my experience with screen readers, the output from a screen reader would be something like this:
-Definition List
-Definition term: Username.
-Definition description: input type text Username.
-Definition term: Password.
-Definition description: input type password Password.
-Definition term: Language.
-Definition description: Select.
-Selected option: English (US).
If we move the Locale and display it under the <select> element, it should be done with CSS only. Personally, I think it doesn’t look good. Instead I think we could align it in the middle, just like we do with the Log In button.
I don’t think displaying the label and the select in a single line is good for mobile usability with the login page and it doesn’t make sense to create a different login page for mobile and desktop just to move a label: http://baymard.com/blog/mobile-form-usability-label-position
I am no UI expert but we need to be sure that we do not add any
HTML5 code that will gives us trouble when dealing with Accessibility.
Thanks,
Samuel
From: kimchi-devel-bounces@ovirt.org [mailto:kimchi-devel-bounces@ovirt.org] On Behalf Of Aline Manera
Sent: segunda-feira, 9 de maio de 2016 10:39
To: pkulkark@linux.vnet.ibm.com; Kimchi Devel <kimchi-devel@ovirt.org>
Subject: Re: [Kimchi-devel] [Wok][PATCH v2 0/7] Multi-Culture Support
Hi all,
I'd like suggest changes on UI layout.
I am not sure about the best practices to display language and locale to users but I will suggest to put:
<label> <drop down menu> in a single line, instead of having the label under the drop down menu.
Samuel, any suggestion on that area?
Regards,
Aline Manera
On 05/05/2016 04:02 AM, pkulkark@linux.vnet.ibm.com wrote:
From: Pooja Kulkarni <pkulkark@linux.vnet.ibm.com>This patch set provides multi-culturesupport by adding another drop downlist during login for user localeselection. The numeric data and datetimefields are formatted based on the localeselected.Pooja Kulkarni (7):Multi-Culture Support - Add a separate drop down list for localeMulti-Culture support - Add methods to get and set locales inwok.lang.jsMulti-Culture support - Add locale in format settings inwok.line-chart.jsMulti-Culture support : Format datetime as per locale in wok.list.jsMulti-Culture support : Implement new drop down list for locale inwok.login.jsMulti-Culture support : Modify wok.formatMeasurement util to includeformatting based on localeMulti-Culture support : Format datetime in user activity log as perlocaleui/js/src/wok.lang.js | 8 ++++++++ui/js/src/wok.line-chart.js | 3 ++-ui/js/src/wok.list.js | 6 +++++-ui/js/src/wok.login.js | 9 +++++++++ui/js/src/wok.utils.js | 10 +++++++---ui/js/wok.bootgrid.js | 10 +++++++++-ui/js/wok.user-log.js | 3 ++-ui/pages/login.html.tmpl | 34 ++++++++++++++++++++++++++++++++++8 files changed, 76 insertions(+), 7 deletions(-)
_______________________________________________Kimchi-devel mailing listKimchi-devel@ovirt.orghttp://lists.ovirt.org/mailman/listinfo/kimchi-devel
