On 02/13/2014 10:03 PM, Crístian Viana wrote:
AFAIU, that setting overrides the icon for everything served by cherrypy. If that's right, can you also remove the following line from ui/pages/kimchi-ui.html.tmpl?

yes. we it can work well.
<link rel="shortcut icon" href="images/logo.ico">

Or is it still needed?
But I think we can keep it.

Here is the document of w3.
http://www.w3.org/2005/10/howto-favicon

w3 prefer to use of a rel attribute value defined in a profile.

However this are some limitations:
1. rel only work in HTML or XHTML
2. rel only can works in one document, not a collection of documents (i.e., a site)

So I have have to set the favicon.ico for the whole site.


Am 13-02-2014 11:53, schrieb shaohef@linux.vnet.ibm.com:
From: ShaoHe Feng <shaohef@linux.vnet.ibm.com>

When we start a VNC window, the favicon.ico is always cherrypy icon.

Actually we open any page:
such as:
http://192.168.1.117:8000/error

the favicon.ico is also a cherrypy icon.

This patch fix this bug.

Ref:
http://docs.cherrypy.org/en/latest/progguide/files/favicon.html

Signed-off-by: ShaoHe Feng <shaohef@linux.vnet.ibm.com>




-- 
Thanks and best regards!

Sheldon Feng(冯少合)<shaohef@linux.vnet.ibm.com>
IBM Linux Technology Center