Assuming that you don't change or exclude any existing info/result from the
current API (ex: exclude an existing key), I approve this proposal.


Daniel

On 11/16/2015 12:41 PM, Suresh Babu Angadi wrote:
Hi Team,
With the current implementation of gingerbase, the processor information is empty for s390 architecture.
O/p of /plugins/gingerbase/host on one of the lpar with KVM for IBM z systems:
{
  "os_distro":"KVM for IBM z Systems",
  "os_codename":"Z",
  "os_version":"1.1.1",
  "cpus":3,
  "memory":4000559104
}

Note: cpu_model is not fetched for s390x architecture.

Additional Information which can be provided for benefit of end users:

Architecture Details: "architecture": "x86 or s390x or  ppc etc"

CPU details(for x86 and s390x): Showing online cpus count and offline cpus count(planned to use lscpu for x86 and s390x, not sure how to fetch these details in power pc). Display offline CPUs only if any processors are offline.
"cpus": {"online": <integer(online_cpus_count)>
              "offline": <integer(offline_cpus_count)>}
Processor Type(s390x): shared and  dedicated cpus
"cpus": {"online": <integer(online_cpus_count)>
              "offline": <integer(offline_cpus_count)>
              "shared": <integer(shared_cpus_count)>
              "dedicated": <integer(dedicated_cpus_count)>}


Host Name(for all architecture): Currently IP address is displayed in the new UI (below kimchi logo). Displaying host name would be more meaningful.

Memory Details(s390x specific): In s390x architecture, we can have online and offline memory.
example:
[root@ ~]# lsmem
Address Range                          Size (MB)  State    Removable  Device
===============================================================================
0x0000000000000000-0x000000000fffffff        256  online   no         0
0x0000000010000000-0x000000002fffffff        512  online   yes        1-2
0x0000000030000000-0x000000007fffffff       1280  online   no         3-7
0x0000000080000000-0x00000000ffffffff       2048  offline  -          8-15

Memory device size  : 256 MB
Memory block size   : 256 MB
Total online memory : 2048 MB
Total offline memory: 2048 MB

so memory would be split to include total online and total offline memory.

memory: {"online": <total_online_memory>, "offline":<total offline memory>}

Virtualization Details(s390x specific):
Providing Hypervisor and Hypervisor Vendor details when virtualized. Example Hypervisor: PR/SM , Hypervisor vendor: IBM.
Lpar Details: Lpar name and Lpar ID
"virtualization": {"hypervisor":"PR/SM",
                            "hypervisor_vendor": "IBM",
                            "lpar_name": "LP6",
                            "lpar_number":"22"}

So the o/p json of /plugins/gingerbase/host would look like below:
for x86:
{
  "os_distro":"Fedora",
  "architecture":"x86_64"
  "cpu_model":"Intel(R) Core(TM) i5-3320M CPU @ 2.60GHz",
  "cpus":{"online":3, "offline":2},
  "os_version":"21",
  "os_codename":"Twenty One",
  "memory":7933894656
  "host":<host_name>
}

for power:
Only change, addition of "architecture" and "host" information, unless we decide to show offline cpus

for s390x:
{
  "os_distro":"KVM for IBM z Systems",
  "os_codename":"Z",
  "os_version":"1.1.1",
  "architecture": "s390x"
  "cpu_model": "IBM / 2827 / 743 H43"
  cpus: {"online":2,
            "offline":2,
             "shared":2,
             "dedicated":0}
  memory : {"online" : 2147483628,
                    "offline" :  2147483628}
  "virtualization": {"hypervisor":"PR/SM",
                            "hypervisor_vendor": "IBM",
                            "lpar_name": "LP6",
                            "lpar_number":"22"},
"host":"zfwpc160"
}


-- 
Regards,
Suresh Babu Angadi


_______________________________________________
Kimchi-devel mailing list
Kimchi-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel