Hi, answers below:

 

From: kimchi-devel-bounces@ovirt.org [mailto:kimchi-devel-bounces@ovirt.org] On Behalf Of Daniel Henrique Barboza
Sent: quarta-feira, 10 de agosto de 2016 16:01
To: kimchi-devel@ovirt.org
Subject: Re: [Kimchi-devel] [RFC} HTML lang attribute in ISO 639-1

 

Hey Samuel,

The link you sent mentions that "According to the W3C recommendation you should declare the
primary language for each Web page with the lang attribute inside the <html> tag". Doesn't this
solve the issue you mentioned with the element width too?

Yes, in fact I can use it with any value. Right now wok sets English as “en_US” so I can create something like [lang="en_US"] .btn { width: width for english; } that it will work. This is what I’m going to do with the “Add” buttons for now.

About the ISO639-1: does WoK set incompatible ISO language codes in the html elements? If
that's the case we need to understand why and perhaps change it.

It sets the incompatible ISO language by this line in wok-ui.html.tmpl:

<html lang="$lang.lang[0]">

Daniel

On 08/10/2016 01:14 PM, Samuel Henrique De Oliveira Guimaraes wrote:

Hi,

 

I’m noticing that some elements are collapsing or having weird width values in certain languages. A solution for this would be changing the element width with SCSS/CSS based on the HTML lang attribute.

For now I’m just going to use the lang values that Wok sets today but I suggest we stick with ISO 639-1 for accessibility reasons. If the browser can’t detect the language it will “think” that the content is in English:

 

http://www.w3schools.com/tags/ref_language_codes.asp

 

Regards,

Samuel




_______________________________________________
Kimchi-devel mailing list
Kimchi-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel