On 05/04/2014 07:13 AM, lvroyce@linux.vnet.ibm.com wrote:

From: Royce Lv <lvroyce@linux.vnet.ibm.com>

Yu Xin Huo (1):
  StoragePool Edit: Add Disk to Logical Pool
Royce Lv (2):
  StoragePool Edit: Add Disk to Logical Pool
  StoragePool Edit: Update json schema

 src/kimchi/API.json                      |  3 ++-
 ui/js/src/kimchi.api.js                  | 12 ++++++++++
 ui/js/src/kimchi.storage_main.js         | 41 ++++++++++++++++++++++++++++++++
 ui/js/src/kimchi.storagepool_add_main.js |  2 +-
 ui/pages/i18n.html.tmpl                  |  1 +
 ui/pages/tabs/storage.html.tmpl          | 10 ++++++++
 6 files changed, 67 insertions(+), 2 deletions(-)

Some comments:

1) When there is any device available, an empty window is displayed.

2) And even when there are device available there is a lack until window be populated.

My suggestion is add a loading icon or loading mouse point, until get the list of devices
And if no device is available display a message.

The code looks good for me.
Maybe a UI expert can do a better review.