General comments:

1) I'd like to edit the VM permission when it is running
    I think it is possible but it is good to have a input from the original authors - Sheldon and Cristian

    Sheldon, Cristian, is it possible to set the metadata element to a running VM?

2) Some suggestions about it UI

*  Update the labels to: "Available system users and groups" and "Selected system users and groups"

*  I think it would be good to insert some instructions to user like:

   "Select system users and groups to have full access to this virtual machine"

* I needed some time to understand that one column is a user list and other one the group list
   Maybe add headers to the columns





On 07/18/2014 07:14 AM, huoyuxin@linux.vnet.ibm.com wrote:
From: Yu Xin Huo <huoyuxin@linux.vnet.ibm.com>

Yu Xin Huo (2):
  Add users/groups to VM
  update po

 po/en_US.po                         |    9 +++
 po/kimchi.pot                       |    9 +++
 po/pt_BR.po                         |   39 ++++++++-----
 po/zh_CN.po                         |    9 +++
 ui/css/theme-default/guest-edit.css |  106 +++++++++++++++++++++++++++++++++
 ui/images/theme-default/group.png   |  Bin 0 -> 1703 bytes
 ui/images/theme-default/user.png    |  Bin 0 -> 1322 bytes
 ui/js/src/kimchi.api.js             |   28 +++++++++
 ui/js/src/kimchi.guest_edit_main.js |  112 ++++++++++++++++++++++++++++++++++-
 ui/pages/guest-edit.html.tmpl       |   33 ++++++++++
 10 files changed, 327 insertions(+), 18 deletions(-)
 create mode 100644 ui/images/theme-default/group.png
 create mode 100644 ui/images/theme-default/user.png

_______________________________________________
Kimchi-devel mailing list
Kimchi-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel