I've fixed the part of the patch that breaks it and will send a v2.
However, I must say that make check does not complete successfully in master due to failures/errors that this patch can't and shouldn't be accounted for:
======================================================================
ERROR: test_delete_running_vm (test_model.ModelTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/danielhb/kimchi/kimchi-upstream/tests/test_model.py", line 1062, in test_delete_running_vm
inst.templates_create(params)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/templates.py", line 45, in create
user = UserTests().probe_user()
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/kvmusertests.py", line 56, in probe_user
dom.create()
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/usr/lib64/python2.7/site-packages/libvirt.py", line 698, in create
if ret == -1: raise libvirtError ('virDomainCreate() failed', dom=self)
libvirtError: monitor socket did not show up: No such file or directory
======================================================================
ERROR: test_template_clone (test_model.ModelTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/danielhb/kimchi/kimchi-upstream/tests/test_model.py", line 693, in test_template_clone
inst.templates_create(orig_params)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/templates.py", line 45, in create
user = UserTests().probe_user()
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/kvmusertests.py", line 56, in probe_user
dom.create()
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/usr/lib64/python2.7/site-packages/libvirt.py", line 698, in create
if ret == -1: raise libvirtError ('virDomainCreate() failed', dom=self)
libvirtError: monitor socket did not show up: No such file or directory
======================================================================
ERROR: test_template_create (test_model.ModelTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/danielhb/kimchi/kimchi-upstream/tests/test_model.py", line 613, in test_template_create
self.assertRaises(InvalidParameter, inst.templates_create, params)
File "/usr/lib64/python2.7/unittest/case.py", line 513, in assertRaises
callableObj(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/templates.py", line 45, in create
user = UserTests().probe_user()
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/kvmusertests.py", line 56, in probe_user
dom.create()
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py", line 62, in wrapper
ret = f(*args, **kwargs)
File "/usr/lib64/python2.7/site-packages/libvirt.py", line 698, in create
if ret == -1: raise libvirtError ('virDomainCreate() failed', dom=self)
libvirtError: monitor socket did not show up: No such file or directory
======================================================================
ERROR: test_vm_cdrom (test_model.ModelTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/danielhb/kimchi/kimchi-upstream/tests/test_model.py", line 400, in test_vm_cdrom
cdrom_dev = inst.vmstorages_create(vm_name, cdrom_args)
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/vmstorages.py", line 178, in create
raise OperationFailed("KCHVMSTOR0008E", {'error': e.message})
OperationFailed: KCHVMSTOR0008E: Error while creating new storage device: internal error unknown protocol type 'http'
======================================================================
ERROR: test_vm_lifecycle (test_model.ModelTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/danielhb/kimchi/kimchi-upstream/tests/test_model.py", line 101, in test_vm_lifecycle
inst.vm_start('kimchi-vm')
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/vms.py", line 542, in start
{'name': name, 'err': e.get_error_message()})
OperationFailed: KCHVM0019E: Unable to start virtual machine kimchi-vm. Details: monitor socket did not show up: No such file or directory
======================================================================
FAIL: test_debug_reports (test_model.ModelTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/danielhb/kimchi/kimchi-upstream/tests/test_model.py", line 1151, in test_debug_reports
"It is not necessary an error. "
AssertionError: It is not necessary an error. You may need to increase the timeout number by TEST_REPORT_TIMEOUT=200 ./run_tests.sh test_model
----------------------------------------------------------------------
Ran 161 tests in 357.586s
FAILED (failures=1, errors=5, skipped=2)
On 08/19/2014 12:12 PM, Crístian Viana wrote:
This patch breaks the tests. Please run "make check" before submitting patches.
On 19-08-2014 11:49, Daniel Henrique Barboza wrote:
As described in Github issue #354, this patch filters the storage
targets list to not show the nfs paths that are in use by an
existing NFS pool.
Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
_______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel