On Mon, Feb 5, 2018 at 8:38 AM, Tomas Jelinek <tjelinek@redhat.com> wrote:


On Sun, Feb 4, 2018 at 6:57 PM, i iordanov <iiordanov@gmail.com> wrote:
Hello,

There is one thing that I wanted to report to you and ask you how we
can approach.

aSPICE is a derivative project of bVNC, and because of that, for a
time in its AndroidManifest.xml file, the mimeType remained
application/vnd.vnc:

<intent-filter>
    <action android:name="android.intent.action.VIEW" />
    <category android:name="android.intent.category.DEFAULT"/>
    <data android:mimeType="application/vnd.vnc" />
</intent-filter>

whereas to avoid it cropping up in the list of applications when a VNC
console is being connected to, its mimeType should have been
application/vnd.spice, like so:

<intent-filter>
    <action android:name="android.intent.action.VIEW" />
    <category android:name="android.intent.category.DEFAULT"/>
    <data android:mimeType="application/vnd.spice" />
</intent-filter>

I noticed this recently when I wrote my own integration with bVNC via
an intent and used it on a device where aSPICE and bVNC are both
present. Instead of seeing just bVNC, I saw both bVNC and aSPICE as
clients to connect to VNC.

So what I've done now is I've put both the above intent filters in
aSPICE's AndroidManifest.xml in order to not break moVirt, but I'd
like for you to change moVirt to create an intent with vnd.spice set
as the mimeType when opening SPICE consoles rather than vnd.vnc as it
does now. Since the fix is already out in aSPICE, you are at liberty
to make the change on your side at any time.

I've created a Pull Request against your project with the fix.

https://github.com/oVirt/moVirt/pull/295

wow, great, thank you!
 
@Filip, can you please have a look at the PR?
 


Thanks a lot. Looks ok. 

I will test it probably next week.



Sincerely,
iordan

On Mon, Jul 13, 2015 at 5:35 PM, i iordanov <iiordanov@gmail.com> wrote:
> Hi Thomas,
>
> You're welcome! As you can tell, I am very busy these days.
>
> Cheers,
> iordan
>
> On Wed, Jul 8, 2015 at 3:53 AM, Tomas Jelinek <tjelinek@redhat.com> wrote:
>>
>>
>> ----- Original Message -----
>>> From: "i iordanov" <iiordanov@gmail.com>
>>> To: "Tomas Jelinek" <tjelinek@redhat.com>
>>> Cc: movirt@ovirt.org
>>> Sent: Monday, July 6, 2015 1:44:45 AM
>>> Subject: Re: [moVirt] Questions for freeaSPICE
>>>
>>> Hey,
>>>
>>> I just released an updated v3.7.7 with the parameters added.
>>>
>>> I've also updated the ticket you opened.
>>>
>>> Please find an updated version here:
>>> https://github.com/iiordanov/remote-desktop-clients/releases/download/v3.7.7/freeaSPICE-3.7.7-final.apk
>>>
>>> I've also released the version above in Google Play.
>>
>> Tested by both Yixin and me and works like a charm. We have updated the movirt page saying to install the version from the play store.
>> Thank you for the fast response!
>>
>>>
>>> Cheers!
>>> iordan
>>>
>>> On Fri, Jul 3, 2015 at 5:30 AM, Tomas Jelinek <tjelinek@redhat.com> wrote:
>>> >
>>> >
>>> > ----- Original Message -----
>>> >> From: "Tomas Jelinek" <tjelinek@redhat.com>
>>> >> To: "i iordanov" <iiordanov@gmail.com>
>>> >> Cc: movirt@ovirt.org
>>> >> Sent: Wednesday, June 24, 2015 4:34:48 PM
>>> >> Subject: Re: [moVirt] Questions for freeaSPICE
>>> >>
>>> >>
>>> >>
>>> >> ----- Original Message -----
>>> >> > From: "i iordanov" <iiordanov@gmail.com>
>>> >> > To: "Tomas Jelinek" <tjelinek@redhat.com>
>>> >> > Cc: "Yixin Zhang" <yixin_1992_cia@126.com>, movirt@ovirt.org
>>> >> > Sent: Wednesday, June 24, 2015 4:13:06 PM
>>> >> > Subject: Re: Questions for freeaSPICE
>>> >> >
>>> >> > Thank you, I hope to look at it this weekend.
>>> >
>>> > Hi, any progress?
>>> >
>>> >>
>>> >> That would be awesome, thank you!
>>> >>
>>> >> >
>>> >> > Cheers!
>>> >> > iordan
>>> >> >
>>> >> > On Wed, Jun 24, 2015 at 4:53 AM, Tomas Jelinek <tjelinek@redhat.com>
>>> >> > wrote:
>>> >> > > I have opened an issue on github for this:
>>> >> > > https://github.com/iiordanov/remote-desktop-clients/issues/49 if that
>>> >> > > is
>>> >> > > a
>>> >> > > more suitable place to discuss it.
>>> >> > >
>>> >> > > ----- Original Message -----
>>> >> > >> From: "Yixin Zhang" <yixin_1992_cia@126.com>
>>> >> > >> To: iiordanov@gmail.com
>>> >> > >> Cc: tjelinek@redhat.com, movirt@ovirt.org
>>> >> > >> Sent: Thursday, June 18, 2015 4:28:14 PM
>>> >> > >> Subject: Questions for freeaSPICE
>>> >> > >>
>>> >> > >> Dear Sir or Madam,
>>> >> > >>
>>> >> > >>
>>> >> > >>
>>> >> > >> Sorry can I have your name? freeaSPICE is a very nice APP, it could
>>> >> > >> be
>>> >> > >> used
>>> >> > >> to connect the virtual machine directly.
>>> >> > >>
>>> >> > >> There are some problems confused me, can I ask for you suggestions?
>>> >> > >>
>>> >> > >>
>>> >> > >>
>>> >> > >> I'm Yixin Zhang,and now doing an internship for Outreachy Project,and
>>> >> > >> now
>>> >> > >> I'm
>>> >> > >> in the project movirt. I'm thinking of calling freeaSPICE in movirt
>>> >> > >> to
>>> >> > >> connect VM, the calling code as followed:
>>> >> > >>
>>> >> > >> Intent intent = new Intent(Intent.ACTION_VIEW)
>>> >> > >>
>>> >> > >> .setType("application/vnd.vnc")
>>> >> > >>
>>> >> > >> .setData(data);
>>> >> > >>
>>> >> > >> startActivity(intent);
>>> >> > >>
>>> >> > >> And the data form as
>>> >> > >> followed:spice://192.168.1.100:5900?SpicePassword=...&TlsPort=5901&CaCertPath=...&CertSubject=....
>>> >> > >>
>>> >> > >> However while I checked for you source
>>> >> > >> code:https://github.com/iiordanov/remote-desktop-clients , I found it
>>> >> > >> can
>>> >> > >> not pass the parameters TlsPort, CaCertPath, CertSubject using this
>>> >> > >> method,
>>> >> > >> is there any other ways to pass the parameters, if there is, could u
>>> >> > >> give
>>> >> > >> me
>>> >> > >> some suggestions? Thank you so much.
>>> >> > >>
>>> >> > >>
>>> >> > >>
>>> >> > >> In order to pass these three parameter TlsPort, CaCertPath,
>>> >> > >> CertSubjectin,I
>>> >> > >> fork your remote-desktop-clients code (fork
>>> >> > >> address:https://github.com/zyx0225/remote-desktop-clients/tree/aSPICE),
>>> >> > >>
>>> >> > >> Also, as you compile instruction I compiled aSPICE(But I have no idea
>>> >> > >> how
>>> >> > >> to
>>> >> > >> compile libspice.so and libgstreamer_android.so, so I copy lib
>>> >> > >> document
>>> >> > >> of
>>> >> > >> freeaSPICE-3.7.7-final.apk),I add the parser code for these three
>>> >> > >> parameters
>>> >> > >> TlsPort, CaCertPath, CertSubject (The main logical code:
>>> >> > >> :https://github.com/zyx0225/remote-desktop-clients/commit/5233d9bb5f6434bba97237fd8ea014cf19b14c88),
>>> >> > >> and invoke aSPICE in movirt to connect VM successfully. However, it
>>> >> > >> just
>>> >> > >> want to prove some my own guess and I have no idea whether there are
>>> >> > >> some
>>> >> > >> problem to code in such way.
>>> >> > >>
>>> >> > >> We really really hope that we could invoke freeaSPICE in movirt to
>>> >> > >> realize
>>> >> > >> such functions, and I like freeaSPICE this APP so much, with great
>>> >> > >> appreciate that you developed such a great APP. If we could realize
>>> >> > >> our
>>> >> > >> ideas mentioned above using your freeaSPICE, it would be such an
>>> >> > >> exciting
>>> >> > >> thing.
>>> >> > >>
>>> >> > >> Could you add parser for these three parameters TlsPort, CaCertPath,
>>> >> > >> CertSubject in next version of freeaSPICE, or other ways that we
>>> >> > >> could
>>> >> > >> invoke freeaSPICE in movirt to connect VM?
>>> >> > >>
>>> >> > >> Thank you so much for your time, looking forward to your reply
>>> >> > >>
>>> >> > >>  Best Regards,
>>> >> > >>
>>> >> > >> Yixin Zhang
>>> >> >
>>> >> >
>>> >> >
>>> >> > --
>>> >> > The conscious mind has only one thread of execution.
>>> >> >
>>> >> _______________________________________________
>>> >> moVirt mailing list
>>> >> moVirt@ovirt.org
>>> >> http://lists.ovirt.org/mailman/listinfo/movirt
>>> >>
>>>
>>>
>>>
>>> --
>>> The conscious mind has only one thread of execution.
>>>
>
>
>
> --
> The conscious mind has only one thread of execution.



--
The conscious mind has only one thread of execution.