From bill.james at j2.com Wed Mar 30 12:37:48 2016 Content-Type: multipart/mixed; boundary="===============3408610009494689592==" MIME-Version: 1.0 From: Bill James To: users at ovirt.org Subject: Re: [ovirt-users] [Bug 1319323] New: VLAN ID check for duplicates Date: Wed, 30 Mar 2016 09:37:35 -0700 Message-ID: <56FC00CF.7090704@j2.com> In-Reply-To: bug-1319323-393952@bugzilla.redhat.com --===============3408610009494689592== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable --------------000508050504010509050906 Content-Type: text/plain; charset=3D"utf-8"; format=3Dflowed Content-Transfer-Encoding: 7bit Any one have an idea on how to "hack" or "patch" ovirt so that instead = of rejecting a new network with duplicate vlan id it would just warn, or = even just ignore? On 03/18/2016 01:54 PM, bugzilla(a)redhat.com wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=3D1319323 > > Bug ID: 1319323 > Summary: VLAN ID check for duplicates > Product: ovirt-engine > Version: 3.3 > Component: RFEs > Severity: medium > Assignee: sherold(a)redhat.com > Reporter: bill.james(a)j2.com > QA Contact: gklein(a)redhat.com > CC: bugs(a)ovirt.org > oVirt Team: Network > Flags: testing_ack? > Flags: planning_ack? > > > > Description of problem: > Adding new network with vlan tag, ovirt doesn't allow duplicate VLAN IDs. > But it should be allowed, because if you are using multiple interfaces yo= u can > have the same vlan ID as long as they aren't assigned to the same interfa= ce on > the hardware node. > > > Version-Release number of selected component (if applicable): > ovirt-engine-3.6.3.4-1.el7.centos.noarch > > > How reproducible: > 100% > > Steps to Reproduce: > 1. Just add network with same vlan id as an already added interface. > > 2. > 3. > > Actual results: > See email thread labeled "Re: [ovirt-users] multiple NICs VLAN ID conflic= t". > GUI says vlan already used. > > Expected results: > Duplicate VLAN ID should be checked when you are assign network to the ha= rdware > node, not when creating the interface. > > > Additional info: > Trying to work around this with vdsm hooks in before_network_setup, > after_get_caps and after_get_stats is very difficult to get it to work ri= ght. > (see email thread) > Yaniv Kaul 2016-03-20 03:12:24 EDT Perhaps only WARN. --------------000508050504010509050906 Content-Type: text/html; charset=3D"utf-8" Content-Transfer-Encoding: 7bit Any one have an idea on how to "hack" or "patch" ovirt so that instead of rejecting a new network with duplicate vlan id it would just warn, or even just ignore?


On 03/18/2016 01:54 PM, bugzilla(a)redhat.com wrote:
https://bugzilla.redhat.com/sho=
w_bug.cgi?id=3D1319323

            Bug ID: 1319323
           Summary: VLAN ID check for duplicates
           Product: ovirt-engine
           Version: 3.3
         Component: RFEs
          Severity: medium
          Assignee: sherold(a)redhat.com
          Reporter: bill.james(a)j2.com
        QA Contact: gklein(a)redhat.com
                CC: bugs(a)ovirt.org
        oVirt Team: Network
             Flags: testing_ack?
             Flags: planning_ack?



Description of problem:
Adding new network with vlan tag, ovirt doesn't allow duplicate VLAN IDs.
But it should be allowed, because if you are using multiple interfaces you =
can
have the same vlan ID as long as they aren't assigned to the same interface=
 on
the hardware node.


Version-Release number of selected component (if applicable):
ovirt-engine-3.6.3.4-1.el7.centos.noarch


How reproducible:
100%

Steps to Reproduce:
1. Just add network with same vlan id as an already added interface.

2.
3.

Actual results:
See email thread labeled "Re: [ovirt-users] multiple NICs VLAN ID conflict".
GUI says vlan already used.

Expected results:
Duplicate VLAN ID should be checked when you are assign network to the hard=
ware
node, not when creating the interface.


Additional info:
Trying to work around this with vdsm hooks in before_network_setup,
after_get_caps and after_get_stats is very difficult to get it to work righ=
t.
(see email thread)
Yaniv Kaul= 2016-03-20 03:12:24 EDT 
Perhaps only W=
ARN.
--------------000508050504010509050906-- --===============3408610009494689592== Content-Type: multipart/alternative MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="attachment.bin" LS0tLS0tLS0tLS0tLS0wMDA1MDgwNTA1MDQwMTA1MDkwNTA5MDYKQ29udGVudC1UeXBlOiB0ZXh0 L3BsYWluOyBjaGFyc2V0PSJ1dGYtOCI7IGZvcm1hdD1mbG93ZWQKQ29udGVudC1UcmFuc2Zlci1F bmNvZGluZzogN2JpdAoKQW55IG9uZSBoYXZlIGFuIGlkZWEgb24gaG93IHRvICJoYWNrIiBvciAi cGF0Y2giIG92aXJ0IHNvIHRoYXQgaW5zdGVhZCAKb2YgcmVqZWN0aW5nIGEgbmV3IG5ldHdvcmsg d2l0aCBkdXBsaWNhdGUgdmxhbiBpZCBpdCB3b3VsZCBqdXN0IHdhcm4sIG9yIApldmVuIGp1c3Qg aWdub3JlPwoKCk9uIDAzLzE4LzIwMTYgMDE6NTQgUE0sIGJ1Z3ppbGxhQHJlZGhhdC5jb20gd3Jv dGU6Cj4gaHR0cHM6Ly9idWd6aWxsYS5yZWRoYXQuY29tL3Nob3dfYnVnLmNnaT9pZD0xMzE5MzIz Cj4KPiAgICAgICAgICAgICAgQnVnIElEOiAxMzE5MzIzCj4gICAgICAgICAgICAgU3VtbWFyeTog VkxBTiBJRCBjaGVjayBmb3IgZHVwbGljYXRlcwo+ICAgICAgICAgICAgIFByb2R1Y3Q6IG92aXJ0 LWVuZ2luZQo+ICAgICAgICAgICAgIFZlcnNpb246IDMuMwo+ICAgICAgICAgICBDb21wb25lbnQ6 IFJGRXMKPiAgICAgICAgICAgIFNldmVyaXR5OiBtZWRpdW0KPiAgICAgICAgICAgIEFzc2lnbmVl OiBzaGVyb2xkQHJlZGhhdC5jb20KPiAgICAgICAgICAgIFJlcG9ydGVyOiBiaWxsLmphbWVzQGoy LmNvbQo+ICAgICAgICAgIFFBIENvbnRhY3Q6IGdrbGVpbkByZWRoYXQuY29tCj4gICAgICAgICAg ICAgICAgICBDQzogYnVnc0BvdmlydC5vcmcKPiAgICAgICAgICBvVmlydCBUZWFtOiBOZXR3b3Jr Cj4gICAgICAgICAgICAgICBGbGFnczogdGVzdGluZ19hY2s/Cj4gICAgICAgICAgICAgICBGbGFn czogcGxhbm5pbmdfYWNrPwo+Cj4KPgo+IERlc2NyaXB0aW9uIG9mIHByb2JsZW06Cj4gQWRkaW5n IG5ldyBuZXR3b3JrIHdpdGggdmxhbiB0YWcsIG92aXJ0IGRvZXNuJ3QgYWxsb3cgZHVwbGljYXRl IFZMQU4gSURzLgo+IEJ1dCBpdCBzaG91bGQgYmUgYWxsb3dlZCwgYmVjYXVzZSBpZiB5b3UgYXJl IHVzaW5nIG11bHRpcGxlIGludGVyZmFjZXMgeW91IGNhbgo+IGhhdmUgdGhlIHNhbWUgdmxhbiBJ RCBhcyBsb25nIGFzIHRoZXkgYXJlbid0IGFzc2lnbmVkIHRvIHRoZSBzYW1lIGludGVyZmFjZSBv bgo+IHRoZSBoYXJkd2FyZSBub2RlLgo+Cj4KPiBWZXJzaW9uLVJlbGVhc2UgbnVtYmVyIG9mIHNl bGVjdGVkIGNvbXBvbmVudCAoaWYgYXBwbGljYWJsZSk6Cj4gb3ZpcnQtZW5naW5lLTMuNi4zLjQt MS5lbDcuY2VudG9zLm5vYXJjaAo+Cj4KPiBIb3cgcmVwcm9kdWNpYmxlOgo+IDEwMCUKPgo+IFN0 ZXBzIHRvIFJlcHJvZHVjZToKPiAxLiBKdXN0IGFkZCBuZXR3b3JrIHdpdGggc2FtZSB2bGFuIGlk IGFzIGFuIGFscmVhZHkgYWRkZWQgaW50ZXJmYWNlLgo+Cj4gMi4KPiAzLgo+Cj4gQWN0dWFsIHJl c3VsdHM6Cj4gU2VlIGVtYWlsIHRocmVhZCBsYWJlbGVkICJSZTogW292aXJ0LXVzZXJzXSBtdWx0 aXBsZSBOSUNzIFZMQU4gSUQgY29uZmxpY3QiLgo+IEdVSSBzYXlzIHZsYW4gYWxyZWFkeSB1c2Vk Lgo+Cj4gRXhwZWN0ZWQgcmVzdWx0czoKPiBEdXBsaWNhdGUgVkxBTiBJRCBzaG91bGQgYmUgY2hl Y2tlZCB3aGVuIHlvdSBhcmUgYXNzaWduIG5ldHdvcmsgdG8gdGhlIGhhcmR3YXJlCj4gbm9kZSwg bm90IHdoZW4gY3JlYXRpbmcgdGhlIGludGVyZmFjZS4KPgo+Cj4gQWRkaXRpb25hbCBpbmZvOgo+ IFRyeWluZyB0byB3b3JrIGFyb3VuZCB0aGlzIHdpdGggdmRzbSBob29rcyBpbiBiZWZvcmVfbmV0 d29ya19zZXR1cCwKPiBhZnRlcl9nZXRfY2FwcyBhbmQgYWZ0ZXJfZ2V0X3N0YXRzIGlzIHZlcnkg ZGlmZmljdWx0IHRvIGdldCBpdCB0byB3b3JrIHJpZ2h0Lgo+IChzZWUgZW1haWwgdGhyZWFkKQo+ Cllhbml2IEthdWwgPG1haWx0bzp5a2F1bEByZWRoYXQuY29tPiAyMDE2LTAzLTIwIDAzOjEyOjI0 IEVEVAoKUGVyaGFwcyBvbmx5IFdBUk4uCgoKLS0tLS0tLS0tLS0tLS0wMDA1MDgwNTA1MDQwMTA1 MDkwNTA5MDYKQ29udGVudC1UeXBlOiB0ZXh0L2h0bWw7IGNoYXJzZXQ9InV0Zi04IgpDb250ZW50 LVRyYW5zZmVyLUVuY29kaW5nOiA3Yml0Cgo8aHRtbD4KICA8aGVhZD4KICAgIDxtZXRhIGNvbnRl bnQ9InRleHQvaHRtbDsgY2hhcnNldD11dGYtOCIgaHR0cC1lcXVpdj0iQ29udGVudC1UeXBlIj4K ICA8L2hlYWQ+CiAgPGJvZHkgdGV4dD0iIzAwMDAwMCIgYmdjb2xvcj0iI0ZGRkZGRiI+CiAgICBB bnkgb25lIGhhdmUgYW4gaWRlYSBvbiBob3cgdG8gImhhY2siIG9yICJwYXRjaCIgb3ZpcnQgc28g dGhhdAogICAgaW5zdGVhZCBvZiByZWplY3RpbmcgYSBuZXcgbmV0d29yayB3aXRoIGR1cGxpY2F0 ZSB2bGFuIGlkIGl0IHdvdWxkCiAgICBqdXN0IHdhcm4sIG9yIGV2ZW4ganVzdCBpZ25vcmU/PGJy PgogICAgPGJyPgogICAgPGJyPgogICAgPGRpdiBjbGFzcz0ibW96LWNpdGUtcHJlZml4Ij5PbiAw My8xOC8yMDE2IDAxOjU0IFBNLAogICAgICA8YSBjbGFzcz0ibW96LXR4dC1saW5rLWFiYnJldmlh dGVkIiBocmVmPSJtYWlsdG86YnVnemlsbGFAcmVkaGF0LmNvbSI+YnVnemlsbGFAcmVkaGF0LmNv bTwvYT4gd3JvdGU6PGJyPgogICAgPC9kaXY+CiAgICA8YmxvY2txdW90ZSBjaXRlPSJtaWQ6YnVn LTEzMTkzMjMtMzkzOTUyQGJ1Z3ppbGxhLnJlZGhhdC5jb20iCiAgICAgIHR5cGU9ImNpdGUiPgog ICAgICA8cHJlIHdyYXA9IiI+PGEgY2xhc3M9Im1vei10eHQtbGluay1mcmVldGV4dCIgaHJlZj0i aHR0cHM6Ly9idWd6aWxsYS5yZWRoYXQuY29tL3Nob3dfYnVnLmNnaT9pZD0xMzE5MzIzIj5odHRw czovL2J1Z3ppbGxhLnJlZGhhdC5jb20vc2hvd19idWcuY2dpP2lkPTEzMTkzMjM8L2E+CgogICAg ICAgICAgICBCdWcgSUQ6IDEzMTkzMjMKICAgICAgICAgICBTdW1tYXJ5OiBWTEFOIElEIGNoZWNr IGZvciBkdXBsaWNhdGVzCiAgICAgICAgICAgUHJvZHVjdDogb3ZpcnQtZW5naW5lCiAgICAgICAg ICAgVmVyc2lvbjogMy4zCiAgICAgICAgIENvbXBvbmVudDogUkZFcwogICAgICAgICAgU2V2ZXJp dHk6IG1lZGl1bQogICAgICAgICAgQXNzaWduZWU6IDxhIGNsYXNzPSJtb3otdHh0LWxpbmstYWJi cmV2aWF0ZWQiIGhyZWY9Im1haWx0bzpzaGVyb2xkQHJlZGhhdC5jb20iPnNoZXJvbGRAcmVkaGF0 LmNvbTwvYT4KICAgICAgICAgIFJlcG9ydGVyOiA8YSBjbGFzcz0ibW96LXR4dC1saW5rLWFiYnJl dmlhdGVkIiBocmVmPSJtYWlsdG86YmlsbC5qYW1lc0BqMi5jb20iPmJpbGwuamFtZXNAajIuY29t PC9hPgogICAgICAgIFFBIENvbnRhY3Q6IDxhIGNsYXNzPSJtb3otdHh0LWxpbmstYWJicmV2aWF0 ZWQiIGhyZWY9Im1haWx0bzpna2xlaW5AcmVkaGF0LmNvbSI+Z2tsZWluQHJlZGhhdC5jb208L2E+ CiAgICAgICAgICAgICAgICBDQzogPGEgY2xhc3M9Im1vei10eHQtbGluay1hYmJyZXZpYXRlZCIg aHJlZj0ibWFpbHRvOmJ1Z3NAb3ZpcnQub3JnIj5idWdzQG92aXJ0Lm9yZzwvYT4KICAgICAgICBv VmlydCBUZWFtOiBOZXR3b3JrCiAgICAgICAgICAgICBGbGFnczogdGVzdGluZ19hY2s/CiAgICAg ICAgICAgICBGbGFnczogcGxhbm5pbmdfYWNrPwoKCgpEZXNjcmlwdGlvbiBvZiBwcm9ibGVtOgpB ZGRpbmcgbmV3IG5ldHdvcmsgd2l0aCB2bGFuIHRhZywgb3ZpcnQgZG9lc24ndCBhbGxvdyBkdXBs aWNhdGUgVkxBTiBJRHMuCkJ1dCBpdCBzaG91bGQgYmUgYWxsb3dlZCwgYmVjYXVzZSBpZiB5b3Ug YXJlIHVzaW5nIG11bHRpcGxlIGludGVyZmFjZXMgeW91IGNhbgpoYXZlIHRoZSBzYW1lIHZsYW4g SUQgYXMgbG9uZyBhcyB0aGV5IGFyZW4ndCBhc3NpZ25lZCB0byB0aGUgc2FtZSBpbnRlcmZhY2Ug b24KdGhlIGhhcmR3YXJlIG5vZGUuCgoKVmVyc2lvbi1SZWxlYXNlIG51bWJlciBvZiBzZWxlY3Rl ZCBjb21wb25lbnQgKGlmIGFwcGxpY2FibGUpOgpvdmlydC1lbmdpbmUtMy42LjMuNC0xLmVsNy5j ZW50b3Mubm9hcmNoCgoKSG93IHJlcHJvZHVjaWJsZToKMTAwJQoKU3RlcHMgdG8gUmVwcm9kdWNl OgoxLiBKdXN0IGFkZCBuZXR3b3JrIHdpdGggc2FtZSB2bGFuIGlkIGFzIGFuIGFscmVhZHkgYWRk ZWQgaW50ZXJmYWNlLgoKMi4KMy4KCkFjdHVhbCByZXN1bHRzOgpTZWUgZW1haWwgdGhyZWFkIGxh YmVsZWQgIlJlOiBbb3ZpcnQtdXNlcnNdIG11bHRpcGxlIE5JQ3MgVkxBTiBJRCBjb25mbGljdCIu CkdVSSBzYXlzIHZsYW4gYWxyZWFkeSB1c2VkLgoKRXhwZWN0ZWQgcmVzdWx0czoKRHVwbGljYXRl IFZMQU4gSUQgc2hvdWxkIGJlIGNoZWNrZWQgd2hlbiB5b3UgYXJlIGFzc2lnbiBuZXR3b3JrIHRv IHRoZSBoYXJkd2FyZQpub2RlLCBub3Qgd2hlbiBjcmVhdGluZyB0aGUgaW50ZXJmYWNlLgoKCkFk ZGl0aW9uYWwgaW5mbzoKVHJ5aW5nIHRvIHdvcmsgYXJvdW5kIHRoaXMgd2l0aCB2ZHNtIGhvb2tz IGluIGJlZm9yZV9uZXR3b3JrX3NldHVwLAphZnRlcl9nZXRfY2FwcyBhbmQgYWZ0ZXJfZ2V0X3N0 YXRzIGlzIHZlcnkgZGlmZmljdWx0IHRvIGdldCBpdCB0byB3b3JrIHJpZ2h0Lgooc2VlIGVtYWls IHRocmVhZCkKCjwvcHJlPgogICAgPC9ibG9ja3F1b3RlPgogICAgPHNwYW4gY2xhc3M9ImJ6X2Nv bW1lbnRfdXNlciI+IDxzcGFuIGNsYXNzPSJ2Y2FyZCByZWRoYXRfdXNlciI+PGEKICAgICAgICAg IGNsYXNzPSJlbWFpbCIgaHJlZj0ibWFpbHRvOnlrYXVsQHJlZGhhdC5jb20iIHRpdGxlPSJZYW5p diBLYXVsCiAgICAgICAgICAmbHQ7eWthdWxAcmVkaGF0LmNvbSZndDsiPiA8c3BhbiBjbGFzcz0i Zm4iPllhbml2IEthdWw8L3NwYW4+PC9hPgogICAgICA8L3NwYW4+IDwvc3Bhbj4gPHNwYW4gY2xh c3M9ImJ6X2NvbW1lbnRfdGltZSI+IDIwMTYtMDMtMjAKICAgICAgMDM6MTI6MjQgRURUIDwvc3Bh bj4KICAgIDxwcmUgY2xhc3M9ImJ6X2NvbW1lbnRfdGV4dAogICAgICAgICAgICAgICAgIGJ6X3dy YXBfY29tbWVudF90ZXh0IiBpZD0iY29tbWVudF90ZXh0XzEiPlBlcmhhcHMgb25seSBXQVJOLgoK PC9wcmU+CiAgPC9ib2R5Pgo8L2h0bWw+CgotLS0tLS0tLS0tLS0tLTAwMDUwODA1MDUwNDAxMDUw OTA1MDkwNi0tCg== --===============3408610009494689592==--