On Fri, Apr 27, 2018 at 7:31 AM, <dhy336@sina.com> wrote:
Hi
 I engine setup faces some error.

 I try to solute it and  it is work. here is my patch. But  not sure it is right?

It seems right, but isn't it already done in these?

https://gerrit.ovirt.org/#/q/Id4e0e621624efff0ff0e8a9fd6f23f53f2aa54d2,n,z
https://gerrit.ovirt.org/#/q/Ib6fdd78f29d88e13547d509d15081de8dc2c21aa,n,z

What version are you using?

Best regards,
 


 $HOME/ovirt-engine/bin/engine-setup
[ INFO  ] Stage: Initializing
          Setup was run under unprivileged user this will produce development installation do you wish to proceed? (Yes, No) [No]: yes
[ INFO  ] Stage: Environment setup
          Configuration files: []
          Log file: /home/guoss4/ovirt-engine/var/log/ovirt-engine/setup/ovirt-engine-setup-20180427001528-6h7snp.log
          Version: otopi-1.8.0_master (otopi-1.8.0-0.0.master.20180313084114.git4e788f9.el7.centos)
[ ERROR ] "before" parameter of method otopi.plugins.ovirt_engine_setup.ovirt_engine.network.ovirtproviderovn.Plugin._misc_configure_ovn_pki is a string, should probably be a tuple. Perhaps a missing comma?
          methodinfo: {'priority': 5000, 'name': None, 'before': 'osetup.ovn.provider.service.restart', 'after': ('osetup.pki.ca.available', 'osetup.ovn.services.restart'), 'method': <bound method ?._misc_configure_ovn_pki of <otopi.plugins.ovirt_engine_setup.ovirt_engine.network.ovirtproviderovn.Plugin object at 0x30087d0>>, 'condition': <bound method ?.<lambda> of <otopi.plugins.ovirt_engine_setup.ovirt_engine.network.ovirtproviderovn.Plugin object at 0x30087d0>>, 'stage': 11}
[ ERROR ] "before" parameter of method otopi.plugins.ovirt_engine_setup.ovirt_engine.network.ovirtproviderovn.Plugin._misc_configure_provider is a string, should probably be a tuple. Perhaps a missing comma?
          methodinfo: {'priority': 5000, 'name': None, 'before': 'osetup.ovn.provider.service.restart', 'after': ('osetup.pki.ca.available', 'osetup.ovn.services.restart'), 'method': <bound method ?._misc_configure_provider of <otopi.plugins.ovirt_engine_setup.ovirt_engine.network.ovirtproviderovn.Plugin object at 0x30087d0>>, 'condition': <bound method ?.<lambda> of <otopi.plugins.ovirt_engine_setup.ovirt_engine.network.ovirtproviderovn.Plugin object at 0x30087d0>>, 'stage': 11}
[ ERROR ] Failed to execute stage 'Environment setup': Found bad "before" or "after" parameters
[ INFO  ] Stage: Clean up
          Log file is located at /home/guoss4/ovirt-engine/var/log/ovirt-engine/setup/ovirt-engine-setup-20180427001528-6h7snp.log
[ ERROR ] Failed to execute stage 'Clean up': 'NoneType' object has no attribute 'cleanup'
[ INFO  ] Generating answer file '/home/guoss4/ovirt-engine/var/lib/ovirt-engine/setup/answers/20180427001531-setup.conf'
[ INFO  ] Stage: Pre-termination
[ INFO  ] Stage: Termination
[ ERROR ] Execution of setup failed

_______________________________________________
Users mailing list
Users@ovirt.org
http://lists.ovirt.org/mailman/listinfo/users




--
Didi