On Fri, May 8, 2020 at 6:55 PM Sandro Bonazzola <sbonazzo@redhat.com> wrote:
[snip]

+Ryan Barry +Michal Skrivanek can you please look into this? Seems like in 4.3.9 CPU was set to 
-machine pc-i440fx-rhel7.6.0,accel=kvm,usb=off,dump-guest-core=off \
-cpu Skylake-Server,spec-ctrl=on,ssbd=on,md-clear=on \

while on 4.4.0 it's set to:
<cpu match="exact"> <model>Cascadelake-Server</model> <feature name="md-clear" policy="require"/> <feature name="mds-no" policy="require"/> <feature name="hle" policy="disable"/> <feature name="rtm" policy="disable"/> <feature name="tsx-ctrl" policy="require"/> <feature name="arch-capabilities" policy="require"/> <topology cores="2" sockets="16" threads="1"/> <numa> <cell cpus="0-31" id="0" memory="16777216"/> </numa> </cpu>

and it fails on missing tsx-ctrl feature.

I confirm that in vdsm.log of the nested host in RC1 I see this config for the engine vm:
...
    <name>HostedEngine</name>
    <uuid>7194f9ff-1d73-4a0d-987e-3e82060c2d99</uuid>
    <memory>16777216</memory>
    <currentMemory>16777216</currentMemory>
    <iothreads>1</iothreads>
    <maxMemory slots="16">67108864</maxMemory>
    <vcpu current="2">32</vcpu>
    <sysinfo type="smbios">
        <system>
            <entry name="manufacturer">oVirt</entry>
            <entry name="product">RHEL</entry>
            <entry name="version">8-1.1911.0.9.el8</entry>
            <entry name="family">oVirt</entry>
            <entry name="serial">d584e962-5461-4fa5-affa-db413e17590c</entry>
            <entry name="uuid">7194f9ff-1d73-4a0d-987e-3e82060c2d99</entry>
        </system>
    </sysinfo>
    <clock adjustment="0" offset="variable">
       <timer name="rtc" tickpolicy="catchup"/>
        <timer name="pit" tickpolicy="delay"/>
        <timer name="hpet" present="no"/>
    </clock>
    <features>
        <acpi/>
    </features>
    <cpu match="exact">
        <model>Cascadelake-Server</model>
        <feature name="md-clear" policy="require"/>
        <feature name="mds-no" policy="require"/>
        <feature name="hle" policy="disable"/>
        <feature name="rtm" policy="disable"/>
        <feature name="tsx-ctrl" policy="require"/>
        <feature name="arch-capabilities" policy="require"/>
        <topology cores="2" sockets="16" threads="1"/>
        <numa>
            <cell cpus="0-31" id="0" memory="16777216"/>
        </numa>
    </cpu>
...
    <os>
        <type arch="x86_64" machine="pc-q35-rhel8.1.0">hvm</type>
        <smbios mode="sysinfo"/>
        <bios useserial="yes"/>
    </os>
...


Maybe related to partial implementation on Bug 1674420 [RFE] - add support for Cascadelake-Server CPUs (and IvyBridge)  
which is targeted to 4.4.2?
Gianluca, can you confirm your host has Cascadelake-Server CPU ?

The physical host cpu is detected as:

model name : Intel(R) Xeon(R) Platinum 8260L CPU @ 2.40GHz

and its cpu flags:

flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc aperfmperf eagerfpu pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch epb cat_l3 cdp_l3 invpcid_single intel_pt ssbd mba ibrs ibpb stibp ibrs_enhanced tpr_shadow vnmi flexpriority ept vpid fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke avx512_vnni md_clear spec_ctrl intel_stibp flush_l1d arch_capabilities

The physical host itself is a 4.3.9 single host HCI system and during install (made with 4.3.8) has been setup as "Intel Skylake Server IBRS SSBD MDS Family" type cluster
I confirm that both in physical 4.3.9 and in another nested 4.3.9 enf I set up, the related HostedEngine VM is started with:

-machine pc-i440fx-rhel7.6.0,accel=kvm,usb=off,dump-guest-core=off -cpu Skylake-Server,spec-ctrl=on,ssbd=on,md-clear=on,vmx=on

Gianluca




OK, but strange that I was able to install 4.3.8 without problems....
Is there a way in HCI setup to specify a "lower level" cluster type from the beginning?

Gianluca