On Fri, Oct 7, 2016 at 3:22 PM, Gianluca Cecchi <gianluca.cecchi@gmail.com> wrote:
On Fri, Oct 7, 2016 at 2:59 PM, Nir Soffer <nsoffer@redhat.com> wrote:

wasn’t it suppose to be fixed to reuse the connection? Like all the other clients (vdsm migration code:-) 

This is orthogonal issue.
 
Does schema validation matter then if there would be only one connection at the start up?

Loading once does not help command line tools like vdsClient, hosted-engine and
vdsm-tool. 

Nir
 


Simone, reusing the connection is good idea anyway, but what you describe is 
a bug in the client library. The library does *not* need to load and parse the
schema at all for sending requests to vdsm.

The schema is only needed if you want to verify request parameters,
or provide online help, these are not needed in a client library.

Please file an infra bug about it.


Here is a patch that should eliminate most most of the problem:

Would be nice if it can be tested on the system showing this problem.

Cheers,
Nir
 _______________________________________________


this is a video of 1 minute with the same system as the first post, but in 4.0.3 now and the same 3 VMs powered on without any particular load.
It seems very similar to the previous 3.6.6 in cpu used by ovirt-ha-agent.

https://drive.google.com/file/d/0BwoPbcrMv8mvSjFDUERzV1owTG8/view?usp=sharing

Enjoy Nir ;-)

If I can apply the patch also to 4.0.3 I'm going to see if there is then a different behavior. 
Let me know,


I'm trying it right now.
Any other tests will be really appreciated.

The patch is pretty simply, you can apply that on the fly.
You have to shutdown ovirt-ha-broker and ovirt-ha-agent; then you could directly edit 
/usr/lib/python2.7/site-packages/api/vdsmapi.py
around line 97 changing from
loaded_schema = yaml.load(f)
to
loaded_schema = yaml.load(f, Loader=yaml.CLoader)
Please pay attention to keep exactly the same amount of initial spaces.

Then you can simply restart the HA agent and check.

Gianluca

_______________________________________________
Users mailing list
Users@ovirt.org
http://lists.ovirt.org/mailman/listinfo/users