On Thu, Mar 9, 2017 at 11:23 AM, Juan Hernández <jhernand@redhat.com> wrote:

>     Very good point Gialuca, you are right, the 'persist_memorystate' flag
>     is 'true' by default, and that makes the pause longer. Would you be so
>     kind to add it to the 'vm_backup.py' example that is part of version 4
>     of the SDK?
>
>
>     https://github.com/oVirt/ovirt-engine-sdk/blob/master/sdk/examples/vm_backup.py#L143-L151
>     <https://github.com/oVirt/ovirt-engine-sdk/blob/master/sdk/examples/vm_backup.py#L143-L151>
>
>     (Note that that Gibhub is just a mirror, the change needs to be submited
>     using gerrit.ovirt.org <http://gerrit.ovirt.org>).
>
>
>
> I already verified (on a 4.1 infra) that changing vm_backup.py
> downloaded yesterday from master this way (apart connection paramters):
>
> $ diff vm_backup.py vm_backup.py.orig
>  150d149
> <         persist_memorystate=False,
>
> I get the backup result and snapshot is correctly without memory saved
> (and no pause at VM side)
>

[snip] 

I see that you already have a gerrit.ovirt.org, so it shouldn't be
difficult. The initial setup should be like this:

  $ git config --global user.name youruser
  $ git config --global user.email your@email
  $ git clone ssh://youruser@gerrit.ovirt.org:29418/ovirt-engine-sdk
  $ gitdir=$(git rev-parse --git-dir); scp -p -P 29418
youruser@gerrit.ovirt.org:hooks/commit-msg ${gitdir}/hooks/

Then, to submit the patch:

  $ cd ovirt-engine-sdk
  $ Edit the vm_backup.py file, and make your changes.
  $ git commit -a -s
  $ git push origin HEAD:refs/for/master


Ok. I found the time to try and apparently it worked as expected.
The master (you? jenkins CI? ;-) should see my change...
Just learnt (a little...) another thing

sys admins often try to put an eye inside devs field but the reverse seldom happens ;-)