Tal Nisan has submitted this change and it was merged. Change subject: core: when starting Live Merge, check for NOT_STARTED child commands ...................................................................... core: when starting Live Merge, check for NOT_STARTED child commands When a Live Merge is started, the RemoveSnapshotCommandCallback does not look for child commands with the NOT_STARTED command status. This causes a race where the child commands may not be detected properly by the parent, causing the actual merge process to be skipped. This adds the needed check to the command callback, eliminating the race condition and ensuring the merge will occur. Change-Id: If47d26d8bedaf0bb4a39cae472533399178b4fdd Bug-Url: https://bugzilla.redhat.com/1280160 Signed-off-by: Greg Padgett <gpadgett@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Greg Padgett: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48441 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If47d26d8bedaf0bb4a39cae472533399178b4fdd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Padgett <gpadgett@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ravi Nori <rnori@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org