[TICKET] gerrit marked patch as still -1, but jenkins supposedly removed the -1
Why is this patch (which is merged!) -1 verified from jenkins? https://gerrit.ovirt.org/#/c/41296/ (May be related to the bug I've already reported on Jenkins / gerrit integration) Greg Sheremeta Red Hat, Inc. Sr. Software Engineer, RHEV Cell: 919-807-1086 gshereme@redhat.com
----- Original Message -----
From: "Greg Sheremeta" <gshereme@redhat.com> To: "infra" <infra@ovirt.org> Sent: Tuesday, May 26, 2015 7:25:05 PM Subject: [TICKET] gerrit marked patch as still -1, but jenkins supposedly removed the -1
Why is this patch (which is merged!) -1 verified from jenkins?
https://gerrit.ovirt.org/#/c/41296/
(May be related to the bug I've already reported on Jenkins / gerrit integration)
it looks like jenkins isn't dropping the -1 from verified even if a second build successeded. i changed the gerrit settings so it will give +1 on verify to see if that's the case, so now you will see +1 verify and +code review, if we don't want ci to +verify then we can just not use the verify flag and stick to the code review which looks to be working. e.
Greg Sheremeta Red Hat, Inc. Sr. Software Engineer, RHEV Cell: 919-807-1086 gshereme@redhat.com _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
----- Original Message -----
From: "Eyal Edri" <eedri@redhat.com> To: "Greg Sheremeta" <gshereme@redhat.com> Cc: "infra" <infra@ovirt.org> Sent: Tuesday, May 26, 2015 7:35:50 PM Subject: Re: [TICKET] gerrit marked patch as still -1, but jenkins supposedly removed the -1
----- Original Message -----
From: "Greg Sheremeta" <gshereme@redhat.com> To: "infra" <infra@ovirt.org> Sent: Tuesday, May 26, 2015 7:25:05 PM Subject: [TICKET] gerrit marked patch as still -1, but jenkins supposedly removed the -1
Why is this patch (which is merged!) -1 verified from jenkins?
https://gerrit.ovirt.org/#/c/41296/
(May be related to the bug I've already reported on Jenkins / gerrit integration)
it looks like jenkins isn't dropping the -1 from verified even if a second build successeded. i changed the gerrit settings so it will give +1 on verify to see if that's the case, so now you will see +1 verify and +code review, if we don't want ci to +verify then we can just not use the verify flag and stick to the code review which looks to be working.
can you check if this still happens? after i changed the settings.
e.
Greg Sheremeta Red Hat, Inc. Sr. Software Engineer, RHEV Cell: 919-807-1086 gshereme@redhat.com _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
It's hard to manually reproduce the conditions. You can close this ticket and I'll just let you know if I see it again. ----- Original Message -----
From: "Eyal Edri" <eedri@redhat.com> To: "Greg Sheremeta" <gshereme@redhat.com> Cc: "infra" <infra@ovirt.org> Sent: Wednesday, May 27, 2015 9:03:04 AM Subject: Re: [TICKET] gerrit marked patch as still -1, but jenkins supposedly removed the -1
----- Original Message -----
From: "Eyal Edri" <eedri@redhat.com> To: "Greg Sheremeta" <gshereme@redhat.com> Cc: "infra" <infra@ovirt.org> Sent: Tuesday, May 26, 2015 7:35:50 PM Subject: Re: [TICKET] gerrit marked patch as still -1, but jenkins supposedly removed the -1
----- Original Message -----
From: "Greg Sheremeta" <gshereme@redhat.com> To: "infra" <infra@ovirt.org> Sent: Tuesday, May 26, 2015 7:25:05 PM Subject: [TICKET] gerrit marked patch as still -1, but jenkins supposedly removed the -1
Why is this patch (which is merged!) -1 verified from jenkins?
https://gerrit.ovirt.org/#/c/41296/
(May be related to the bug I've already reported on Jenkins / gerrit integration)
it looks like jenkins isn't dropping the -1 from verified even if a second build successeded. i changed the gerrit settings so it will give +1 on verify to see if that's the case, so now you will see +1 verify and +code review, if we don't want ci to +verify then we can just not use the verify flag and stick to the code review which looks to be working.
can you check if this still happens? after i changed the settings.
e.
Greg Sheremeta Red Hat, Inc. Sr. Software Engineer, RHEV Cell: 919-807-1086 gshereme@redhat.com _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
It's hard to manually reproduce the conditions. You can close this ticket and I'll just let you know if I see it again. =20 ----- Original Message -----
From: "Eyal Edri" <eedri@redhat.com> To: "Greg Sheremeta" <gshereme@redhat.com> Cc: "infra" <infra@ovirt.org> Sent: Wednesday, May 27, 2015 9:03:04 AM Subject: Re: [TICKET] gerrit marked patch as still -1, but jenkins supp= osedly removed the -1 =20 =20 =20 ----- Original Message -----
From: "Eyal Edri" <eedri@redhat.com> To: "Greg Sheremeta" <gshereme@redhat.com> Cc: "infra" <infra@ovirt.org> Sent: Tuesday, May 26, 2015 7:35:50 PM Subject: Re: [TICKET] gerrit marked patch as still -1, but jenkins supposedly removed the -1 =20 =20 =20 ----- Original Message -----
From: "Greg Sheremeta" <gshereme@redhat.com> To: "infra" <infra@ovirt.org> Sent: Tuesday, May 26, 2015 7:25:05 PM Subject: [TICKET] gerrit marked patch as still -1, but jenkins supp= osedly removed the -1 =20 Why is this patch (which is merged!) -1 verified from jenkins? =20 https://gerrit.ovirt.org/#/c/41296/ =20 (May be related to the bug I've already reported on Jenkins / gerrit integration) =20 it looks like jenkins isn't dropping the -1 from verified even if a s= econd build successeded. i changed the gerrit settings so it will give +1 on verify to see if =
--WYTEVAkct0FjGQmd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I think this might be the same case exposed here: https://code.google.com/p/gerrit/issues/detail?id=3D3267 On 06/01, Greg Sheremeta wrote: that's
the case, so now you will see +1 verify and +code review, if we don't want ci to +verify then we can just not use the verify flag and stick to the code review= which looks to be working. =20 =20 can you check if this still happens? after i changed the settings. =20 e. =20
=20 =20 Greg Sheremeta Red Hat, Inc. Sr. Software Engineer, RHEV Cell: 919-807-1086 gshereme@redhat.com _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra =20 =20 =20
Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra =20 =20 =20 =20
Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --WYTEVAkct0FjGQmd Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVbXemAAoJEEBxx+HSYmnDK0cH/jRMmc6snndyc/yb85ASVweo O8DBJTYcpaqiZl13RjfH8sJp8vgIyXjqm1o6g/GHRW30phxNXemUClzFYy3omvoE b1B/++cCnGihYXwhJQINc+IyEpC0WkFSY2N11gZx/StQqWAHdppFO06wOKytXEHB bp7kDBXZbC8e9dsF6ZhTPPhYqMT/8s0AQOxN0vDv3ZbgS8g4Puuqn9hlTgb7/B3s zmlUC3aKIGPrbFR85HCVeUZDuALeJCDvnJ17W2yUGrtNo/vPJjLDg6bjTYndICzk TEV3Vy35ZZWM4TSZPB8iOz7Z3fDgz8fTXRE/dUBmIn9u0rJyHB4d4Ol4Wws/jyY= =nrmX -----END PGP SIGNATURE----- --WYTEVAkct0FjGQmd--
participants (3)
-
David Caro -
Eyal Edri -
Greg Sheremeta