[VDSM] Trouble merging patch, related to jenkins whitelist or new RHEL CI?

I could not merge: https://gerrit.ovirt.org/c/109402/ Although it was approved and verified, and got +1 from Continuous Integration. There is a new "RHEL-Continuous-Integration", which does not run with this change, even when I trigger the tests manually with "ci test". I tried to add +1 for "RHEL-Continuous-Integration" but this is not possible, I see: RHEL-Continuous-Integration You don't have permission to edit this label. So finally I downloaded the patch and pushed it manually. I think this patch will fix the problem: https://gerrit.ovirt.org/#/c/110576/ But I need CI experts to review this. Since we have 50 projects that need this, this probably should be fixed elsewhere, and inherited by all projects. I know that Germano was not able to trigger tests because he was missing in the jenkins whitelist, but this was fixed last week. Germano, maybe just to check that everything works for you, you can post some trivial patch? Nir

On Sat, Aug 1, 2020 at 12:10 AM Nir Soffer <nsoffer@redhat.com> wrote:
I could not merge: https://gerrit.ovirt.org/c/109402/
Another patch I cannot merge: https://gerrit.ovirt.org/c/108393/
Although it was approved and verified, and got +1 from Continuous Integration.
There is a new "RHEL-Continuous-Integration", which does not run with this change, even when I trigger the tests manually with "ci test".
I tried to add +1 for "RHEL-Continuous-Integration" but this is not possible, I see:
RHEL-Continuous-Integration You don't have permission to edit this label.
So finally I downloaded the patch and pushed it manually.
I think this patch will fix the problem: https://gerrit.ovirt.org/#/c/110576/
But I need CI experts to review this. Since we have 50 projects that need this, this probably should be fixed elsewhere, and inherited by all projects.
I know that Germano was not able to trigger tests because he was missing in the jenkins whitelist, but this was fixed last week.
Germano, maybe just to check that everything works for you, you can post some trivial patch?
Nir

On Sat, Aug 1, 2020 at 7:11 AM Nir Soffer <nsoffer@redhat.com> wrote:
I could not merge: https://gerrit.ovirt.org/c/109402/
Although it was approved and verified, and got +1 from Continuous Integration.
There is a new "RHEL-Continuous-Integration", which does not run with this change, even when I trigger the tests manually with "ci test".
I tried to add +1 for "RHEL-Continuous-Integration" but this is not possible, I see:
RHEL-Continuous-Integration You don't have permission to edit this label.
So finally I downloaded the patch and pushed it manually.
I think this patch will fix the problem: https://gerrit.ovirt.org/#/c/110576/
But I need CI experts to review this. Since we have 50 projects that need this, this probably should be fixed elsewhere, and inherited by all projects.
I know that Germano was not able to trigger tests because he was missing in the jenkins whitelist, but this was fixed last week.
Germano, maybe just to check that everything works for you, you can post some trivial patch?
Build and test are working for me now after contacting infra.
Nir

On Mon, Aug 3, 2020 at 2:24 AM Germano Veit Michel <germano@redhat.com> wrote:
On Sat, Aug 1, 2020 at 7:11 AM Nir Soffer <nsoffer@redhat.com> wrote:
I could not merge: https://gerrit.ovirt.org/c/109402/
Although it was approved and verified, and got +1 from Continuous Integration.
There is a new "RHEL-Continuous-Integration", which does not run with this change, even when I trigger the tests manually with "ci test".
I tried to add +1 for "RHEL-Continuous-Integration" but this is not possible, I see:
RHEL-Continuous-Integration You don't have permission to edit this label.
I cannot merge anything as well. I wonder why maintainers don't get the permission for the new flag? Apparently the automation for this is not working yet.
So finally I downloaded the patch and pushed it manually.
I think this patch will fix the problem: https://gerrit.ovirt.org/#/c/110576/
But I need CI experts to review this. Since we have 50 projects that need this, this probably should be fixed elsewhere, and inherited by all projects.
I know that Germano was not able to trigger tests because he was missing in the jenkins whitelist, but this was fixed last week.
Germano, maybe just to check that everything works for you, you can post some trivial patch?
Build and test are working for me now after contacting infra.
Nir
-- Ales Musil Software Engineer - RHV Network Red Hat EMEA <https://www.redhat.com> amusil@redhat.com IM: amusil <https://red.ht/sig>

Hey, That's my fault there, I've added the label to prepare for the rhel tests on ovirt and forgot to add the maintainers group. Could you verify you can add it now? Thanks, Ehud. On Mon, Aug 3, 2020 at 8:43 AM Ales Musil <amusil@redhat.com> wrote:
On Mon, Aug 3, 2020 at 2:24 AM Germano Veit Michel <germano@redhat.com> wrote:
On Sat, Aug 1, 2020 at 7:11 AM Nir Soffer <nsoffer@redhat.com> wrote:
I could not merge: https://gerrit.ovirt.org/c/109402/
Although it was approved and verified, and got +1 from Continuous Integration.
There is a new "RHEL-Continuous-Integration", which does not run with this change, even when I trigger the tests manually with "ci test".
I tried to add +1 for "RHEL-Continuous-Integration" but this is not possible, I see:
RHEL-Continuous-Integration You don't have permission to edit this label.
I cannot merge anything as well. I wonder why maintainers don't get the permission for the new flag? Apparently the automation for this is not working yet.
So finally I downloaded the patch and pushed it manually.
I think this patch will fix the problem: https://gerrit.ovirt.org/#/c/110576/
But I need CI experts to review this. Since we have 50 projects that need this, this probably should be fixed elsewhere, and inherited by all projects.
I know that Germano was not able to trigger tests because he was missing in the jenkins whitelist, but this was fixed last week.
Germano, maybe just to check that everything works for you, you can post some trivial patch?
Build and test are working for me now after contacting infra.
Nir
--
Ales Musil
Software Engineer - RHV Network
Red Hat EMEA <https://www.redhat.com>
amusil@redhat.com IM: amusil <https://red.ht/sig> _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/GFIT7NPOYQUINU...

On Mon, Aug 3, 2020 at 8:30 AM Ehud Yonasi <eyonasi@redhat.com> wrote:
Hey, That's my fault there, I've added the label to prepare for the rhel tests on ovirt and forgot to add the maintainers group.
Could you verify you can add it now?
Unfortunately not. It still has the same message/error.
Thanks, Ehud.
On Mon, Aug 3, 2020 at 8:43 AM Ales Musil <amusil@redhat.com> wrote:
On Mon, Aug 3, 2020 at 2:24 AM Germano Veit Michel <germano@redhat.com> wrote:
On Sat, Aug 1, 2020 at 7:11 AM Nir Soffer <nsoffer@redhat.com> wrote:
I could not merge: https://gerrit.ovirt.org/c/109402/
Although it was approved and verified, and got +1 from Continuous Integration.
There is a new "RHEL-Continuous-Integration", which does not run with this change, even when I trigger the tests manually with "ci test".
I tried to add +1 for "RHEL-Continuous-Integration" but this is not possible, I see:
RHEL-Continuous-Integration You don't have permission to edit this label.
I cannot merge anything as well. I wonder why maintainers don't get the permission for the new flag? Apparently the automation for this is not working yet.
So finally I downloaded the patch and pushed it manually.
I think this patch will fix the problem: https://gerrit.ovirt.org/#/c/110576/
But I need CI experts to review this. Since we have 50 projects that need this, this probably should be fixed elsewhere, and inherited by all projects.
I know that Germano was not able to trigger tests because he was missing in the jenkins whitelist, but this was fixed last week.
Germano, maybe just to check that everything works for you, you can post some trivial patch?
Build and test are working for me now after contacting infra.
Nir
--
Ales Musil
Software Engineer - RHV Network
Red Hat EMEA <https://www.redhat.com>
amusil@redhat.com IM: amusil <https://red.ht/sig> _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/GFIT7NPOYQUINU...
-- Ales Musil Software Engineer - RHV Network Red Hat EMEA <https://www.redhat.com> amusil@redhat.com IM: amusil <https://red.ht/sig>

Try again please, I think it will now work. On Mon, Aug 3, 2020 at 9:47 AM Ales Musil <amusil@redhat.com> wrote:
On Mon, Aug 3, 2020 at 8:30 AM Ehud Yonasi <eyonasi@redhat.com> wrote:
Hey, That's my fault there, I've added the label to prepare for the rhel tests on ovirt and forgot to add the maintainers group.
Could you verify you can add it now?
Unfortunately not. It still has the same message/error.
Thanks, Ehud.
On Mon, Aug 3, 2020 at 8:43 AM Ales Musil <amusil@redhat.com> wrote:
On Mon, Aug 3, 2020 at 2:24 AM Germano Veit Michel <germano@redhat.com> wrote:
On Sat, Aug 1, 2020 at 7:11 AM Nir Soffer <nsoffer@redhat.com> wrote:
I could not merge: https://gerrit.ovirt.org/c/109402/
Although it was approved and verified, and got +1 from Continuous Integration.
There is a new "RHEL-Continuous-Integration", which does not run with this change, even when I trigger the tests manually with "ci test".
I tried to add +1 for "RHEL-Continuous-Integration" but this is not possible, I see:
RHEL-Continuous-Integration You don't have permission to edit this label.
I cannot merge anything as well. I wonder why maintainers don't get the permission for the new flag? Apparently the automation for this is not working yet.
So finally I downloaded the patch and pushed it manually.
I think this patch will fix the problem: https://gerrit.ovirt.org/#/c/110576/
But I need CI experts to review this. Since we have 50 projects that need this, this probably should be fixed elsewhere, and inherited by all projects.
I know that Germano was not able to trigger tests because he was missing in the jenkins whitelist, but this was fixed last week.
Germano, maybe just to check that everything works for you, you can post some trivial patch?
Build and test are working for me now after contacting infra.
Nir
--
Ales Musil
Software Engineer - RHV Network
Red Hat EMEA <https://www.redhat.com>
amusil@redhat.com IM: amusil <https://red.ht/sig> _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/GFIT7NPOYQUINU...
--
Ales Musil
Software Engineer - RHV Network
Red Hat EMEA <https://www.redhat.com>
amusil@redhat.com IM: amusil <https://red.ht/sig>

On Mon, Aug 3, 2020 at 8:51 AM Ehud Yonasi <eyonasi@redhat.com> wrote:
Try again please, I think it will now work.
It does. Thank you.
On Mon, Aug 3, 2020 at 9:47 AM Ales Musil <amusil@redhat.com> wrote:
On Mon, Aug 3, 2020 at 8:30 AM Ehud Yonasi <eyonasi@redhat.com> wrote:
Hey, That's my fault there, I've added the label to prepare for the rhel tests on ovirt and forgot to add the maintainers group.
Could you verify you can add it now?
Unfortunately not. It still has the same message/error.
Thanks, Ehud.
On Mon, Aug 3, 2020 at 8:43 AM Ales Musil <amusil@redhat.com> wrote:
On Mon, Aug 3, 2020 at 2:24 AM Germano Veit Michel <germano@redhat.com> wrote:
On Sat, Aug 1, 2020 at 7:11 AM Nir Soffer <nsoffer@redhat.com> wrote:
I could not merge: https://gerrit.ovirt.org/c/109402/
Although it was approved and verified, and got +1 from Continuous Integration.
There is a new "RHEL-Continuous-Integration", which does not run with this change, even when I trigger the tests manually with "ci test".
I tried to add +1 for "RHEL-Continuous-Integration" but this is not possible, I see:
RHEL-Continuous-Integration You don't have permission to edit this label.
I cannot merge anything as well. I wonder why maintainers don't get the permission for the new flag? Apparently the automation for this is not working yet.
So finally I downloaded the patch and pushed it manually.
I think this patch will fix the problem: https://gerrit.ovirt.org/#/c/110576/
But I need CI experts to review this. Since we have 50 projects that need this, this probably should be fixed elsewhere, and inherited by all projects.
I know that Germano was not able to trigger tests because he was missing in the jenkins whitelist, but this was fixed last week.
Germano, maybe just to check that everything works for you, you can post some trivial patch?
Build and test are working for me now after contacting infra.
Nir
--
Ales Musil
Software Engineer - RHV Network
Red Hat EMEA <https://www.redhat.com>
amusil@redhat.com IM: amusil <https://red.ht/sig> _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/GFIT7NPOYQUINU...
--
Ales Musil
Software Engineer - RHV Network
Red Hat EMEA <https://www.redhat.com>
amusil@redhat.com IM: amusil <https://red.ht/sig>
-- Ales Musil Software Engineer - RHV Network Red Hat EMEA <https://www.redhat.com> amusil@redhat.com IM: amusil <https://red.ht/sig>

On Mon, Aug 3, 2020, 09:55 Ales Musil <amusil@redhat.com> wrote:
On Mon, Aug 3, 2020 at 8:51 AM Ehud Yonasi <eyonasi@redhat.com> wrote:
Try again please, I think it will now work.
It does. Thank you.
On Mon, Aug 3, 2020 at 9:47 AM Ales Musil <amusil@redhat.com> wrote:
On Mon, Aug 3, 2020 at 8:30 AM Ehud Yonasi <eyonasi@redhat.com> wrote:
Hey, That's my fault there, I've added the label to prepare for the rhel tests on ovirt and forgot to add the maintainers group.
Ehud, please discuss here changes to vdsm CI before applying them.
Could you verify you can add it now?
Unfortunately not. It still has the same message/error.
Thanks, Ehud.
On Mon, Aug 3, 2020 at 8:43 AM Ales Musil <amusil@redhat.com> wrote:
On Mon, Aug 3, 2020 at 2:24 AM Germano Veit Michel <germano@redhat.com> wrote:
On Sat, Aug 1, 2020 at 7:11 AM Nir Soffer <nsoffer@redhat.com> wrote:
> I could not merge: > https://gerrit.ovirt.org/c/109402/ > > Although it was approved and verified, and got +1 from Continuous > Integration. > > There is a new "RHEL-Continuous-Integration", which does not run with > this change, > even when I trigger the tests manually with "ci test". > > I tried to add +1 for "RHEL-Continuous-Integration" but this is not > possible, I see: > > RHEL-Continuous-Integration You don't have permission to edit > this label. >
I cannot merge anything as well. I wonder why maintainers don't get the permission for the new flag? Apparently the automation for this is not working yet.
> So finally I downloaded the patch and pushed it manually. > > I think this patch will fix the problem: > https://gerrit.ovirt.org/#/c/110576/ > > But I need CI experts to review this. Since we have 50 projects that > need this, > this probably should be fixed elsewhere, and inherited by all > projects. > > I know that Germano was not able to trigger tests because he was > missing in the > jenkins whitelist, but this was fixed last week. > > Germano, maybe just to check that everything works for you, you can > post some > trivial patch? > Build and test are working for me now after contacting infra.
> > Nir > >
--
Ales Musil
Software Engineer - RHV Network
Red Hat EMEA <https://www.redhat.com>
amusil@redhat.com IM: amusil <https://red.ht/sig> _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/GFIT7NPOYQUINU...
--
Ales Musil
Software Engineer - RHV Network
Red Hat EMEA <https://www.redhat.com>
amusil@redhat.com IM: amusil <https://red.ht/sig>
--
Ales Musil
Software Engineer - RHV Network
Red Hat EMEA <https://www.redhat.com>
amusil@redhat.com IM: amusil <https://red.ht/sig> _______________________________________________ Infra mailing list -- infra@ovirt.org To unsubscribe send an email to infra-leave@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/infra@ovirt.org/message/H7FLG4HKUDNGXX...

Nir, I will. On Mon, Aug 3, 2020 at 10:17 AM Nir Soffer <nsoffer@redhat.com> wrote:
On Mon, Aug 3, 2020, 09:55 Ales Musil <amusil@redhat.com> wrote:
On Mon, Aug 3, 2020 at 8:51 AM Ehud Yonasi <eyonasi@redhat.com> wrote:
Try again please, I think it will now work.
It does. Thank you.
On Mon, Aug 3, 2020 at 9:47 AM Ales Musil <amusil@redhat.com> wrote:
On Mon, Aug 3, 2020 at 8:30 AM Ehud Yonasi <eyonasi@redhat.com> wrote:
Hey, That's my fault there, I've added the label to prepare for the rhel tests on ovirt and forgot to add the maintainers group.
Ehud, please discuss here changes to vdsm CI before applying them.
Could you verify you can add it now?
Unfortunately not. It still has the same message/error.
Thanks, Ehud.
On Mon, Aug 3, 2020 at 8:43 AM Ales Musil <amusil@redhat.com> wrote:
On Mon, Aug 3, 2020 at 2:24 AM Germano Veit Michel < germano@redhat.com> wrote:
> > > On Sat, Aug 1, 2020 at 7:11 AM Nir Soffer <nsoffer@redhat.com> > wrote: > >> I could not merge: >> https://gerrit.ovirt.org/c/109402/ >> >> Although it was approved and verified, and got +1 from Continuous >> Integration. >> >> There is a new "RHEL-Continuous-Integration", which does not run >> with >> this change, >> even when I trigger the tests manually with "ci test". >> >> I tried to add +1 for "RHEL-Continuous-Integration" but this is not >> possible, I see: >> >> RHEL-Continuous-Integration You don't have permission to edit >> this label. >> > I cannot merge anything as well. I wonder why maintainers don't get the permission for the new flag? Apparently the automation for this is not working yet.
> >> So finally I downloaded the patch and pushed it manually. >> >> I think this patch will fix the problem: >> https://gerrit.ovirt.org/#/c/110576/ >> >> But I need CI experts to review this. Since we have 50 projects >> that need this, >> this probably should be fixed elsewhere, and inherited by all >> projects. >> >> I know that Germano was not able to trigger tests because he was >> missing in the >> jenkins whitelist, but this was fixed last week. >> >> Germano, maybe just to check that everything works for you, you can >> post some >> trivial patch? >> > Build and test are working for me now after contacting infra. > > > >> >> Nir >> >>
--
Ales Musil
Software Engineer - RHV Network
Red Hat EMEA <https://www.redhat.com>
amusil@redhat.com IM: amusil <https://red.ht/sig> _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/GFIT7NPOYQUINU...
--
Ales Musil
Software Engineer - RHV Network
Red Hat EMEA <https://www.redhat.com>
amusil@redhat.com IM: amusil <https://red.ht/sig>
--
Ales Musil
Software Engineer - RHV Network
Red Hat EMEA <https://www.redhat.com>
amusil@redhat.com IM: amusil <https://red.ht/sig> _______________________________________________ Infra mailing list -- infra@ovirt.org To unsubscribe send an email to infra-leave@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/infra@ovirt.org/message/H7FLG4HKUDNGXX...
participants (4)
-
Ales Musil
-
Ehud Yonasi
-
Germano Veit Michel
-
Nir Soffer